On 31/05/12 19:00, Paolo Bonzini wrote:
Il 30/05/2012 15:26, Luiz Capitulino ha scritto:
qapi-types.h:
typedef enum KeyCodes
{
KEY_CODES_SHIFT = 0,
KEY_CODES_SHIFT_R = 1,
KEY_CODES_ALT = 2,
....
KEY_CODES_< = ..
^^^ problem should exist here
That's because you have something like '<' in the enum list, right? I think
we can call it 'less-than', no?
Let's keep some consistency and use "less" as in ui/vnc_keysym.h.
Yeah! I also identified this.
https://github.com/kongove/QEMU/commit/23f657b0379ecfb151f97f34e34ec1bdfc9a04a2
I would send V2 later,
https://github.com/kongove/QEMU/commits/qmp/sendkey/v2 (unfinished)
Since we're at it, let's add the missing ones: prtsc (b7), break (c6),
win (db), win_r (dc), menu (dd), power (de), sleep (df), wake (e3).
Especially win/win_r/menu.
Ok, I would do it.
Paolo
--
Amos.
