On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> On 2012-03-21 14:41, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:36, Avi Kivity wrote:
> >>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> This is now implied by kvm_irqchi
Does anyone have time to review this patchset?
Thanks
Wen Congyang
At 03/20/2012 11:28 AM, Wen Congyang Wrote:
> Hi, all
>
> 'virsh dump' can not work when host pci device is used by guest. We have
> discussed this issue here:
> http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.ht
On Wed, Mar 21, 2012 at 02:19:34PM -0500, Anthony Liguori wrote:
> On 03/21/2012 11:25 AM, Avi Kivity wrote:
> >On 03/21/2012 06:18 PM, Corey Minyard wrote:
> >>
> >>>Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic
> >>>event over IMPI. The code is pretty complex. Of course i
On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote:
> At 03/22/2012 03:19 AM, Anthony Liguori Wrote:
> > On 03/21/2012 11:25 AM, Avi Kivity wrote:
> >> On 03/21/2012 06:18 PM, Corey Minyard wrote:
> >>>
> Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic
> e
On Wed, Mar 21, 2012 at 02:04:34PM -0500, Anthony Liguori wrote:
> On 03/13/2012 05:47 AM, Avi Kivity wrote:
> >On 03/13/2012 11:18 AM, Daniel P. Berrange wrote:
> >>On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote:
> >>>On 03/12/2012 11:04 AM, Wen Congyang wrote:
> Do you have any ot
At 03/22/2012 03:28 PM, Gleb Natapov Wrote:
> On Wed, Mar 21, 2012 at 02:19:34PM -0500, Anthony Liguori wrote:
>> On 03/21/2012 11:25 AM, Avi Kivity wrote:
>>> On 03/21/2012 06:18 PM, Corey Minyard wrote:
> Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic
> event
On March 21, 2012 at 6:36 PM Gerd Hoffmann wrote:
> Not only QHs can form rings, but TDs too. With the new
> queuing/pipelining support we are following TD chains and
> can actually walk in circles. An assert() prevents us from
> entering an endless loop then.
>
> Fix is easy: Just stop queui
At 03/22/2012 03:12 AM, Anthony Liguori Wrote:
> On 03/15/2012 06:46 AM, Avi Kivity wrote:
>> On 03/15/2012 01:25 PM, Jan Kiszka wrote:
>
There was such vm exit (KVM_EXIT_HYPERCALL), but it was deemed to be a
bad idea.
>>>
>>> BTW, this would help a lot in emulating hypercalls of othe
At 03/22/2012 03:31 PM, Gleb Natapov Wrote:
> On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote:
>> At 03/22/2012 03:19 AM, Anthony Liguori Wrote:
>>> On 03/21/2012 11:25 AM, Avi Kivity wrote:
On 03/21/2012 06:18 PM, Corey Minyard wrote:
>
>> Look at drivers/char/ipmi/ipmi_m
On Thu, Mar 22, 2012 at 03:44:45PM +0800, Wen Congyang wrote:
> At 03/22/2012 03:31 PM, Gleb Natapov Wrote:
> > On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote:
> >> At 03/22/2012 03:19 AM, Anthony Liguori Wrote:
> >>> On 03/21/2012 11:25 AM, Avi Kivity wrote:
> On 03/21/2012 06:1
>From my test, this bug is fixed in the latest kvm.git. I tried 82572 NIC for
>device assignment in WinXP, Win7 and Win2k8. The VT-d NIC works fine in
>Windows guest.
kvm.git+qemu-kvm.git = result
f4d1f417 +df44afac = bad
eb9ede96 +df44afac = good
But I don
@Ricardo I did not have such a problem and it ran all simple programs just fine
(top, ls, cd, cp and so on) on my armv5t. Though I did not cross-compile, but
natively compiled qemu on the box itself.
It would be cool to have it working, but I don't think it will happen any time
soon. I just bou
On Wed, Mar 21, 2012 at 03:10:49PM +0100, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> [...]
> >> Maybe this would work nice for everybody:
> >>
> >> tracetool.py # main program (just parse cmdline opts and
> >> call tracetool module)
> >> tracetool/__init__.py # com
On Wed, Mar 21, 2012 at 05:08:15PM +, Lee Essen wrote:
> On Solaris/Illumos dtrace will remove the "const" qualifier from any
> arguments when producing the header file, this results in hundreds
> of compile-time warnings.
I wonder why DTrace does this, it seems wrong. If anything it should b
On Wed, Mar 21, 2012 at 10:10:46AM -0500, Michael Roth wrote:
> This was added by mistake a while back.
>
> Signed-off-by: Michael Roth
> ---
> Makefile |1 +
> tests/Makefile |2 +-
> 2 files changed, 2 insertions(+), 1 deletions(-)
Thanks, applied all 3 patches to the trivial pa
Currently the virtio balloon device, when using the virtio-pci interface
advertises itself with PCI class code MEMORY_RAM. This is wrong; the
balloon is vaguely related to memory, but is nothing like a PCI memory
device in the meaning of the class code, and this code is not required or
suggested b
On 22/03/2012 08:28, Stefan Hajnoczi wrote:
On Wed, Mar 21, 2012 at 05:08:15PM +, Lee Essen wrote:
On Solaris/Illumos dtrace will remove the "const" qualifier from any
arguments when producing the header file, this results in hundreds
of compile-time warnings.
I wonder why DTrace does this
Hi all,
i am using *qcow2 internal snapshot *, but it seems they are not working
fine
Now to explain my scenario, I created qcow2 internal snapshot *(qcow2 VM is
on). *
Now i list the snapshot
*-bash-4.1# qemu-img snapshot -l guestqcow2*
Snapshot list:
IDTAG VM SIZE
Dear All,
I have downloaded the QEMU sources from linaro and built it successfully.
My PC architecture is X86, I downloaded the test image tarball from linaro,
the image includes two images (zImage.integrator and arm_root.img). Then I
use the following commands to boot them on QEMU successfully.
On Tue, Mar 20, 2012 at 9:56 PM, Stefan Hajnoczi
wrote:
> On Mon, Mar 19, 2012 at 05:17:15PM +0800, Li Zhi Hui wrote:
>> @@ -1196,107 +1322,108 @@ static int fdctrl_transfer_handler (void *opaque,
>> int nchan,
>> return 0;
>> }
>> cur_drv = get_cur_drv(fdctrl);
>> - if (fdc
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
> So, trying to summarize what was discussed in the call:
>
> On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
> > > Let's say we moved CPU definitions to /usr/share/qemu/cpu-models.xml.
> > >
> > > Obviously, we'd w
On 22 March 2012 06:24, stefan weids wrote:
> I have downloaded the QEMU sources from linaro and built it successfully.
>
> My PC architecture is X86, I downloaded the test image tarball from linaro,
> the image includes two images (zImage.integrator and arm_root.img). Then I
> use the following c
When passing through a usb pendrive seabios will present it in the F12
boot menu and will happily boot from it.
This patch adds bootorder support so you can even make it the default
boot device.
Signed-off-by: Gerd Hoffmann
---
hw/usb/host-linux.c |3 +++
hw/usb/redirect.c |3 +++
2 f
Hi,
> -#include "hw/qdev-addr.h"
> +//#include "hw/qdev-addr.h"
Minor nit: Just zap it instead of leaving it in commented out.
Looks fine otherwise.
Acked-by: Gerd Hoffmann
cheers,
Gerd
On Thu, Mar 22, 2012 at 9:09 AM, David Gibson
wrote:
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 3f99f9a..72a4250 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> .driver = "isa-fdc",
> .property = "ch
On 03/22/12 03:14, David Gibson wrote:
> This patch converts it to use the new universal DMA helper functions.
> In the PCI case, it obtains its DMAContext from pci_dma_context(), in
> the SysBus case, it uses NULL - i.e. assumes for now that there will
> be no IOMMU translation for a SysBus OHCI.
Good one, ACK.
Acked-by: Hans de Goede
On 03/21/2012 05:17 PM, Alon Levy wrote:
The current intptr_t casts are a problem when the address's highest
bit is 1, and it is cast to a intptr_t and then to uint64_t, such
as at:
surface.mem= (intptr_t)ssd->buf;
This causes the sign bit
This would be used be following patches.
Signed-off-by: Jason Wang
---
hw/e1000_hw.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/e1000_hw.h b/hw/e1000_hw.h
index 9e29af8..c9cb79e 100644
--- a/hw/e1000_hw.h
+++ b/hw/e1000_hw.h
@@ -349,6 +349,18 @@
#def
According to the spec:
"When set to 1b by software, it causes an Interrupt to be
asserted to indicate the end of an MDI cycle."
We need check the Interrupt Enable bit and raise irq only when it is
set.
Signed-off-by: Jason Wang
---
hw/e1000.c |5 -
1 files changed, 4 insertions(+), 1 d
The missing of loopback mode prevent the running of self diagnosis
program in guest. This patch adds this support.
After this patch, loopback test of ethtool were passed in guest.
Signed-off-by: Jason Wang
---
hw/e1000.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
On Thu, Mar 22, 2012 at 7:06 AM, liu ping fan wrote:
> On Tue, Mar 20, 2012 at 9:56 PM, Stefan Hajnoczi
> wrote:
>> On Mon, Mar 19, 2012 at 05:17:15PM +0800, Li Zhi Hui wrote:
>>> @@ -1196,107 +1322,108 @@ static int fdctrl_transfer_handler (void *opaque,
>>> int nchan,
>>> return 0;
>>
Signed-off-by: Jason Wang
---
hw/e1000.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index fc30361..4eb95be 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -42,7 +42,7 @@ enum {
DEBUG_GENERAL, DEBUG_IO, DEBUG_MMIO, DEBUG_INTERRU
This patch introduces helpers to change link status bit for phy/mac
register. This would help to reduce code duplication and would be used
by following patches.
Signed-off-by: Jason Wang
---
hw/e1000.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git
Indeed, there's nothing else except for the time spent on the
negotiation needs to be emulated. This is needed for resuming windows
guest from hibernation, as without a proper delay, qemu would send the
packet too early ( guest even does not have a proper intr handler),
which could lead windows gue
E1000_ICR_INT_ASSERTED were introduced only for 8257x, so we need to
check the E1000_DEVID before setting this bit in ICS.
Signed-off-by: Jason Wang
---
hw/e1000.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 921f0cc..5584cc6 100644
--
On Thu, Mar 22, 2012 at 12:05 AM, Paolo Bonzini wrote:
> Il 21/03/2012 22:02, Peter Portante ha scritto:
>> Hi Folks,
>>
>> Please forgive me if you find these changes are annoying, as I am trying to
>> learn the ropes of patch submission with git ahead of making a real patch.
>>
>> While working
>> +if (proxy->class_code != PCI_CLASS_OTHERS &&
>> +proxy->class_code != PCI_CLASS_MEMORY_RAM) /* qemu < 1.1 */
>> +proxy->class_code = PCI_CLASS_OTHERS;
>> +
>
> Why is this hunk is needed?
Catch users doing -device virtio-balloon,class=42
cheers,
Gerd
On Thu, 22 Mar 2012, Zhang, Yang Z wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> > Sent: Wednesday, March 21, 2012 2:04 AM
> >
> > On Mon, 19 Mar 2012, Zhang, Yang Z wrote:
> > > Use a timer to emulate update cycle. When update cycle
On Wed, 21 Mar 2012, Paolo Bonzini wrote:
> Il 21/03/2012 17:54, Stefano Stabellini ha scritto:
> >> >
> >> > No, you need to set UF in case the code observes it without actually
> >> > enabling interrupt delivery on the ISA bus.
> >
> > Well, if it is just about updating UF, can we do it only w
Il 22/03/2012 11:29, Stefano Stabellini ha scritto:
>> The purpose of using two timer is trying to keep the UF, AF and UIP
>> synchronous. User can poll UIP to check UF and AF bit. If we use
>> timer for UF/AF bit track and check UIP by another way, since the
>> timer will be fired with delay, then
On Thu, Mar 22, 2012 at 10:27 AM, Gerd Hoffmann wrote:
>>> + if (proxy->class_code != PCI_CLASS_OTHERS &&
>>> + proxy->class_code != PCI_CLASS_MEMORY_RAM) /* qemu < 1.1 */
>>> + proxy->class_code = PCI_CLASS_OTHERS;
>>> +
>>
>> Why is this hunk is needed?
>
> Catch users doing -de
Il 22/03/2012 10:52, Gerd Hoffmann ha scritto:
> When passing through a usb pendrive seabios will present it in the F12
> boot menu and will happily boot from it.
>
> This patch adds bootorder support so you can even make it the default
> boot device.
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw
On Wed, 21 Mar 2012, Paolo Bonzini wrote:
> Il 21/03/2012 17:06, Crístian Viana ha scritto:
> > The current value for the -rtc timedrift option is none. This patch
> > makes sure that the old machines configuration will work the same way
> > even after that option changes its default value.
> >
>
On Wed, 21 Mar 2012, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
Acked-by: Stefano Stabellini
On Wed, 21 Mar 2012, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
Acked-by: Stefano Stabellini
On 21 March 2012 21:02, Peter Portante wrote:
> Please forgive me if you find these changes are annoying, as I am trying to
> learn the ropes of patch submission with git ahead of making a real patch.
I'd recommend using git format-patch's --cover-letter option to create your
'cover letter' patch
This patch includes a few minor changes to QAPI found during a
more careful code review (patches 1-5) and the implementation of
a strict mode for the QObject input visitor (patches 6-10).
While QMP in general is designed so that it is possible to ignore
unknown arguments, in the case of the QMP se
"O" is being used by the transaction and qom-set commands to mean "any
QObject", but it really means "do not validate the argument list".
Add a new specifier with the correct meaning.
Signed-off-by: Paolo Bonzini
---
monitor.c |3 +++
qmp-commands.hx |4 ++--
2 files changed, 5 ins
On Thu, Mar 22, 2012 at 08:09:27PM +1100, David Gibson wrote:
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index a0fb7c1..1fd5768 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -790,6 +790,10 @@ static int virtio_balloon_init_pci(PCIDevice *pci_dev)
> VirtIOPCIProxy *proxy =
On Thu, Mar 22, 2012 at 10:01:46AM +, Stefan Hajnoczi wrote:
> On Thu, Mar 22, 2012 at 9:09 AM, David Gibson
> wrote:
> > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > index 3f99f9a..72a4250 100644
> > --- a/hw/pc_piix.c
> > +++ b/hw/pc_piix.c
> > @@ -386,6 +386,10 @@ static QEMUMachine pc_mach
Tweak a bit the code so that there is cleaner separation between
operation on the list and operation on the output. The next patch
requires this change.
Signed-off-by: Paolo Bonzini
---
qapi/qmp-input-visitor.c | 15 +++
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git
... to make vmstate id string truely unique with multiple host
controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr"
(usb tabled connected to piix3 uhci).
This obviously breaks migration. To handle this the usb bus
property "full-path" is added. When setting this to false old
behav
Il 22/03/2012 13:07, Gerd Hoffmann ha scritto:
> @@ -460,7 +462,21 @@ static void usb_bus_dev_print(Monitor *mon, DeviceState
> *qdev, int indent)
> static char *usb_get_dev_path(DeviceState *qdev)
> {
> USBDevice *dev = USB_DEVICE(qdev);
> -return g_strdup(dev->port->path);
> +Devi
QmpInputVisitor would leak the malloced struct if the stack was
overflowed. This can be easily fixed using error_propagate.
Signed-off-by: Paolo Bonzini
---
qapi/qmp-input-visitor.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp
This is a slight change in the implementation of QMPInputVisitor
that helps when adding strict mode.
Const QObjects cannot be inc/decref-ed, and that's why QMPInputVisitor
relies heavily on weak references to inner objects. I'm not removing
the weak references now, but since refcount+const is a l
On Wed, Mar 21, 2012 at 20:46, Michael S. Tsirkin wrote:
> On Wed, Mar 21, 2012 at 06:29:02PM +, Anthony PERARD wrote:
>> diff --git a/hw/xen_pci_passthrough.h b/hw/xen_pci_passthrough.h
>> new file mode 100644
>> index 000..2c5e83d
>> --- /dev/null
>> +++ b/hw/xen_pci_passthrough.h
>> @@
Objects going through the dealloc visitor can be only partially allocated.
Detect the situation and avoid a segfault. This also helps with the
input visitor, when there are errors.
Signed-off-by: Paolo Bonzini
---
scripts/qapi-visit.py |7 +++
1 files changed, 7 insertions(+), 0 deletio
We can exit very soon if we enter a visitor with a preexisting error.
This simplifies some cases because we will not have to deal with
obj being non-NULL while *obj is NULL.
Signed-off-by: Paolo Bonzini
---
scripts/qapi-visit.py |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
Signed-off-by: Paolo Bonzini
---
scripts/qapi-commands.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 3aabf61..4774b61 100644
--- a/scripts/qapi-commands.py
+++ b/scripts/qapi-commands.py
@@ -140,7 +140,7 @@ v
QmpOutputVisitor will segfault if an imbalanced end function is
called. So we can abort in QmpInputVisitor too.
Signed-off-by: Paolo Bonzini
---
qapi/qmp-input-visitor.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visito
There is no test case for parse errors, add one.
Signed-off-by: Paolo Bonzini
---
test-qmp-input-visitor.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/test-qmp-input-visitor.c b/test-qmp-input-visitor.c
index 1996e49..c30fdc4 100644
--- a/test-qmp-
On 2012-03-22 08:18, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
>> On 2012-03-21 14:41, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
On 2012-03-21 14:36, Avi Kivity wrote:
> On 03/21/2012 02:36 PM, Jan Kiszka wro
Am 19.03.2012 23:57, schrieb Juan Quintela:
> They only contain vmstate cpu sections nowadays. Change name to reflect the
> case.
In light of me creating a file cpu.c for every target except ppc, might
it make more sense to call it cpu-vmstate.c? Or do you envision other
vmstate-*.c files?
Andr
While QMP in general is designed so that it is possible to ignore
unknown arguments, in the case of the QMP server it is better to
reject them to detect bad clients. In fact, we're already doing
this at the top level in the argument checker. To extend this to
complex structures, add a mode to the
On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
> On 2012-03-22 08:18, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:41, Gleb Natapov wrote:
> >>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> On 2012-03-21
On Thu, Mar 22, 2012 at 1:09 AM, Marcelo Tosatti wrote:
>
> Close the now unused images that were part of the previous backing file
> chain and adjust ->backing_hd properly.
>
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=801449
>
> Signed-off-by: Marcelo Tosatti
Reviewed-by: Stefan Hajnoc
On Wed, Mar 21, 2012 at 11:23:00PM +0100, Paolo Bonzini wrote:
> Il 21/03/2012 15:42, Eduardo Habkost ha scritto:
> > For this one, we would have compatibility issues to take care of:
> >
> > ./configure --datadir=FOO --sysconfdir=SYS
> > qemu data dir: FOO
> > (it would be better if it was
Andreas Färber wrote:
> Am 19.03.2012 23:57, schrieb Juan Quintela:
>> They only contain vmstate cpu sections nowadays. Change name to
>> reflect the case.
>
> In light of me creating a file cpu.c for every target except ppc, might
> it make more sense to call it cpu-vmstate.c? Or do you envision
On Wed, Mar 21, 2012 at 3:52 PM, Benoît Canet wrote:
> The QED image is reopened to flush metadata and check consistency.
>
> Signed-off-by: Benoit Canet
> ---
> block/qed.c | 15 +++
> block/qed.h | 1 +
> 2 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/block
On 2012-03-22 13:52, Gleb Natapov wrote:
> On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
>> On 2012-03-22 08:18, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
On 2012-03-21 14:41, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:39:47PM +
... to make vmstate id string truely unique with multiple host
controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr"
(usb tabled connected to piix3 uhci).
This obviously breaks migration. To handle this the usb bus
property "full-path" is added. When setting this to false old
behav
On 2012-03-20 13:31, Michael S. Tsirkin wrote:
> We use a 2 byte ioeventfd for virtio memory,
> add support for this.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/ivshmem.c |8
> kvm-all.c| 15 ---
> kvm-stub.c |2 +-
> kvm.h|3 ++-
> 4 files
On 2012-03-20 13:31, Michael S. Tsirkin wrote:
> We use a 2 byte ioeventfd for virtio memory,
> add support for this.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/ivshmem.c |8
> kvm-all.c| 15 ---
> kvm-stub.c |2 +-
> kvm.h|3 ++-
> 4 files
On 2012-03-22 01:05, Paolo Bonzini wrote:
> Il 21/03/2012 22:02, Peter Portante ha scritto:
>> Hi Folks,
>>
>> Please forgive me if you find these changes are annoying, as I am trying to
>> learn the ropes of patch submission with git ahead of making a real patch.
>>
>> While working on the code, I
On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
Fix stupid copy&paste mistake at commit
ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
"optarg" on the cpu_list() call.
Reported-by: Jiri Denemark
Signed-off-by: Eduardo Habkost
---
vl.c |2 +-
1 files changed, 1 inser
On 03/22/2012 03:28 PM, Jan Kiszka wrote:
> On 2012-03-20 13:31, Michael S. Tsirkin wrote:
> > We use a 2 byte ioeventfd for virtio memory,
> > add support for this.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/ivshmem.c |8
> > kvm-all.c| 15 ---
> > k
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
> On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
> > So, trying to summarize what was discussed in the call:
> >
> > On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
> > > > Let's say we moved CPU defin
On 03/20/2012 02:31 PM, Michael S. Tsirkin wrote:
> We use a 2 byte ioeventfd for virtio memory,
> add support for this.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
This is the MIPS ASE DSP Support for Qemu.
Signed-off-by: Jia Liu
---
Version History:
V2:
Addressed Stefan's review comments:
- fixed coding style.
- changed acc into unsigned int form int and no initialization in translation.
- added return value in testcases.
V1:
- add MIPS ASE DSP Support.
This is the helper define of MIPS ASE DSP.
Signed-off-by: Jia Liu
---
Version History:
V2:
- Addressed Stefan's review comments, use "one space after comma" codeing style.
V1:
- add MIPS ASE DSP helper define.
target-mips/helper.h | 152 ++
1
This is the translation of MIPS ASE DSP.
Signed-off-by: Jia Liu
---
Version History:
V2:
- Addressed Stefan's review comments, changed acc into unsigned int form int,
and no initialization.
- Coding style fixed.
V1:
- add MIPS ASE DSP translation.
target-mips/translate.c | 1110
From: Alon Levy
The current intptr_t casts are a problem when the address's highest
bit is 1, and it is cast to a intptr_t and then to uint64_t, such
as at:
surface.mem= (intptr_t)ssd->buf;
This causes the sign bit to be extended which causes a wrong address to
be passed on to spice
Hi,
This patch series fixes the remaining 32bit bugs in spice. With this
series merged and the latest spice-server bits (from git, no release
yet) spice works on 32bit hosts too.
please pull,
Gerd
The following changes since commit 33cf629a3754b58a1e2dbbe01d91d97e712b7c06:
Merge remote-t
From: Peter Maydell
Fix compilation failures ("cast from pointer to integer of
different size [-Werror=pointer-to-int-cast]") by using
uintptr_t instead.
Signed-off-by: Peter Maydell
Signed-off-by: Gerd Hoffmann
---
ui/spice-display.c | 12 ++--
1 files changed, 6 insertions(+), 6 d
On Wed, Mar 21, 2012 at 4:17 PM, Stefan Weil wrote:
> Am 12.03.2012 09:32, schrieb Jia Liu:
>
>>
>> This patch is the helper define of MIPS ASE DSP.
>>
>> Signed-off-by: Jia Liu
>> ---
>> target-mips/helper.h | 152
>> ++
>> 1 files changed, 152 inse
Am 22.03.2012 14:28, schrieb Stefan Berger:
> On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
>> Fix stupid copy&paste mistake at commit
>> ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
>> "optarg" on the cpu_list() call.
>>
>> Reported-by: Jiri Denemark
>> Signed-off-by: Ed
On 22 March 2012 13:36, Jia Liu wrote:
> This is the helper implementation of MIPS ASE DSP.
>
> Signed-off-by: Jia Liu
git am complains about this patch:
Applying: add MIPS DSP helpers implement
/home/petmay01/linaro/qemu-from-laptop/qemu/.git/rebase-apply/patch:17:
new blank line at EOF.
+
warn
Am 22.03.2012 13:07, schrieb Gerd Hoffmann:
> ... to make vmstate id string truely unique with multiple host
> controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr"
> (usb tabled connected to piix3 uhci).
>
> This obviously breaks migration. To handle this the usb bus
> property "fu
On 22 March 2012 13:36, Jia Liu wrote:
> Jia Liu (4):
> add MIPS DSP helpers define
> add MIPS DSP helpers implement
> add MIPS DSP translation
> add MIPS DSP testcase
You can't split these changes into patches like this.
Every patch needs to be complete of itself, and in particular
it has to
On 22 March 2012 13:36, Jia Liu wrote:
> This is the MIPS ASE DSP Support for Qemu.
> Jia Liu (4):
> add MIPS DSP helpers define
> add MIPS DSP helpers implement
> add MIPS DSP translation
> add MIPS DSP testcase
Most of these patches generate lots of errors when run
through scripts/checkpatc
On Thu, Mar 22, 2012 at 02:46:48PM +0100, Andreas Färber wrote:
> Am 22.03.2012 14:28, schrieb Stefan Berger:
> > On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
> >> Fix stupid copy&paste mistake at commit
> >> ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
> >> "optarg" on
>It's not clear to me why we need to introduce this field to stash
>flags values. bs->open_flags already has this information.
>Originally this was introduced in 06d9260ffa9 ("qcow2: implement
>bdrv_invalidate_cache (v2)") for qcow2. I wonder if that field is
>necessary when we already have bs->
Il 22/03/2012 15:15, Benoît Canet ha scritto:
>
> I added this flag after seeing the following code in in bdrv_open_common.
>
> /*
> * Clear flags that are internal to the block layer before opening the
> * image.
> */
> open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BA
On Thu, Mar 22, 2012 at 10:31:21AM -0300, Eduardo Habkost wrote:
> On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
> > On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
> > > So, trying to summarize what was discussed in the call:
> > >
> > > On Mon, Mar 12, 2012 at 10
On 2012-03-22 01:02, Paolo Bonzini wrote:
> Right now, slirp/slirp.h cannot include some system headers and,
> indirectly, qemu_socket.h. Clean this up, and remove a duplicate
> prototype that was introduced because of that.
>
>
> Signed-off-by: Paolo Bonzini
> ---
> slirp/slirp.h |8 +
Hi,
>> +.driver = "USB",
>> +.property = "full-path",
>> +.value= "no",
>
> This touches on our "favorite" bit/bool topic again. While I agree that
> "no" makes sense for a property of that name, the current code still
> expects "on" and "off". In parti
For one, while non-functional, this patch should probably be reviewed by
the block maintainer to not interfere with already queued patches.
Then the subject should indicate which part of code it touches, like
"block: " or "block/raw-posix.c: ". If Kevin agrees to merge this patch
I would suggest t
Basically, the main wait loop calls qemu_run_all_timers() unconditionally. The
first thing this routine used to do is to see if a timer had been serviced,
and then reset the loop timeout to the next deadline.
However, the new deadlines had not been calculated at that point, as
qemu_run_timers() ha
Am 22.03.2012 15:37, schrieb Gerd Hoffmann:
>>> +.driver = "USB",
>>> +.property = "full-path",
>>> +.value= "no",
>>
>> This touches on our "favorite" bit/bool topic again. While I agree that
>> "no" makes sense for a property of that name, the current cod
Hi,
This patch series implements client-side audio volume support. This reduces
confusion of guest users when volume control is not effective (because mixemu
is disabled or because client-side is muted and can't be unmuted by the guest..)
Instead, the backend is responsible for applying volume
1 - 100 of 187 matches
Mail list logo
