Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Stefan Hajnoczi
On Tue, Aug 30, 2011 at 7:43 PM, Blue Swirl wrote: > On Mon, Aug 29, 2011 at 12:17 PM, Stefan Hajnoczi wrote: >> On Fri, Aug 26, 2011 at 8:06 PM, Blue Swirl wrote: >>> Let guests inject tracepoint data via fw_cfg device. >>> >>> Signed-off-by: Blue Swirl >>> --- >>> The patch is used like this:

[Qemu-devel] [PATCH] rename qemu_malloc and related to glib names for coherence

2011-08-31 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- trace-events | 10 +- vl.c |6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/trace-events b/trace-events index dc300a2..37da2e0 100644 --- a/trace-events +++ b/trace-events @@ -14,7 +14,7 @@ # # [disable] ( [, ]

Re: [Qemu-devel] [PATCH] rename qemu_malloc and related to glib names for coherence

2011-08-31 Thread Stefan Hajnoczi
On Wed, Aug 31, 2011 at 8:25 AM, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- >  trace-events |   10 +- >  vl.c         |    6 +++--- >  2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-31 Thread Kevin Wolf
Am 30.08.2011 20:29, schrieb Alexander Graf: > > On 30.08.2011, at 19:25, Stefan Weil wrote: > >> Am 30.08.2011 09:44, schrieb Kevin Wolf: >>> Am 29.08.2011 21:55, schrieb Stefan Weil: Am 29.08.2011 10:34, schrieb TeLeMan: > On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: >> Am 28

Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc

2011-08-31 Thread Jan Kiszka
On 2011-08-31 02:03, Chris Friesen wrote: > Hi, > > I've run into another problem. I configured qemu-kvm-0.15.0 as: > > ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl > --disable-vnc --disable-curses > > > Building it, I get: > > CCi386-softmmu/pcspk.o > CC

[Qemu-devel] [PATCH] vhost: Fix typo in comment

2011-08-31 Thread Amos Kong
vhost_dev_stop() and vhost_dev_disable_notifiers() are called in vhost_net_stop(), correct this comment. Signed-off-by: Amos Kong --- hw/vhost.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vhost.c b/hw/vhost.c index 0870cb7..640aff0 100644 --- a/hw/vhost.c +++ b/

Re: [Qemu-devel] [PATCH] vhost: Fix typo in comment

2011-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2011 at 03:43:48PM +0800, Amos Kong wrote: > vhost_dev_stop() and vhost_dev_disable_notifiers() are called in > vhost_net_stop(), correct this comment. > > Signed-off-by: Amos Kong > --- > hw/vhost.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/

Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc

2011-08-31 Thread Kevin Wolf
Am 31.08.2011 09:40, schrieb Jan Kiszka: > On 2011-08-31 02:03, Chris Friesen wrote: >> Hi, >> >> I've run into another problem. I configured qemu-kvm-0.15.0 as: >> >> ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl >> --disable-vnc --disable-curses >> >> >> Building it, I g

[Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Yonit Halperin
if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored further interrupts of the same kind, since ram->int_pending was set. As a result, the gues

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-08-31 Thread Peter Maydell
On 30 August 2011 20:28, Jan Kiszka wrote: > Yes, that's the current state. Once we have bidirectional IRQ links in > place (pushing downward, querying upward - required to skip IRQ routers > for fast, lockless deliveries), that should change again. Can you elaborate a bit more on this? I don't t

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-08-31 Thread Avi Kivity
On 08/30/2011 10:19 PM, Blue Swirl wrote: > > We need some kind of two phase restore. In the first phase all state is > restored; since some of that state drivers outputs that are input to other > devices, they may experience an edge, and we need to supress that. In the > second phase edge d

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Avi Kivity
On 08/26/2011 10:06 PM, Blue Swirl wrote: Let guests inject tracepoint data via fw_cfg device. At least on x86, fw_cfg is pretty slow, involving multiple exits. IMO, for kvm, even one exit per tracepoint is too high. We need to use a shared memory transport with a way to order guest/host

Re: [Qemu-devel] [PATCH] vhost: Fix typo in comment

2011-08-31 Thread Amos Kong
- Original Message - > On Wed, Aug 31, 2011 at 03:43:48PM +0800, Amos Kong wrote: > > vhost_dev_stop() and vhost_dev_disable_notifiers() are called in > > vhost_net_stop(), correct this comment. > > > > Signed-off-by: Amos Kong > > --- > > hw/vhost.c | 2 +- > > 1 files changed, 1 inserti

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Stefan Hajnoczi
On Wed, Aug 31, 2011 at 11:38:50AM +0300, Avi Kivity wrote: > On 08/26/2011 10:06 PM, Blue Swirl wrote: > >Let guests inject tracepoint data via fw_cfg device. > > > > > > At least on x86, fw_cfg is pretty slow, involving multiple exits. > IMO, for kvm, even one exit per tracepoint is too high. W

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Avi Kivity
On 08/31/2011 12:08 PM, Stefan Hajnoczi wrote: > > At least on x86, fw_cfg is pretty slow, involving multiple exits. > IMO, for kvm, even one exit per tracepoint is too high. We need to > use a shared memory transport with a way to order guest/host events > later on (by using a clock). It d

Re: [Qemu-devel] [PATCH V2] Memory API conversion for mpic (openpic.c)

2011-08-31 Thread Avi Kivity
On 08/30/2011 06:46 PM, Fabien Chouteau wrote: This patch converts mpic to the new memory API (through old mmio). I got two copies of this, which one is the right one? This one looks good. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] pseries machine updates

2011-08-31 Thread Alexander Graf
On 11.08.2011, at 02:39, David Gibson wrote: > On Wed, Aug 10, 2011 at 05:16:35PM +0200, Alexander Graf wrote: >> On 08/04/2011 09:02 AM, David Gibson wrote: >>> Hi Alex, >>> >>> Here's another batch of assorted updates for the pseries machine. >> >> Looks pretty nice. Please update patch 2/6 w

Re: [Qemu-devel] pseries machine updates

2011-08-31 Thread Alexander Graf
On 11.08.2011, at 02:44, David Gibson wrote: > On Wed, Aug 10, 2011 at 05:24:59PM +0200, Alexander Graf wrote: >> On 08/10/2011 05:16 PM, Alexander Graf wrote: >>> On 08/04/2011 09:02 AM, David Gibson wrote: Hi Alex, Here's another batch of assorted updates for the pseries machine

Re: [Qemu-devel] [PATCH 1/2] pseries: use macro for firmware filename

2011-08-31 Thread Alexander Graf
On 11.08.2011, at 04:36, David Gibson wrote: > From: Nishanth Aravamudan > > For some time we've had a nicely defined macro with the filename for our > firmware image. However we didn't actually use it in the place we're > supposed to. This patch fixes it. > > Signed-off-by: Nishanth Aravamu

Re: [Qemu-devel] [PATCH 2/2] pseries: Implement hcall-bulk hypervisor interface

2011-08-31 Thread Alexander Graf
On 11.08.2011, at 04:36, David Gibson wrote: > This patch adds support for the H_REMOVE_BULK hypercall on the pseries > machine. Strictly speaking this isn't necessarym since the kernel will > only attempt to use this if hcall-bulk is advertised in the device tree, > which previously it was not.

Re: [Qemu-devel] [PATCH V2] Memory API conversion for mpic (openpic.c)

2011-08-31 Thread Fabien Chouteau
On 31/08/2011 11:16, Avi Kivity wrote: > On 08/30/2011 06:46 PM, Fabien Chouteau wrote: >> This patch converts mpic to the new memory API (through old mmio). > > I got two copies of this, which one is the right one? Excuse me, I sent the same patch twice... -- Fabien Chouteau

Re: [Qemu-devel] [PATCH V2] Memory API conversion for mpic (openpic.c)

2011-08-31 Thread Avi Kivity
On 08/31/2011 12:22 PM, Fabien Chouteau wrote: On 31/08/2011 11:16, Avi Kivity wrote: > On 08/30/2011 06:46 PM, Fabien Chouteau wrote: >> This patch converts mpic to the new memory API (through old mmio). > > I got two copies of this, which one is the right one? Excuse me, I sent the same pat

Re: [Qemu-devel] [PATCH V2] Memory API conversion for mpic (openpic.c)

2011-08-31 Thread Fabien Chouteau
On 31/08/2011 11:35, Avi Kivity wrote: > On 08/31/2011 12:22 PM, Fabien Chouteau wrote: >> On 31/08/2011 11:16, Avi Kivity wrote: >> > On 08/30/2011 06:46 PM, Fabien Chouteau wrote: >> >> This patch converts mpic to the new memory API (through old mmio). >> > >> > I got two copies of this, which

Re: [Qemu-devel] [PATCH v7 05/13] trace: avoid conditional code compilation during option parsing

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 09:18:04PM +0200, Lluís wrote: > diff --git a/trace/control.h b/trace/control.h > new file mode 100644 > index 000..80526f7 > --- /dev/null > +++ b/trace/control.h > @@ -0,0 +1,23 @@ > +/* > + * Interface for configuring and controlling the state of tracing events. > + *

Re: [Qemu-devel] [PATCH v7 08/13] trace-state: always compile support for controlling and querying trace event states

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 09:18:24PM +0200, Lluís wrote: > The current interface is generic for this small set of operations, and thus > other backends can easily modify the "trace/control.c" file to add their own > implementation. > > Signed-off-by: Lluís Vilanova > --- > docs/tracing.txt | 39

Re: [Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 09:17:31PM +0200, Lluís wrote: > This patch defines the "disable" trace event state to always use the "nop" > backend. > > As a side-effect, all events are now enabled (without "disable") by default, > as > all backends (except "stderr") have programmatic support for dynam

Re: [Qemu-devel] [PATCH v7 11/13] trace-state: [simple] disable all trace points by default

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 09:18:43PM +0200, Lluís wrote: > Note that this refers to the backend-specific state (whether the output must > be > generated), not the event "disabled" property (which always uses the "nop" > backend). > > Signed-off-by: Lluís Vilanova > --- > scripts/tracetool |9

Re: [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Gerd Hoffmann
On 08/31/11 10:20, Yonit Halperin wrote: if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored further interrupts of the same kind, since ram-

[Qemu-devel] [PATCH 0/2] Fix packing for MinGW with new macro QEMU_PACKED

2011-08-31 Thread Stefan Weil
The new series adds macro QEMU_PACKED and converts most code locations mechanically (script) to use this macro. See log message of patch 2/2 for the few exceptions. [PATCH 1/2] Add new macro QEMU_PACKED for packed C structures [PATCH 2/2] Use new macro QEMU_PACKED for packed structures Cheers, S

[Qemu-devel] [PATCH 1/2] Add new macro QEMU_PACKED for packed C structures

2011-08-31 Thread Stefan Weil
A packed struct needs different gcc attributes for compilations with MinGW compilers because glib-2.0 adds compiler flag -mms-bitfields which modifies the packing algorithm. Attribute gcc_struct reverses the negative effects of -mms-bitfields. QEMU_PACKED sets this attribute and must be used for a

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-08-31 Thread Jan Kiszka
On 2011-08-31 10:25, Peter Maydell wrote: > On 30 August 2011 20:28, Jan Kiszka wrote: >> Yes, that's the current state. Once we have bidirectional IRQ links in >> place (pushing downward, querying upward - required to skip IRQ routers >> for fast, lockless deliveries), that should change again. >

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Jan Kiszka
On 2011-08-31 11:08, Stefan Hajnoczi wrote: > On Wed, Aug 31, 2011 at 11:38:50AM +0300, Avi Kivity wrote: >> On 08/26/2011 10:06 PM, Blue Swirl wrote: >>> Let guests inject tracepoint data via fw_cfg device. >>> >>> >> >> At least on x86, fw_cfg is pretty slow, involving multiple exits. >> IMO, for

Re: [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Yonit Halperin
On 08/31/2011 01:23 PM, Gerd Hoffmann wrote: On 08/31/11 10:20, Yonit Halperin wrote: if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored f

Re: [Qemu-devel] [PATCH v7 05/13] trace: avoid conditional code compilation during option parsing

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 8:18 PM, Lluís wrote: > diff --git a/vl.c b/vl.c > index 145d738..ed2db9a 100644 > --- a/vl.c > +++ b/vl.c > @@ -156,7 +156,7 @@ int main(int argc, char **argv) >  #include "slirp/libslirp.h" > >  #include "trace.h" > -#include "trace/simple.h" > +#include "trace/control.h"

Re: [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Gerd Hoffmann
Hi, You can call qxl_set_irq unconditionally, it checks for int_pending anyway. Hi, qxl_set_irq doesn't test int_pending, but it will call qemu_set_irq with level=0 if !int_pending. Yes. Also checks int_mask. That is fine, isn't it? BTW: qxl_update_irq would be a better name, this is w

Re: [Qemu-devel] [PATCH v7 03/13] trace: [make] replace 'ifeq' with values in CONFIG_TRACE_*

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 8:17 PM, Lluís wrote: > Signed-off-by: Lluís Vilanova > --- >  Makefile.objs |   12 +--- >  1 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index 44d7238..aaf6542 100644 > --- a/Makefile.objs > +++ b/Makefile.objs >

Re: [Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-31 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 8:17 PM, Lluís wrote: > This patch defines the "disable" trace event state to always use the "nop" > backend. > > As a side-effect, all events are now enabled (without "disable") by default, > as > all backends (except "stderr") have programmatic support for dynamically >

[Qemu-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Yonit Halperin
if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored further interrupts of the same kind, since ram->int_pending was set. As a result, the gues

[Qemu-devel] [PATCH v2 2/2] qxl: s/qxl_set_irq/qxl_update_irq/

2011-08-31 Thread Yonit Halperin
--- hw/qxl.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index c7edc60..3ddca88 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -808,7 +808,7 @@ static void qxl_exit_vga_mode(PCIQXLDevice *d) qxl_destroy_primary(d, QXL_SYNC); } -static vo

Re: [Qemu-devel] [PATCH 1/1] USB XHCI emulation

2011-08-31 Thread Alexander Graf
On 31.08.2011, at 12:32, Juan Antonio Moya Vicén wrote: > Author: Hector Martin > > [Patch applies to stable/0.14 or to featured snapshot kvm-0.14.1] > > This patch adds support for USB XHCI controller emulation, presented in > the guest as a Renesas NEC USB 3.0 device (part UPD720200) > > We

Re: [Qemu-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-08-31 Thread Gerd Hoffmann
On 08/31/11 14:37, Yonit Halperin wrote: if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored further interrupts of the same kind, since ram-

Re: [Qemu-devel] [PATCH 1/1] USB XHCI emulation

2011-08-31 Thread Juan Antonio Moya Vicén
Sure! As Gerd pointed out (I'm quoting him here) "Right now the code winds up libusb directly and supports pass-through only. It doesn't integrate with the qemu usb subsystem at all and you can't hook up emulated usb devices to xhci. I can see why you are doing that given the state of the qemu u

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread malc
On Tue, 30 Aug 2011, Anthony Liguori wrote: > On 08/30/2011 08:30 PM, malc wrote: > > On Tue, 30 Aug 2011, Anthony Liguori wrote: > > > > > This won't even come close to passing checkpatch.pl > > > > Have you actually tried? > > Sigh. I was hoping checkpatch.pl was more useful than it appears

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread Anthony Liguori
On 08/31/2011 08:17 AM, malc wrote: On Tue, 30 Aug 2011, Anthony Liguori wrote: On 08/30/2011 08:30 PM, malc wrote: On Tue, 30 Aug 2011, Anthony Liguori wrote: This won't even come close to passing checkpatch.pl Have you actually tried? Sigh. I was hoping checkpatch.pl was more useful t

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread bifferos
--- On Wed, 31/8/11, malc wrote: > From: malc > Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC > To: "Anthony Liguori" > Cc: qemu-devel@nongnu.org, "bifferos" > Date: Wednesday, 31 August, 2011, 14:17 > On Tue, 30 Aug 2011, Anthony Liguori > wrote: > > > On 08/30/2011 08:30 PM,

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-08-31 Thread Stefan Hajnoczi
On Wed, Aug 31, 2011 at 10:11 AM, Avi Kivity wrote: > On 08/31/2011 12:08 PM, Stefan Hajnoczi wrote: >> >> > >> >  At least on x86, fw_cfg is pretty slow, involving multiple exits. >> >  IMO, for kvm, even one exit per tracepoint is too high.  We need to >> >  use a shared memory transport with a

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread malc
On Wed, 31 Aug 2011, Anthony Liguori wrote: > On 08/31/2011 08:17 AM, malc wrote: > > On Tue, 30 Aug 2011, Anthony Liguori wrote: > > > > > On 08/30/2011 08:30 PM, malc wrote: > > > > On Tue, 30 Aug 2011, Anthony Liguori wrote: > > > > > > > > > This won't even come close to passing checkpatch.p

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread Anthony Liguori
On 08/31/2011 08:39 AM, malc wrote: On Wed, 31 Aug 2011, Anthony Liguori wrote: On 08/31/2011 08:17 AM, malc wrote: On Tue, 30 Aug 2011, Anthony Liguori wrote: On 08/30/2011 08:30 PM, malc wrote: On Tue, 30 Aug 2011, Anthony Liguori wrote: This won't even come close to passing checkpatch.

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread malc
On Wed, 31 Aug 2011, Anthony Liguori wrote: > On 08/31/2011 08:39 AM, malc wrote: > > On Wed, 31 Aug 2011, Anthony Liguori wrote: > > > > > On 08/31/2011 08:17 AM, malc wrote: > > > > On Tue, 30 Aug 2011, Anthony Liguori wrote: > > > > > > > > > On 08/30/2011 08:30 PM, malc wrote: > > > > > > On

Re: [Qemu-devel] [PATCH v2 2/4] kvm: ppc: booke206: use MMU API

2011-08-31 Thread Alexander Graf
On 18.08.2011, at 22:38, Scott Wood wrote: > Share the TLB array with KVM. This allows us to set the initial TLB > both on initial boot and reset, is useful for debugging, and could > eventually be used to support migration. > > Signed-off-by: Scott Wood > --- > v2 (was 1/3 in v1): > updated f

[Qemu-devel] [PATCH] simpletrace: fix process() argument count

2011-08-31 Thread Stefan Hajnoczi
The simpletrace.process() function invokes analyzer methods with the wrong number of arguments if a timestamp should be included. This patch fixes the issue so that trace analysis scripts can make use of timestamps. Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py |4 ++-- 1 files

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread Anthony Liguori
On 08/31/2011 08:51 AM, malc wrote: On Wed, 31 Aug 2011, Anthony Liguori wrote: On 08/31/2011 08:39 AM, malc wrote: On Wed, 31 Aug 2011, Anthony Liguori wrote: On 08/31/2011 08:17 AM, malc wrote: On Tue, 30 Aug 2011, Anthony Liguori wrote: On 08/30/2011 08:30 PM, malc wrote: On Tue, 30 A

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread malc
On Wed, 31 Aug 2011, Anthony Liguori wrote: > On 08/31/2011 08:51 AM, malc wrote: > > On Wed, 31 Aug 2011, Anthony Liguori wrote: > > > > > On 08/31/2011 08:39 AM, malc wrote: > > > > On Wed, 31 Aug 2011, Anthony Liguori wrote: > > > > > > > > > On 08/31/2011 08:17 AM, malc wrote: > > > > > > On

[Qemu-devel] [PATCH V8 03/14] Add persistent state handling to TPM TIS frontend driver

2011-08-31 Thread Stefan Berger
This patch adds support for handling of persistent state to the TPM TIS frontend. The currently used buffer is determined (can only be in currently active locality and either be a read or a write buffer) and only that buffer's content is stored. The reverse is done when the state is restored from

[Qemu-devel] [PATCH V8 06/14] Add a TPM backend skeleton implementation

2011-08-31 Thread Stefan Berger
This patch provides a TPM backend skeleton implementation. It doesn't do anything useful (except for returning error response for every TPM command) but it compiles. It serves as the basis for the libtpms based backend as well as the null driver backend. v6: - moved unused variable out_len to su

[Qemu-devel] [PATCH V8 01/14] Support for TPM command line options

2011-08-31 Thread Stefan Berger
This patch adds support for TPM command line options. The command line supported here (considering the libtpms based backend) are ./qemu-... -tpm builtin,path= and ./qemu-... -tpmdev builtin,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar t

[Qemu-devel] [PATCH V8 07/14] Implementation of the libtpms-based backend

2011-08-31 Thread Stefan Berger
This patch provides the glue for the TPM TIS interface (frontend) to the libtpms that provides the actual TPM functionality. Some details: This part of the patch provides support for the spawning of a thread that will interact with the libtpms-based TPM. It expects a signal from the frontend to w

[Qemu-devel] [PATCH V8 00/14] Qemu Trusted Platform Module (TPM) integration

2011-08-31 Thread Stefan Berger
The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabling for examp

[Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-08-31 Thread Stefan Berger
This patch adds encryption of the individual state blobs that are written into the block storage. The 'directory' at the beginnig of the block storage is not encrypted. The encryption support added in this patch would also work if QCoW2 was not to be used as the (only) image file format to store t

[Qemu-devel] [PATCH V8 09/14] Add block storage support for libtpms based TPM backend

2011-08-31 Thread Stefan Berger
This patch adds support for storing the TPM's persistent state into Qemu block storage, i.e., QCoW2. The TPM creates state of varying size, depending for example on how many keys are loaded into it at a certain time. The worst-case sizes of the different blobs the TPM can write have been pre-calcu

[Qemu-devel] [PATCH V8 04/14] Add tpm_tis driver to build process

2011-08-31 Thread Stefan Berger
The TPM interface (tpm_tis) needs to be explicitly enabled via ./configure --enable-tpm. This patch also restricts the building of the TPM support to i386 and x86_64 targets since only there it is currently supported. This prevents that one will end up with support for a frontend but no available b

[Qemu-devel] [PATCH V8 14/14] Allow to provide inital TPM state

2011-08-31 Thread Stefan Berger
This patch adds a -tpm ...,initstate=...,... command line option to the TPM's existing options and enables the TPM to be initialized with an existing state blob. This in turn allows us to simulate TPM manufacturing and equip the TPM with an endorsement key, certificates and initialize its NVRAM are

[Qemu-devel] [PATCH 1/9] milkymist-ac97: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-ac97.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-ac97.c b/hw/milkymist-ac97.c index 6104732..5c5ed27 100644 --- a/hw/milkymist-ac97.c +++ b/hw/milkymist-ac97.c @@ -53,6 +53,7

[Qemu-devel] [PATCH 0/9] Memory API conversion for milkymist models

2011-08-31 Thread Michael Walle
This patchset converts the remaining milkymist models to the new memory API. Additionally, it fixes a minor naming issue. This patches are againts avi's memory/master branch, for inclusion into his memory queue. Michael Walle (9): milkymist-ac97: convert to memory API milkymist-hpdmc: convert

[Qemu-devel] [PATCH 4/9] milkymist-pfpu: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-pfpu.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/milkymist-pfpu.c b/hw/milkymist-pfpu.c index 306d1ce..672f6e4 100644 --- a/hw/milkymist-pfpu.c +++ b/hw/milkymist-pfpu.c @@ -118,6 +11

[Qemu-devel] [PATCH 3/9] milkymist-memcard: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-memcard.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-memcard.c b/hw/milkymist-memcard.c index 22dc377..fb6e558 100644 --- a/hw/milkymist-memcard.c +++ b/hw/milkymist-memcard.c

[Qemu-devel] [PATCH 9/9] milkymist-{minimac2, softusb}: rename memory names

2011-08-31 Thread Michael Walle
Be consistent with other milkymist models. Signed-off-by: Michael Walle --- hw/milkymist-minimac2.c |4 ++-- hw/milkymist-softusb.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/milkymist-minimac2.c b/hw/milkymist-minimac2.c index fb48e37..85d9400 100644 ---

[Qemu-devel] [PATCH 7/9] milkymist-uart: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-uart.c | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-uart.c b/hw/milkymist-uart.c index e8e309d..128cd8c 100644 --- a/hw/milkymist-uart.c +++ b/hw/milkymist-uart.c @@ -35,7 +35,

[Qemu-devel] [PATCH 8/9] milkymist-vgafb: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-vgafb.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/milkymist-vgafb.c b/hw/milkymist-vgafb.c index 2e55e42..be81abd 100644 --- a/hw/milkymist-vgafb.c +++ b/hw/milkymist-vgafb.c @@ -64,6

[Qemu-devel] [PATCH V8 13/14] Add a TPM backend null driver implementation

2011-08-31 Thread Stefan Berger
This patch adds a TPM null driver implementation acting as a backend for the TIS hardware emulation. The NULL driver responds to all commands with a TPM fault response. To use this null driver, use either -tpm null or -tpmdev null,id=tpm0 -device tpm-tis,tpmdev=tpm0 as parameters on the comman

Re: [Qemu-devel] [PATCH 0/9] Memory API conversion for milkymist models

2011-08-31 Thread Avi Kivity
On 08/31/2011 05:48 PM, Michael Walle wrote: This patchset converts the remaining milkymist models to the new memory API. Additionally, it fixes a minor naming issue. This patches are againts avi's memory/master branch, for inclusion into his memory queue. Added to memory/queue, thanks! --

[Qemu-devel] [PATCH V8 12/14] Support for taking measurements when kernel etc. are passed to Qemu

2011-08-31 Thread Stefan Berger
This patch adds support for hashing the kernel and initrd as well as the command line parameters in the case that Qemu was provided the -kernel, -initrd and -apppend command line parameters. The hashes are then passed to SeaBIOS for logging. Typically SeaBIOS would take those measurements (hashing)

[Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-08-31 Thread Stefan Berger
This patch introduces file locking via fcntl() for the block layer so that concurrent access to files shared by 2 Qemu instances, for example via NFS, can be serialized. This feature is useful primarily during initial phases of VM migration where the target machine's TIS driver validates the block

[Qemu-devel] [PATCH 6/9] milkymist-tmu2: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-tmu2.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-tmu2.c b/hw/milkymist-tmu2.c index 790cdcb..82cb6af 100644 --- a/hw/milkymist-tmu2.c +++ b/hw/milkymist-tmu2.c @@ -77,6 +77,7

[Qemu-devel] [PATCH V8 11/14] Experimental support for block migrating TPMs state

2011-08-31 Thread Stefan Berger
This patch adds (experimental) support for block migration. In the case of block migration an empty QCoW2 image must be found on the destination so that early checks on the content and whether it can be decrytped with the provided key have to be skipped. That empty file needs to be created by high

[Qemu-devel] Temporary kvm and qemu git repositories

2011-08-31 Thread Avi Kivity
Since master.kernel.org is down for maintenance, I've set up temporary repositories on github: git://github.com/avikivity/kvm.git git://github.com/avikivity/qemu.git Please use these instead of kvm.git and qemu-kvm.git until further notice. -- error compiling committee.c: too many argument

[Qemu-devel] [PATCH 2/9] milkymist-hpdmc: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-hpdmc.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-hpdmc.c b/hw/milkymist-hpdmc.c index c0962fb..17c840f 100644 --- a/hw/milkymist-hpdmc.c +++ b/hw/milkymist-hpdmc.c @@ -42,12

[Qemu-devel] [PATCH V8 02/14] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-08-31 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

[Qemu-devel] [PATCH V8 05/14] Add a debug register

2011-08-31 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). v3: - all output goes to stderr Signed-off-by: Stefan Berger --- hw/tpm_tis.c | 67

[Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev

2011-08-31 Thread Peter Maydell
This patchset converts the omap_intc device to MemoryRegion and qdev. The MemoryRegion conversion is fairly straightforward; the slight ugliness of using get_system_memory() is just so it can be pulled out as a separate patch for review and is dropped in the qdevification patch. The bulk of the q

[Qemu-devel] [PATCH 1/2] omap_intc: Use MemoryRegion API

2011-08-31 Thread Peter Maydell
Convert omap_intc to use the MemoryRegion API Signed-off-by: Peter Maydell --- hw/omap_intc.c | 64 ++- 1 files changed, 30 insertions(+), 34 deletions(-) diff --git a/hw/omap_intc.c b/hw/omap_intc.c index f1f570e..38637c6 100644 --- a/hw/om

[Qemu-devel] [PATCH 2/2] omap_intc: Qdevify

2011-08-31 Thread Peter Maydell
Convert the omap_intc devices to qdev. This includes adding a 'revision' property which will be needed for omap3. The bulk of this patch is the replacement of "s->irq[x][y]" with "qdev_get_gpio_in(s->ih[x], y)" now that the interrupt controller exposes its input lines as qdev gpio inputs. The de

[Qemu-devel] [PATCH 5/9] milkymist-sysctl: convert to memory API

2011-08-31 Thread Michael Walle
Signed-off-by: Michael Walle --- hw/milkymist-sysctl.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/milkymist-sysctl.c b/hw/milkymist-sysctl.c index 7b2d544..5783f08 100644 --- a/hw/milkymist-sysctl.c +++ b/hw/milkymist-sysctl.c @@ -

Re: [Qemu-devel] Temporary kvm and qemu git repositories

2011-08-31 Thread Lucas Meneghel Rodrigues
On 08/31/2011 12:38 PM, Avi Kivity wrote: Since master.kernel.org is down for maintenance, I've set up temporary repositories on github: git://github.com/avikivity/kvm.git git://github.com/avikivity/qemu.git Please use these instead of kvm.git and qemu-kvm.git until further notice. Ok, thanks

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread Anthony Liguori
On 08/31/2011 09:35 AM, malc wrote: On Wed, 31 Aug 2011, Anthony Liguori wrote: Upper case field names are not okay. If you think coding style isn't clear, that's a bug in coding style. Sez hu? Coding style is garbage that should be thrown out of the window. As for looking, yeah, i'm looking

Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify

2011-08-31 Thread Peter Maydell
On 31 August 2011 16:55, Peter Maydell wrote: > Convert the omap_intc devices to qdev. This includes adding > a 'revision' property which will be needed for omap3. Incidentally this patch is a test case for a false positive in checkpatch.pl, which complains: ERROR: need consistent spacing around

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-08-31 Thread malc
On Wed, 31 Aug 2011, Anthony Liguori wrote: > On 08/31/2011 09:35 AM, malc wrote: > > On Wed, 31 Aug 2011, Anthony Liguori wrote: > > > > > Upper case field names are not okay. If you think coding style isn't > > > clear, > > > that's a bug in coding style. > > > > Sez hu? Coding style is garba

[Qemu-devel] [PATCH] linux-user: Implement new ARM 64 bit cmpxchg kernel helper

2011-08-31 Thread Dr. David Alan Gilbert
linux-user: Implement new ARM 64 bit cmpxchg kernel helper Linux 3.1 will have a new kernel-page helper for ARM implementing 64 bit cmpxchg. Implement this helper in QEMU linux-user mode: * Provide kernel helper emulation for 64bit cmpxchg * Allow guest to object to guest offset to ensure it

Re: [Qemu-devel] [PATCH] Probe HPET existence

2011-08-31 Thread Jan Kiszka
On 2011-08-30 02:35, Kevin O'Connor wrote: > On Mon, Aug 29, 2011 at 05:50:10PM +0200, Jan Kiszka wrote: >> QEMU does not provide a HPET block if it was configured with -no-hpet, >> other machines SeaBIOS runs on may lack a HPET as well. Perform basic >> checks the ID register for a reasonable vend

Re: [Qemu-devel] [PULL] Another fix for rom_device

2011-08-31 Thread Avi Kivity
On 08/30/2011 11:25 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core Also available from: git://github.com/avikivity/qemu.git memory/core -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to co

[Qemu-devel] [PATCH v8 00/14] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-31 Thread Lluís
This patch defines the "disable" trace event state to always use the "nop" backend. As a side-effect, all events are now enabled (without "disable") by default, as all backends (except "stderr") have programmatic support for dynamically (de)activating each trace event. In order to make this true,

[Qemu-devel] [PATCH v8 01/14] build: Fix linkage of QEMU_PROG

2011-08-31 Thread Lluís
Using '$^' to establish the files to link with will remove any repeated entries in the list of dependencies. Signed-off-by: Lluís Vilanova --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 70fa1ae..d3ac8c5 100644

[Qemu-devel] [PATCH v8 02/14] build: [simple] Include qemu-timer-common.o in trace-obj-y

2011-08-31 Thread Lluís
Helper programs like qemu-ga use tracing primitives, but qemu-timer-common.o (also used by simpletrace.o) is not necessarily included in the linkage line. Signed-off-by: Lluís Vilanova --- Makefile.objs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Mak

[Qemu-devel] [PATCH v8 03/14] trace: [configure] rename CONFIG_*_TRACE into CONFIG_TRACE_*

2011-08-31 Thread Lluís
Provides a more hierarchical view of the variable domain. Also adds the CONFIG_TRACE_* variables for all backends. Signed-off-by: Lluís Vilanova --- Makefile.target |6 +++--- configure | 20 +++- hmp-commands.hx |4 ++-- monitor.c |8

[Qemu-devel] [PATCH v8 05/14] trace: move backend-specific code into the trace/ directory

2011-08-31 Thread Lluís
Signed-off-by: Lluís Vilanova --- Makefile |1 Makefile.objs |6 + scripts/tracetool |2 simpletrace.c | 355 - simpletrace.h | 48 --- trace/simple.c| 355 ++

Re: [Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour of "disable" consistent across all backends

2011-08-31 Thread Lluís
Stefan Hajnoczi writes: > On Thu, Aug 25, 2011 at 8:17 PM, Lluís wrote: >> This patch defines the "disable" trace event state to always use the "nop" >> backend. >> >> As a side-effect, all events are now enabled (without "disable") by default, >> as >> all backends (except "stderr") have progr

[Qemu-devel] [PATCH v8 08/14] trace-state: separate trace event control and query routines from the simple backend

2011-08-31 Thread Lluís
Generalize the 'st_print_trace_events' and 'st_change_trace_event_state' into backend-specific 'trace_print_events' and 'trace_event_set_state' (respectively) in the "trace/control.h" file. Signed-off-by: Lluís Vilanova --- hmp-commands.hx |2 +- monitor.c | 11 ++- trace/con

[Qemu-devel] [PATCH v8 09/14] trace-state: always compile support for controlling and querying trace event states

2011-08-31 Thread Lluís
The current interface is generic for this small set of operations, and thus other backends can easily modify the "trace/control.c" file to add their own implementation. Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 48 ++-- hmp-commands.hx |

[Qemu-devel] [PATCH v8 11/14] trace-state: always use the "nop" backend on events with the "disable" keyword

2011-08-31 Thread Lluís
Any event with the keyword/property "disable" generates an empty trace event using the "nop" backend, regardless of the current backend. Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 25 +++-- scripts/tracetool | 15 ++- 2 files changed, 17 insertions(

[Qemu-devel] [PATCH v8 10/14] trace-state: add "-trace events" argument to control initial state

2011-08-31 Thread Lluís
The "-trace events" argument can be used to provide a file with a list of trace event names that will be enabled prior to starting execution, thus providing early tracing. This saves the user from manually toggling event states through the monitor interface or whichever backend-specific interface.

  1   2   3   >