On Thu, Aug 25, 2011 at 8:17 PM, Lluís <xscr...@gmx.net> wrote: > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > --- > Makefile.objs | 12 +++++------- > 1 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index 44d7238..aaf6542 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -374,16 +374,14 @@ endif > > simpletrace.o: simpletrace.c $(GENERATED_HEADERS) > > -ifeq ($(TRACE_BACKEND),dtrace) > -trace-obj-y = trace-dtrace.o > -else > +trace-obj-$(CONFIG_TRACE_SYSTEMTAP) += trace-dtrace.o > +ifneq ($(TRACE_BACKEND),dtrace)
ifeq ($(TRACE_BACKEND),dtrace) is not equivalent to ifeq ($(CONFIG_TRACE_SYSTEMTAP),y). There are 3 cases here: 1. The backend is not DTrace-like (e.g. stderr, simple, ust). 2. The backend is SystemTap (i.e. Fedora and Red Hat builds). 3. The backend is DTrace-like (i.e. Illumos real DTrace) For most of the build 2 & 3 should be treated the same. The only case where we care about SystemTap specifically is when building .stp files. Therefore we need to introduce a CONFIG_TRACE_DTRACE in ./configure and use that instead of CONFIG_TRACE_SYSTEMTAP here. If we were to use CONFIG_TRACE_SYSTEMTAP here then Illumos host builds will not be able to use real DTrace. Stefan
