Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Peter Maydell
On 9 June 2011 14:59, Markus Armbruster wrote: > The fact that we duplicate qtree information in a separate list "busses" > either means we've been too lazy to garbage collect busses, or we've > failed to make working with the qtree as easy as it should be. If you get rid of busses you need to up

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Gerd Hoffmann
Hi, Gave up after resending it one or two times, the forgot about it, wasn't *that* important to me. Still got a pointer to the patch? Not in my git tree any more. Google found me this instead: http://permalink.gmane.org/gmane.comp.emulators.qemu/74360 Looks like I'm not the only one wh

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Peter Maydell writes: > >> If you have a model with more than one USB bus, and you >> create a USB device on the command line without specifying >> which bus to plug it into, QEMU will choose a different bus >> depending on whether you use the legacy "-usbdevic

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Peter Maydell
On 8 June 2011 18:37, Andreas Färber wrote: > From Peter's description I believe this could be the root cause of Rob's > reversed -net /dev/ethX devices as well? That supposedly broke with 0.14. So > for setups earlier than 0.14 reversing would be a bugfix, but if people > adapted to 0.14 behavior

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Andreas Färber
Am 08.06.2011 um 19:39 schrieb Peter Maydell: On 8 June 2011 18:37, Andreas Färber wrote: From Peter's description I believe this could be the root cause of Rob's reversed -net /dev/ethX devices as well? That supposedly broke with 0.14. So for setups earlier than 0.14 reversing would be a b

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Andreas Färber
Hi, Am 08.06.2011 um 19:00 schrieb Gerd Hoffmann: Since qbus_create_inplace() adds each new child bus to the front of the parent's child_bus list, this means that qbus_find_recursive() will encounter the last-added bus first, whereas usb_bus_find() will get the first-added bus. Quite a while

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Rob Landley
On 06/08/2011 12:39 PM, Peter Maydell wrote: > On 8 June 2011 18:37, Andreas Färber wrote: >> From Peter's description I believe this could be the root cause of Rob's >> reversed -net /dev/ethX devices as well? That supposedly broke with 0.14. So >> for setups earlier than 0.14 reversing would be

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Gerd Hoffmann
Hi, Since qbus_create_inplace() adds each new child bus to the front of the parent's child_bus list, this means that qbus_find_recursive() will encounter the last-added bus first, whereas usb_bus_find() will get the first-added bus. Quite a while back I've tried to switch qdev from QLIST to

[Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Peter Maydell
If you have a model with more than one USB bus, and you create a USB device on the command line without specifying which bus to plug it into, QEMU will choose a different bus depending on whether you use the legacy "-usbdevice keyboard" or the qdev "-device usb-kbd". This is because the legacy opt