Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-23 Thread Pavel Dovgalyuk
On 23.12.2024 20:26, Peter Xu wrote: On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: Migration reads CLOCK_HOST when not holding the replay_mutex, which assert

Re: [PATCH 00/17] replay: Fixes and avocado test updates

2024-12-20 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 20.12.2024 13:42, Nicholas Piggin wrote: Hi, This is another round of replay fixes posted here https://lore.kernel.org/qemu-devel/20240813050638.446172-1-npig...@gmail.com/ A bunch of those fixes have been merged, but there are still some outstanding here

Re: [RFC/WIP 0/3] WIP CTU CAN FD IP core mapping to the platform bus

2024-12-10 Thread Pavel Pisa
Hello Peter, On Tuesday 10 of December 2024 11:08:53 Peter Maydell wrote: > On Mon, 9 Dec 2024 at 23:33, Pavel Pisa wrote: > > our CTU CAN FD IP core is used on many FPGA platforms > > and has been even tapeout on some other university > > and even prototypes of the mas

[RFC 3/3] hw/net/can: WIP CTU CAN FD add parameter to specify IRQ controller on command line

2024-12-09 Thread Pavel Pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- hw/net/can/ctucan_mm.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/net/can/ctucan_mm.c b/hw/net/can/ctucan_mm.c index 6d6b8aecb8..e599df18be 100644 --- a/hw/net/can/ctucan_mm.c +++ b/hw/net/can

[RFC 2/3] hw/net/can: WIP CTU CAN FD mapping of IRQ for platform device solved.

2024-12-09 Thread Pavel Pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- hw/net/can/ctucan_mm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/can/ctucan_mm.c b/hw/net/can/ctucan_mm.c index 43e6823b73..6d6b8aecb8 100644 --- a/hw/net/can/ctucan_mm.c +++ b/hw/net/can/ctucan_mm.c @@ -160,6 +160,9 @@ static

[RFC 1/3] hw/net/can: WIP CTU CAN FD IP core mapping to the platform bus

2024-12-09 Thread Pavel Pisa
From: Pavel Pisa It is initial attempt (IRQ not working yet) to provide alternative to PCIe mapping. In this case, the platform bus is used to match FPGA design for Xilinx Zynq MZ_APO education kit with four CTU CAN FD cores on branch mz_apo-2x-xcan-4x-ctu of repo https://gitlab.fel.cvut.cz

[RFC/WIP 0/3] WIP CTU CAN FD IP core mapping to the platform bus

2024-12-09 Thread Pavel Pisa
From: Pavel Pisa Hello Peter, Gustavo and others, our CTU CAN FD IP core is used on many FPGA platforms and has been even tapeout on some other university and even prototypes of the massive production chips (support for that organized by our former student in his company). But actual QEMU

Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

2024-12-09 Thread Pavel Pisa
ers. In this case include them directly. > > Signed-off-by: Alex Bennée Acked-by: Pavel Pisa Tested on Debian/GNU/Linux for SJA1000 and CTU CAN FD QEMU=/home/pi/repo/qemu/qemu-build/qemu-system-x86_64 $QEMU -enable-kvm -kernel $KERNEL \ -m 512M \ -initrd ramdisk.cpio \

[PATCH v3 2/2] arm/ptw: use get_S1prot in get_phys_addr_v6

2024-11-18 Thread Pavel Skripkin
To share missing SCTRL.{U}WXN and SCR.SIF in short format walker, use get_S1prot instead of open-coded checks. Signed-off-by: Pavel Skripkin --- target/arm/ptw.c | 54 +--- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/target/arm

[PATCH v3 1/2] arm/ptw: make get_S1prot accept decoded AP

2024-11-18 Thread Pavel Skripkin
AP in armv7 short descriptor mode has 3 bits and also domain, which makes it incompatible with other arm schemas. To make it possible to share get_S1prot between armv8, armv7 long format, armv7 short format and armv6 it's easier to make caller decode AP. Signed-off-by: Pavel Skr

[PATCH v3 0/2] arm/ptw: fix missing sctlr.{u}wxn handling in get_phys_addr_v6

2024-11-18 Thread Pavel Skripkin
cover letter - Use get_S1prot() instead of open-coded checks v2: https://lore.kernel.org/qemu-devel/20241117134931.37249-1-paskrip...@gmail.com/ v1: https://lore.kernel.org/qemu-devel/20241114165900.6399-1-paskrip...@gmail.com/ Pavel Skripkin (2): arm/ptw: make get_S1prot accept decoded AP

[PATCH v2 1/2] arm/ptw: make get_S1prot accept decoded AP

2024-11-17 Thread Pavel Skripkin
AP in armv7 short descriptor mode has 3 bits and also domain, which makes it incompatible with other arm schemas. To make it possible to share get_S1prot between armv8, armv7 long format, armv7 short format and armv6 it's easier to make caller decode AP. Signed-off-by: Pavel Skr

[PATCH v2 2/2] arm/ptw: use get_S1prot in get_phys_addr_v6

2024-11-17 Thread Pavel Skripkin
To share missing SCTRL.{U}WXN and SCR.SIF in short format walker, use get_S1prot instead of open-coded checks. Signed-off-by: Pavel Skripkin --- target/arm/ptw.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/target/arm/ptw.c b

[PATCH v2 0/2] arm/ptw: fix missing sctlr.{u}wxn

2024-11-17 Thread Pavel Skripkin
in our OS passed on following platforms: - arm64-virt - arm-vexpress (v7) - arm-virt (v7) Changes from v1: - Fix style errors - Add cover letter - Use get_S1prot() instead of open-coded checks v1: https://lore.kernel.org/qemu-devel/20241114165900.6399-1-paskrip...@gmail.com/ Pavel

Re: [PATCH 2/2] arm/ptw: respect sctlr.{u}wxn in get_phys_addr_v6

2024-11-15 Thread Pavel Skripkin
Hi Peter, Peter Maydell says: On Thu, 14 Nov 2024 at 16:59, Pavel Skripkin wrote: get_phys_addr_v6() is used for decoding armv7's short descriptor format. Based on ARM ARM AArch32.S1SDHasPermissionsFault(), WXN should be respected in !LPAE mode as well. Signed-off-by: Pavel Skr

[PATCH 1/2] arm/ptw: factor out wxn logic to separate functions

2024-11-14 Thread Pavel Skripkin
The next patch will add support for WXN for short descriptor format. To prevent code duplication, wxn logic was factored out to separate functions. Signed-off-by: Pavel Skripkin --- target/arm/ptw.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions

[PATCH 2/2] arm/ptw: respect sctlr.{u}wxn in get_phys_addr_v6

2024-11-14 Thread Pavel Skripkin
get_phys_addr_v6() is used for decoding armv7's short descriptor format. Based on ARM ARM AArch32.S1SDHasPermissionsFault(), WXN should be respected in !LPAE mode as well. Signed-off-by: Pavel Skripkin --- target/arm/ptw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/t

[PATCH 1/2] arm/ptw: factor out wxn logic to separate functions

2024-11-14 Thread Pavel Skripkin
The next patch will add support for WXN for short descriptor format. To prevent code duplication, wxn logic was factored out to separate functions. Signed-off-by: Pavel Skripkin --- target/arm/ptw.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions

Re: [PATCH 3/3] target/mips: Convert Octeon LX instructions to decodetree

2024-11-11 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 12.11.2024 01:29, Philippe Mathieu-Daudé wrote: Use Octeon decodetree to call gen_lx() for the LX instructions. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/octeon.decode | 8 target/mips/tcg/octeon_translate.c | 12

Plea for advice with PCIe on QEMU for iMX6 and plan to add FlexCAN controller support

2024-10-02 Thread Pavel Pisa
ivers are enabled in the kernel. But it is possible that something has been overlooked. Do you have some hint or some kernel and QEMU working example for iMX6 PCIe device mapping? Thanks in advance. Best wishes, Pavel -- Pavel Pisa phone: +420 6035313

Re: [PATCH] replay: Remove unused replay_disable_events

2024-09-18 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 19.09.2024 02:40, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" replay_disable_events has been unused since 2019's c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working") Remove it. Signed-

Re: [RFC PATCH 00/16] Implements RISC-V WorldGuard extension v0.4

2024-09-07 Thread Pavel Skripkin
be an SBI support for that? With regards, Pavel Skripkin

Re: [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues

2024-08-29 Thread Pavel Pisa
per analysis if no other looks into the whole code. Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague 2 university: http://con

Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions

2024-08-29 Thread Pavel Pisa
DLC of 0-8, which was broken previously. > > Signed-off-by: Doug Brown Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague

Re: [PATCH v2 5/7] hw/net/can/xlnx-versal-canfd: Fix byte ordering

2024-08-29 Thread Pavel Pisa
TX and RX code to put the data in the correct order. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Acked-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT

Re: [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly

2024-08-29 Thread Pavel Pisa
o it's only implemented for the receive case. > > Signed-off-by: Doug Brown Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121

Re: [PATCH v2 3/7] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers

2024-08-29 Thread Pavel Pisa
me for all of its ID registers. Correct this problem for > both RX and TX, including RX filtering. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Acked-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut

Re: [PATCH v2 2/7] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-29 Thread Pavel Pisa
Brown > Reviewed-by: Pavel Pisa > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Pra

Re: [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level

2024-08-29 Thread Pavel Pisa
applying it, resulting in the IRQ never being delivered. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-25 Thread Pavel Pisa
able to me. Anyway, I am the initiator of QEMU CAN subsystem as GSoC and studnets mentor and coauthor but I have no commit right to the QEMU mainline. So actual merge has to be realized by people with commit right. Paolo Bonzini has provided help with CAN subsystem integration and the committing. Best w

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-21 Thread Pavel Pisa
ree time which should have at least some maintainership backup by somebody who intend to use the project in frame of company or some automotive consortium. I know that there are big money flowing on base of these activities. Best wishes, Pavel Pisa phone: +420 603531

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-20 Thread Pavel Pisa
{ > is_canfd_frame = true; > > /* Store dlc value in Xilinx specific format. */ Reviewed-by: Pavel Pisa That is a great catch, I have overlooked this in previous review of the Xilinx code. When I look into hw/net/can/xlnx-versal-canfd.c functions regs2f

Re: [PATCH v5 20/24] replay: simple auto-snapshot mode for record

2024-04-04 Thread Pavel Dovgalyuk
On 18.03.2024 18:46, Nicholas Piggin wrote: record makes an initial snapshot when the machine is created, to enable reverse-debugging. Often the issue being debugged appears near the end of the trace, so it is important for performance to keep snapshots close to the end. This implements a period

Re: [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

2024-04-04 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 18.03.2024 18:46, Nicholas Piggin wrote: The regular qemu_bh_schedule() calls result in non-deterministic execution of the bh in record-replay mode, which causes replay failure. Signed-off-by: Nicholas Piggin --- hw/net/virtio-net.c | 11 ++- 1 file

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
On 12.03.2024 14:05, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with snapshots. On 11.03.2024 20:40, Nicholas Piggin wrote: Using virtual time for announce ensures that guest visible effe

Re: [PATCH v4 20/24] replay: simple auto-snapshot mode for record

2024-03-12 Thread Pavel Dovgalyuk
On 11.03.2024 20:40, Nicholas Piggin wrote: record makes an initial snapshot when the machine is created, to enable reverse-debugging. Often the issue being debugged appears near the end of the trace, so it is important for performance to keep snapshots close to the end. This implements a period

Re: [Spam][PATCH] replay: Improve error messages about configuration conflicts

2024-03-01 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 01.03.2024 15:06, Markus Armbruster wrote: Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot'

Re: [PATCH 4/4] replay: simple auto-snapshot mode for record

2024-02-27 Thread Pavel Dovgalyuk
On 26.02.2024 10:36, Nicholas Piggin wrote: On Fri Aug 18, 2023 at 2:36 PM AEST, Pavel Dovgalyuk wrote: On 14.08.2023 19:31, Nicholas Piggin wrote: record makes an initial snapshot when the machine is created, to enable reverse-debugging. Often the issue being debugged appears near the end of

Re: [PATCH 16/21] hw/net/can/versal: Prefer object_initialize_child over object_initialize

2024-02-23 Thread Pavel Pisa via
gt; Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa

Re: [PATCH v1 02/21] tests: correct typos

2024-02-20 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 20.02.2024 11:52, Manos Pitsidianakis wrote: Correct typos automatically found with the `typos` tool <https://crates.io/crates/typos> Signed-off-by: Manos Pitsidianakis --- tests/avocado/acpi-bits/bits-tests/smbios.py2 | 2 +- tests/avocado/mem-addr

Re: [PATCH v2 4/4] tests/avocado: excercise scripts/replay-dump.py in replay tests

2024-01-28 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 25.01.2024 19:08, Nicholas Piggin wrote: This runs replay-dump.py after recording a trace, and fails the test if the script fails. replay-dump.py is modified to exit with non-zero if an error is encountered while parsing, to support this. Signed-off-by

Re: [PATCH v2 1/4] replay: allow runstate shutdown->running when replaying trace

2024-01-28 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 25.01.2024 19:08, Nicholas Piggin wrote: When replaying a trace, it is possible to go from shutdown to running with a reverse-debugging step. This can be useful if the problem being debugged triggers a reset or shutdown. Signed-off-by: Nicholas Piggin

Re: [PATCH 7/9] target/i386: Extract x86_need_replay_interrupt() from accel/tcg/

2024-01-24 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 24.01.2024 13:16, Philippe Mathieu-Daudé wrote: Move this x86-specific code out of the generic accel/tcg/. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/tcg/helper-tcg.h| 1 + accel/tcg/cpu-exec.c| 9 - target/i386

Re: [PATCH 6/9] accel/tcg: Introduce TCGCPUOps::need_replay_interrupt() handler

2024-01-24 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 24.01.2024 13:16, Philippe Mathieu-Daudé wrote: In order to make accel/tcg/ target agnostic, introduce the need_replay_interrupt() handler. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/tcg-cpu-ops.h | 5 + accel/tcg/cpu-exec.c | 5

[PATCH v2] hw/net/can/sja1000: fix bug for single acceptance filter and standard frame

2024-01-03 Thread Pavel Pisa
From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0) and

Re: [PATCH] docs: use "buses" rather than "busses"

2024-01-03 Thread Pavel Pisa
On Wednesday 03 of January 2024 18:28:17 Samuel Tardieu wrote: > If "busses" might be encountered as a plural of "bus" (5 instances), > the correct spelling is "buses" (26 instances). Fixing those 5 > instances makes the doc more consistent. > > Sign

[PATCH] hw/net/can/sja1000: fix bug for single acceptance filer and standard frame

2023-12-14 Thread Pavel Pisa
From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0) and

Re: [PATCH 09/11] replay: stop us hanging in rr_wait_io_event

2023-12-08 Thread Pavel Dovgalyuk
most of the failures in replay_kernel.py Is there an effect for console QEMU only? I've tested this patch on Windows7 boot scenario and replay speed has not changed. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2013 Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk --- in

Re: [PATCH 11/11] tests/avocado: remove skips from replay_kernel

2023-12-07 Thread Pavel Dovgalyuk
): """ :avocado: tags=arch:microblaze @@ -389,7 +381,6 @@ def test_or1k_sim(self): file_path = self.fetch_asset(tar_url, asset_hash=tar_hash) self.do_test_advcal_2018(file_path, 'vmlinux') -@skip("nios2 emulation is buggy under record/replay") def test_nios2_10m50(self): """ :avocado: tags=arch:nios2 Acked-by: Pavel Dovgalyuk

Re: [PATCH 08/11] replay: introduce a central report point for sync errors

2023-12-07 Thread Pavel Dovgalyuk
e migrated, because RR may be started from the snapshot, which references the middle of replayed scenario. Pavel Dovgalyuk

Re: [PATCH 10/11] chardev: force write all when recording replay logs

2023-12-07 Thread Pavel Dovgalyuk
oject/qemu/-/issues/2010 Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk --- chardev/char.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/char.c b/chardev/char.c index 996a024c7a..6e5b4d7345 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -171,7 +171,8 @

Re: [PATCH 07/11] replay: make has_unread_data a bool

2023-12-07 Thread Pavel Dovgalyuk
deletions(-) Reviewed-by: Pavel Dovgalyuk

Re: [PATCH 06/11] replay: add proper kdoc for ReplayState

2023-12-07 Thread Pavel Dovgalyuk
overlapping ids. */ uint64_t block_request_id; -/*! Asynchronous event id read from the log */ uint64_t read_event_id; } ReplayState; extern ReplayState replay_state; Reviewed-by: Pavel Dovgalyuk

Re: [PATCH 05/11] replay: remove host_clock_last

2023-12-07 Thread Pavel Dovgalyuk
clock */ -uint64_t host_clock_last; /*! Asynchronous event id read from the log */ uint64_t read_event_id; } ReplayState; Reviewed-by: Pavel Dovgalyuk

Re: [PATCH 04/11] scripts/replay_dump: track total number of instructions

2023-12-07 Thread Pavel Dovgalyuk
): +global total_insns ins_diff = read_dword(dumpfile) -print_event(eid, name, "0x%x" % (ins_diff)) +total_insns += ins_diff +print_event(eid, name, "+ %d -> %d" % (ins_diff, total_insns)) return True def decode_char_write(eid, name, dumpfile): Reviewed-by: Pavel Dovgalyuk

Re: [PATCH 01/11] tests/avocado: add a simple i386 replay kernel test

2023-12-07 Thread Pavel Dovgalyuk
1 file changed, 16 insertions(+) Acked-by: Pavel Dovgalyuk

Re: [PATCH 02/11] tests/avocado: fix typo in replay_linux

2023-12-07 Thread Pavel Dovgalyuk
logger.info('successfully finished the replay') elapsed = time.time() - start_time logger.info('elapsed time %.2f sec' % elapsed) return elapsed Reviewed-by: Pavel Dovgalyuk

Re: [PATCH v6 06/21] net: Remove flag propagation

2023-11-13 Thread Pavel Dovgalyuk
On 11.11.2023 17:27, Akihiko Odaki wrote: On 2023/11/10 16:35, Pavel Dovgalyuk wrote: You need to bump REPLAY_VERSION in replay/replay.c, because your patch changes the replay log format. Otherwise, for replay part: Acked-by: Pavel Dovgalyuk I'll drop this change then. It's just

Re: [PATCH v6 06/21] net: Remove flag propagation

2023-11-09 Thread Pavel Dovgalyuk
You need to bump REPLAY_VERSION in replay/replay.c, because your patch changes the replay log format. Otherwise, for replay part: Acked-by: Pavel Dovgalyuk On 30.10.2023 08:12, Akihiko Odaki wrote: There is no defined flag now. Signed-off-by: Akihiko Odaki --- include/net/filter.h

Re: [PATCH] MAINTAINERS: Add the can documenation file to the CAN section

2023-10-29 Thread Pavel Pisa
changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cce6feff35..48d45b958f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2606,6 +2606,7 @@ W: https://canbus.pages.fel.cvut.cz/ > F: net/can/* > F: hw/net/can/* > F: include/net/can_*.h > +F

[PATCH 0/3] Record/replay patches

2023-09-29 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk The set of patches include the following modifications: - fix for allowing record/replay with virtio-net - fix for loading non-replay snapshots Pavel Dovgalyuk (3): replay: improve determinism of virtio-net virtio-net: added replay blocker for guest_announce replay

[PATCH 1/3] replay: improve determinism of virtio-net

2023-09-29 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode. Signed-off-by: Pavel

[PATCH 3/3] replay: fix for loading non-replay snapshots

2023-09-29 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk Snapshots created in regular icount execution mode can't be loaded in recording mode, because icount value advances only by 32-bit value. This patch initializes replay icount initial value after loading the snapshot. Cc: Pizarro Solar Rafael Ulises Luzius Signed-o

[PATCH 2/3] virtio-net: added replay blocker for guest_announce

2023-09-29 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk This patch blocks record/replay when guest_announce is enabled, because this flag breaks loading the snapshots in deterministic execution mode. Signed-off-by: Pavel Dovgalyuk --- hw/net/virtio-net.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/net/virtio

Re: [RFC v2 PATCH] record-replay: support SMP target machine

2023-08-21 Thread Pavel Dovgalyuk
On 11.08.2023 04:47, Nicholas Piggin wrote: RR CPU switching is driven by timers and events so it is deterministic like everything else. Record a CPU switch event and use that to drive the CPU switch on replay. Signed-off-by: Nicholas Piggin --- This is still in RFC phase because so far I've on

Re: [PATCH 4/4] replay: simple auto-snapshot mode for record

2023-08-17 Thread Pavel Dovgalyuk
On 14.08.2023 19:31, Nicholas Piggin wrote: record makes an initial snapshot when the machine is created, to enable reverse-debugging. Often the issue being debugged appears near the end of the trace, so it is important for performance to keep snapshots close to the end. This implements a period

Re: [PATCH 3/4] replay: allow runstate shutdown->running when replaying trace

2023-08-17 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 14.08.2023 19:31, Nicholas Piggin wrote: When replaying a trace, it is possible to go from shutdown to running with a reverse-debugging step. This can be useful if the problem being debugged triggers a reset or shutdown. Signed-off-by: Nicholas Piggin

Re: [PATCH 2/4] tests/avocado: replay_linux.py add replay-dump.py test

2023-08-17 Thread Pavel Dovgalyuk
On 14.08.2023 19:31, Nicholas Piggin wrote: This runs replay-dump.py after recording a trace, and fails the test if the script fails. replay-dump.py is modified to exit with non-zero if an error is encountered while parsing. I would like to have separate test for replay-dump, because replay-li

Re: [PATCH 1/4] scripts/replay_dump.sh: Update to current rr record format

2023-08-17 Thread Pavel Dovgalyuk
On 14.08.2023 19:31, Nicholas Piggin wrote: This thing seems to have fallen by the wayside. This gets it working with the current format, although does not quite implement all events. Signed-off-by: Nicholas Piggin The code looks ok, therefore Rewieved-by: Pavel Dovgalyuk However, there is

[PATCH 1/3] replay: improve determinism of virtio-net

2023-08-11 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode. Signed-off-by: Pavel

[PATCH 3/3] tests/avocado: fix waiting for vm shutdown in replay_linux

2023-08-11 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk This patch fixes the race condition in waiting for shutdown of the replay linux test. Signed-off-by: Pavel Dovgalyuk Suggested-by: John Snow --- tests/avocado/replay_linux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado

[PATCH 0/3] Record/replay patches

2023-08-11 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk The set of patches include the following modifications: - fix for allowing record/replay with virtio-net - fix of the record/replay test Pavel Dovgalyuk (3): replay: improve determinism of virtio-net virtio-net: added replay blocker for guest_announce tests/avocado

[PATCH 2/3] virtio-net: added replay blocker for guest_announce

2023-08-11 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk This patch blocks record/replay when guest_announce is enabled, because this flag breaks loading the snapshots in deterministic execution mode. Signed-off-by: Pavel Dovgalyuk --- hw/net/virtio-net.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/net/virtio

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-07 Thread Pavel Dovgalyuk
On 08.08.2023 06:09, Nicholas Piggin wrote: On Sun Aug 6, 2023 at 9:46 PM AEST, Nicholas Piggin wrote: On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote: BTW, there is a function qemu_register_reset_nosnapshotload that can be used in similar cases. Can you just use it without changing

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-04 Thread Pavel Dovgalyuk
. When loading a snapshot for record-replay, the machine is reset again, and that tries to consume the random event record again, crashing due to inconsistent record Fix this by saving the seed to populate the device tree with, and skipping the rng on snapshot load. Cc: Pavel Dovgalyuk Signed-off-by

Re: [PATCH 7/7] tests/avocado: ppc64 reverse debugging tests for pseries and powernv

2023-07-31 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 26.07.2023 21:35, Nicholas Piggin wrote: These machines run reverse-debugging well enough to pass basic tests. Wire them up. Cc: Pavel Dovgalyuk Signed-off-by: Nicholas Piggin --- tests/avocado/reverse_debugging.py | 29 + 1

Re: [PATCH 6/7] tests/avocado: reverse-debugging cope with re-executing breakpoints

2023-07-31 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 26.07.2023 21:35, Nicholas Piggin wrote: The reverse-debugging test creates a trace, then replays it and: 1. Steps the first 10 instructions and records their addresses. 2. Steps backward and verifies their addresses match. 3. Runs to (near) the end of the

Re: [PATCH 5/7] tests/avocado: boot ppc64 pseries replay-record test to Linux VFS mount

2023-07-31 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 26.07.2023 21:35, Nicholas Piggin wrote: This the ppc64 record-replay test is able to replay the full kernel boot so try enabling it. Cc: Pavel Dovgalyuk Signed-off-by: Nicholas Piggin --- tests/avocado/replay_kernel.py | 3 +-- 1 file changed, 1 insertion

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-07-31 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 26.07.2023 21:35, Nicholas Piggin wrote: spapr_machine_reset gets a random number to populate the device-tree rng seed with. When loading a snapshot for record-replay, the machine is reset again, and that tries to consume the random event record again, crashing due

[PATCH] tests/avocado: fix waiting for vm shutdown in replay_linux This patch fixes the race condition in waiting for shutdown of the replay linux test.

2023-07-31 Thread pavel . dovgalyuk
From: Pavel Dovgalyuk Signed-off-by: Pavel Dovgalyuk Suggested-by: John Snow --- tests/avocado/replay_linux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/replay_linux.py b/tests/avocado/replay_linux.py index a76dd507fc..270ccc1eae 100644 --- a/tests

Re: tests/avocado/replay_kernel: ReplayKernelNormal.test_aarch64_virt failing

2023-07-10 Thread Pavel Dovgalyuk
On 10.07.2023 20:14, Philippe Mathieu-Daudé wrote: Hi, Per tests/avocado/replay_kernel.py:     def test_aarch64_virt(self):     ...     console_pattern = 'VFS: Cannot open root device' the test is succeeding, but Avocado reports an error. Does the emulator exit when error "Cannot

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-06-26 Thread Pavel Dovgalyuk
e500 has the same problem, I think, according to this issue: https://gitlab.com/qemu-project/qemu/-/issues/1634 Btw, ARM virt platform rebuilds fdt only at initialization phase, not when reset. Isn't this behavior correct? Shouldn't PPC platforms do the similar thing? On 23.06.2023 15:57, Nic

Re: [PATCH 5/7] target/ppc: Fix timebase reset with record-replay

2023-06-26 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 23.06.2023 15:57, Nicholas Piggin wrote: Timebase save uses a random number for a legacy vmstate field, which makes rr snapshot loading unbalanced. The easiest way to deal with this is just to skip the rng if record-replay is active. Signed-off-by: Nicholas

Re: [PATCH 7/7] tests/avocado: ppc64 pseries reverse debugging test

2023-06-26 Thread Pavel Dovgalyuk
On 23.06.2023 15:57, Nicholas Piggin wrote: pseries can run reverse-debugging well enough to pass basic tests. There is strangeness with reverse-continue possibly relating to a bp being set on the first instruction or on a snapshot, that causes the PC to be reported on the first instruction rath

Re: [PATCH 1/7] target/ppc: Fix CPU reservation migration for record-replay

2023-06-26 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 23.06.2023 15:57, Nicholas Piggin wrote: ppc only migrates reserve_addr, so the destination machine can get a valid reservation with an incorrect reservation value of 0. Prior to commit 392d328abe753 ("target/ppc: Ensure stcx size matches larx"), this co

Re: [PATCH v2] hw/net/can: Add mcp25625 model

2023-03-27 Thread Pavel Pisa
There is tracing support with --trace "*mcp25*" > > Signed-off-by: Ben Dooks > Co-developed-by: Nazar Kazakov > Signed-off-by: Nazar Kazakov > Co-developed-by: Lawrence Hunter > Signed-off-by: Lawrence Hunter > Reviewed-by: Frank Chang Tested-by: Pavel P

Re: [PATCH v2] hw/net/can: Add mcp25625 model

2023-03-17 Thread Pavel Pisa
does not provide right SPI emulation as you have noticed, what about BeagleBoneBlack? Does it support SPI? It could be good target to test that mcp25625 chip emulation is portable.. Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.fe

Re: [PATCH 2/4] virtio-input: add a virtio-mulitouch device

2023-02-21 Thread Pavel Dovgalyuk
replay/replay-input.c part: Reviewed-by: Pavel Dovgalyuk On 18.02.2023 19:22, Sergio Lopez wrote: Add a virtio-multitouch device to the family of devices emulated by virtio-input implementing the Multi-touch protocol as descripted here: https://www.kernel.org/doc/html/latest/input/multi-touch

[PATCH v2 2/5] target/avr: implement small RAM/large RAM feature

2023-01-23 Thread Pavel Dovgalyuk
xmega controllers, that could be added later. For the currently supported MCUs this feature is disabled and RAMPZ is not used for RAM access. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson --- target/avr/cpu.h |2 ++ target/avr/translate.c | 63

[PATCH v2 1/5] target/avr: fix long address calculation

2023-01-23 Thread Pavel Dovgalyuk
deposit tcg instructions. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Reviewed-by: Michael Rolnik --- target/avr/translate.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 2bed56f135..552f739b3d

[PATCH v2 4/5] target/avr: fix interrupt processing

2023-01-23 Thread Pavel Dovgalyuk
Interrupt bit vector has 64 bits, but interrupt vector is found with ctz32 function. This patch replaces it with ctz64. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/avr/helper.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 0/5] AVR target fixes

2023-01-23 Thread Pavel Dovgalyuk
This set of patches includes multiple changes for AVR target. v2 changes: - fixed instruction translation in icount mode --- Pavel Dovgalyuk (5): target/avr: fix long address calculation target/avr: implement small RAM/large RAM feature target/avr: fix avr features processing

[PATCH v2 5/5] target/avr: enable icount mode

2023-01-23 Thread Pavel Dovgalyuk
: Pavel Dovgalyuk Reviewed-by: Richard Henderson --- target/avr/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index 40b15d116e..ee137dfe54 100644 --- a/target/avr/translate.c +++ b/target/avr

[PATCH v2 3/5] target/avr: fix avr features processing

2023-01-23 Thread Pavel Dovgalyuk
Bit vector for features has 64 bits. This patch fixes bit shifts in avr_feature and set_avr_feature functions to be 64-bit too. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/avr/cpu.h |4 ++-- 1

[PATCH v2 1/5] target/avr: fix long address calculation

2023-01-19 Thread Pavel Dovgalyuk
deposit tcg instructions. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Reviewed-by: Michael Rolnik --- target/avr/translate.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 2bed56f135..552f739b3d

[PATCH v2 2/5] target/avr: implement small RAM/large RAM feature

2023-01-19 Thread Pavel Dovgalyuk
xmega controllers, that could be added later. For the currently supported MCUs this feature is disabled and RAMPZ is not used for RAM access. Signed-off-by: Pavel Dovgalyuk --- target/avr/cpu.h |2 ++ target/avr/translate.c | 63 ++-- 2 files

[PATCH v2 3/5] target/avr: fix avr features processing

2023-01-19 Thread Pavel Dovgalyuk
Bit vector for features has 64 bits. This patch fixes bit shifts in avr_feature and set_avr_feature functions to be 64-bit too. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Michael Rolnik --- target/avr/cpu.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr

[PATCH v2 0/5] AVR target fixes

2023-01-19 Thread Pavel Dovgalyuk
This set of patches includes multiple changes for AVR target. v2 changes: - fixed instruction translation in icount mode --- Pavel Dovgalyuk (5): target/avr: fix long address calculation target/avr: implement small RAM/large RAM feature target/avr: fix avr features processing

Re: reverse-{debugging,continue} not working on v7.2.0, i386 guest

2023-01-19 Thread Pavel Dovgalyuk
On 19.01.2023 07:40, Hyeonggon Yoo wrote: On Wed, Jan 18, 2023 at 12:39:16PM +0300, Pavel Dovgalyuk wrote: Sometimes replay (or reverse debugging) have problems due to incomplete or incorrect virtual device save/load implementation. Can you try removing -cpu from your command line? Or you can

  1   2   3   4   5   6   7   8   9   10   >