On 11.11.2023 17:27, Akihiko Odaki wrote:
On 2023/11/10 16:35, Pavel Dovgalyuk wrote:
You need to bump REPLAY_VERSION in replay/replay.c, because your patch changes the replay log format.

Otherwise, for replay part:
Acked-by: Pavel Dovgalyuk <pavel.dovgal...@ispras.ru>

I'll drop this change then. It's just a cleanup and does not bring an additional benefit worth breaking the log format.

Breaking the log format is ok, because replays may be incompatible for different builds, because peripheral or vCPU behavior may change.

So bumping the version just helps with not replaying the wrong log.

Reply via email to