'channels' documentation
changes soon in Qemu, as discussed above.
Regards,
Het Gala
On 11/04/24 7:56 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
On Thu, Apr 11, 2024 at 07:45:21PM +0530, Het Gala wrote:
On 10/04/24 8:23 pm, Peter Xu
On 10/04/24 8:23 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
On Wed, Apr 10, 2024 at 10:04:33AM -0300, Fabiano Rosas wrote:
Het Gala writes:
This
On 10/04/24 6:45 pm, Fabiano Rosas wrote:
!---|
CAUTION: External Email
|---!
Het Gala writes:
Add qtests to perform postcopy live migration by having list of
On 10/04/24 6:44 pm, Fabiano Rosas wrote:
!---|
CAUTION: External Email
|---!
Het Gala writes:
Alter migrate_incoming_qmp() to allow both uri and channels
On 10/04/24 6:34 pm, Fabiano Rosas wrote:
!---|
CAUTION: External Email
|---!
Het Gala writes:
This reverts commit 8e3766eefbb4036cbc280c1f1a0d28537929f7fb
On 05/04/24 7:58 pm, Fabiano Rosas wrote:
!---|
CAUTION: External Email
|---!
Het Gala writes:
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes
Alter migrate_incoming_qmp() to allow both uri and channels
independently. For channels, convert string to a QDict.
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 13 +++--
tests/qtest/migration-helpers.h | 4 ++--
tests/qtest/migration-test.c | 12
mporarily introduced 'migrate-incoming' QAPI
with the new 'channels' syntax.
Patch 2-3:
-
Introduce channels arg to migrate_incoming_qmp
Patch 4:
---
Introduce postcopy qtests with new QAPI syntax
Het Gala (4):
Revert "migration: modify test_multifd_tcp_non
of the new syntax
since the migration qtest framework lacked any logic for introducing
'channels' argument.
Now that the qtest framework has logic to introduce uri and channel
argument separately, we can remove this temporary change.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c
Already have a migrate_incoming_qmp helper function to initiate
'migrate-incoming' QMP command with some additional checks.
Replace 'migrate-incoming' qtest_qmp_assert_success command with
calling migrate_incoming_qmp helper function for postcopy qtests.
Signed-off-by: Het Ga
Add qtests to perform postcopy live migration by having list of
'channels' argument as the starting point instead of uri string.
(Note: length of the list is restricted to 1 for now)
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 38 ++
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 584d7c496f..5d6d8cd634 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index b2a90469fb..3b72cad6c1 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest
multifd_tcp_channels_none to actually use 'channels' arg.
2. use 'git commit --fixup' to improve commit message as well as
to inform on which commit is the fix meant to be.
Het Gala (3):
fixup! tests/qtest/migration: Add negative tests to validate migration
QAPIs
fi
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d03a655f83..584d7c496f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
On 08/04/24 9:10 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
On Sun, Apr 07, 2024 at 01:21:25PM +, Het Gala wrote:
Earlier, without args
On 08/04/24 9:05 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
Hey, Het,
On Sun, Apr 07, 2024 at 01:21:24PM +, Het Gala wrote:
Fixes: (tests/qtest
Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs)
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d03a655f83..584d7c496f
ng to introduce
similar qtests in migration.
Fix multifd_tcp_channels_none qtest to actually utilise 'channels' arg
in migrate QAPIs
This patchset is built on top of (tests/qtest/migration: Add tests for
introducing 'channels' argument in migrate QAPIs)
Het Gala (2):
Fix typ
setting correct migration ports. Fix that.
Fixes: (tests/qtest/migration: Add multifd_tcp_plain test using list of
channels instead of uri)
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 2 --
tests/qtest/migration-test.c| 2 +-
2 files changed, 1 insertion(+), 3 de
ping !
On 27/03/24 4:18 pm, Het Gala wrote:
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes:
Some comments, mostly just thinking out loud...
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
Do we need an optional 'capability' element?
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes:
Some comments, mostly just thinking out loud...
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
Do we need an optional 'capability' element? I'm not sure how practical
is to leave that
, will comply
with that once, we are on a consensus with the design)
On 27/03/24 1:08 am, Het Gala wrote:
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
test-type:: migrate | validate
migration-mode
a. migrate --> :: precopy | postcopy | mul
needs to be
addressed. Can be multiple
(more than one applicable, separated by using '-' in between)
O: optional
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 143 ++-
1 file changed, 72 insertions(+),
On 20/03/24 6:49 pm, Fabiano Rosas wrote:
Het Gala writes:
On 20/03/24 3:27 am, Peter Xu wrote:
On Tue, Mar 19, 2024 at 08:48:39PM +, Het Gala wrote:
'object' can return NULL if there is no socket-address, such as with a
file migration. Then the visitor code below fails an
On 20/03/24 3:27 am, Peter Xu wrote:
On Tue, Mar 19, 2024 at 08:48:39PM +, Het Gala wrote:
'object' can return NULL if there is no socket-address, such as with a
file migration. Then the visitor code below fails and the test crashes.
Ignore and return NULL when socket-address
On 20/03/24 12:33 am, Fabiano Rosas wrote:
Het Gala writes:
On 18/03/24 7:46 pm, Fabiano Rosas wrote:
Het Gala writes:
On 15/03/24 6:28 pm, Fabiano Rosas wrote:
Het Galawrites:
Refactor migrate_get_socket_address to internally utilize 'socket-address'
parameter
FYI: This 2 patches are rebased on top of another
(tests/qtest/migration: Add tests for introducing 'channels' argument in
migrate QAPIs) series.
Can find the build for both the patches here:
https://gitlab.com/galahet/Qemu/-/pipelines/1219841944
On 20/03/24 2:18 am, Het Gala wrote
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index fb7156f09a..651c6c555a 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest/migration
: Fabiano Rosas
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index b2a90469fb..fb7156f09a 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest/migr
On 18/03/24 7:46 pm, Fabiano Rosas wrote:
Het Gala writes:
On 15/03/24 6:28 pm, Fabiano Rosas wrote:
Het Gala writes:
Refactor migrate_get_socket_address to internally utilize 'socket-address'
parameter, reducing redundancy in the function definition.
migrate_get_sock
On 15/03/24 6:28 pm, Fabiano Rosas wrote:
Het Gala writes:
Refactor migrate_get_socket_address to internally utilize 'socket-address'
parameter, reducing redundancy in the function definition.
migrate_get_socket_address implicitly converts SocketAddress into
Can find the passed build here:
https://gitlab.com/galahet/Qemu/-/pipelines/1210931136
On 13/03/24 1:56 am, Het Gala wrote:
With recent migrate QAPI changes, enabling the direct use of the
'channels' argument to avoid redundant URI string parsing is achieved.
To ensure backward com
x27; introduction is not required now for migrate_qmp_incoming
4. Remove custom function for converting string to MigrationChannelList
5. move calls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (8):
t
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 30
rn the uri string instead.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by:
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Ro
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fa
migrate_get_connect_qdict gets qdict with the dst QEMU parameters.
migrate_set_ports() from list of channels reads each QDict for port,
and fills the port with correct value in case it was 0 in the test.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 55
a rule yet.. but any such prefix is still
helpful.
Thanks,
Yes, sure Peter. Let me rebase it to latest master and also share the
latest passed build link.
Will add "tests/qtest/migration" prefix to all the commit message headers.
Regards,
Het Gala
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/
rn the uri string instead.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qt
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Ro
migrate_get_connect_qdict gets qdict with the dst QEMU parameters.
migrate_set_ports() from list of channels reads each QDict for port,
and fills the port with correct value in case it was 0 in the test.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 30 +++---
1 file
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 55 +++-
1 file
lls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (8):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_get_socket_address inside
migrate_qmp
Replace migrate_get_
ent, migrate_qmp still makes live migration
succeed.
Sending out a new patchset series - v6. Can directly review v6
patchset series.
On 12/03/24 3:23 am, Het Gala wrote:
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
inst
Can also check the passed build at
https://gitlab.com/galahet/Qemu/-/pipelines/1209497470
On 12/03/24 3:23 am, Het Gala wrote:
With recent migrate QAPI changes, enabling the direct use of the
'channels' argument to avoid redundant URI string parsing is achieved.
v4->
On 12/03/24 3:08 am, Peter Xu wrote:
On Tue, Mar 12, 2024 at 03:01:51AM +0530, Het Gala wrote:
On 12/03/24 2:55 am, Peter Xu wrote:
On Sat, Mar 09, 2024 at 01:11:45PM +0530, Het Gala wrote:
Can find the reference to the githab pipeline (before patchset) :
https://urldefense.proofpoint.com/v2
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Ro
migrate_get_connect_qdict gets qdict with the dst QEMU parameters.
migrate_set_ports() from list of channels reads each QDict for port,
and fills the port with correct value in case it was 0 in the test.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 30 +++---
1 file
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 53
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qt
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/
ove custom function for converting string to MigrationChannelList
5. move calls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (8):
Add 'to' object into migrate_qmp()
Replace connect_uri and
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
rn the uri string instead.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index
On 12/03/24 2:55 am, Peter Xu wrote:
On Sat, Mar 09, 2024 at 01:11:45PM +0530, Het Gala wrote:
Can find the reference to the githab pipeline (before patchset) :
https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_galahet_Qemu_-2D_pipelines_1207185095&d=DwIB
On 12/03/24 12:12 am, Fabiano Rosas wrote:
Het Gala writes:
migrate_set_get_qdict gets qdict with the dst QEMU parameters
s/set_//
Ack
migrate_set_ports() from list of channels reads each QDict for port,
and fills the port with correct value in case it was 0 in the test.
Signed-off-by
On 12/03/24 2:21 am, Fabiano Rosas wrote:
Het Gala writes:
On 11/03/24 11:49 pm, Fabiano Rosas wrote:
Het Gala writes:
bool migrate_watch_for_events(QTestState *who, const char *name,
@@ -130,7 +140,7 @@ void migrate_qmp(QTestState *who, QTestState *to, const
char *uri
On 11/03/24 11:49 pm, Fabiano Rosas wrote:
Het Gala writes:
bool migrate_watch_for_events(QTestState *who, const char *name,
@@ -130,7 +140,7 @@ void migrate_qmp(QTestState *who, QTestState *to, const
char *uri,
g_assert(!qdict_haskey(args, "uri"));
On 11/03/24 11:46 pm, Fabiano Rosas wrote:
Het Gala writes:
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
On 11/03/24 8:16 pm, Peter Xu wrote:
On Mon, Mar 11, 2024 at 08:00:06PM +0530, Het Gala wrote:
Let me send a proper patch to qemu devel mailing list and cc all the people
involved.
I have reviewed and tested the change. Have tweaked the commit message
accordingly.
I hope that's okay wit
.
Ich versuche, Google Application-specific password zu erstellen für Zukunft.
QEMU Upstream bietet diese Lösung für kleinen Patch an im Notfall.
Sie werden es behanden.
Viele Grüße
Yu
On Fri, Mar 8, 2024 at 8:09 AM Alexei Pastuchov
wrote:
Regards,
Het Gala
Can find the reference to the githab pipeline (before patchset) :
https://gitlab.com/galahet/Qemu/-/pipelines/1207185095
Can find the reference to the githab pipeline (after patchset) :
https://gitlab.com/galahet/Qemu/-/pipelines/1207183673
On 09/03/24 2:29 am, Het Gala wrote:
With recent
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 54
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/
migrate_set_get_qdict gets qdict with the dst QEMU parameters
migrate_set_ports() from list of channels reads each QDict for port,
and fills the port with correct value in case it was 0 in the test.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 73
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 30 +++---
1 file
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by:
migrate_get_socket_address implicitly converts SocketAddress into str.
Move migrate_get_socket_address inside migrate_get_connect_uri which
should return the uri string instead.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 26
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
Reviewed-by: Fabiano Ro
converting string to MigrationChannelList
5. move calls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (8):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_get_socket_a
On 06/03/24 9:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
On 06/03/24 9:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
On 06/03/24 8:37 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
On 06/03/24 8:12 pm, Fabiano Rosas wrote:
Het Gala writes:
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signe
On 06/03/24 8:10 pm, Fabiano Rosas wrote:
Het Gala writes:
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
passes more than one channel.
Signed-off-by: Het Gala
Suggested-by
On 06/03/24 4:19 pm, Het Gala wrote:
Can also find the successful build here:
https://gitlab.com/galahet/Qemu/-/pipelines/1201488612
Het Gala (7):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_get_socket_address inside
migrate_qmp
Add channels
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 54
1 file
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
passes more than one channel.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 26
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migr
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qt
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 29 ++---
1 file changed
stom function for converting string to MigrationChannelList
5. move calls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (7):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_g
On 01/03/24 2:19 pm, Het Gala wrote:
On 29/02/24 6:47 am, Fabiano Rosas wrote:
Het Gala writes:
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted
On 29/02/24 6:47 am, Fabiano Rosas wrote:
Het Gala writes:
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted. It won't work because
The
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted. It won't work because
The final 'migrate' QAPI with channels string would look l
1 - 100 of 379 matches
Mail list logo
