Hi Maintainers, this is my first attempt trying to standardise the grammar around migration qtests. I am not sure at multiple places on whether a particular string is placed at the right place with the right grammar. Please comment on the patch, if anything you feel can be improvised in the existing design. Suggestions are most welcomed :)
Thank you Fabiano for initiating the idea on having a strict convention to call migration qtests. Hope that this would help further down the lane for anyone to call qtests in particular manner. (For now, have not focused on the character width limit, will comply with that once, we are on a consensus with the design) On 27/03/24 1:08 am, Het Gala wrote:
For <test-type> --> migrate /<test-type>/<migration-mode>/<method>/<transport>/<invocation>/ <compression>/<encryption>/O:<others>/... For <test-type> --> validate /<test-type>/<validate-variable>/O:<transport>/O:<invocation>/ <validate-test-result>/O:<test-reason>/O:<others>/... test-type :: migrate | validate migration-mode a. migrate --> :: precopy | postcopy | multifd b. validate --> :: (what to validate) methods :: preempt | recovery | reboot | suspend | simple transport :: tcp | fd | unix | file invocation :: uri | channels | both CompressionType :: zlib | zstd | none encryptionType :: tls | plain validate-test-result :: success | failure others :: other comments/capability that needs to be addressed. Can be multiple (more than one applicable, separated by using '-' in between) O: optional Signed-off-by: Het Gala <het.g...@nutanix.com> Suggested-by: Fabiano Rosas <faro...@suse.de> --- tests/qtest/migration-test.c | 143 ++++++++++++++++++----------------- 1 file changed, 72 insertions(+), 71 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index bd9f4b9dbb..bf4d000b76 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -3620,62 +3620,63 @@ int main(int argc, char **argv)
Regards, Het Gala