On 10/04/24 6:34 pm, Fabiano Rosas wrote:
!-------------------------------------------------------------------|
CAUTION: External Email
|-------------------------------------------------------------------!
Het Gala<het.g...@nutanix.com> writes:
This reverts commit 8e3766eefbb4036cbc280c1f1a0d28537929f7fb
After addition of 'channels' as the starting argument of new QAPI
syntax inside postcopy test, even if the user entered the old QAPI
syntax, test used the new syntax.
It was a temporary patch added to have some presence of the new syntax
since the migration qtest framework lacked any logic for introducing
'channels' argument.
That wasn't clear to me when we merged that. Was that really the case?
Yes, I had little to no experience on how to introduce 'channels' as a new
argument in the migration QAPIs back then.
IIRC, while trying to merge the series (migration: Modify 'migrate' and
'migrate-incoming' QAPI commands for migration), I was adviced to just
modify
one of the qtest with the new QAPI syntax rather than writing a new qtest
altogether. So, I just renamed the old syntax with the new one.
Now that the qtest framework has logic to introduce uri and channel
argument separately, we can remove this temporary change.
Signed-off-by: Het Gala<het.g...@nutanix.com>
Anyway, I can see the point of this.
Thanks for the support for building that framework.
Today we can independently call channel or uri easily for 'migrate' QAPI
Reviewed-by: Fabiano Rosas <faro...@suse.de
Regards,
Het Gala
