On 11/04/24 7:56 pm, Peter Xu wrote:
!-------------------------------------------------------------------|
CAUTION: External Email
|-------------------------------------------------------------------!
On Thu, Apr 11, 2024 at 07:45:21PM +0530, Het Gala wrote:
On 10/04/24 8:23 pm, Peter Xu wrote:
!-------------------------------------------------------------------|
CAUTION: External Email
|-------------------------------------------------------------------!
On Wed, Apr 10, 2024 at 10:04:33AM -0300, Fabiano Rosas wrote:
Het Gala <het.g...@nutanix.com> writes:
This reverts commit 8e3766eefbb4036cbc280c1f1a0d28537929f7fb
After addition of 'channels' as the starting argument of new QAPI
syntax inside postcopy test, even if the user entered the old QAPI
syntax, test used the new syntax.
It was a temporary patch added to have some presence of the new syntax
since the migration qtest framework lacked any logic for introducing
'channels' argument.
That wasn't clear to me when we merged that. Was that really the case?
Yeah these look all a bit confusing..
I'm wondering whether do we need the new interface to cover both precopy
and postcopy, or one would suffice?
Both should share the same interface. I think it means if we covered the
channels interface in precopy, then perhaps we don't need to test anywhere
else, as we got the code paths all covered.
We actually do the same already for all kinds of channels for postcopy,
where we stick with either tcp/unix but don't cover the rest.
Do we want to add other transports too (vsock, exec, rdma) with the new
interface ?
I believe we have tests for fd based migration
Het,
What I meant is we used to do white box testing for migration, trying to
cover all the code paths would suffice for us in that case.
It means maybe we don't need the postcopy test to cover the channels
interface as long as precopy has covered that and also if that covered all
the "channels" abi then we should be safe.
What I worry is we keep extending the test matrix but we're actually
testing the same code paths. Then the test runs slower each time, we burn
more cpus for each CI kick, but without a real beneift.
Yeah, I understood your concern Peter. Yes, since precopy and postcopy tests
cover the same code path, adding 'channels' postcopy qtests does not make
much sense after already having introduced in precopy qtests.
I just wanted to highlight couple of pointers:
1. though we are using 'channels' in the precopy tests for 'migrate'
QAPI, we
use the old uri for 'migrate-incoming' QAPI.
2. We do not cover other 'channels' abi, only have tcp path tested.
So, the TO-DOs could be:
1. Omit the 4th patch here, which introduced postcopy qtests with 'channels'
interface OR have 'channels' interface with other than tcp transport
(file, exec, vsock, etc) so as to cover different code paths.
2. Extend channels interface to migrate-incoming QAPI for precopy qtests
Regards,
Het Gala
