[PATCH] hw/core/qdev-properties-system: Add missing return in set_drive_helper()

2025-05-22 Thread Fiona Ebner
Currently, changing the drive property of e.g. a scsi-hd object will result in an assertion failure: > bdrv_replace_child_noperm: Assertion `bdrv_get_aio_context(old_bs) == > bdrv_get_aio_context(new_bs)' failed. The problematic scenario is already detected, but a 'return' statement was missing.

RE: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-22 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to >host > >Hey Nic, > >On 2025/5/22 06:49, Nicolin Chen wrote: >> On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: >>> +static const MemoryListener iommufd_s2d

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-22 Thread Cédric Le Goater
On 5/22/25 19:30, Steven Sistare wrote: On 5/22/2025 1:20 PM, Cédric Le Goater wrote: On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma m

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-22 Thread Yi Liu
On 2025/5/23 03:29, Nicolin Chen wrote: On Thu, May 22, 2025 at 06:50:42AM +, Duan, Zhenzhong wrote: -Original Message- From: Nicolin Chen Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-22 Thread Yi Liu
Hey Nic, On 2025/5/22 06:49, Nicolin Chen wrote: On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: +static const MemoryListener iommufd_s2domain_memory_listener = { +.name = "iommufd_s2domain", +.priority = 1000, +.region_add = iommufd_listener_region_add_s2domain, +

Re: [PATCH] target/riscv/cpu.c: fix zama16b order in isa_edata_arr[]

2025-05-22 Thread Alistair Francis
On Thu, May 22, 2025 at 9:35 PM Daniel Henrique Barboza wrote: > > Put it after zalrsc and before zawrs. > > Cc: qemu-triv...@nongnu.org > Fixes: a60ce58fd9 ("target/riscv: Support Zama16b extension") > Signed-off-by: Daniel Henrique Barboza Thanks! Applied to riscv-to-apply.next Alistair > -

[RFC PATCH v10 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Rorie Reyes
Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 12 +++

[RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change

2025-05-22 Thread Rorie Reyes
Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. If configuring --without-default-devices, hw/s390x/ap-stub.c was created to handle such circumstance. Also added the following to hw/s390x/meson.build if CONFIG_VFIO_AP is false, it wi

[RFC PATCH v10 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Rorie Reyes
These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 53 inc

[RFC PATCH v10 0/4] Report vfio-ap configuration changes

2025-05-22 Thread Rorie Reyes
Changelog: v10: - Added reviewed by for patch 4 by Tony and Cedric - review needed for patch 2 and 3 - changed 'cfg_chg_events' to a static variable - locked 'cfg_chg_events' using QemuMutex - removed ';' at the end of the definition for NT0 - returning bools for 'ap_chsc_sei_nt0_get_event' and

[RFC PATCH v10 1/4] hw/vfio/ap: notification handler for AP config changed event

2025-05-22 Thread Rorie Reyes
Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 31 +++ 1 file cha

Re: [PATCH] target/riscv/cpu.c: fix zama16b order in isa_edata_arr[]

2025-05-22 Thread Alistair Francis
On Thu, May 22, 2025 at 9:35 PM Daniel Henrique Barboza wrote: > > Put it after zalrsc and before zawrs. > > Cc: qemu-triv...@nongnu.org > Fixes: a60ce58fd9 ("target/riscv: Support Zama16b extension") > Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Alistair > --- > tar

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Rorie Reyes
Please ignore my comments bellow. I made some foundational mistakes going through this process. I should be able to return bools based on Cedric's remarks. I flipped the meaning behind returning 1 vs 0 as false vs true which is incorrect. Returning 1 is true and returning 0 is false. I had thos

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Rorie Reyes
On 5/22/25 3:02 PM, Anthony Krowiak wrote: On 5/22/25 9:35 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Rorie Reyes
On 5/22/25 11:36 AM, Cédric Le Goater wrote: On 5/22/25 16:28, Rorie Reyes wrote: On 5/22/25 9:27 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects wil

Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-22 Thread Zhijian Li (Fujitsu)
On 22/05/2025 21:16, Peter Xu wrote: > I followed up with Dave's idea, but then added all entries into it, below. > >Status: postcopy-active >Time (ms): total=40504, setup=14, down=145 >RAM info: > Throughput (Mbps): 6102.65 > Sizes (KiB):pagesize=4, total=16777992

[PATCH v4 5/9] plugins: Add memory hardware address read/write API

2025-05-22 Thread Rowan Hart
From: novafacing This patch adds functions to the plugins API to allow plugins to read and write memory via hardware addresses. The functions use the current address space of the current CPU in order to avoid exposing address space information to users. A later patch may want to add a function to

[PATCH v4 4/9] plugins: Add memory virtual address write API

2025-05-22 Thread Rowan Hart
From: novafacing This patch adds functions to the plugins API to allow reading and writing memory via virtual addresses. These functions only permit doing so on the current CPU, because there is no way to ensure consistency if plugins are allowed to read or write to other CPUs that aren't current

[PATCH v4 6/9] plugins: Add patcher plugin and test

2025-05-22 Thread Rowan Hart
From: novafacing This patch adds a plugin that exercises the virtual and hardware memory read-write API functions added in a previous patch. The plugin takes a target and patch byte sequence, and will overwrite any instruction matching the target byte sequence with the patch. Signed-off-by: nova

[PATCH v4 0/9] Add additional plugin API functions to read and write memory and registers

2025-05-22 Thread Rowan Hart
This patch series adds several new API functions focused on enabling use cases around reading and writing guest memory from QEMU plugins. To support these new APIs, some utility functionality around retrieving information about address spaces is added as well. The new qemu_plugin_write_register ut

[PATCH v4 7/9] plugins: Add hypercalls plugin and test

2025-05-22 Thread Rowan Hart
From: novafacing This patch adds a plugin that implements a simple form of hypercalls from guest code to the plugin by using the register read API. It accepts only one hypercall, which writes a magic value to guest memory. Signed-off-by: novafacing Signed-off-by: Rowan Hart --- tests/tcg/Make

[PATCH v4 3/9] plugins: Add enforcement of QEMU_PLUGIN_CB flags in register R/W callbacks

2025-05-22 Thread Rowan Hart
This patch adds functionality to enforce the requested QEMU_PLUGIN_CB_ flags level passed when registering a callback function using the plugins API. Each time a callback is about to be invoked, a thread-local variable will be updated with the level that callback requested. Then, called API functio

[PATCH v4 8/9] plugins: Remove use of qemu_plugin_read_register where it is not permitted

2025-05-22 Thread Rowan Hart
This patch is required to make the insn plugin work after adding enforcement of QEMU_PLUGIN_CB_ flags in calls to read or write registers. Previously, these flags were not enforced and the API could be called from anywhere, but this was not intended as described by the documentation. Now, the flags

[PATCH v4 2/9] plugins: Add register write API

2025-05-22 Thread Rowan Hart
From: novafacing This patch adds a function to the plugins API to allow plugins to write register contents. It also moves the qemu_plugin_read_register function so all the register-related functions are grouped together in the file. Signed-off-by: novafacing Signed-off-by: Rowan Hart --- incl

[PATCH v4 1/9] gdbstub: Expose gdb_write_register function to consumers of gdbstub

2025-05-22 Thread Rowan Hart
From: novafacing This patch exposes the gdb_write_register function from gdbstub/gdbstub.c via the exec/gdbstub.h header file to support use in plugins to write register contents. Signed-off-by: novafacing Signed-off-by: Rowan Hart --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h |

[PATCH v4 9/9] plugins: Update plugin version and add notes

2025-05-22 Thread Rowan Hart
From: novafacing This patch updates the plugin version to gate new APIs and adds notes describing what has been added. Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/

[PATCH] target/loongarch: add check for fcond

2025-05-22 Thread Song Gao
fcond only has 22 types, add a check for fcond. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2972 Signed-off-by: Song Gao --- target/loongarch/tcg/insn_trans/trans_fcmp.c.inc | 11 --- target/loongarch/tcg/insn_trans/trans_vec.c.inc | 4 ++-- 2 files changed, 10 insertions(

Re: [PATCH v1 0/3] target/i386: Add the immediate form MSR access instruction support

2025-05-22 Thread Xin Li
On 4/15/2025 8:25 PM, Xin Li wrote: On 1/3/2025 12:48 AM, Xin Li (Intel) wrote: The immediate form of MSR access instructions are primarily motivated by performance, not code size: by having the MSR number in an immediate, it is available *much* earlier in the pipeline, which allows the hardware

New test in bios-tables-test.c for the ACPI PCI hotplug on ARM series

2025-05-22 Thread Gustavo Romero
Hi Eric, While we go through the ACPI PCI Hotplug series [0] and review it, I'm starting to take a look at tests/qtest/bios-tables-test.c. You mentioned testing the combinations of "acpi-root-pci-hotplug" and "acpi-pci-hotplug-with-bridge-support" flags [1], but taking a look now I see that "acp

Re: [PATCH] target/arm: Ignore SCTLR_EL2.EnSCXT when !ELIsInHost()

2025-05-22 Thread Gustavo Romero
Hi Oliver, Thanks for patch. On 5/21/25 16:02, Oliver Upton wrote: Using an EL2 that enables SCXTNUM_ELx for guests while disabling the feature for the host generates erroneous traps to EL2 when running under TCG. Fix the issue by only evaluating SCTLR_EL2.EnSCXT when ELIsInHost(). Signed-off

Re: [PATCH] Add support for FMAPI Get Mutliheaded Head info opcode (5501h)

2025-05-22 Thread Anisa Su
On Thu, May 22, 2025 at 12:01:35PM +0530, Vinayak Holikatti wrote: > CXL spec 3.2 section 7.6.7.5.2 describes Get Head Info. > > Signed-off-by: Vinayak Holikatti > --- > This patch is generated against Jonathan Cameron's branch cxl-2025-03-20 > > hw/cxl/cxl-mailbox-utils.c | 21 + > h

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Pierrick Bouvier
On 5/22/25 2:01 PM, Rowan Hart wrote: > This definition strikes me as odd. What was your reason to assert > `current_cpu` here, but not in the other two functions? Also a bit > surprising is the declaration of `cpu` if you use it in just one place > (rather than just use

Re: [PATCH 00/16] hw/pci-host/raven clean ups

2025-05-22 Thread BALATON Zoltan
On Sun, 4 May 2025, BALATON Zoltan wrote: Hello, This series cleans up and simplifies the raven model which does some strange stuff that no other pci-host is doing and does it in a convoluted way and also has some legacy bits that can be removed. Apart from making the model much more readable th

Re: [PATCH 00/13] Pegasos2 clean up and pegasos1 emulation

2025-05-22 Thread BALATON Zoltan
On Fri, 2 May 2025, BALATON Zoltan wrote: This series changes how the fdt for VOF is generated in pegasos2 by moving the static parts to a dtb and only generate the changing parts such as memory size and PCI devices programmatically. This simplifies the code and allows simply adding emulation of

sr-iov live migration with NET_FAILOVER

2025-05-22 Thread Paul B. Henson
I'm running libvirtd under Debian 12 and trying to set up live migration of a linux vm that's using an sr-iov VF as its primary ethernet device. I have that device and the corresponding virtio backup device properly configured in libvirt, and when the vm starts up everything looks good: 2: nic

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie

[PATCH] iotests: Improve mirror-sparse on various filesystems

2025-05-22 Thread Eric Blake
Fiona reported that an ext4 filesystem on top of LVM can sometimes report over-allocation to du (based on the hueristics the filesystem is making while observing the contents being mirrored); even though the contents and actual size matched, about 50% of the time the size reported by disk_usage was

Re: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-22 Thread Steven Sistare
On 5/21/2025 11:19 PM, Duan, Zhenzhong wrote: -Original Message- From: Steven Sistare Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl On 5/20/2025 11:11 PM, Duan, Zhenzhong wrote: -Original Message- From: Steven Sistare Subject: Re: [PATCH V3 29/42] backen

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Rowan Hart
> > > > This definition strikes me as odd. What was your reason to assert > > `current_cpu` here, but not in the other two functions? Also a bit > > surprising is the declaration of `cpu` if you use it in just one place > > (rather than just use `current_cpu` directly as for the assertion). > > > >

Re: [PATCH] migration/multifd: Don't send device state packets with zerocopy flag

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 11:12:22PM +0300, Michael Tokarev wrote: > On 16.05.2025 16:53, Maciej S. Szmigiero wrote: > > From: "Maciej S. Szmigiero" > > > > If zerocopy is enabled for multifd then QIO_CHANNEL_WRITE_FLAG_ZERO_COPY > > flag is forced into all multifd channel write calls via p->write_

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-22 Thread Wei Liu
On Thu, May 22, 2025 at 05:42:48PM +0200, Magnus Kulke wrote: > On Tue, May 20, 2025 at 07:07:06PM +, Wei Liu wrote: > > On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > > > +static void mshv_reset(void *param) > > > +{ > > > +warn_report("mshv reset"); > > > > What's missin

Re: [PATCH v2 1/2] migration: Allow caps to be set when preempt or multifd cap enabled

2025-05-22 Thread Michael Tokarev
On 14.05.2025 23:01, Peter Xu wrote: With commit 82137e6c8c ("migration: enforce multifd and postcopy preempt to be set before incoming"), and if postcopy preempt / multifd is enabled, one cannot setup any capability because these checks would always fail. (qemu) migrate_set_capability xbzrle of

Re: [PATCH] migration/multifd: Don't send device state packets with zerocopy flag

2025-05-22 Thread Michael Tokarev
On 16.05.2025 16:53, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" If zerocopy is enabled for multifd then QIO_CHANNEL_WRITE_FLAG_ZERO_COPY flag is forced into all multifd channel write calls via p->write_flags that was setup in multifd_nocomp_send_setup(). However, device state packe

Re: [PATCH v3 2/8] Add register write API

2025-05-22 Thread Rowan Hart
> a) handle the QEMU_PLUGIN_CB_RW_REGS I missed that this was not already handled. I'll fix that. > b) try and enforce we are only being called from such callbacks Sure, beyond documentation I suppose we can add and check a flag to ensure this. I think it's a good idea to reduce foot guns from

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 8:34 PM, Rowan Hart wrote: Well, first I just noticed that I left a debug print in this function! So I'll fix that. Reading this patch, and patch 3 (Add address space API), I am not sure AddressSpace is something we want to leak in plugins interface. It is a concept *very* internal t

Re: [PATCH rfcv3 05/21] vfio/iommufd: Save vendor specific device info

2025-05-22 Thread Nicolin Chen
On Thu, May 22, 2025 at 09:21:04AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Nicolin Chen > >Subject: Re: [PATCH rfcv3 05/21] vfio/iommufd: Save vendor specific device > >info > > > >On Wed, May 21, 2025 at 07:14:35PM +0800, Zhenzhong Duan wrote: > >> @@ -852,6 +8

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-22 Thread Nicolin Chen
On Thu, May 22, 2025 at 06:50:42AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Nicolin Chen > >Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to > >host > > > >On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: > >> +static co

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Pierrick Bouvier
On 5/22/25 4:59 AM, Julian Ganz wrote: This definition strikes me as odd. What was your reason to assert `current_cpu` here, but not in the other two functions? Also a bit surprising is the declaration of `cpu` if you use it in just one place (rather than just use `current_cpu` directly as for th

Re: [PATCH] Add support for FMAPI Get Mutliheaded Head info opcode (5501h)

2025-05-22 Thread Davidlohr Bueso
On Thu, 22 May 2025, Vinayak Holikatti wrote: CXL spec 3.2 section 7.6.7.5.2 describes Get Head Info. So how was this tested? Ideally this now comes with a libcxlmi (or equivalent) test case. See for example how Anisa is going about this with the FMAPI DCD patches: https://lore.kernel.org/li

Re: [PATCH 5/8] python: convert remaining deprecated type hints for 3.9+

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 5:31 AM Markus Armbruster wrote: > John Snow writes: > > > In this patch, we don't have a builtin type to use for a type hint, but > > we do have collections.abc and other standard library types. Replace > > deprecated type hints with their standard library equivalents: >

Re: [PATCH 4/8] python: use 3.9+ builtin type hints

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 5:26 AM Markus Armbruster wrote: > John Snow writes: > > > This patch changes type hints that have built-in equivalents as of > > Python 3.9. The versions we currently use, imported from the typing > > module, have been deprecated since 3.9 and may be removed at any time

Re: [PATCH 2/8] python: update pylint ignores

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 3:42 AM Markus Armbruster wrote: > John Snow writes: > > > The next patch will synchronize the qemu.qmp library with the external, > > standalone version. That synchronization will require a few extra > > ignores for pylint, so do that now. > > Just one, unless I'm cross-

[PATCH v4 01/15] qapi: expose rtc-reset-reinjection command unconditionally

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the rtc-reset-reinjection command. This requires providing a QMP command stub for non-i386 target. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from

Re: [PATCH v3 00/14] qapi: remove all TARGET_* conditionals from the schema

2025-05-22 Thread Pierrick Bouvier
This series contains a rebase mistake (two patches were merged together), please skip it and check v4 instead: https://lore.kernel.org/qemu-devel/20250522190542.588267-1-pierrick.bouv...@linaro.org Regards, Pierrick

[PATCH v4 06/15] qapi: make Xen event commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the Xen event channel commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Acked-by: Dav

[PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema

2025-05-22 Thread Pierrick Bouvier
This series exposes all qmp commands for any target unconditionally, allowing to compile QAPI generated code without any TARGET conditionals. Based on original RFC from Daniel P. Berrangé: https://lore.kernel.org/qemu-devel/20250508135816.673087-1-berra...@redhat.com/ v4 -- - Update commit descr

[PATCH v4 05/15] qapi: make SGX commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SGX confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Observe a pre-existing bug that the "SGXEPCSection" struct lacked

[PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/

2025-05-22 Thread Pierrick Bouvier
As requested by Markus: > I'd prefer "field is set". Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 3fda7a20bdd..6f79817e382 100644 --- a/qapi/misc-i386.json +++ b/qapi/mi

[PATCH v4 09/15] qapi: make most CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs are provided to cope with targets which do not currently implement all of the commands. Adjust the doc comments accordingly. Reviewed-by: Richard Henderson Signed-off-by: Danie

[PATCH v4 13/15] qapi: use imperative style in documentation

2025-05-22 Thread Pierrick Bouvier
As requested by Markus: > We prefer imperative mood "Return" over "Returns". Signed-off-by: Pierrick Bouvier --- qapi/audio.json | 2 +- qapi/char.json | 4 ++-- qapi/cryptodev.json | 2 +- qapi/machine.json | 4 ++-- qapi/migration.json | 8 qapi/misc-i386.json | 6 +++--- q

[PATCH v4 02/15] qapi: expand docs for SEV commands

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This gives some more context about the behaviour of the commands in unsupported guest configuration or platform scenarios. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by: Pierrick Bouvier --- qapi/misc-target.json | 43

[PATCH v4 12/15] qapi: make all generated files common

2025-05-22 Thread Pierrick Bouvier
Monolithic files (qapi_nonmodule_outputs) can now be compiled just once, so we can remove qapi_util_outputs logic. This removes the need for any specific_ss file. Signed-off-by: Pierrick Bouvier --- qapi/meson.build | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-)

[PATCH v4 11/15] qapi: remove qapi_specific_outputs from meson.build

2025-05-22 Thread Pierrick Bouvier
There is no more QAPI files that need to be compiled per target, so we can remove this. qapi_specific_outputs is now empty, so we can remove the associated logic in meson. Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Signed-off-by: Pierrick Bouvi

[PATCH v4 07/15] qapi: remove the misc-target.json file

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This file is now empty and can thus be removed. Observe the pre-existing bug with s390-skeys.c and target/i386/monitor.c both including qapi-commands-misc-target.h despite not requiring it. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by

[PATCH v4 10/15] qapi: make s390x specific CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_S390X and CONFIG_KVM conditions from the CPU commands that are conceptually specific to s390x. Top level stubs are provided to cope with non-s390x targets, or builds without KVM. The removal of CONFIG_KVM is justified by the fact there is no conce

[PATCH v4 04/15] qapi: expose query-gic-capability command unconditionally

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_ARM condition from the query-gic-capability command. This requires providing a QMP command stub for non-ARM targets. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from t

[PATCH v4 15/15] qapi/misc-i386: move errors to their own documentation section

2025-05-22 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 6f79817e382..796eaa5f406 100644 --- a/qapi/misc-i386.json +++ b/qapi/misc-i386.json

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 1:17 PM, Rorie Reyes wrote: On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct pr

[PATCH v4 03/15] qapi: make SEV commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SEV confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé

[PATCH v4 08/15] qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic

2025-05-22 Thread Pierrick Bouvier
From: Philippe Mathieu-Daudé We'd like to have some unified QAPI schema. Having a structure field conditional to a target being built in is not very practical. While @deprecated-props is only used by s390x target, it is generic enough and could be used by other targets (assuming we expand CpuMod

Re: [PULL 00/12] Migration 20250520 patches

2025-05-22 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-22 Thread Eric Blake
On Thu, May 22, 2025 at 08:38:34PM +0300, Andrey Drobyshev wrote: > On 4/28/25 9:46 PM, Eric Blake wrote: > > From: "Richard W.M. Jones" > > > > Add multi-conn option to the NBD client. This commit just adds the > > option, it is not functional. > > > > Setting this to a value > 1 permits multi

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 9:35 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie

Re: [PATCH v2 2/7] hw/arm: remove explicit dependencies listed

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 9:52 PM, Thomas Huth wrote: On 22/05/2025 00.34, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/arm/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth There is another bunch of pixmans in hw/display/meson.build and

Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 10:12 PM, Markus Armbruster wrote: Pierrick Bouvier writes: On 5/18/25 11:29 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs

Re: [PATCH v2 4/4] nbd: Enable multi-conn using round-robin

2025-05-22 Thread Eric Blake
On Thu, May 22, 2025 at 08:37:58PM +0300, Andrey Drobyshev wrote: > On 4/28/25 9:46 PM, Eric Blake wrote: > > From: "Richard W.M. Jones" > > > > Enable NBD multi-conn by spreading operations across multiple > > connections. > > > > (XXX) This uses a naive round-robin approach which could be impr

[PULL 5/5] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 Thread Kevin Wolf
When scsi-block is used on a host multipath device, it runs into the problem that the kernel dm-mpath doesn't know anything about SCSI or SG_IO and therefore can't decide if a SG_IO request returned an error and needs to be retried on a different path. Instead of getting working failover, an error

[PULL 1/5] scsi-disk: Add native FUA write support

2025-05-22 Thread Kevin Wolf
From: Alberto Faria Simply propagate the FUA flag on write requests to the driver. The block layer will emulate it if necessary. Signed-off-by: Alberto Faria Message-ID: <20250502121115.3613717-2-afa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 5

[PULL 4/5] file-posix: allow BLKZEROOUT with -t writeback

2025-05-22 Thread Kevin Wolf
From: Stefan Hajnoczi The Linux BLKZEROOUT ioctl is only invoked when BDRV_O_NOCACHE is set because old kernels did not invalidate the page cache. In that case mixing BLKZEROOUT with buffered I/O could lead to corruption. However, Linux 4.9 commit 22dd6d356628 ("block: invalidate the page cache

[PULL 0/5] Block layer patches

2025-05-22 Thread Kevin Wolf
The following changes since commit f0737158b483e7ec2b2512145aeab888b85cc1f7: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2025-05-20 10:26:30 -0400) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch cha

[PULL 3/5] qemu-img: fix offset calculation in bench

2025-05-22 Thread Kevin Wolf
From: Denis Rastyogin This error was discovered by fuzzing qemu-img. The current offset calculation leads to an EIO error in block/block-backend.c: blk_check_byte_request(): if (offset > len || len - offset < bytes) { return -EIO; } This triggers the error message: "qemu-img: Failed req

[PULL 2/5] scsi-disk: Advertise FUA support by default

2025-05-22 Thread Kevin Wolf
From: Alberto Faria Allow the guest to submit FUA requests directly, instead of forcing it to emulate them using a regular flush. Signed-off-by: Alberto Faria Message-ID: <20250502121115.3613717-3-afa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- hw/core/machine.c |

Re: [PATCH v2 4/4] tests/functional/test_vmstate: Test whether the checker script works as expected

2025-05-22 Thread Thomas Huth
On 22/05/2025 16.40, Peter Xu wrote: On Thu, May 22, 2025 at 03:37:56PM +0200, Thomas Huth wrote: From: Thomas Huth We've got two vmstate dump files in the repository which are meant for verifying whether the vmstate-static-checker.py works as expected. Since running this manually is a cumbers

Re: [PATCH v2 3/4] tests/functional: Test with scripts/vmstate-static-checker.py

2025-05-22 Thread Thomas Huth
On 22/05/2025 16.38, Peter Xu wrote: On Thu, May 22, 2025 at 03:37:55PM +0200, Thomas Huth wrote: [...] +def test_vmstate(self): +target_machine = { +'aarch64': 'virt-7.2', +'m68k': 'virt-7.2', +'ppc64': 'pseries-7.2', +'s390x': 's390

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-22 Thread Andrey Drobyshev
On 4/28/25 9:46 PM, Eric Blake wrote: > From: "Richard W.M. Jones" > > Add multi-conn option to the NBD client. This commit just adds the > option, it is not functional. > > Setting this to a value > 1 permits multiple connections to the NBD > server; a typical value might be 4. The default is

Re: [PATCH v2 4/4] nbd: Enable multi-conn using round-robin

2025-05-22 Thread Andrey Drobyshev
On 4/28/25 9:46 PM, Eric Blake wrote: > From: "Richard W.M. Jones" > > Enable NBD multi-conn by spreading operations across multiple > connections. > > (XXX) This uses a naive round-robin approach which could be improved. > For example we could look at how many requests are in flight and > assig

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-22 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: >>> The migration parameters validation involves producing a temporary >>> structure which merges the current parameter values with the new >>> parameters set by the user. >>> >>> The ha

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-22 Thread Steven Sistare
On 5/22/2025 1:20 PM, Cédric Le Goater wrote: On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma map vfio-user message; CPR will also will

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-22 Thread Cédric Le Goater
On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma map vfio-user message; CPR will also will need this. Originally-by: John Johnson Signed

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Rorie Reyes
On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie R

[PATCH 2/3] docs: remove legacy QAPI manual generator

2025-05-22 Thread John Snow
Thanks for your service! Remove the old qapidoc and the option to enable the transmogrifier, leaving the transmogrifier as the ONLY qapi doc generator. This has the side effect of converting the tests to use the new system, too. Signed-off-by: John Snow --- docs/interop/qemu-ga-ref.rst

[PATCH 0/3] docs: remove legacy qapidoc

2025-05-22 Thread John Snow
This series is RFC-ish and based on python-qapi-linting-v4, which I think ... should show up in origin/master soon(?). John Snow (3): docs: fix errors formatting in test-good docs: remove legacy QAPI manual generator docs: remove special parsing for freeform sections docs/devel/qapi-code-g

[PATCH 3/3] docs: remove special parsing for freeform sections

2025-05-22 Thread John Snow
This change removes special parsing for freeform sections and allows them to simply be unmodified rST syntax. The existing headings in the QAPI schema are adjusted to reflect the new paradigm. Markus: presumably you'll want to update the tests and/or change the parser errors. Please advise! Signe

[PATCH 1/3] docs: fix errors formatting in test-good

2025-05-22 Thread John Snow
If we remove the legacy parser, this formulation begins to fail because the body text is appended directly after the field list entry, which is invalid rST syntax. Markus: suggest where the new Exception(s) should go, if anywhere, and how to update the tests? I'm assuming deeply you'll want to. S

Re: [PATCH] Add support for FMAPI Get Mutliheaded Head info opcode (5501h)

2025-05-22 Thread Fan Ni
On Thu, May 22, 2025 at 12:01:35PM +0530, Vinayak Holikatti wrote: > CXL spec 3.2 section 7.6.7.5.2 describes Get Head Info. > > Signed-off-by: Vinayak Holikatti > --- > This patch is generated against Jonathan Cameron's branch cxl-2025-03-20 > > hw/cxl/cxl-mailbox-utils.c | 21 + > h

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-22 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: >> The migration parameters validation involves producing a temporary >> structure which merges the current parameter values with the new >> parameters set by the user. >> >> The has_ boolean fields of MigrateSetPa

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Rorie Reyes
On 5/22/25 11:36 AM, Cédric Le Goater wrote: On 5/22/25 16:28, Rorie Reyes wrote: On 5/22/25 9:27 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects wil

[PATCH 0/5] Enable QEMU TCI to run 64bit guests on browsers

2025-05-22 Thread Kohei Tokunaga
This patch series is split from the original "Enable QEMU to run on browsers" series, focusing solely on supporting 64bit guest on QEMU TCI compiled with Emscripten. The implementation is based on discussions from the thread in the "tcg: Add WebAssembly backend" patch series, particulalrly Paolo Bo

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-22 Thread Magnus Kulke
On Tue, May 20, 2025 at 07:07:06PM +, Wei Liu wrote: > On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > > +static void mshv_reset(void *param) > > +{ > > +warn_report("mshv reset"); > > What's missing for this hook? > Ah, I suppose this was inspired by the KVM accel. The h

Re: [PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

2025-05-22 Thread Alex Bennée
Thomas Huth writes: > From: Thomas Huth > > The problem with the PCI bridge has been fixed in commit e5894fd6f411c1 > ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the > corresponding test again. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée -- Alex Bennée Vir

  1   2   3   >