On Thu, May 22, 2025 at 11:12:22PM +0300, Michael Tokarev wrote: > On 16.05.2025 16:53, Maciej S. Szmigiero wrote: > > From: "Maciej S. Szmigiero" <maciej.szmigi...@oracle.com> > > > > If zerocopy is enabled for multifd then QIO_CHANNEL_WRITE_FLAG_ZERO_COPY > > flag is forced into all multifd channel write calls via p->write_flags > > that was setup in multifd_nocomp_send_setup(). > > > > However, device state packets aren't compatible with zerocopy - the data > > buffer isn't getting kept pinned until multifd channel flush. > > > > Make sure to mask that QIO_CHANNEL_WRITE_FLAG_ZERO_COPY flag in a multifd > > send thread if the data being sent is device state. > > > > Fixes: 0525b91a0b99 ("migration/multifd: Device state transfer support - > > send side") > > Signed-off-by: Maciej S. Szmigiero <maciej.szmigi...@oracle.com> > > Is this qemu-stable material (for 10.0)? > > I'm picking it up for 10.0 branch, please let me know if I shouldn't.
Yes please, for two migration patches in the lastest pull. I forgot to add Cc: for stable. I'll try to remember again, thanks. -- Peter Xu