On 5/22/25 11:36 AM, Cédric Le Goater wrote:
On 5/22/25 16:28, Rorie Reyes wrote:

On 5/22/25 9:27 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
Creates an object indicating that an AP configuration change event
has been received and stores it in a queue. These objects will later
be used to store event information for an AP configuration change
when the CHSC instruction is intercepted.

Signed-off-by: Rorie Reyes <rre...@linux.ibm.com>
---
  hw/vfio/ap.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 3d0af7a54a..5ea5dd9cca 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13 @@ struct VFIOAPDevice {
      EventNotifier cfg_notifier;
  };
  +typedef struct APConfigChgEvent {
+    QTAILQ_ENTRY(APConfigChgEvent) next;
+} APConfigChgEvent;
+
+QTAILQ_HEAD(, APConfigChgEvent) cfg_chg_events =
+    QTAILQ_HEAD_INITIALIZER(cfg_chg_events);
+

Could cfg_chg_events be static ?


Thanks,

C.

You make a good point, Cedric. I'm only using this variable in ap.c. Having it as a static would prevent it from being modified anywhere else


Good. Would you have time to send a v10 ?


Thanks,

C.


I should be able to send a v10 by today. I'm currently working on the other two comments you left for patch 3

Reply via email to