[PATCH 3/4] docs/about/deprecated: Move deprecation notes to tidy up order

2025-05-20 Thread Markus Armbruster
The deprecation notes within a section are mostly in version order. Move the few that aren't so they are. Signed-off-by: Markus Armbruster --- docs/about/deprecated.rst | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/about/deprecated.rs

[PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

2025-05-20 Thread Markus Armbruster
Argument @detach has always been ignored. Start the clock to get rid of it. Cc: Peter Xu Cc: Fabiano Rosas Signed-off-by: Markus Armbruster --- docs/about/deprecated.rst | 5 + qapi/migration.json | 18 +- 2 files changed, 14 insertions(+), 9 deletions(-) diff --gi

[PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

2025-05-20 Thread Markus Armbruster
Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP device_add) fixed them for v9.2.0, but neglected to update documentation. Do that now. Cc: Stefan Hajnoczi Signed-off-by: Markus Armbruster --- docs/about/de

[PATCH 0/4] An overdue deprecation, a doc fix, a bit of cleanup

2025-05-20 Thread Markus Armbruster
Markus Armbruster (4): docs/about: Belatedly document tightening of QMP device_add checking qapi/migration: Deprecate migrate argument @detach docs/about/deprecated: Move deprecation notes to tidy up order docs/about/removed-features: Move removal notes to tidy up order docs/about/depreca

[PATCH 4/4] docs/about/removed-features: Move removal notes to tidy up order

2025-05-20 Thread Markus Armbruster
The removal notes within a section are mostly in version order. Move the few that aren't so they are. Signed-off-by: Markus Armbruster --- docs/about/removed-features.rst | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/docs/about/removed-f

Re: [PATCH v2 00/20] AMD vIOMMU: DMA remapping support for VFIO devices

2025-05-20 Thread Sairaj Kodilkar
On 5/21/2025 8:05 AM, Alejandro Jimenez wrote: Hi Sairaj On 5/16/25 4:07 AM, Sairaj Kodilkar wrote: On 5/2/2025 7:45 AM, Alejandro Jimenez wrote: Hi Alejandro, Tested the v2, everything looks good when I boot guest with upstream kernel. But I observed that NVME driver fails to load wit

Re: [PATCH v2 11/17] gdbstub: Try unlinking the unix socket before binding

2025-05-20 Thread Alex Bennée
Ilya Leoshkevich writes: > On 2025-05-20 15:50, Michael Tokarev wrote: >> 07.02.2025 18:31, Alex Bennée wrote: >>> From: Ilya Leoshkevich >>> In case an emulated process execve()s another emulated process, >>> bind() >>> will fail, because the socket already exists. So try deleting it. Use >>> t

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-20 Thread Akihiko Odaki
On 2025/05/21 9:51, Jason Wang wrote: On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki wrote: On 2025/05/16 10:44, Jason Wang wrote: On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki wrote: On 2025/05/14 14:05, 'Jason Wang' via devel wrote: On Sat, May 10, 2025 at 3:24 PM Akihiko Odaki wrote:

RE: [PATCH V3 31/42] vfio/iommufd: use IOMMU_IOAS_MAP_FILE

2025-05-20 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 31/42] vfio/iommufd: use IOMMU_IOAS_MAP_FILE > >On 5/19/2025 11:52 AM, Steven Sistare wrote: >> On 5/16/2025 4:48 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH V

RE: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-20 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl > >On 5/19/2025 11:51 AM, Steven Sistare wrote: >> On 5/16/2025 4:42 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH

Re: [RFC PATCH] migration/ram: avoid to do log clear in the last round

2025-05-20 Thread Yanfei Xu
On 2025/5/21 04:33, Peter Xu wrote: On Tue, May 20, 2025 at 04:05:57PM -0300, Fabiano Rosas wrote: Yanfei Xu writes: There won't be any ram sync after the stage of save_complete, therefore it's unnecessary to do manually protect for dirty pages being sent. Skip to do this in last round can re

RE: [PATCH V3 28/42] backends/iommufd: iommufd_backend_map_file_dma

2025-05-20 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 28/42] backends/iommufd: >iommufd_backend_map_file_dma > >On 5/19/2025 11:51 AM, Steven Sistare wrote: >> On 5/16/2025 4:26 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject

RE: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors

2025-05-20 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors > >On 5/16/25 10:55, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Steve Sistare >>> Subject: [PATCH V3 33/42] vfio/iommufd: define hwpt constructor

Re: [PATCH v2 00/20] AMD vIOMMU: DMA remapping support for VFIO devices

2025-05-20 Thread Alejandro Jimenez
Hi Sairaj On 5/16/25 4:07 AM, Sairaj Kodilkar wrote: On 5/2/2025 7:45 AM, Alejandro Jimenez wrote: Hi Alejandro, Tested the v2, everything looks good when I boot guest with upstream kernel. But I observed that NVME driver fails to load with guest kernel version 4.15.0-213-generic. This is

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-20 Thread Jason Wang
On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki wrote: > > On 2025/05/16 10:44, Jason Wang wrote: > > On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki > > wrote: > >> > >> On 2025/05/14 14:05, 'Jason Wang' via devel wrote: > >>> On Sat, May 10, 2025 at 3:24 PM Akihiko Odaki > >>> wrote: > > >

Re: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-20 Thread Gavin Shan
Hi Salil, A kindly ping. vCPU hotplug is an important feature and You has put so much energies and amazing efforts to enable the feature from QEMU side, but it seems it has been stuck recently. I received many messages from Redhat internal and external to ask if vCPU hotplug has been supported on

Re: [PATCH v3 1/1] hw/nvme: CMIC.MCTRS should be set automatically for multi-controller subsystems or by parameter

2025-05-20 Thread alan . adamson
Reposting. Alan On 5/1/25 11:45 AM, Alan Adamson wrote: If there are multiple controllers in a subsystem, CMIC.MCTRS should be set to on for all controllers. For single controller subsystems, CMIC.MCTRS will be off by default. A new subsystem specific parameter will allow setting CMIC.MCTRS fo

Re: [RFC PATCH 24/25] target/i386/mshv: Implement mshv_vcpu_run()

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:17PM +0200, Magnus Kulke wrote: > Add the main vCPU execution loop for MSHV using the MSHV_RUN_VP ioctl. > > A translate_gva() hypercall is implemented. The execution loop handles > guest entry and VM exits. There are handlers for memory r/w, PIO and > MMIO to which t

Re: [RFC PATCH 22/25] target/i386/mshv: Integrate x86 instruction decoder/emulator

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:15PM +0200, Magnus Kulke wrote: > Connect the x86 instruction decoder and emulator to the MSHV backend > to handle intercepted instructions. This enables software emulation > of MMIO operations in MSHV guests. MSHV has a translate_gva hypercall > that is used to access

Re: [RFC PATCH 18/25] target/i386/mshv: Implement mshv_arch_put_registers()

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:11PM +0200, Magnus Kulke wrote: > Write CPU register state to MSHV vCPUs. Various mapping functions to > prepare the payload for the HV call have been implemented. > > Signed-off-by: Magnus Kulke > --- [...] > +static int set_special_regs(const CPUState *cpu) > +{ >

Re: [PATCH v2 11/17] gdbstub: Try unlinking the unix socket before binding

2025-05-20 Thread Ilya Leoshkevich
On 2025-05-20 15:50, Michael Tokarev wrote: 07.02.2025 18:31, Alex Bennée wrote: From: Ilya Leoshkevich In case an emulated process execve()s another emulated process, bind() will fail, because the socket already exists. So try deleting it. Use the existing unix_listen() function which does th

Re: [RFC PATCH 17/25] target/i386/mshv: Implement mshv_get_special_regs()

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:10PM +0200, Magnus Kulke wrote: > Retrieve special registers (e.g. segment, control, and descriptor > table registers) from MSHV vCPUs. > > Various helper functions to map register state representations between > Qemu and MSHV are introduced. > > Signed-off-by: Magnu

Re: [RFC PATCH 16/25] target/i386/mshv: Implement mshv_get_standard_regs()

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:09PM +0200, Magnus Kulke wrote: > Fetch standard register state from MSHV vCPUs to support debugging, > migration, and other introspection features in QEMU. > > Fetch standard register state from a MHSV vCPU's. A generic get_regs() > function and a mapper to map the d

Re: [RFC PATCH 15/25] target/i386/mshv: Implement mshv_store_regs()

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:08PM +0200, Magnus Kulke wrote: > Add support for writing general-purpose registers to MSHV vCPUs > during initialization or migration using the MSHV register interface. A > generic set_register call is introduced to abstract the HV call over > the various register typ

Re: [RFC PATCH 14/25] target/i386/mshv: Add CPU create and remove logic

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:07PM +0200, Magnus Kulke wrote: > Implement MSHV-specific hooks for vCPU creation and teardown in the > i386 target. A list of locks per vCPU is maintained to lock CPU state in > MMIO operations. > > Signed-off-by: Magnus Kulke > --- > target/i386/mshv/mshv-cpu.c |

Re: [PATCH v5 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-05-20 Thread Pierrick Bouvier
On 5/20/25 1:44 PM, Julian Ganz wrote: Hi Pierrick, May 20, 2025 at 10:01 PM, Pierrick Bouvier wrote: Regarding the issue with the same tb being mapped at different virtual addresses, I'm ok with the current solution of comparing only page bits. That said, a better solution could be to compar

Re: [PATCH V3 34/42] vfio/iommufd: invariant device name

2025-05-20 Thread Steven Sistare
On 5/20/2025 9:55 AM, Cédric Le Goater wrote: On 5/12/25 17:32, Steve Sistare wrote: cpr-transfer will use the device name as a key to find the value of the device descriptor in new QEMU.  However, if the descriptor number is specified by a command-line fd parameter, then vfio_device_get_name cr

Re: [PATCH] trace/simple: seperate hot paths of tracing fucntions

2025-05-20 Thread Paolo Bonzini
Il mar 20 mag 2025, 21:01 Stefan Hajnoczi ha scritto: > On Mon, May 19, 2025 at 2:52 PM Tanish Desai > wrote: > > > > Remove hot paths from .c file and added it in .h file to keep it inline. > > Please include performance results in the commit description so it's > clear what impact this change

Re: [PATCH v2] vfio/igd: Respect x-igd-opregion=off in IGD quirk handling

2025-05-20 Thread edmund.raile
Hi Moeko, >On 5/19/25 16:03, edmund.raile wrote: >> Restore SR-IOV Intel iGPU VF passthrough capability: >> Check x-igd-opregion=off parameter in vfio_pci_igd_config_quirk and >> vfio_pci_kvmgt_config_quirk to ensure x-igd-opregion=off is >> respected despite subsequent attempt of automatic >> IGD

Re: [PATCH v5 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-05-20 Thread Julian Ganz
Hi Pierrick, May 20, 2025 at 10:01 PM, Pierrick Bouvier wrote: > Regarding the issue with the same tb being mapped at different virtual > addresses, I'm ok with the current solution of comparing only page bits. > > That said, a better solution could be to compare physical addresses when a > dis

Re: [PATCH v13 5/5] qtest/cxl: Add aarch64 virt test for CXL

2025-05-20 Thread Itaru Kitayama
Jonathan, > On May 19, 2025, at 21:54, Jonathan Cameron > wrote: > > On Thu, 15 May 2025 18:04:18 +0900 > Itaru Kitayama wrote: > >>> On May 13, 2025, at 20:14, Jonathan Cameron >>> wrote: >>> >>> Add a single complex case for aarch64 virt machine. >>> Given existing much more comprehensiv

Re: [RFC PATCH] migration/ram: avoid to do log clear in the last round

2025-05-20 Thread Peter Xu
On Tue, May 20, 2025 at 04:05:57PM -0300, Fabiano Rosas wrote: > Yanfei Xu writes: > > > There won't be any ram sync after the stage of save_complete, therefore > > it's unnecessary to do manually protect for dirty pages being sent. Skip > > to do this in last round can reduce noticeable downtime

Re: [RFC PATCH 11/25] accel/mshv: Add basic interrupt injection support

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:04PM +0200, Magnus Kulke wrote: > Implement initial interrupt handling logic in the MSHV backend. This > includes management of MSI and un/registering of irqfd mechanisms. > > Signed-off-by: Magnus Kulke > --- [...] > +int mshv_request_interrupt(int vm_fd, uint32_t i

Re: [RFC PATCH 09/25] accel/mshv: Register guest memory regions with hypervisor

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:02PM +0200, Magnus Kulke wrote: > Handle region_add events by invoking the MSHV memory registration > ioctl to map guest memory into the hypervisor partition. This allows > the guest to access memory through MSHV-managed mappings. > > Note that this assumes the hyperv

Re: [PATCH v5 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-05-20 Thread Pierrick Bouvier
On 5/19/25 8:24 AM, Julian Ganz wrote: We recently introduced plugin API for the registration of callbacks for discontinuity events, specifically for interrupts, exceptions and host call events. The callback receives various bits of information, including the VCPU index and PCs. This change intr

Re: [PATCH 12/22] hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots to pcihp

2025-05-20 Thread Gustavo Romero
Hi Eric, On 5/14/25 14:00, Eric Auger wrote: We intend to reuse build_append_pci_bus_devices and build_append_pcihp_slots on ARM. So Let's move them to nit: lowercase ---^ hw/acpi/pcihp.c as well as all static helpers they use. No functional change intended. Signed-off

Re: [PATCH 13/22] hw/i386/acpi-build: Introduce and use acpi_get_pci_host

2025-05-20 Thread Gustavo Romero
Hi Eric, On 5/14/25 14:01, Eric Auger wrote: pcihp acpi_set_pci_info() generic code currently uses acpi_get_i386_pci_host() to retrieve the pci host bridge. Let's rename acpi_get_i386_pci_host into acpi_get_pci_host and move it in pci generic code. The helper is augmented with the support of A

[PATCH] hw/cxl: fix DC extent capacity tracking

2025-05-20 Thread nifan . cxl
From: Fan Ni Per cxl r3.2 Section 9.13.3.3, extent capacity tracking should include extents in different states including added, pending, etc. Before the change, for the in-device extent number tracking purpose, we only have "total_extent_count" defined, which only tracks the number of extents a

Re: [PATCH V3 31/42] vfio/iommufd: use IOMMU_IOAS_MAP_FILE

2025-05-20 Thread Steven Sistare
On 5/19/2025 11:52 AM, Steven Sistare wrote: On 5/16/2025 4:48 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH V3 31/42] vfio/iommufd: use IOMMU_IOAS_MAP_FILE Use IOMMU_IOAS_MAP_FILE when the mapped region is backed by a file. Such a mapping can be pre

Re: [PATCH 11/22] hw/i386/acpi-build: Move build_append_notification_callback to pcihp

2025-05-20 Thread Gustavo Romero
Hi Eric, On 5/14/25 14:00, Eric Auger wrote: We plan to reuse build_append_notification_callback() on ARM so let's move it to pcihp.c. No functional change intended. Signed-off-by: Eric Auger --- include/hw/acpi/pcihp.h | 1 + hw/acpi/pcihp.c | 58 +

Re: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-20 Thread Steven Sistare
On 5/19/2025 11:51 AM, Steven Sistare wrote: On 5/16/2025 4:42 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH V3 29/42] backends/iommufd: change process ioctl Define the change process ioctl Signed-off-by: Steve Sistare --- backends/iommufd.c  

Re: [PATCH V3 28/42] backends/iommufd: iommufd_backend_map_file_dma

2025-05-20 Thread Steven Sistare
On 5/19/2025 11:51 AM, Steven Sistare wrote: On 5/16/2025 4:26 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH V3 28/42] backends/iommufd: iommufd_backend_map_file_dma Define iommufd_backend_map_file_dma to implement IOMMU_IOAS_MAP_FILE. This will be c

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > Create the MSHV virtual machine by opening a partition and issuing > the necessary ioctl to initialize it. This sets up the basic VM > structure and initial configuration used by MSHV to manage guest state. > > Signed-off-by: Magnus K

Re: [RFC PATCH] migration/ram: avoid to do log clear in the last round

2025-05-20 Thread Fabiano Rosas
Yanfei Xu writes: > There won't be any ram sync after the stage of save_complete, therefore > it's unnecessary to do manually protect for dirty pages being sent. Skip > to do this in last round can reduce noticeable downtime. > > Signed-off-by: Yanfei Xu > --- > As I don't have proper machine to

Re: [PATCH] trace/simple: seperate hot paths of tracing fucntions

2025-05-20 Thread Stefan Hajnoczi
On Mon, May 19, 2025 at 2:52 PM Tanish Desai wrote: > > Remove hot paths from .c file and added it in .h file to keep it inline. Please include performance results in the commit description so it's clear what impact this change has. > > Signed-off-by: Tanish Desai > --- > scripts/tracetool/bac

Re: [PATCH 09/22] hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper

2025-05-20 Thread Gustavo Romero
Hi Eric, On 5/14/25 14:00, Eric Auger wrote: Extract the code that reserves resources for ACPI PCI hotplug into a new helper named build_append_pcihp_resources() and move it to pcihp.c. We will reuse it on ARM. Signed-off-by: Eric Auger --- include/hw/acpi/pcihp.h | 2 ++ hw/acpi/pcihp.c

Re: [PATCH 10/22] hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug

2025-05-20 Thread Gustavo Romero
Hi Eric, On 5/14/25 14:00, Eric Auger wrote: On ARM we will put the operation regions in AML_SYSTEM_MEMORY. So let's allow this configuration. Signed-off-by: Eric Auger --- include/hw/acpi/pcihp.h | 3 ++- hw/acpi/pcihp.c | 8 hw/i386/acpi-build.c| 4 ++-- 3 files cha

Re: [PATCH v2 09/10] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:05AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > 7.6.7.6.5 > This patch needs to fix. See comments below. > Signed-off-by: Anisa Su > --- > hw/cxl/cxl-mailbox-utils.c | 195

Re: Rust in QEMU update, April 2025

2025-05-20 Thread Paolo Bonzini
On 5/20/25 18:23, Zhao Liu wrote: HPET does some very simple memory accesses; a good safe solution for this may be the ``vm-memory`` crate. While I have not looked into using it, ``vm-memory`` and ``vm-virtio`` were written with QEMU's use cases in mind. I'm working on this and trying to wrap s

Re: [RFC PATCH 03/25] target/i386/mshv: Add x86 decoder/emu implementation

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:29:56PM +0200, Magnus Kulke wrote: > The MSHV accelerator requires a x86 decoder/emulator in userland to > emulate MMIO instructions. This change contains the implementations for > the generalized i386 instruction decoder/emulator. > > Signed-off-by: Magnus Kulke > ---

Re: [PATCH v2 01/10] cxl-mailbox-utils: Move opcodes enum to new header file

2025-05-20 Thread Anisa Su
On Tue, May 20, 2025 at 08:37:35AM -0700, Fan Ni wrote: > On Thu, May 08, 2025 at 12:00:57AM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > In preparation for the next patch, move opcodes enum to new cxl_opcodes.h > > file > > for visibility from mailbox-utils.c and i2c_mctp_cxl.

Re: [PATCH v13 0/5] arm/virt: CXL support via pxb_cxl

2025-05-20 Thread Jonathan Cameron via
On Fri, 16 May 2025 11:30:49 +0900 Itaru Kitayama wrote: > Hi Jonathan, > > > On May 13, 2025, at 20:14, Jonathan Cameron > > wrote: > > > > V13: > > - Make CXL fixed memory windows sysbus devices. > > IIRC this was requested by Peter in one of the reviews a long time back > > but at the ti

Re: [RFC PATCH 02/25] target/i386/emulate: allow instruction decoding from stream

2025-05-20 Thread Wei Liu
On Tue, May 20, 2025 at 01:29:55PM +0200, Magnus Kulke wrote: > Introduce a new helper function to decode x86 instructions from a > raw instruction byte stream. MSHV delivers an instruction stream in a > buffer of the vm_exit message. It can be used to speed up MMIO > emulation, since instructions

Re: [PATCH 3/4] block/copy-before-write: reverse access bitmap

2025-05-20 Thread Eric Blake
On Tue, May 13, 2025 at 03:32:37AM +0200, Andrey Zhadchenko wrote: > HBitmaps allow us to search set bits pretty fast. On the contrary, > when searching zeroes, we may be forced to fully traverse the lower > level. > When we run blockdev-backup with mode=full on top of snapshot filter > + cbw filte

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Yiwei Zhang
On Tue, May 20, 2025 at 9:31 AM Dmitry Osipenko wrote: > > On 5/20/25 11:26, Yiwei Zhang wrote: > > On Mon, May 19, 2025 at 7:29 PM Dmitry Osipenko > > wrote: > >> > >> On 5/18/25 18:26, Yiwei Zhang wrote: > >>> +#if VIRGL_VERSION_MAJOR >= 1 > >>> +static void virgl_write_context_fence(void *opaq

Re: [PATCH v2 08/10] cxl-mailbox-utils: 0x5603 - FMAPI Get DC Region Extent Lists

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:04AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5603 implemented per CXL r3.2 Spec Section > 7.6.7.6.4 > Very similar to previously implemented command 0x4801. > > Signed-off-by: Anisa Su Reviewed-by: Fan Ni > --- > hw

[PATCH 0/3] target/riscv: profile handling fixes

2025-05-20 Thread Daniel Henrique Barboza
Hi, The motivation of this short series is to fix a reported in [1]. A couple of bugs were fixed along the way. Björn, these patches should remediate the situation you're experiencing. Patches based on master. [1] https://lore.kernel.org/qemu-riscv/87y0usiz22@all.your.base.are.belong.to.us

[PATCH 3/3] target/riscv: add profile->present flag

2025-05-20 Thread Daniel Henrique Barboza
Björn reported in [1] a case where a rv64 CPU is going through the profile code path to enable satp mode. In this case,the amount of extensions on top of the rv64 CPU made it compliant with the RVA22S64 profile during the validation of CPU 0. When the subsequent CPUs were initialized the static pro

[PATCH 2/3] target/riscv/tcg: decouple profile enablement from user prop

2025-05-20 Thread Daniel Henrique Barboza
We have code in riscv_cpu_add_profiles() to enable a profile right away in case a CPU chose the profile during its cpu_init(). But we're using the user callback option to do so, setting profile->user_set. Create a new helper that does all the grunt work to enable/disable a given profile. Use this

[PATCH 1/3] target/riscv/tcg: restrict satp_mode changes in cpu_set_profile

2025-05-20 Thread Daniel Henrique Barboza
We're changing 'mmu' to true regardless of whether the profile is being enabled or not, and at the same time we're changing satp_mode to profile->enabled. This will promote a situation where we'll set mmu=on without a virtual memory mode, which is a mistake. Only touch 'mmu' and satp_mode if the

[PULL 03/12] qtest/migration/rdma: Add test for rdma migration with ipv6

2025-05-20 Thread Peter Xu
From: Li Zhijian Recently, we removed ipv6 restriction[0] from RDMA migration, add a test for it. [0] https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/ Cc: Jack Wang Cc: Michael R. Galaxy Cc: Peter Xu Cc: Yu Zhang Reviewed-by: Jack Wang Signed-off-by: Li Zhiji

[PULL 08/12] migration: enable multifd and postcopy together

2025-05-20 Thread Peter Xu
From: Prasad Pandit Enable Multifd and Postcopy migration together. The migration_ioc_process_incoming() routine checks magic value sent on each channel and helps to properly setup multifd and postcopy channels. The Precopy and Multifd threads work during the initial guest RAM transfer. When mig

[PULL 07/12] migration: write zero pages when postcopy enabled

2025-05-20 Thread Peter Xu
From: Prasad Pandit During multifd migration, zero pages are written if they are migrated more than once. This may result in a migration thread hang issue when multifd and postcopy are enabled together. When postcopy is enabled, always write zero pages as and when they are migrated. Signed-off

[PULL 04/12] ci: Re-enable python subtests in qtest migration suite

2025-05-20 Thread Peter Xu
From: Fabiano Rosas The migration compatibility tests have been running with the PYTHON variable unset to avoid running a broken test. The faulty test has since been removed, so we can enable the python tests once again. Aside from the broken test, only one other test uses python and I have been

[PULL 06/12] ci: Reduce the size of artifacts for build-previous-qemu

2025-05-20 Thread Peter Xu
From: Fabiano Rosas The build-previous-qemu job is intented to produce a build of the previous QEMU release for consumption by the migration-compat-* jobs. Keep only the pieces of the build that are necessary. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Link: https://lore.kernel.org/r/2

[PULL 12/12] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-20 Thread Peter Xu
A new parameter "-a" is added to "info migrate" to dump all info, while when not specified it only dumps the important ones. When at it, reorg everything to make it easier to read for human. The general rule is: - Put important things at the top - Reuse a single line when things are very rel

[PULL 11/12] migration: Allow caps to be set when preempt or multifd cap enabled

2025-05-20 Thread Peter Xu
With commit 82137e6c8c ("migration: enforce multifd and postcopy preempt to be set before incoming"), and if postcopy preempt / multifd is enabled, one cannot setup any capability because these checks would always fail. (qemu) migrate_set_capability xbzrle off Error: Postcopy preempt must be set b

[PULL 09/12] tests/qtest/migration: add postcopy tests with multifd

2025-05-20 Thread Peter Xu
From: Prasad Pandit Add new qtests to run postcopy migration with multifd channels enabled. Signed-off-by: Prasad Pandit Link: https://lore.kernel.org/r/20250512125124.147064-4-ppan...@redhat.com [peterx: rename all new tests to be under /migration/multifd+postcopy/] Signed-off-by: Peter Xu --

[PULL 05/12] ci: Fix build-previous-qemu when the version tag is absent

2025-05-20 Thread Peter Xu
From: Fabiano Rosas Stefan reports that during QEMU release, pushing a series with the VERSION bump commit, but not pushing the new git tag in the same command will cause a failure of the build-previous-qemu job at the git fetch step. Since the job is intended to produce a build of the previous

[PULL 02/12] qtest/migration/rdma: Enforce RLIMIT_MEMLOCK >= 128MB requirement

2025-05-20 Thread Peter Xu
From: Li Zhijian Ensure successful migration over RDMA by verifying that RLIMIT_MEMLOCK is set to at least 128MB. This allocation is necessary due to the requirement to pin significant portions of guest memory, typically exceeding 100MB in this test, while the remainder is transmitted as compress

[PULL 00/12] Migration 20250520 patches

2025-05-20 Thread Peter Xu
/migration-20250520-pull-request for you to fetch changes up to e09c6d837593aa1e12d92d7031c65a881eb2eb27: migration/hmp: Add "info migrate -a", reorg the dump (2025-05-20 13:05:57 -0400) Migration pull - Peter's vms

[PULL 10/12] migration/multifd: Don't send device state packets with zerocopy flag

2025-05-20 Thread Peter Xu
From: "Maciej S. Szmigiero" If zerocopy is enabled for multifd then QIO_CHANNEL_WRITE_FLAG_ZERO_COPY flag is forced into all multifd channel write calls via p->write_flags that was setup in multifd_nocomp_send_setup(). However, device state packets aren't compatible with zerocopy - the data buff

[PULL 01/12] scripts/vmstate-static-checker.py: Add new hpet entry for num_timers

2025-05-20 Thread Peter Xu
The old "num_timers" got a rename. See commit 1433e38cc8 ("hpet: do not overwrite properties on post_load") for more details. Teach the script to accept the new name. Cc: Paolo Bonzini Cc: Thomas Huth Reviewed-by: Thomas Huth Link: https://lore.kernel.org/r/20250501151235.636709-1-pet...@redh

Re: [PATCH v2 07/10] cxl-mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:03AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section > 7.6.7.6.3 > > Signed-off-by: Anisa Su > --- > hw/cxl/cxl-mailbox-utils.c | 97 > hw/mem/c

Re: [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate"

2025-05-20 Thread Peter Xu
On Mon, May 19, 2025 at 01:27:35PM +0200, Mario Casquero wrote: > This series has been successfully tested. Now the HMP info migrate > command is more compact and readable. With the -a option the values of > the globals are displayed as well. > > (qemu) info migrate > Status: active > Time (ms): t

Re: [PATCH 066/147] include/exec: Move TLB_MMIO, TLB_DISCARD_WRITE to slow flags

2025-05-20 Thread Jonathan Cameron via
On Thu, 8 May 2025 14:29:18 +0100 Jonathan Cameron wrote: > On Tue, 29 Apr 2025 19:43:05 -0700 > Richard Henderson wrote: > > > On 4/29/25 14:35, Alistair Francis wrote: > > > On Sat, Apr 26, 2025 at 3:36 AM Jonathan Cameron via > > > wrote: > > >> > > >> On Tue, 22 Apr 2025 12:26:55 -07

[RFC PATCH] util: split unix socket functions out of qemu-sockets

2025-05-20 Thread Alex Bennée
Since fccb744f41 (gdbstub: Try unlinking the unix socket before binding) we use the unix_listen() function from linux-user which causes complications when trying to build statically. Fix this by splitting the unix functions into its own file and doing the appropriate tweaks to the headers. Signed

Re: [PATCH v2 06/10] hw/cxl_type3: Add DC Region bitmap lock

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:02AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > Add a lock on the bitmap of each CXLDCRegion in preparation for the next > patch which implements FMAPI Set DC Region Configuration. This command > can modify the block size, which means the region's bitma

Re: [PATCH v2 05/10] cxl_events.h: Move definition for dynamic_capacity_uuid and enum for DC event types

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:01AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > Move definition/enum to cxl_events.h for shared use in next patch > > Signed-off-by: Anisa Su > --- Reviewed-by: Fan Ni > hw/mem/cxl_type3.c | 15 --- > include/hw/cxl/cxl_events

Re: [PATCH] target/i386: Fix #GP error code for INT instructions

2025-05-20 Thread Andrew Cooper
Ping? On 12/03/2025 12:06 am, Andrew Cooper wrote: > While the (intno << shift) expression is correct for indexing the IDT based on > whether Long Mode is active, the error code itself was unchanged with AMD64, > and is still the index with 3 bits of metadata in the bottom. > > Found when running

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Dmitry Osipenko
On 5/20/25 11:26, Yiwei Zhang wrote: > On Mon, May 19, 2025 at 7:29 PM Dmitry Osipenko > wrote: >> >> On 5/18/25 18:26, Yiwei Zhang wrote: >>> +#if VIRGL_VERSION_MAJOR >= 1 >>> +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id, >>> + uint32_t

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Dmitry Osipenko
On 5/20/25 18:44, Alex Bennée wrote: > Yiwei Zhang writes: > >> Venus and later native contexts have their own fence context along with >> multiple timelines within. Fences wtih VIRTIO_GPU_FLAG_INFO_RING_IDX in >> the flags must be dispatched to be created on the target context. Fence >> signalin

Re: [PATCH 2/4] hbitmap: introduce hbitmap_reverse()

2025-05-20 Thread Eric Blake
On Tue, May 13, 2025 at 03:32:36AM +0200, Andrey Zhadchenko wrote: > and bdrv_dirty_bitmap_reverse() helper Is 'inverse' a better name than 'reverse'? > > Signed-off-by: Andrey Zhadchenko > --- > +++ b/util/hbitmap.c > @@ -940,3 +940,18 @@ char *hbitmap_sha256(const HBitmap *bitmap, Error **err

Re: [PATCH 1/4] hbitmap: drop meta bitmap leftovers

2025-05-20 Thread Eric Blake
On Tue, May 13, 2025 at 03:32:35AM +0200, Andrey Zhadchenko wrote: > API to manipulate meta bitmap was removed with commit 0c88f1970c76 > > Signed-off-by: Andrey Zhadchenko > --- > util/hbitmap.c | 17 ++--- > 1 file changed, 2 insertions(+), 15 deletions(-) Reviewed-by: Eric Blake

[PATCH] vfio: add more VFIOIOMMUClass docs

2025-05-20 Thread John Levon
Add some additional doc comments for these class methods. Signed-off-by: John Levon --- include/hw/vfio/vfio-container-base.h | 75 +-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/include/hw/vfio/vfio-container-base.h b/include/hw/vfio/vfio-container-b

Re: [PATCH v2 04/10] cxl-mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:01:00AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section > 7.6.7.6.2 > > Signed-off-by: Anisa Su One minor comment inline. Otherwise, Reviewed-by: Fan Ni > --- > hw/cxl/cxl-mailbox-ut

Re: [PATCH v2 01/29] vfio: add more VFIOIOMMUClass docs

2025-05-20 Thread Cédric Le Goater
On 5/20/25 17:03, John Levon wrote: Add some additional doc comments for these class methods. Signed-off-by: John Levon --- include/hw/vfio/vfio-container-base.h | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/include/hw/vfio/vfio-container-bas

Re: [PATCH v2 03/10] cxl/type3: Add dsmas_flags to CXLDCRegion struct

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:00:59AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > Add booleans to DC Region struct to represent dsmas flags (defined in CDAT) > in preparation for the next command, which returns the flags in the s/next command/mailbox command 0x5601h/, otherwise Reviewe

Re: Rust in QEMU update, April 2025

2025-05-20 Thread Zhao Liu
(Resend as the previous email may have failed.) > Remaining unsafe code > ' > > qdev bindings cover basic classes and interfaces, including > GPIO pins, timers, clocks and MemoryRegionOps. VMState > still needs unsafe callbacks for pre_save/post_load, with > the final version

Re: [PATCH v2 11/17] gdbstub: Try unlinking the unix socket before binding

2025-05-20 Thread Peter Maydell
On Tue, 20 May 2025 at 16:53, Alex Bennée wrote: > > Michael Tokarev writes: > > > 07.02.2025 18:31, Alex Bennée wrote: > >> From: Ilya Leoshkevich > >> In case an emulated process execve()s another emulated process, > >> bind() > >> will fail, because the socket already exists. So try deleting

Re: [PATCH v2 02/10] cxl-mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-05-20 Thread Fan Ni
On Thu, May 08, 2025 at 12:00:58AM +, anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section > 7.6.7.6.1. > > Signed-off-by: Anisa Su LGTM. minor comments inline. Reviewed-by: Fan Ni > --- > hw/cxl/cxl-mailbox-utils.c

Re: [PATCH 4/5] rust: Fix Zhao's email address

2025-05-20 Thread Peter Maydell
On Tue, 20 May 2025 at 16:09, Zhao Liu wrote: > > No one could find Zhao Liu via zhai1@intel.com. > > Signed-off-by: Zhao Liu Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 24/24] block: add bdrv_graph_wrlock_drained() convenience wrapper

2025-05-20 Thread Eric Blake
On Tue, May 20, 2025 at 12:30:12PM +0200, Fiona Ebner wrote: > Many write-lockded sections are also drained sections. A new write-locked > bdrv_graph_wrunlock_drained() wrapper around bdrv_graph_wrunlock() is > introduced, which will begin a drained section first. A global > variable is used so b

Re: [PATCH v2 11/17] gdbstub: Try unlinking the unix socket before binding

2025-05-20 Thread Alex Bennée
Michael Tokarev writes: > 07.02.2025 18:31, Alex Bennée wrote: >> From: Ilya Leoshkevich >> In case an emulated process execve()s another emulated process, >> bind() >> will fail, because the socket already exists. So try deleting it. Use >> the existing unix_listen() function which does this. L

RE: [PATCH V3 39/42] vfio/iommufd: reconstruct hwpt

2025-05-20 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 39/42] vfio/iommufd: reconstruct hwpt > >On 5/18/2025 11:25 PM, Duan, Zhenzhong wrote: >>> -Original Message- >>> From: Steve Sistare >>> Subject: [PATCH V3 39/42] vfio/iommufd: reconstruct hwpt >>> >>> Save the

Re: [PATCH v2 07/24] block: mark bdrv_child_change_aio_context() GRAPH_RDLOCK

2025-05-20 Thread Eric Blake
On Tue, May 20, 2025 at 12:29:55PM +0200, Fiona Ebner wrote: > This is a small step in preparation to mark bdrv_drained_begin() as > GRAPH_UNLOCKED. More concretely, it is in preparatoin to move the preparation > drain out of bdrv_change_aio_context() and marking that function as > GRAPH_RDLOCK.

Re: [PATCH v2 06/24] block: mark change_aio_ctx() callback and instances as GRAPH_RDLOCK(_PTR)

2025-05-20 Thread Eric Blake
On Tue, May 20, 2025 at 12:29:54PM +0200, Fiona Ebner wrote: > This is a small step in preparation to mark bdrv_drained_begin() as > GRAPH_UNLOCKED. More concretely, it is in preparatoin to move the preparation > drain out of bdrv_change_aio_context() and marking that function as > GRAPH_RDLOCK.

Re: [PATCH v2 00/24] block: do not drain while holding the graph lock

2025-05-20 Thread Eric Blake
On Tue, May 20, 2025 at 12:29:48PM +0200, Fiona Ebner wrote: > Previous discussion [0]. > > NOTE: > there are pre-existing test failures on current master, e.g. '240' for > all formats, '295 296 inactive-node-nbd luks-detached-header' for luks > and 'mirror-sparse' for raw. For me, the failures d

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Alex Bennée
Yiwei Zhang writes: > Venus and later native contexts have their own fence context along with > multiple timelines within. Fences wtih VIRTIO_GPU_FLAG_INFO_RING_IDX in > the flags must be dispatched to be created on the target context. Fence > signaling also has to be handled on the specific time

Re: [PATCH 5/5] rust: Fix the typos in doc

2025-05-20 Thread Peter Maydell
On Tue, 20 May 2025 at 16:07, Zhao Liu wrote: > > These typos are found by "cargo spellcheck". Though it outputs a lot of > noise and false positives, there still are some real typos. > > Signed-off-by: Zhao Liu > --- > Note: But I have to admit, cargo spellcheck isn't a great tool. > > Picked fr

  1   2   3   4   >