RE: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors

[Duan, Zhenzhong]

>-----Original Message-----
>From: Cédric Le Goater <c...@redhat.com>
>Subject: Re: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors
>
>On 5/16/25 10:55, Duan, Zhenzhong wrote:
>>
>>
>>> -----Original Message-----
>>> From: Steve Sistare <steven.sist...@oracle.com>
>>> Subject: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors
>>>
>>> Extract hwpt creation code from iommufd_cdev_autodomains_get into the
>>> helpers iommufd_cdev_use_hwpt and iommufd_cdev_make_hwpt.  These will
>>> be used by CPR in a subsequent patch.
>>>
>>> Call vfio_device_hiod_create_and_realize earlier so
>iommufd_cdev_make_hwpt
>>> can use vbasedev->hiod hw_caps, avoiding an extra call to
>>> iommufd_backend_get_device_info
>>
>> We had made consensus to realize hiod after attachment,
>> it's not a hot path so an extra call is acceptable per Cedric.
>
>We also placed the realize call where it is in preparation for
>nested IOMMU support, and avoid a late_realize handler AFAICR
>
>
>>> No functional change.
>
>
>We should add a comment before to make sure the code is not moved
>around.

Yes, I should have done that last time. Do you want me to send a patch to fix 
it?

Thanks
Zhenzhong