Re: [PATCH 7/6] mirror: Allow QMP override to declare target already zero

2025-04-11 Thread Markus Armbruster
Eric Blake writes: > Qemu's attempts to learn whether a destination file starts life with QEMU (multiple times). > all zero contents are just a hueristic. There may be cases where the heuristic > caller is aware of information that qemu cannot learn quickly, in > which case telling qemu what

Re: [PATCH v2 08/10] usb/msd: Rename mode to cbw_state, and tweak names

2025-04-11 Thread Nicholas Piggin
On Fri Apr 11, 2025 at 8:37 PM AEST, Philippe Mathieu-Daudé wrote: > On 11/4/25 10:04, Nicholas Piggin wrote: >> This reflects a little better what it does, particularly with a >> subsequent change to relax the order packets are seen in. This >> field is not the general state of the MSD state machi

Re: [PATCH v2 10/10] usb/msd: Add more tracing

2025-04-11 Thread Nicholas Piggin
On Fri Apr 11, 2025 at 8:36 PM AEST, Philippe Mathieu-Daudé wrote: > On 11/4/25 10:04, Nicholas Piggin wrote: >> Add tracing for more received packet types, cbw_state changes, and >> some more SCSI callbacks. These were useful in debugging relaxed >> packet ordering support. >> >> Signed-off-by: N

Re: [PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Nicholas Piggin
On Fri Apr 11, 2025 at 8:21 PM AEST, Philippe Mathieu-Daudé wrote: > On 11/4/25 10:04, Nicholas Piggin wrote: >> These structures are hardware interfaces, ensure the layout is >> correct. >> >> Signed-off-by: Nicholas Piggin >> --- >> hw/usb/dev-storage.c | 5 - >> 1 file changed, 4 insert

Re: [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread

2025-04-11 Thread Nicholas Piggin
On Fri Apr 11, 2025 at 8:55 AM AEST, Pierrick Bouvier wrote: > On MacOS, UI event loop has to be ran in the main thread of a process. > Because of that restriction, on this platform, qemu main event loop is > ran on another thread [1]. > > This breaks record/replay feature, which expects thread run

Re: [PATCH v3 0/5] ipmi: bmc-sim improvements

2025-04-11 Thread Nicholas Piggin
On Sat Apr 12, 2025 at 4:20 AM AEST, Corey Minyard wrote: > On Fri, Apr 11, 2025 at 04:25:10PM +1000, Nicholas Piggin wrote: >> On Wed Apr 2, 2025 at 5:17 AM AEST, Corey Minyard wrote: >> > On Wed, Apr 02, 2025 at 12:01:47AM +1000, Nicholas Piggin wrote: >> >> These little things came up when looki

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-11 Thread Farhan Ali
On 4/11/2025 3:28 PM, Alex Williamson wrote: On Thu, 10 Apr 2025 09:07:51 -0700 Farhan Ali wrote: On 4/3/2025 2:24 PM, Alex Williamson wrote: On Thu, 3 Apr 2025 13:33:17 -0700 Farhan Ali wrote: On 4/3/2025 11:05 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 10:33:52 -0700 Farhan Ali

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-11 Thread Alex Williamson
On Thu, 10 Apr 2025 09:07:51 -0700 Farhan Ali wrote: > On 4/3/2025 2:24 PM, Alex Williamson wrote: > > On Thu, 3 Apr 2025 13:33:17 -0700 > > Farhan Ali wrote: > > > >> On 4/3/2025 11:05 AM, Alex Williamson wrote: > >>> On Thu, 3 Apr 2025 10:33:52 -0700 > >>> Farhan Ali wrote: > >>> > >

[ANNOUNCE] QEMU 10.0.0-rc3 is now available

2025-04-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 10.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-10.0.0-rc3.tar.xz http://download.qe

[RFC V3 PATCH 13/13] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2025-04-11 Thread Annie Li
Followng hmp/qmp commands are implemented for pressing virtual sleep button, hmp: system_sleep qmp: { "execute": "system_sleep" } These commands put the guest into suspend or other power states depending on the power settings inside the guest. These hmp/qmp command are in '*_*' format, it is int

[RFC V3 PATCH 12/13] microvm: enable suspend

2025-04-11 Thread Annie Li
The function qemu_wakeup_suspend_enabled combines the suspend and wakeup together. However, the microvm doesn't support wakeup yet. Suspend is enabled here, but wakeup doesn't actually work for microvm now. Signed-off-by: Annie Li --- hw/i386/microvm.c | 1 + 1 file changed, 1 insertion(+) diff

[RFC V3 PATCH 11/13] microvm: suspend the system as requested

2025-04-11 Thread Annie Li
Once the microvm guest requests to go to sleep state and sets the GED register with S3 type, QEMU needs to continue suspending the system. Signed-off-by: Annie Li --- hw/acpi/generic_event_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/ge

[RFC V3 PATCH 10/13] tests/qtest/bios-table-tests: Update ACPI table binaries for microvm

2025-04-11 Thread Annie Li
Following is the diff generated by the step 5 and 6 in tests/qtest/bios-tables-test.c Diff from iasl to show changes in DSDT table: --- /tmp/asl-2F0N42.dsl 2025-04-11 12:50:02.892883467 + +++ /tmp/asl-C81N42.dsl 2025-04-11 12:50:02.890883378 + @@ -1,30 +1,30 @@ /* * Intel ACPI Componen

[RFC V3 PATCH 09/13] microvm: enable sleep GED event

2025-04-11 Thread Annie Li
The sleep GED event is enabled for MicroVM. Also, the system suspend is enabled when the GED register is set for sleep. Signed-off-by: Annie Li --- hw/i386/microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index d0a236c74f..eba3

[RFC V3 PATCH 08/13] hw/acpi: Add ACPI GED support for the sleep event

2025-04-11 Thread Annie Li
From: Miguel Luis Add support for ACPI GED sleep event on the ACPI device interface so that HW-reduced systems can enable guests to sleep. Signed-off-by: Miguel Luis Signed-off-by: Annie Li --- hw/acpi/generic_event_device.c | 9 + include/hw/acpi/generic_event_device.h | 1 +

[RFC V3 PATCH 07/13] microvm: support control method sleep button

2025-04-11 Thread Annie Li
Add the support of control method sleep button and System S3 Sleeping State for microvm. Signed-off-by: Annie Li --- hw/i386/acpi-microvm.c | 11 +++ include/hw/acpi/generic_event_device.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/i386/acpi-microvm.c b/hw

[RFC V3 PATCH 06/13] test/acpi: allow DSDT table changes for microvm

2025-04-11 Thread Annie Li
list changed files in tests/qtest/bios-tables-test-allowed-diff.h Signed-off-by: Annie Li --- tests/qtest/bios-tables-test-allowed-diff.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8

[RFC V3 PATCH 05/13] acpi: Send the GPE event of suspend and wakeup for x86

2025-04-11 Thread Annie Li
The GPE event is triggered to notify x86 guest to suppend itself. The function acpi_send_sleep_event will also trigger GED events on HW-reduced systems where ACPI GED sleep event is supported. Signed-off-by: Annie Li --- hw/acpi/core.c | 10 ++ include/hw/acpi/acpi.

[RFC V3 PATCH 04/13] tests/qtest/bios-table-tests: Update ACPI table binaries for x86

2025-04-11 Thread Annie Li
Following is the diff generated by the step 5 and 6 in tests/qtest/bios-tables-test.c Diff from iasl to show changes in DSDT table: --- /tmp/asl-34PV42.dsl 2025-04-09 19:04:34.846646690 + +++ /tmp/asl-5XBW42.dsl 2025-04-09 19:04:34.839646378 + @@ -1,30 +1,30 @@ /* * Intel ACPI Componen

[RFC V3 PATCH 03/13] acpi: Support Control Method sleep button for x86

2025-04-11 Thread Annie Li
Add Control Method Sleep button and its GPE event handler for x86 platform. The GPE event handler notifies OSPM when the Sleep button event is triggered. Signed-off-by: Annie Li --- hw/i386/acpi-build.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/hw

[RFC V3 PATCH 02/13] test/acpi: allow DSDT table changes for x86 platform

2025-04-11 Thread Annie Li
list changed files in tests/qtest/bios-tables-test-allowed-diff.h Signed-off-by: Annie Li --- tests/qtest/bios-tables-test-allowed-diff.h | 42 + 1 file changed, 42 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed

[RFC V3 PATCH 01/13] acpi: Implement control method sleep button

2025-04-11 Thread Annie Li
The fixed hardware sleep button isn't appropriate for hardware reduced platform. This patch implements the control method sleep button in a separate source file so that the button can be added for various platforms. Co-developed-by: Miguel Luis Signed-off-by: Annie Li --- hw/acpi/control_method

Re: [PATCH 0/6] Make blockdev-mirror dest sparse in more cases

2025-04-11 Thread Eric Blake
On Thu, Apr 10, 2025 at 08:04:50PM -0500, Eric Blake wrote: > When mirroring images, it makes sense for the destination to be sparse > even if it was not connected with "discard":"unmap"; the only time the > destination should be fully allocated is if the user pre-allocated it, > or if the source w

[RFC V3 PATCH 00/13] Support ACPI Control Method Sleep button

2025-04-11 Thread Annie Li
The ACPI sleep button can be implemented as a fixed hardware button or Control Method Sleep button. The patch of implementing a fixed hardware sleep button was posted here 1). More discussions can be found here 2). Essentially, the discussion mainly focuses on whether the sleep button is implement

Re: [PATCH 1/6] mirror: Skip pre-zeroing destination if it is already zero

2025-04-11 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: When doing a sync=full mirroring, QMP drive-mirror requests full zeroing if it did not just create the destination, and blockdev-mirror requests full zeroing unconditionally. This is because during a full sync, we must ensure that the portions of the disk tha

[RFC PATCH 12/13] [PoC] migration: Add query/set commands for MigrationConfig

2025-04-11 Thread Fabiano Rosas
Add the QMP commands query-migrate-config and migrate-set-config to read and write the migration configuration options. Signed-off-by: Fabiano Rosas --- migration/options.c | 24 migration/options.h | 2 +- qapi/migration.json | 42 ++

Re: [PATCH v1 13/24] hw/s390x/ipl: Set iplb->len to maximum length of IPL Parameter Block

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: The IPL Information Report Block (IIRB) immediately follows the IPL Parameter Block (IPLB). The IPLB struct is allocated 4KB in memory, and iplb->len indicates the amount of memory currently used by the IPLB. To ensure proper alignment of the IIRB and pr

[RFC PATCH 07/13] migration: Introduce new MigrationConfig structure

2025-04-11 Thread Fabiano Rosas
Add a new migration structure to consolidate the capabilities and parameters. This structure will be used in place of the s->parameters and s->capabilities data structures in the next few patches. The QAPI migration types now look like this: /* options previously known as parameters */ { 'struct'

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-04-11 Thread Fabiano Rosas
Fabiano Rosas writes: > Fabiano Rosas writes: > > +Cc Markus > > context: > This series was trying to stop savevm from crashing when arbitrary > migration capabilities are enabled. Daniel brought up the previous > discussion around unifying capabilities + parameters and passing it all > via the

[RFC PATCH 05/13] migration: Reduce a bit of duplication in migration.json

2025-04-11 Thread Fabiano Rosas
Introduce a new MigrationConfigBase, to allow most of the duplication in migration.json to be eliminated. The reason we need MigrationParameters and MigrationSetParameters is that the internal parameter representation in the migration code, as well as the user-facing return of query-migrate-parame

[RFC PATCH 01/13] migration: Fix latent bug in migrate_params_test_apply()

2025-04-11 Thread Fabiano Rosas
From: Markus Armbruster migrate_params_test_apply() neglects to apply tls_authz. Currently harmless, because migrate_params_check() doesn't care. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas Message-ID: <20250407072833.2118928-1-arm...@redhat.com> Signed-off-by:

[RFC PATCH 00/13] migration: Unify capabilities and parameters

2025-04-11 Thread Fabiano Rosas
Hi everyone, I did a cleanup (if it can be called that) of the user input validation for capabilities and parameters and turned the two concepts into a single 'options' to be stored in a MigrationConfig object. RFC mostly because this idea exposes (pre-existing) issues around how to validate capab

[RFC PATCH 09/13] migration: Do away with usage of QERR_INVALID_PARAMETER_VALUE

2025-04-11 Thread Fabiano Rosas
Now that we're removing mentions of 'parameters' from migration code, the "Parameter X expects..." message is a little confusing, although the "parameter" there refers to the QMP command parameter. There's also some instances which don't make sense grammatically. Remove all the usage of QERR_INVAL

[RFC PATCH 13/13] [PoC] migration: Allow migrate commands to provide the migration config

2025-04-11 Thread Fabiano Rosas
Allow the migrate and migrate_incoming commands to pass the migration configuration options all at once, dispensing the use of migrate-set-parameters and migrate-set-capabilities. The motivation of this is to simplify the interface with the management layer and avoid the usage of several command i

[RFC PATCH 11/13] migration: Merge parameters and capability checks

2025-04-11 Thread Fabiano Rosas
Since parameters and capabilities are now stored in the same structure and both use the same method to validate the input (i.e. copy, set a temporary, validate the temporary and overwrite), it's possible to use the same routine for both. With this all distinction from capabilities and parameters i

[RFC PATCH 08/13] migration: Replace s->parameters with s->config

2025-04-11 Thread Fabiano Rosas
The concepts of 'parameters' and 'capabilities' are almost functionally identical and there is a consensus that their usage is confusing, particularly when it comes to determine to which category a new option should belong. The new MigrationConfig type was introduced to eliminate the distinction b

[RFC PATCH 10/13] migration: Replace s->capabilities with s->config

2025-04-11 Thread Fabiano Rosas
Continuing with the removal of parameters and capabilities, replace the internal usage of s->capabilities with MigrationConfig. To keep compatibility with the special format of the user-facing migrate-set-capabilities and query-migrate-capabilities, introduce a few compatibility routines to conver

[RFC PATCH 06/13] migration: Remove the parameters copy during validation

2025-04-11 Thread Fabiano Rosas
While validating migration parameters, a temporary structure is used to apply the values to be validated. Only when validation succeeds on the temporary values, they are actually copied into the internal s->parameters. There is however an extra step, which is to copy s->parameters into the tempora

[RFC PATCH 04/13] migration: Fix parameter validation

2025-04-11 Thread Fabiano Rosas
The migration parameters validation involves producing a temporary structure which merges the current parameter values with the new parameters set by the user. The has_ boolean fields of MigrateSetParameter are taken into consideration when writing the temporary structure, however the copy of the

[RFC PATCH 03/13] migration: Run a post update routine after setting parameters

2025-04-11 Thread Fabiano Rosas
Some migration parameters are updated immediately once they are set via migrate-set-parameters. Move that work outside of migrate_params_apply() and leave that function with the single responsibility of setting s->parameters and not doing any side-effects. Signed-off-by: Fabiano Rosas --- migrat

[RFC PATCH 02/13] migration: Normalize tls arguments

2025-04-11 Thread Fabiano Rosas
The tls_creds, tls_authz and tls_hostname arguments are strings that can be set by the user. They are allowed to be either a valid string, an empty string or NULL. The values "" and NULL are effectively treated the same by the code, but this is not entirely clear because the handling is not uniform

Re: [PATCH v1 12/24] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block

2025-04-11 Thread Farhan Ali
...snip... diff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h index b8e7d1da71..2355fcecbb 100644 --- a/include/hw/s390x/ipl/qipl.h +++ b/include/hw/s390x/ipl/qipl.h @@ -23,6 +23,9 @@ #define MAX_CERTIFICATES 64 #define CERT_MAX_SIZE (1024 * 8) +#define DIAG308_

Re: [PATCH v1 04/24] s390x/diag: Introduce DIAG 320 for certificate store facility

2025-04-11 Thread Collin Walling
On 4/11/25 9:43 AM, Thomas Huth wrote: > On 08/04/2025 17.55, Zhuoying Cai wrote: >> From: Collin Walling > ... >> Signed-off-by: Zhuoying Cai > > So the patch is from Collin, but S-o-b only by you? Looks weird, this should > either have an additional S-o-b by Collin, too, or not have that "Fro

Re: [PATCH v3 0/5] ipmi: bmc-sim improvements

2025-04-11 Thread Corey Minyard
On Fri, Apr 11, 2025 at 04:25:10PM +1000, Nicholas Piggin wrote: > On Wed Apr 2, 2025 at 5:17 AM AEST, Corey Minyard wrote: > > On Wed, Apr 02, 2025 at 12:01:47AM +1000, Nicholas Piggin wrote: > >> These little things came up when looking at behaviour of IPMI with > >> the bmc-sim implementation ru

Re: [PULL 8/9] meson: Disallow 64-bit on 32-bit emulation

2025-04-11 Thread Stefan Hajnoczi
On Fri, Apr 11, 2025 at 11:09 AM Daniel P. Berrangé wrote: > > On Fri, Apr 11, 2025 at 05:05:20PM +0200, Philippe Mathieu-Daudé wrote: > > On 11/4/25 15:42, Daniel P. Berrangé wrote: > > > On Sat, Feb 08, 2025 at 12:57:23PM -0800, Richard Henderson wrote: > > > > For system mode, we can rarely sup

Re: Management applications and CPU feature flags

2025-04-11 Thread Jiri Denemark
On Fri, Apr 11, 2025 at 13:43:39 +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > Considering the bigger picture QMP design, when libvirt is trying to > >> > understand QEMU's

Re: [PATCH v3 05/12] iotests/common.rc: add disk_usage function

2025-04-11 Thread Eric Blake
On Fri, Sep 13, 2024 at 07:39:35PM +0300, Andrey Drobyshev wrote: > Move the definition from iotests/250 to common.rc. This is used to > detect real disk usage of sparse files. In particular, we want to use > it for checking subclusters-based discards. > > Signed-off-by: Andrey Drobyshev > Revi

Re: [PATCH v1 01/24] Add -boot-certificates /path/dir:/path/file option in QEMU command line

2025-04-11 Thread Zhuoying Cai
On 4/11/25 8:57 AM, Daniel P. Berrangé wrote: > On Fri, Apr 11, 2025 at 12:44:17PM +0200, Thomas Huth wrote: >> On 08/04/2025 17.55, Zhuoying Cai wrote: >>> The `-boot-certificates /path/dir:/path/file` option is implemented >>> to provide path to either a directory or a single certificate. >>> >

Re: [PATCH v1 06/24] s390x/diag: Implement DIAG 320 subcode 1

2025-04-11 Thread Farhan Ali
On 4/8/2025 8:55 AM, Zhuoying Cai wrote: DIAG 320 subcode 1 provides information needed to determine the amount of storage to store one or more certificates. The subcode value is denoted by setting the left-most bit of an 8-byte field. The verification-certificate-storage-size block (VCSSB) c

Re: [PATCH v1 09/24] s390x/diag: Implement DIAG 508 subcode 2 for signature verification

2025-04-11 Thread Collin Walling
On 4/11/25 10:38 AM, Thomas Huth wrote: > On 08/04/2025 17.55, Zhuoying Cai wrote: >> From: Collin Walling >> >> DIAG 508 subcode 2 performs signature-verfication on signed components. >> A signed component may be a Linux kernel image, or any other signed >> binary. **Verification of initrd is not

Re: [PATCH v2 2/2] block/io: skip head/tail requests on EINVAL

2025-04-11 Thread Eric Blake
On Fri, Apr 11, 2025 at 10:18:55AM +0200, Hanna Czenczek wrote: > > if (ret && ret != -ENOTSUP) { > > -goto out; > > +if (ret == -EINVAL && (offset % align != 0 || num % align != > > 0)) { > > Could use `(offset | num) % align != 0`, but either way: Use of | and

Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-11 Thread Kohei Tokunaga
Hi Pierrick, thank you for the feedback. > first, congrats for this work! > It would be really nice to have this available upstream, starting with a > modest TCI port, before having the tcg backend also. Sure, I'll split the patch series, starting with the TCI port. > Do you have recent informat

Re: [PATCH 1/4] target/arm/ptw: extract arm_mmu_idx_to_security_space

2025-04-11 Thread Pierrick Bouvier
On 4/11/25 06:44, Philippe Mathieu-Daudé wrote: On 10/4/25 23:00, Pierrick Bouvier wrote: We'll reuse this function later. Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/target/arm/ptw.c b/tar

Re: [PATCH 1/2] file-posix: probe discard alignment on Linux block devices

2025-04-11 Thread Eric Blake
On Wed, Apr 09, 2025 at 02:29:13PM -0400, Stefan Hajnoczi wrote: > Populate the pdiscard_alignment block limit so the block layer is able > align discard requests correctly. > > Signed-off-by: Stefan Hajnoczi > --- > block/file-posix.c | 56 +- > 1 fil

Re: [PATCH v6] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

2025-04-11 Thread Eric Blake
On Mon, Apr 07, 2025 at 08:47:30AM -0700, Pinku Deb Nath wrote: > Full Unit Access (FUA) is an optimization where a disk write with the > flag set will be persisted to disk immediately instead of potentially > remaining in the disk's write cache. > > This commit address the todo task > for using p

Re: [PATCH v3 4/5] util/qemu-sockets: Add support for keep-alive flag to passive sockets

2025-04-11 Thread Daniel P . Berrangé
On Tue, Apr 08, 2025 at 01:25:03PM +0200, Juraj Marcin wrote: > From: Juraj Marcin > > Commit aec21d3175 (qapi: Add InetSocketAddress member keep-alive) > introduces the keep-alive flag, which enables the SO_KEEPALIVE socket > option, but only on client-side sockets. However, this option is also

Re: [PATCH v2 07/10] hw/arm/aspeed: Add support for loading vbootrom image via "-bios"

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: Introduce "aspeed_load_vbootrom()" to support loading a virtual boot ROM image into the vbootrom memory region, using the "-bios" command-line option. Signed-off-by: Jamin Lin --- hw/arm/aspeed.c | 32 1 file changed, 32 ins

Re: Query on the dirty bitmap

2025-04-11 Thread Eric Blake
On Tue, Apr 08, 2025 at 04:30:38PM +0530, prashant patil wrote: > Thank you, Eric, for the thorough information—truly appreciate it. > > Just to confirm what I understood, when we are reading a bitmap with > 'x-dirty-bitmap' (for powered on vm of course), the 'start' is always a > logical offset

Re: [PATCH v2 08/10] pc-bios: Add AST27x0 vBootrom

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: The boot ROM is a minimal implementation designed to load an AST27x0 boot image. Its source code is available at: https://github.com/google/vbootrom See commit d1cb5eda67a0 ("roms: Add virtual Boot ROM for NPCM7xx SoCs") for an example adding a ROM file. Also

Re: [PATCH v2 03/10] hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: The variable "sram_name" was only used for naming the SRAM memory region. Rename it to "name" for consistency with similar code and avoid unnecessary new local variable declarations. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --

Re: [PATCH v2 09/10] tests/functional/aspeed: Update AST2700 functional test to use vbootrom

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: Refactor the AST2700 functional test to boot using the vbootrom image instead of manually loading boot components with -device loader. The boot ROM binary is now passed via the -bios option, using the image located in pc-bios/ast27x0_bootrom.bin. Signed-off-by:

Re: [PATCH v2 04/10] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: Introduce a new vbootrom memory region. The region is mapped at address "0x" and has a size of 128KB, identical to the SRAM region size. This memory region is intended for loading a vbootrom image file as part of the boot process. The vbootrom region is

Re: [PATCH v2 06/10] hw/arm/aspeed: Reuse rom_size variable for vbootrom setup

2025-04-11 Thread Cédric Le Goater
On 4/10/25 04:38, Jamin Lin wrote: Move the declaration of `rom_size` to an outer scope in aspeed_machine_init() so it can be reused for setting up the vbootrom region as well. This avoids introducing a redundant local variable and ensures consistent ROM sizing logic when both SPI boot and vboot

Re: [PATCH v2 00/10] Support vbootrom for AST2700

2025-04-11 Thread Cédric Le Goater
Hello Jamin On 4/10/25 04:38, Jamin Lin wrote: v1: Add initial support for AST27x0 The purpose of vbootrom here is to simulate the work of BootMCU SPL (riscv) in AST2700, because QEMU doesn't support heterogenous architecture yet. ast27x0_bootrom.bin is a simplified, free (Apache 2.

Re: [PATCH v3 5/5] utils/qemu-sockets: Introduce inet socket options controlling TCP keep-alive

2025-04-11 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 02:54:29PM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 08, 2025 at 01:25:04PM +0200, Juraj Marcin wrote: > > From: Juraj Marcin > > > > With the default TCP stack configuration, it could be even 2 hours > > before the connection times out due to the other side not being

Re: [PATCH 0/2] fix record/replay on MacOS

2025-04-11 Thread Philippe Mathieu-Daudé
On 11/4/25 00:55, Pierrick Bouvier wrote: Pierrick Bouvier (2): system/main: transfer replay mutex ownership from main thread to main loop thread tests/functional/test_aarch64_replay: reenable on macos Series: Tested-by: Philippe Mathieu-Daudé

Re: [PATCH 3/4] target/arm/ptw: extract arm_cpu_get_phys_page

2025-04-11 Thread Philippe Mathieu-Daudé
On 10/4/25 23:00, Pierrick Bouvier wrote: Allow to call that function easily several times in next commit. Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v1 13/24] hw/s390x/ipl: Set iplb->len to maximum length of IPL Parameter Block

2025-04-11 Thread Jared Rossi
On 4/11/25 10:46 AM, Thomas Huth wrote: On 08/04/2025 17.55, Zhuoying Cai wrote: The IPL Information Report Block (IIRB) immediately follows the IPL Parameter Block (IPLB). The IPLB struct is allocated 4KB in memory, and iplb->len indicates the amount of memory currently used by the IPLB. T

Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-11 Thread Pierrick Bouvier
On 4/11/25 07:36, Kohei Tokunaga wrote: Hi Pierrick, thank you for the feedback. > first, congrats for this work! > It would be really nice to have this available upstream, starting with a > modest TCI port, before having the tcg backend also. Sure, I'll split the patch series, starting with

Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-11 Thread Kohei Tokunaga
Hi Daniel, > On Wed, Apr 09, 2025 at 03:21:15PM -0400, Stefan Hajnoczi wrote: > > On Mon, Apr 07, 2025 at 11:45:51PM +0900, Kohei Tokunaga wrote: > > > This patch series enables QEMU's system emulator to run in a browser using > > > Emscripten. > > > It includes implementations and workarounds to

Re: [PULL 8/9] meson: Disallow 64-bit on 32-bit emulation

2025-04-11 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 05:05:20PM +0200, Philippe Mathieu-Daudé wrote: > On 11/4/25 15:42, Daniel P. Berrangé wrote: > > On Sat, Feb 08, 2025 at 12:57:23PM -0800, Richard Henderson wrote: > > > For system mode, we can rarely support the amount of RAM that > > > the guest requires. TCG emulation is

Re: [PULL 8/9] meson: Disallow 64-bit on 32-bit emulation

2025-04-11 Thread Philippe Mathieu-Daudé
On 11/4/25 15:42, Daniel P. Berrangé wrote: On Sat, Feb 08, 2025 at 12:57:23PM -0800, Richard Henderson wrote: For system mode, we can rarely support the amount of RAM that the guest requires. TCG emulation is restricted to round-robin mode, which solves many of the atomicity issues, but not tho

Re: [PATCH v1 20/24] Add -secure-boot on|off option in QEMU command line

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: The `-secure-boot on|off` command line option is implemented to enable secure IPL. By default, -secure-boot is set to false if not specified in the command line. Signed-off-by: Zhuoying Cai --- qemu-options.hx | 8 system/vl.c | 21

[PATCH 7/6] mirror: Allow QMP override to declare target already zero

2025-04-11 Thread Eric Blake
Qemu's attempts to learn whether a destination file starts life with all zero contents are just a hueristic. There may be cases where the caller is aware of information that qemu cannot learn quickly, in which case telling qemu what to assume about the destination can make the mirror operation fas

Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-11 Thread Kohei Tokunaga
Hi Paolo, > > > The biggest problem I'm seeing is we no longer support 64-bit guests on > > > 32-bit hosts, and don't plan to revert that. > > > > Yes, so the sixth patch ("[PATCH 06/10] include/exec: Allow using 64bit > > guest addresses on emscripten") should be considered as a temporary > > wor

Re: [PATCH v1 09/24] s390x/diag: Implement DIAG 508 subcode 2 for signature verification

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: From: Collin Walling DIAG 508 subcode 2 performs signature-verfication on signed components. A signed component may be a Linux kernel image, or any other signed binary. **Verification of initrd is not supported.** The instruction call expects two item-p

Re: [PATCH v1 08/24] s390x/diag: Introduce DIAG 508 for secure IPL operations

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: From: Collin Walling In order to support secure IPL (aka secure boot) for the s390-ccw BIOS, a new s390 DIAGNOSE instruction is introduced to leverage QEMU for handling operations such as signature verification and certificate retrieval. Currently, only

Re: [PATCH 08/10] hw/9pfs: Allow using hw/9pfs with emscripten

2025-04-11 Thread Kohei Tokunaga
Hi Paolo, > > Emscripten's fiber does not support submitting coroutines to other > > threads. > > Does it work as long as the thread does not rewind? The structure used by Fiber includes a thread-specific field related to rewind [1], which prevents it from being shared across threads. The behavio

Re: Management applications and CPU feature flags

2025-04-11 Thread Cornelia Huck
On Fri, Apr 11 2025, Jiri Denemark wrote: > On Fri, Apr 11, 2025 at 13:43:39 +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> > Considering the bigger picture QMP design,

Re: [PATCH v1 06/24] s390x/diag: Implement DIAG 320 subcode 1

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: DIAG 320 subcode 1 provides information needed to determine the amount of storage to store one or more certificates. The subcode value is denoted by setting the left-most bit of an 8-byte field. The verification-certificate-storage-size block (VCSSB) con

Re: [PATCH v3 5/5] utils/qemu-sockets: Introduce inet socket options controlling TCP keep-alive

2025-04-11 Thread Daniel P . Berrangé
On Tue, Apr 08, 2025 at 01:25:04PM +0200, Juraj Marcin wrote: > From: Juraj Marcin > > With the default TCP stack configuration, it could be even 2 hours > before the connection times out due to the other side not being > reachable. However, in some cases, the application needs to be aware of > a

Re: [PATCH v3 3/5] util/qemu-sockets: Refactor success and failure paths in inet_listen_saddr()

2025-04-11 Thread Daniel P . Berrangé
On Tue, Apr 08, 2025 at 01:25:02PM +0200, Juraj Marcin wrote: > From: Juraj Marcin > > To get a listening socket, we need to first create a socket, try binding > it to a certain port, and lastly starting listening to it. Each of these > operations can fail due to various reasons, one of them bein

Re: [PATCH 1/4] target/arm/ptw: extract arm_mmu_idx_to_security_space

2025-04-11 Thread Philippe Mathieu-Daudé
On 10/4/25 23:00, Pierrick Bouvier wrote: We'll reuse this function later. Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 8d4e9e07a94..5e196cfa955 100644

Re: [PATCH v1 04/24] s390x/diag: Introduce DIAG 320 for certificate store facility

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: From: Collin Walling ... Signed-off-by: Zhuoying Cai So the patch is from Collin, but S-o-b only by you? Looks weird, this should either have an additional S-o-b by Collin, too, or not have that "From:" line at all? ... diff --git a/include/hw/s

Re: [PULL 8/9] meson: Disallow 64-bit on 32-bit emulation

2025-04-11 Thread Daniel P . Berrangé
On Sat, Feb 08, 2025 at 12:57:23PM -0800, Richard Henderson wrote: > For system mode, we can rarely support the amount of RAM that > the guest requires. TCG emulation is restricted to round-robin > mode, which solves many of the atomicity issues, but not those > associated with virtio. In any case

Re: [PATCH v1 01/24] Add -boot-certificates /path/dir:/path/file option in QEMU command line

2025-04-11 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 01:57:26PM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 11, 2025 at 12:44:17PM +0200, Thomas Huth wrote: > > On 08/04/2025 17.55, Zhuoying Cai wrote: > > > The `-boot-certificates /path/dir:/path/file` option is implemented > > > to provide path to either a directory or a

Re: [PATCH v1 03/24] s390x: Guest support for Certificate Store Facility (CS)

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: DIAG 320 is supported when the certificate-store (CS) facility is installed. Availability of CS facility is determined by byte 134 bit 5 of the SCLP Read Info block. Signed-off-by: Zhuoying Cai --- ... diff --git a/target/s390x/cpu_features.c b/target

Re: [PATCH] virtio-net: Copy all for dhclient workaround

2025-04-11 Thread Antoine Damhet
On Fri, Apr 11, 2025 at 05:01:01PM +0900, Akihiko Odaki wrote: > On 2025/04/07 17:29, Antoine Damhet wrote: > > On Sat, Apr 05, 2025 at 05:04:28PM +0900, Akihiko Odaki wrote: > > > The goal of commit 7987d2be5a8b ("virtio-net: Copy received header to > > > buffer") was to remove the need to patch t

Re: [PATCH v1 02/24] hw/s390x/ipl: Create certificate store

2025-04-11 Thread Daniel P . Berrangé
On Tue, Apr 08, 2025 at 11:55:04AM -0400, Zhuoying Cai wrote: > Create a certificate store for boot certificates used for secure IPL. > > Load certificates from the -boot-certificate option into the cert store. > > Currently, only x509 certificates in DER format and uses SHA-256 hashing > algorit

Re: [PATCH v1 02/24] hw/s390x/ipl: Create certificate store

2025-04-11 Thread Thomas Huth
On 08/04/2025 17.55, Zhuoying Cai wrote: Create a certificate store for boot certificates used for secure IPL. Load certificates from the -boot-certificate option into the cert store. Currently, only x509 certificates in DER format and uses SHA-256 hashing algorithm are supported, as these are

Re: [PATCH v1 01/24] Add -boot-certificates /path/dir:/path/file option in QEMU command line

2025-04-11 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 12:44:17PM +0200, Thomas Huth wrote: > On 08/04/2025 17.55, Zhuoying Cai wrote: > > The `-boot-certificates /path/dir:/path/file` option is implemented > > to provide path to either a directory or a single certificate. > > > > Multiple paths can be delineated using a colon.

Re: [PATCH] migration: add FEATURE_SEEKABLE to QIOChannelBlock

2025-04-11 Thread Fabiano Rosas
"Marco Cavenati" writes: > On Thursday, April 10, 2025 21:52 CEST, Fabiano Rosas wrote: > >> We'll need to add the infrastructure to reject multifd and direct-io >> before this. The rest of the capabilities should not affect mapped-ram, >> so it's fine (for now) if we don't honor them. > > Ok, t

Re: Issue with stoptrigger.c Plugin in QEMU Emulation

2025-04-11 Thread Alex Bennée
Saanjh Sengupta writes: > Hi, > > I am writing to seek assistance with an issue I am experiencing while using > the stoptrigger.c plugin in QEMU emulation. I am > currently utilising the latest QEMU version, 9.2.92, and attempting to > emulate the Debian 11 as the operating system. > > The com

Re: Management applications and CPU feature flags

2025-04-11 Thread David Hildenbrand
On 11.04.25 13:43, Markus Armbruster wrote: Daniel P. Berrangé writes: On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbr

[PATCH v9 4/7] migration/ram: Implement save_postcopy_prepare()

2025-04-11 Thread Prasad Pandit
From: Peter Xu Implement save_postcopy_prepare(), preparing for the enablement of both multifd and postcopy. Signed-off-by: Peter Xu Signed-off-by: Prasad Pandit --- migration/ram.c | 37 + 1 file changed, 37 insertions(+) v8: reorder patch and some typogr

[PATCH v9 3/7] migration: Add save_postcopy_prepare() savevm handler

2025-04-11 Thread Prasad Pandit
From: Peter Xu Add a savevm handler for a module to opt-in sending extra sections right before postcopy starts, and before VM is stopped. RAM will start to use this new savevm handler in the next patch to do flush and sync for multifd pages. Note that we choose to do it before VM stopped becaus

[PATCH v9 7/7] tests/qtest/migration: add postcopy tests with multifd

2025-04-11 Thread Prasad Pandit
From: Prasad Pandit Add new qtests to run postcopy migration with multifd channels enabled. Signed-off-by: Prasad Pandit --- tests/qtest/migration/compression-tests.c | 16 tests/qtest/migration/postcopy-tests.c| 27 + tests/qtest/migration/precopy-tests.c | 19 +++

[PATCH v9 5/7] migration: enable multifd and postcopy together

2025-04-11 Thread Prasad Pandit
From: Prasad Pandit Enable Multifd and Postcopy migration together. The migration_ioc_process_incoming() routine checks magic value sent on each channel and helps to properly setup multifd and postcopy channels. The Precopy and Multifd threads work during the initial guest RAM transfer. When mig

[PATCH v9 2/7] migration: refactor channel discovery mechanism

2025-04-11 Thread Prasad Pandit
From: Prasad Pandit The various logical migration channels don't have a standardized way of advertising themselves and their connections may be seen out of order by the migration destination. When a new connection arrives, the incoming migration currently make use of heuristics to determine which

[PATCH v9 6/7] tests/qtest/migration: consolidate set capabilities

2025-04-11 Thread Prasad Pandit
From: Prasad Pandit Migration capabilities are set in multiple '.start_hook' functions for various tests. Instead, consolidate setting capabilities in 'migrate_start_set_capabilities()' function which is called from the 'migrate_start()' function. While simplifying the capabilities setting, it he

  1   2   >