On Fri, Apr 11, 2025 at 04:25:10PM +1000, Nicholas Piggin wrote: > On Wed Apr 2, 2025 at 5:17 AM AEST, Corey Minyard wrote: > > On Wed, Apr 02, 2025 at 12:01:47AM +1000, Nicholas Piggin wrote: > >> These little things came up when looking at behaviour of IPMI with > >> the bmc-sim implementation running the ppc powernv machine, and > >> trying to clean up error messages and missing features. > > > > This all looks good to me. Thanks to Philippe for reviewing, too. > > > > I can give you an > > > > Acked-by: Corey Minyard <cminy...@mvista.com> > > > > if you are working on this for your own tree, or I can take it into > > mine. > > Hey Corey, > > Thanks for all the review, and sorry I missed your question... > > I don't have anything further in my tree, I don't have an > immediate need for it, it was just tidying up a few errors > and warnings I noticed. > > I'd be happy for you to take it in your tree and send it up > when it suits you.
Ok, it's in my tree. I had to fix up pci_ipmi_kcs.c, it defined pci_ipmi_bt_get_fwinfo, not pci_ipmi_kcs_get_fwinfo. -corey > > Thanks, > Nick