Re: [PATCH v1 12/24] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block

[Farhan Ali]

...snip...
  
diff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h
index b8e7d1da71..2355fcecbb 100644
--- a/include/hw/s390x/ipl/qipl.h
+++ b/include/hw/s390x/ipl/qipl.h
@@ -23,6 +23,9 @@
  #define MAX_CERTIFICATES 64
  #define CERT_MAX_SIZE     (1024 * 8)
  
+#define DIAG308_IPIB_FLAGS_SIPL 0x40
+#define DIAG308_IPIB_FLAGS_IPLIR 0x20
+

nit: We have a diag308 flag defined here 
https://github.com/qemu/qemu/blob/master/hw/s390x/ipl.h#L22. It would be 
easier if we had the flags defined in one place.

  /*
   * The QEMU IPL Parameters will be stored at absolute address
   * 204 (0xcc) which means it is 32-bit word aligned but not
@@ -104,7 +107,8 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi;
  union IplParameterBlock {
      struct {
          uint32_t len;
-        uint8_t  reserved0[3];
+        uint8_t  hdr_flags;
+        uint8_t  reserved0[2];
          uint8_t  version;
          uint32_t blk0_len;
          uint8_t  pbt;