Re: [PATCH v2 02/14] rust: fix cfgs of proc-macro2 for 1.63.0

2024-10-23 Thread Junjie Mao
Paolo Bonzini writes: > Replay the configuration that would be computed by build.rs when compiling > on a 1.63.0 compiler. > > Signed-off-by: Paolo Bonzini Reviewed-by: Junjie Mao One question below. > --- > subprojects/packagefiles/proc-macro2-1-rs/meson.build | 4 +++- > 1 file changed,

[PULL 17/17] test/qtest/aspeed_smc-test: Fix coding style

2024-10-23 Thread Cédric Le Goater
From: Jamin Lin Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater --- tests/qtest/aspeed_smc-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/a

[PULL 4/4] vfio/helpers: Align mmaps

2024-10-23 Thread Cédric Le Goater
From: Alex Williamson Thanks to work by Peter Xu, support is introduced in Linux v6.12 to allow pfnmap insertions at PMD and PUD levels of the page table. This means that provided a properly aligned mmap, the vfio driver is able to map MMIO at significantly larger intervals than PAGE_SIZE. For

[PULL 12/17] hw/block:m25p80: Fix coding style

2024-10-23 Thread Cédric Le Goater
From: Jamin Lin Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/block/m25p80.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index f7123f9e6878..3f55b8f

[PULL 09/17] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-23 Thread Cédric Le Goater
From: Alejandro Zeise Make the Aspeed HACE module use the new qcrypto accumulative hashing functions when in scatter-gather accumulative mode. A hash context will maintain a "running-hash" as each scatter-gather chunk is received. Previously each scatter-gather "chunk" was cached so the hash cou

[PULL 05/17] hw/gpio/aspeed: Add AST2700 support

2024-10-23 Thread Cédric Le Goater
From: Jamin Lin AST2700 integrates two set of Parallel GPIO Controller with maximum 212 control pins, which are 27 groups. (H, exclude pin: H7 H6 H5 H4) In the previous design of ASPEED SOCs, one register is used for setting one function for one set which are 32 pins and 4 groups. ex: GPIO000 is

[PULL 13/17] hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq

2024-10-23 Thread Cédric Le Goater
From: Jamin Lin According to the w25q01jv datasheet at page 16, it is required to set QE bit in "Status Register 2" to enable quad mode. Currently, m25p80 support users utilize "Write Status Register 1(0x01)" command to set QE bit in "Status Register 2" and utilize "Read Status Register 2(0x35)"

RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode

2024-10-23 Thread Jamin Lin
Hi Cedric, > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode > > Hello Jamin, > > On 10/22/24 11:40, Jamin Lin wrote: > > change from v1: > > 1. Fix write incorrect data into flash in user mode. > > 2. Refactor aspeed smc qtest testcases to support AST2600, AST

Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in user mode

2024-10-23 Thread Cédric Le Goater
On 10/23/24 03:41, Jamin Lin wrote: Hi Cedric, Subject: Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in user mode static const VMStateDescription vmstate_aspeed_smc = { .name = "aspeed.smc", -.version_id = 2, +.version_id = 3, .minimum_version

Re: [PATCH v2 06/13] rust: modernize link_section usage for ELF platforms

2024-10-23 Thread Paolo Bonzini
Il mer 23 ott 2024, 17:15 Zhao Liu ha scritto: > > let expanded = quote! { > > #[allow(non_upper_case_globals)] > > #[used] > > -#[cfg_attr(target_os = "linux", link_section = ".ctors")] > > -#[cfg_attr(target_os = "macos", link_section = > "__DATA,__mod_ini

[PULL 1/4] vfio/migration: Report only stop-copy size in vfio_state_pending_exact()

2024-10-23 Thread Cédric Le Goater
From: Avihai Horon vfio_state_pending_exact() is used to update migration core how much device data is left for the device migration. Currently, the sum of pre-copy and stop-copy sizes of the VFIO device are reported. The pre-copy size is obtained via the VFIO_MIG_GET_PRECOPY_INFO ioctl, which r

[PULL 0/4] vfio queue

2024-10-23 Thread Cédric Le Goater
The following changes since commit 6f625ce2f21d6a1243065d236298277c56f972d5: Merge tag 'pull-request-2024-10-21' of https://gitlab.com/thuth/qemu into staging (2024-10-21 17:12:59 +0100) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfio-20241024 for y

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-23 Thread Joel Stanley
On Wed, 23 Oct 2024 at 19:50, Jamin Lin wrote: > > > Someone (aspeed?) should take a todo to resolve the HACE situation in > > u-boot. > > > > I will build a br2 image with upstream u-boot. The ones we use for tests > > have > > an OpenBMC u-boot IIRC. > > > > I used ASPEED FORKED OpenBMC pre-bui

Re: [PATCH v42 51/98] hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)

2024-10-23 Thread Guenter Roeck
On 10/23/24 20:27, Philippe Mathieu-Daudé wrote: Hi Guenter, On 23/10/24 19:24, Guenter Roeck wrote: Hi, On Fri, Jun 28, 2024 at 09:01:27AM +0200, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater --- This patch results in: [    5.976133] W

Re: [PATCH v42 51/98] hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)

2024-10-23 Thread Philippe Mathieu-Daudé
Hi Guenter, On 23/10/24 19:24, Guenter Roeck wrote: Hi, On Fri, Jun 28, 2024 at 09:01:27AM +0200, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater --- This patch results in: [5.976133] Waiting for root device /dev/mmcblk0... [6.5014

Re: [PATCH v2 06/14] rust: synchronize dependencies between subprojects and Cargo.lock

2024-10-23 Thread Junjie Mao
Paolo Bonzini writes: > The next commit will introduce a new build dependency for rust/qemu-api, > version_check. Before adding it, ensure that all dependencies are > synchronized between the Meson- and cargo-based build systems. > > Note that it's not clear whether in the long term we'll use

Re: [PATCH v2 01/14] rust: patch bilge-impl to allow compilation with 1.63.0

2024-10-23 Thread Junjie Mao
Paolo Bonzini writes: > Apply a patch that removes "let ... else" constructs, replacing them with > "if let ... else" or "let ... = match ...". "let ... else" was stabilized in > Rust 1.65.0. > > Reviewed-by: Zhao Liu > Signed-off-by: Paolo Bonzini Reviewed-by: Junjie Mao One question and

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-23 Thread Yong Huang
On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > v3: > > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by > Daniel > > > > Please review, thanks > > Yong > > > > v2: > > 1. Update the MAINTAINERS section s

Re: Please put qemu-system-sh4eb back.

2024-10-23 Thread Rob Landley
On 10/23/24 19:11, Rob Landley wrote: There was a big-endian issue breaking r2d last year, but it also broke big endian mips and some other targets too, and it got fixed. The binary I built a few months ago was working fine for me with vanilla qemu git source? (I don't _think_ I had local chang

Please put qemu-system-sh4eb back.

2024-10-23 Thread Rob Landley
I use it, and ship system images for it: https://landley.net/bin/mkroot/latest/sh4eb.tgz And here's me recentish-ly debugging an issue via it: https://landley.net/notes-2024.html#24-05-2024 (Compile/test cycles are WAY easier there than copying files onto an sd card to test on actual hardw

Re: [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing

2024-10-23 Thread Dmitry Osipenko
On 10/23/24 13:04, Akihiko Odaki wrote: ... >> +    ret = virgl_renderer_context_create_fence(cmd- >> >cmd_hdr.ctx_id, flags, >> +  cmd->cmd_hdr.ring_idx, >> +  cmd- >> >cmd_hdr.fence_id); >> +  

Re: [RFC V1 11/14] monitor: connect in precreate

2024-10-23 Thread Steven Sistare
On 10/21/2024 3:28 PM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:12AM -0700, Steve Sistare wrote: Complete monitor connections as early as possible, prior to qemu_create_early_backends, so the user can issue commands during the precreate phase. Make a list of the chardev's referenced by all

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Paolo Bonzini
On 10/17/24 17:14, Steve Sistare wrote: Make all global and compat properties available before the first objects are created. Set accelerator compatibility properties in configure_accelerators, when the accelerator is chosen, and call configure_accelerators earlier. Set machine options earlier.

[PATCH v3 1/3] contrib/plugins/cflow: fix warning

2024-10-23 Thread Pierrick Bouvier
contrib/plugins/cflow.c: In function ‘plugin_exit’: contrib/plugins/cflow.c:167:19: error: declaration of ‘n’ shadows a previous local [-Werror=shadow=local] 167 | NodeData *n = l->data; | ^ contrib/plugins/cflow.c:139:9: note: shadowed declaration is here 139 |

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Paolo Bonzini
On Wed, Oct 23, 2024 at 6:00 PM Paolo Bonzini wrote: > This makes it impossible to refer to a backend in a machine option from > the command line. While this is not done for now, it is not a > limitation I'd like to introduce. I stand corrected; it's exactly what's happening with canbus. Paolo

[PATCH] linux-user/strace: show TID instead of PID

2024-10-23 Thread J . Neuschäfer
This aligns with strace, and is very useful when tracing multi-threaded programs. The result is the same in single-threaded programs. gettid() requires the _GNU_SOURCE feature test macro, so it might be unavailable in rare cases. I don't expect it to be a problem though, because it's implemented b

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Paolo Bonzini
On 10/17/24 17:14, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties. For now call preinit and init_machine at the same place, so no functional change. For KVM I would also

Re: [PATCH] qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo (addtl)

2024-10-23 Thread Cal Peake
On Wed, 23 Oct 2024, Markus Armbruster wrote: > I posted the same fix, and it's in a pull request now: > > Subject: [PULL 07/14] crypto/hash-afalg: Fix broken build > Date: Tue, 22 Oct 2024 16:24:08 +0100 > Message-ID: <20241022152415.1632556-8-berra...@redhat.com> > > https://lo

[PATCH 1/2] target/i386: fix hang when using slow path for ptw_setl

2024-10-23 Thread Pierrick Bouvier
When instrumenting memory accesses for plugin, we force memory accesses to use the slow path for mmu. [1] This create a situation where we end up calling ptw_setl_slow. Since this function gets called during a cpu_exec, start_exclusive then hangs. This exclusive section was introduced initially fo

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Steven Sistare
On 10/22/2024 4:30 AM, David Hildenbrand wrote: On 18.10.24 21:15, Steven Sistare wrote: On 10/18/2024 11:40 AM, Steven Sistare wrote: On 10/18/2024 11:32 AM, Steven Sistare wrote: On 10/18/2024 11:08 AM, Fabiano Rosas wrote: Steve Sistare writes: Make all global and compat properties avai

[PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Peter Xu
This is a follow up of below patch from Avihai as a replacement: https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/ This is v2 of the series, and it became a more generic rework on how we do migration object refcounts, so I skipped a changelog because most of this is ne

Re: [PATCH v42 51/98] hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)

2024-10-23 Thread Guenter Roeck
Hi, On Fri, Jun 28, 2024 at 09:01:27AM +0200, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Cédric Le Goater > --- This patch results in: [5.976133] Waiting for root device /dev/mmcblk0... [6.501462] mmc0: error -38 whilst initialising SD card [

Re: [PATCH] tap-win32: fix format-truncation warning

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 14:30, Richard Henderson wrote: On 10/23/24 13:15, Pierrick Bouvier wrote: On 10/23/24 12:50, Alex Bennée wrote: Pierrick Bouvier writes: Simply increase destination buffer size so truncation can't happen. "cc" "-m64" "-Ilibcommon.a.p" "-Isubprojects/dtc/libfdt" "-I../subproject

Re: [PATCH v2 18/20] meson: build contrib/plugins with meson

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 01:57, Alex Bennée wrote: Pierrick Bouvier writes: On 10/22/24 03:56, Alex Bennée wrote: From: Pierrick Bouvier Tried to unify this meson.build with tests/tcg/plugins/meson.build but the resulting modules are not output in the right directory. Originally proposed by Anton Kochkov

[PATCH 0/2] target/i386: fix hang when using slow path for ptw_setl

2024-10-23 Thread Pierrick Bouvier
Most of the details are available in first patch. Second one is there to ensure we'll have a useful error message if start_exclusive is called from cpu_exec again. I'm a bit puzzled that we never triggered this hang before. Is there something wrong with the potential slow path for ptw_setl, or is

[PATCH 2/2] cpu: ensure we don't call start_exclusive from cpu_exec

2024-10-23 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- cpu-common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpu-common.c b/cpu-common.c index 6b262233a3b..c979138fce9 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -194,6 +194,9 @@ void start_exclusive(void) CPUState *other_cpu; int running

Re: [PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 06:03:36PM -0300, Fabiano Rosas wrote: > Right, but consider that it's easy enough for someone to look for a > global object to write in the code, find the wrong one and just use > it. It would then be up to reviewers to catch the mistake. > > Look at this: > > bool migr

Re: [PATCH v2] net/tap-win32: Fix gcc 14 format truncation errors

2024-10-23 Thread Pierrick Bouvier
On 10/8/24 13:28, Bernhard Beschow wrote: The patch fixes the following errors generated by GCC 14.2: ../src/net/tap-win32.c:343:19: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 176 [-Werror=format-truncation=] 343 | "%s\\%s\\Connec

Re: [PATCH] tap-win32: fix format-truncation warning

2024-10-23 Thread Richard Henderson
On 10/23/24 13:15, Pierrick Bouvier wrote: On 10/23/24 12:50, Alex Bennée wrote: Pierrick Bouvier writes: Simply increase destination buffer size so truncation can't happen. "cc" "-m64" "-Ilibcommon.a.p" "-Isubprojects/dtc/libfdt" "-I../subprojects/dtc/libfdt" "-ID:/a/_temp/msys64/mingw64/in

[PATCH v3 2/3] meson: build contrib/plugins with meson

2024-10-23 Thread Pierrick Bouvier
Tried to unify this meson.build with tests/tcg/plugins/meson.build but the resulting modules are not output in the right directory. Originally proposed by Anton Kochkov, thank you! Solves: https://gitlab.com/qemu-project/qemu/-/issues/1710 Signed-off-by: Pierrick Bouvier --- meson.build

[PATCH v3 3/3] contrib/plugins: remove Makefile for contrib/plugins

2024-10-23 Thread Pierrick Bouvier
Now replaced by meson build. Signed-off-by: Pierrick Bouvier --- configure| 18 - Makefile | 10 - contrib/plugins/Makefile | 87 3 files changed, 115 deletions(-) delete mode 100644 contrib/plugins/Makefile d

[PATCH v3 0/3] build contrib/plugins using meson

2024-10-23 Thread Pierrick Bouvier
Contrib plugins have been built out of tree so far, thanks to a Makefile. However, it is quite inconvenient for maintenance, as we may break them, especially for specific architectures. First patches are fixing warnings for existing plugins, then we add meson support, and finally, we remove Makefi

Re: [PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Fabiano Rosas
Peter Xu writes: > This is a follow up of below patch from Avihai as a replacement: > > https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/ > > This is v2 of the series, and it became a more generic rework on how we do > migration object refcounts, so I skipped a changel

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 11:14:24AM -0400, Peter Xu wrote: > On Wed, Oct 23, 2024 at 11:30:14AM +0300, Avihai Horon wrote: > > > > On 22/10/2024 19:07, Peter Xu wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > Migration object can be freed before some other

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Steven Sistare
On 10/21/2024 11:19 AM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:05AM -0700, Steve Sistare wrote: Make all global and compat properties available before the first objects are created. Set accelerator compatibility properties in configure_accelerators, when the accelerator is chosen, and ca

Re: [PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Oct 23, 2024 at 04:32:01PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > This is a follow up of below patch from Avihai as a replacement: >> > >> > https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/ >> > >> > This is v2 of the seri

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Steven Sistare
On 10/23/2024 12:00 PM, Paolo Bonzini wrote: On 10/17/24 17:14, Steve Sistare wrote: Make all global and compat properties available before the first objects are created.  Set accelerator compatibility properties in configure_accelerators, when the accelerator is chosen, and call configure_accel

[PATCH v2] linux-user: Fix GDB complaining about system-supplied DSO string table index

2024-10-23 Thread Ilya Leoshkevich
When debugging qemu-user processes using gdbstub, the following warning appears every time: warning: BFD: warning: system-supplied DSO at 0x7f8253cc3000 has a corrupt string table index The reason is that QEMU does not map the VDSO's section headers. The VDSO's ELF header's e_shoff points to

Re: [PATCH] linux-user: Fix GDB complaining about system-supplied DSO string table index

2024-10-23 Thread Richard Henderson
On 10/23/24 07:46, Ilya Leoshkevich wrote: When debugging qemu-user processes using gdbstub, the following warning appears every time: warning: BFD: warning: system-supplied DSO at 0x7f8253cc3000 has a corrupt string table index The reason is that QEMU does not map the VDSO's section head

Re: Qemu v9.0.2: Boot failed qemu-arm with Linux next-20241017 tag.

2024-10-23 Thread Alex Bennée
"Arnd Bergmann" writes: > On Sun, Oct 20, 2024, at 17:39, Naresh Kamboju wrote: >> On Fri, 18 Oct 2024 at 12:35, Naresh Kamboju >> wrote: >>> >>> The QEMU-ARMv7 boot has failed with the Linux next-20241017 tag. >>> The boot log is incomplete, and no kernel crash was detected. >>> However, the s

Re: [PATCH v2 4/4] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024, 2:02 p.m. Peter Xu wrote: > Migration object can be freed (e.g. after migration_shutdown()) before some > other device codes can still run, while we do have a bunch of migration > helpers exported in migration/misc.h that logically can be invoked at any > time of QEMU, even

Re: [PATCH] tap-win32: fix format-truncation warning

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 12:50, Alex Bennée wrote: Pierrick Bouvier writes: Simply increase destination buffer size so truncation can't happen. "cc" "-m64" "-Ilibcommon.a.p" "-Isubprojects/dtc/libfdt" "-I../subprojects/dtc/libfdt" "-ID:/a/_temp/msys64/mingw64/include/pixman-1" "-ID:/a/_temp/msys64/mingw64

Re: [PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 04:32:01PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > This is a follow up of below patch from Avihai as a replacement: > > > > https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/ > > > > This is v2 of the series, and it became a more gen

Re: [PATCH] hvf: remove unused but set variable

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 12:53, Alex Bennée wrote: Pierrick Bouvier writes: fixes associated warning when building on MacOS. Signed-off-by: Pierrick Bouvier --- target/i386/hvf/x86_task.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/i386/hvf/x86_task.c b/target

Re: [PATCH] hvf: remove unused but set variable

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > fixes associated warning when building on MacOS. > > Signed-off-by: Pierrick Bouvier > --- > target/i386/hvf/x86_task.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target/i386/hvf/x86_task.c b/target/i386/hvf/x86_task.c > index

Re: [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8

2024-10-23 Thread Alex Bennée
Ilya Leoshkevich writes: > [1] deprecated -mpower8-vector, resulting in: > > powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer > supported > qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before > 'float' > 4 | typedef vector float vsx_float32

Re: [PATCH] tap-win32: fix format-truncation warning

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > Simply increase destination buffer size so truncation can't happen. > > "cc" "-m64" "-Ilibcommon.a.p" "-Isubprojects/dtc/libfdt" > "-I../subprojects/dtc/libfdt" > "-ID:/a/_temp/msys64/mingw64/include/pixman-1" > "-ID:/a/_temp/msys64/mingw64/include/glib-2.0" > "-ID:/a/_

Re: [PATCH] linux-user: Fix GDB complaining about system-supplied DSO string table index

2024-10-23 Thread Ilya Leoshkevich
On Wed, 2024-10-23 at 12:03 -0700, Richard Henderson wrote: > On 10/23/24 07:46, Ilya Leoshkevich wrote: > > [...] > > > - Fix up VDSO's PHDR size in gen-vdso. This is the simplest > > solution, > >    so do it. The only tricky part is byte-swaps: they need to be > > either > >    done on local

Re: [PATCH] hvf: remove unused but set variable

2024-10-23 Thread Richard Henderson
On 10/23/24 11:29, Pierrick Bouvier wrote: fixes associated warning when building on MacOS. Signed-off-by: Pierrick Bouvier --- target/i386/hvf/x86_task.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~ diff --git a/target/i386/hvf/x8

Re: [PATCH v2 0/4] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 02:02:12PM -0400, Peter Xu wrote: > This is a follow up of below patch from Avihai as a replacement: > > https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/ > > This is v2 of the series, and it became a more generic rework on how we do > migration

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 10:12, Julian Ganz wrote: Hi, Pierrick, October 23, 2024 at 6:39 PM, "Pierrick Bouvier" wrote: So we could have something like: /* plugin side */ void on_cf_event(qemu_plugin_cf_event_type, uint64_t from, uint64_t to) { ... } We also need the VCPU id, but yes. Yes! /* AP

[PATCH] hvf: remove unused but set variable

2024-10-23 Thread Pierrick Bouvier
fixes associated warning when building on MacOS. Signed-off-by: Pierrick Bouvier --- target/i386/hvf/x86_task.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/i386/hvf/x86_task.c b/target/i386/hvf/x86_task.c index f09bfbdda5b..cdea2ea69d9 100644 --- a/targe

[PATCH] tap-win32: fix format-truncation warning

2024-10-23 Thread Pierrick Bouvier
Simply increase destination buffer size so truncation can't happen. "cc" "-m64" "-Ilibcommon.a.p" "-Isubprojects/dtc/libfdt" "-I../subprojects/dtc/libfdt" "-ID:/a/_temp/msys64/mingw64/include/pixman-1" "-ID:/a/_temp/msys64/mingw64/include/glib-2.0" "-ID:/a/_temp/msys64/mingw64/lib/glib-2.0/incl

[PATCH v2 2/4] migration: Reset current_migration properly

2024-10-23 Thread Peter Xu
current_migration is never reset, even if the migration object is freed already. It means anyone references that can trigger UAF and it'll be hard to debug. Properly clear the pointer now, so far by doing it in the finalize() (as we know there's only one instance of it). Add a TODO entry for it

[PATCH v2 4/4] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
Migration object can be freed (e.g. after migration_shutdown()) before some other device codes can still run, while we do have a bunch of migration helpers exported in migration/misc.h that logically can be invoked at any time of QEMU, even during destruction of a VM. Make all these functions safe

[PATCH v2 3/4] migration: Add global_migration

2024-10-23 Thread Peter Xu
Add a variable that is only used in exported / global migration helpers, reflecting whether migration is available to the outside world. Note that we haven't yet started using this variable, but hopefully that is still better already because now we have an explicit place to say who owns the initia

[PATCH v2 1/4] migration: Unexport dirty_bitmap_mig_init() in misc.h

2024-10-23 Thread Peter Xu
It's only used within migration/, so it shouldn't be exported. Reviewed-by: Cédric Le Goater Signed-off-by: Peter Xu --- include/migration/misc.h | 3 --- migration/migration.h| 4 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/migration/misc.h b/include/migrati

Re: [RFC V1 14/14] migration: allow commands during precreate and preconfig

2024-10-23 Thread Steven Sistare
On 10/21/2024 3:36 PM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:15AM -0700, Steve Sistare wrote: Allow various migration commands during the precreate and preconfig phases so migration may be set up and initiated at that time. Signed-off-by: Steve Sistare --- hmp-commands.hx | 2 ++

Re: [RFC V1 13/14] net: cleanup for precreate phase

2024-10-23 Thread Steven Sistare
On 10/21/2024 3:20 PM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:14AM -0700, Steve Sistare wrote: Guard against unconfigured state if cleanup is called early, such as during the precreate phase. Signed-off-by: Steve Sistare Reviewed-by: Peter Xu One nitpick.. --- net/net.c | 4 +++-

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-23 Thread Paolo Bonzini
On 10/21/24 18:20, Peter Xu wrote: On Fri, Oct 18, 2024 at 03:15:56PM -0400, Steven Sistare wrote: I understand this now. The old code worked in this order: qemu_create_early_backends() ... creates "-object can-bus,id=canbus" qemu_create_machine() qemu_apply_machine_options()

Re: [RFC V1 11/14] monitor: connect in precreate

2024-10-23 Thread Steven Sistare
On 10/23/2024 12:05 PM, Paolo Bonzini wrote: On 10/17/24 17:14, Steve Sistare wrote: Complete monitor connections as early as possible, prior to qemu_create_early_backends, so the user can issue commands during the precreate phase. Make a list of the chardev's referenced by all monitors.  Creat

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Julian Ganz
Hi, Pierrick, October 23, 2024 at 6:39 PM, "Pierrick Bouvier" wrote: > > So we could have something like: > > /* plugin side */ > void on_cf_event(qemu_plugin_cf_event_type, uint64_t from, uint64_t to) { > ... > } We also need the VCPU id, but yes. > /* API side */ > void qemu_plugin_register

Re: [RFC V1 00/14] precreate phase

2024-10-23 Thread Paolo Bonzini
On 10/17/24 17:14, Steve Sistare wrote: Define a new qemu initialization phase called 'precreate' which occurs before most backends or devices have been created. The only exception is monitor and qtest devices and their associated chardevs. QEMU runs in the main loop during this phase. Monitor

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 09:12, Julian Ganz wrote: Hi, Pierrick, October 23, 2024 at 5:16 PM, "Pierrick Bouvier" wrote: Hi Julian, On 10/23/24 05:56, Julian Ganz wrote: October 22, 2024 at 11:15 PM, "Pierrick Bouvier" wrote: On 10/22/24 01:21, Julian Ganz wrote: Ok, I'll introduce an enum and

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Steven Sistare
On 10/23/2024 11:53 AM, Paolo Bonzini wrote: On 10/17/24 17:14, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties.  For now call preinit and init_machine at the same place, s

Re: Qemu v9.0.2: Boot failed qemu-arm with Linux next-20241017 tag.

2024-10-23 Thread Arnd Bergmann
On Sun, Oct 20, 2024, at 17:39, Naresh Kamboju wrote: > On Fri, 18 Oct 2024 at 12:35, Naresh Kamboju > wrote: >> >> The QEMU-ARMv7 boot has failed with the Linux next-20241017 tag. >> The boot log is incomplete, and no kernel crash was detected. >> However, the system did not proceed far enough t

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Steven Sistare
On 10/21/2024 10:54 AM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:03AM -0700, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties. For now call preinit and init_machine at

Re: [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8

2024-10-23 Thread Richard Henderson
On 10/23/24 06:12, Ilya Leoshkevich wrote: [1] deprecated -mpower8-vector, resulting in: powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before 'float' 4 | typedef vector float vsx_

Re: [PATCH] tests/tcg: Replace -mpower8-vector with -mvsx

2024-10-23 Thread Richard Henderson
On 10/23/24 05:17, Ilya Leoshkevich wrote: On Mon, 2024-10-21 at 19:59 -0700, Richard Henderson wrote: On 10/21/24 07:27, Ilya Leoshkevich wrote: [1] deprecated -mpower8-vector, resulting in: powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported qemu/tes

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Julian Ganz
Hi, Pierrick, October 23, 2024 at 5:16 PM, "Pierrick Bouvier" wrote: > > Hi Julian, > > On 10/23/24 05:56, Julian Ganz wrote: > > > October 22, 2024 at 11:15 PM, "Pierrick Bouvier" wrote: > > > > > > > > On 10/22/24 01:21, Julian Ganz wrote: > > > > > > > Ok, I'll introduce an enum and co

Re: [RFC V1 11/14] monitor: connect in precreate

2024-10-23 Thread Paolo Bonzini
On 10/17/24 17:14, Steve Sistare wrote: Complete monitor connections as early as possible, prior to qemu_create_early_backends, so the user can issue commands during the precreate phase. Make a list of the chardev's referenced by all monitors. Create the chardevs, then create the monitors. Exc

Re: [RFC V1 05/14] migration: init and listen during precreate

2024-10-23 Thread Steven Sistare
On 10/21/2024 5:05 PM, Fabiano Rosas wrote: Steve Sistare writes: Initialize the migration object as early as possible so that migration configuration commands may be sent during the precreate phase. Also, start listening for the incoming migration connection during precreate, so that the lis

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Pierrick Bouvier
On 10/23/24 06:57, Alex Bennée wrote: "Julian Ganz" writes: Hi, Pierrick, resent as I was too stupid to hit reply instead of reply-all. October 22, 2024 at 11:15 PM, "Pierrick Bouvier" wrote: On 10/22/24 01:21, Julian Ganz wrote: Hi, Pierrick, October 21, 2024 at 11:59 PM, "Pierrick B

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Pierrick Bouvier
Hi Julian, On 10/23/24 05:56, Julian Ganz wrote: Hi, Pierrick, resent as I was too stupid to hit reply instead of reply-all. October 22, 2024 at 11:15 PM, "Pierrick Bouvier" wrote: On 10/22/24 01:21, Julian Ganz wrote: Hi, Pierrick, October 21, 2024 at 11:59 PM, "Pierrick Bouvier" wrote

Re: [PATCH v2 06/13] rust: modernize link_section usage for ELF platforms

2024-10-23 Thread Zhao Liu
On Mon, Oct 21, 2024 at 06:35:31PM +0200, Paolo Bonzini wrote: > Date: Mon, 21 Oct 2024 18:35:31 +0200 > From: Paolo Bonzini > Subject: [PATCH v2 06/13] rust: modernize link_section usage for ELF > platforms > X-Mailer: git-send-email 2.46.2 > > Some newer ABI implementations do not provide .cto

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 11:30:14AM +0300, Avihai Horon wrote: > > On 22/10/2024 19:07, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > Migration object can be freed before some other device codes run, while we > > do have a bunch of migration helpers expo

Re: [PATCH 0/2] vfio: Align mmaps

2024-10-23 Thread Cédric Le Goater
On 10/22/24 22:08, Alex Williamson wrote: As described in patch /2, newer kernels may support pfnmap with PMD or PUD sized mappings. Mappings must be aligned in order to see the full benefit of this support. We're largely able to get PMD alignment for free from mmap, but PUD alignment requires

Re: [PATCH 0/3] vfio/migration: Some bug fixes and cleanups

2024-10-23 Thread Cédric Le Goater
On 10/20/24 15:01, Avihai Horon wrote: This small series contains some bug fixes and cleanups. Reviews are welcome. Thanks. Avihai Horon (3): vfio/migration: Report only stop-copy size in vfio_state_pending_exact() vfio/migration: Refactor vfio_vmstate_change/_prepare() error re

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-10-23 Thread Fabiano Rosas
yong.hu...@smartx.com writes: > From: Hyman Huang > > v3: > 1. Remove the two redundant assignments in [PATCH v2 2/5] suggested by Daniel > > Please review, thanks > Yong > > v2: > 1. Update the MAINTAINERS section suggested by Fabiano Rosas > 2. Ensure the dependencies when build the initrd-st

[PATCH] linux-user: Fix GDB complaining about system-supplied DSO string table index

2024-10-23 Thread Ilya Leoshkevich
When debugging qemu-user processes using gdbstub, the following warning appears every time: warning: BFD: warning: system-supplied DSO at 0x7f8253cc3000 has a corrupt string table index The reason is that QEMU does not map the VDSO's section headers. The VDSO's ELF header's e_shoff points to

[Bug 2072564] Re: qemu-aarch64-static segfaults running ldconfig.real (amd64 host)

2024-10-23 Thread Thomas Irgang
Hi, this issue also happens when I try to run debootstrap for Jammy arm64 on a Noble amd64 host. At the moment I use the workaround to use ubuntu:jammy workers instead of ubunut:latest. It would be great if this issue can be fixed soon. -- You received this bug notification because you are a memb

Re: [PATCH v8 0/6] AWS Nitro Enclave emulation support

2024-10-23 Thread Dorjoy Chowdhury
On Wed, Oct 16, 2024 at 7:58 PM Dorjoy Chowdhury wrote: > > Ping > > This patch series has been reviewed by Alex. I am not sure if it needs > more review. If not, maybe this can be picked up for merging. Thanks! > Gentle ping. This patch series has been reviewed by Alex and there hasn't been any

Re: [RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-23 Thread Alex Bennée
"Julian Ganz" writes: > Hi, Pierrick, > > resent as I was too stupid to hit reply instead of reply-all. > > October 22, 2024 at 11:15 PM, "Pierrick Bouvier" wrote: >> >> On 10/22/24 01:21, Julian Ganz wrote: >> >> > >> > Hi, Pierrick, >> > October 21, 2024 at 11:59 PM, "Pierrick Bouvier" wrot

[PATCH] tests/functional: Fix the s390x and ppc64 tuxrun tests

2024-10-23 Thread Thomas Huth
I forgot to add the tests to the meson.build file and looks like I even managed to somehow mix up the hashsums in the ppc64 test! Signed-off-by: Thomas Huth --- tests/functional/meson.build | 3 +++ tests/functional/test_ppc64_tuxrun.py | 4 ++-- 2 files changed, 5 insertions(+), 2 dele

Re: [RFC V1 06/14] vl: precreate phase

2024-10-23 Thread Fabiano Rosas
Steve Sistare writes: > Refactor qemu_init into actions performed during the precreate phase, > and actions performed when exiting precreate. For now, always exit > the precreate phase immediately at init time. Future patches will add > conditions that cause QEMU to linger in the precreate phas

Re: [PATCH v2 05/13] rust: remove uses of #[no_mangle]

2024-10-23 Thread Zhao Liu
On Wed, Oct 23, 2024 at 12:48:33PM +0200, Paolo Bonzini wrote: > Date: Wed, 23 Oct 2024 12:48:33 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH v2 05/13] rust: remove uses of #[no_mangle] > > On 10/21/24 18:35, Paolo Bonzini wrote: > > @@ -566,7 +563,6 @@ pub fn update(&self) { > > /// # Saf

Re: [PATCH v2 05/13] rust: remove uses of #[no_mangle]

2024-10-23 Thread Zhao Liu
On Mon, Oct 21, 2024 at 06:35:30PM +0200, Paolo Bonzini wrote: > Date: Mon, 21 Oct 2024 18:35:30 +0200 > From: Paolo Bonzini > Subject: [PATCH v2 05/13] rust: remove uses of #[no_mangle] > X-Mailer: git-send-email 2.46.2 > > Mangled symbols do not cause any issue; disabling mangling is only usefu

Re: [PATCH 2/2] vfio/helpers: Align mmaps

2024-10-23 Thread Alex Williamson
On Wed, 23 Oct 2024 14:44:19 +0200 Cédric Le Goater wrote: > On 10/22/24 22:08, Alex Williamson wrote: > > Thanks to work by Peter Xu, support is introduced in Linux v6.12 to > > allow pfnmap insertions at PMD and PUD levels of the page table. This > > means that provided a properly aligned mmap

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-10-23 Thread Michael Galaxy
Hi All, This is just a heads up: I will be changing employment soon, so my Akamai email address will cease to operate this week. My personal email: mich...@flatgalaxy.com. I'll re-subscribe later once I have come back online to work soon. Thanks! - Michael On 10/7/24 08:45, Michael Galaxy

Re: [PATCH 1/3] scsi: fetch unit attention when creating the request

2024-10-23 Thread Michael Galaxy
On 10/11/24 14:44, Michael Tokarev wrote: !---|  This Message Is From an External Sender  This message came from outside your organization. |---! On 09.10.2024 21:00, M

  1   2   3   >