On Mon, Oct 21, 2024 at 06:35:30PM +0200, Paolo Bonzini wrote: > Date: Mon, 21 Oct 2024 18:35:30 +0200 > From: Paolo Bonzini <pbonz...@redhat.com> > Subject: [PATCH v2 05/13] rust: remove uses of #[no_mangle] > X-Mailer: git-send-email 2.46.2 > > Mangled symbols do not cause any issue; disabling mangling is only useful if > C headers reference the Rust function, which is not the case here. > > Reviewed-by: Junjie Mao <junjie....@hotmail.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > rust/hw/char/pl011/src/device.rs | 5 ----- > rust/hw/char/pl011/src/device_class.rs | 2 -- > rust/hw/char/pl011/src/memory_ops.rs | 2 -- > rust/qemu-api/src/definitions.rs | 1 - > rust/qemu-api/src/device_class.rs | 2 -- > 5 files changed, 12 deletions(-) >
With pl011_create() fixed, Reviewed-by: Zhao Liu <zhao1....@intel.com>
