On 10/23/24 13:04, Akihiko Odaki wrote: ... >> + ret = virgl_renderer_context_create_fence(cmd- >> >cmd_hdr.ctx_id, flags, >> + cmd->cmd_hdr.ring_idx, >> + cmd- >> >cmd_hdr.fence_id); >> + if (ret) >> + qemu_log_mask(LOG_GUEST_ERROR, >> + "%s: virgl_renderer_context_create_fence >> error: %s", >> + __func__, strerror(ret)); > > This should use: strerror(-ret)
Indeed, here error code should be negative, while for the legacy virgl_renderer_create_fence() it's positive. Will correct it in v3, add a clarifying comment and address other comments. Thanks for the review! -- Best regards, Dmitry
