Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in user mode

[Cédric Le Goater]

On 10/23/24 03:41, Jamin Lin wrote:

Hi Cedric,

Subject: Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in
user mode

   static const VMStateDescription vmstate_aspeed_smc = {
       .name = "aspeed.smc",
-    .version_id = 2,
+    .version_id = 3,
       .minimum_version_id = 2,
       .fields = (const VMStateField[]) {
           VMSTATE_UINT32_ARRAY(regs, AspeedSMCState,

ASPEED_SMC_R_MAX),

           VMSTATE_UINT8(snoop_index, AspeedSMCState),
           VMSTATE_UINT8(snoop_dummies, AspeedSMCState),
+        VMSTATE_BOOL(unselect, AspeedSMCState),
           VMSTATE_END_OF_LIST()
       }
   };

I think this will break migration compatibility. In order to enable at
least forward migration, it should be:

      VMSTATE_BOOL_V(unselect, AspeedSMCState, 3),

This is correct. I will fix the patch.

If I need to re-send v3 patch, I will fix it.

I took care of it. No need to resend.

Thanks

C.