Re: [PATCH v3 0/3] docs/interop: Convert QMP related txt docs to rst

2023-05-15 Thread Markus Armbruster
Peter Maydell writes: > This patchset deals with a couple of the old .txt files > that are still hanging around in docs/interop: qmp-spec.txt > and qmp-intro.txt. Patch 1 converts qmp-spec to rST and > integrates it into the manual. Patch 2 takes the only > interesting parts of qmp-intro.txt (the

Gpio in vexpress

2023-05-15 Thread ido berenbaum
Hi, I was trying to understand the architecture of the vexpress virtual machine in regards to adding new gpios that are going to be external. First, is it right to act as if I am developing on a physical board and add the gpios to the VexpressMachineState struct? Secondly, which gpio type fits here

Re: [PATCH v3 2/3] docs/interop/qmp-spec: Update error description for parsing errors

2023-05-15 Thread Markus Armbruster
Peter Maydell writes: > The description text for a parsing error has changed since the > spec doc was first written; update the example in the docs. > > Suggested-by: Markus Armbruster > Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster

Re: [PATCH v3 1/3] docs/interop: Convert qmp-spec.txt to rST

2023-05-15 Thread Markus Armbruster
Peter Maydell writes: > Convert the qmp-spec.txt document to restructuredText. > Notable points about the conversion: > * numbers at the start of section headings are removed, to match >the style of the rest of the manual > * cross-references to other sections or documents are hyperlinked >

Re: [PATCH v4 6/8] migration: modified 'migrate' QAPI to accept 'channels' argument for migration

2023-05-15 Thread Het Gala
On 15/05/23 4:06 pm, Daniel P. Berrangé wrote: On Fri, May 12, 2023 at 02:32:38PM +, Het Gala wrote: MigrateChannelList ideally allows to connect accross multiple interfaces. Added MigrateChannelList struct as argument to 'migrate' qapi. Introduced MigrateChannelList in hmp_migrate() and

Re: [PATCH] qapi/parser: Fix type hints

2023-05-15 Thread Markus Armbruster
Richard Henderson writes: > On 5/11/23 04:17, Markus Armbruster wrote: >> Fixes: 3e32dca3f0d1 (qapi: Rewrite parsing of doc comment section symbols >> and tags) >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi/parser.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

2023-05-15 Thread Harsh Prateek Bora
On 5/16/23 01:26, Juan Quintela wrote: Define and use RATE_LIMIT_MAX instead. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 6 ++ migration/migration.c | 4 ++-- migration/qemu-file.c | 6 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --

[PATCH] target/arm: allow DC CVA[D]P in user mode emulation

2023-05-15 Thread Zhuojia Shen
DC CVAP and DC CVADP instructions can be executed in EL0 on Linux, either directly when SCTLR_EL1.UCI == 1 or emulated by the kernel (see user_cache_maint_handler() in arch/arm64/kernel/traps.c). The Arm ARM documents the semantics of the two instructions that they behave as DC CVAC if the address

[PATCH] vfio/pci: Fix a use-after-free issue

2023-05-15 Thread Zhenzhong Duan
We should free the duplicated variant of vbasedev->name plus uuid rather than vbasedev->name itself. Fixes: 2dca1b37a7 ("vfio/pci: add support for VF toke") Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/v

Re: [PATCH] target: ppc: Correctly initialize HILE in HID-0 for book3s processors

2023-05-15 Thread Nicholas Piggin
On Tue May 16, 2023 at 11:54 AM AEST, Narayana Murty N wrote: > > On 5/15/23 12:02, Nicholas Piggin wrote: > > On Sat Apr 29, 2023 at 12:30 AM AEST, Fabiano Rosas wrote: > Could you describe in more detail what is your setup? Specifically > whether both guests are running TCG or KVM (info

Re: [PATCH] target: ppc: Correctly initialize HILE in HID-0 for book3s processors

2023-05-15 Thread Narayana Murty N
On 5/15/23 12:02, Nicholas Piggin wrote: On Sat Apr 29, 2023 at 12:30 AM AEST, Fabiano Rosas wrote: Vaibhav Jain writes: Hi Fabiano, Thanks for looking into this patch and apologies for the delayed reponse. Fabiano Rosas writes: Narayana Murty N writes: On PPC64 the HILE(Hypervisor In

Re: [PATCH] cryptodev-vhost-user: add asymmetric crypto support

2023-05-15 Thread zhenwei pi
On 5/14/23 14:55, Gowrishankar Muthukrishnan wrote: Add asymmetric crypto support in vhost_user backend. Signed-off-by: Gowrishankar Muthukrishnan --- backends/cryptodev-vhost-user.c | 9 +++--- hw/virtio/vhost-user.c | 52 - 2 files changed, 43

[PATCH v4] hw/riscv: qemu crash when NUMA nodes exceed available CPUs

2023-05-15 Thread Yin Wang
Command "qemu-system-riscv64 -machine virt -m 2G -smp 1 -numa node,mem=1G -numa node,mem=1G" would trigger this problem.Backtrace with: #0 0x55b5b1a4 in riscv_numa_get_default_cpu_node_id at ../hw/riscv/numa.c:211 #1 0x558ce510 in machine_numa_finish_cpu_init at ../hw/core/m

Re: [PATCH] qapi/parser: Fix type hints

2023-05-15 Thread Richard Henderson
On 5/11/23 04:17, Markus Armbruster wrote: Fixes: 3e32dca3f0d1 (qapi: Rewrite parsing of doc comment section symbols and tags) Signed-off-by: Markus Armbruster --- scripts/qapi/parser.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/parser.py b/scripts/

Re: [PULL v2 00/16] Block patches

2023-05-15 Thread Richard Henderson
On 5/15/23 09:04, Stefan Hajnoczi wrote: The following changes since commit 8844bb8d896595ee1d25d21c770e6e6f29803097: Merge tag 'or1k-pull-request-20230513' ofhttps://github.com/stffrdhrn/qemu into staging (2023-05-13 11:23:14 +0100) are available in the Git repository at: https://gitl

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-15 Thread Richard Henderson
On 5/15/23 09:43, Peter Maydell wrote: +static uint16_t load_atom_2(CPUArchState *env, uintptr_t ra, +void *pv, MemOp memop) +{ +uintptr_t pi = (uintptr_t)pv; +int atmax; + +if (likely((pi & 1) == 0)) { +return load_atomic2(pv); +} +if (HAVE

Re: [PATCH] python: honour message limit when using pre-opened socket

2023-05-15 Thread John Snow
On Mon, Mar 20, 2023 at 8:27 PM John Snow wrote: > > On Mon, Mar 20, 2023 at 8:20 AM Vladimir Sementsov-Ogievskiy > wrote: > > > > On 20.03.23 13:54, Daniel P. Berrangé wrote: > > > The default message recv limit in asyncio is smaller than our needs, so > > > when opening connections we override

Re: [RFC PATCH 1/1] virtio-balloon: Add Working Set Reporting feature

2023-05-15 Thread T.J. Alumbaugh
For completeness, here is the corresponding proposed VIRTIO spec expansion: https://lists.oasis-open.org/archives/virtio-comment/202305/msg00227.html The corresponding balloon driver change is part of this RFC patch series: https://lore.kernel.org/linux-mm/20230509185419.1088297-1-yuan...@google

Re: [PATCH v3 2/3] docs/interop/qmp-spec: Update error description for parsing errors

2023-05-15 Thread Eric Blake
On Mon, May 15, 2023 at 05:22:44PM +0100, Peter Maydell wrote: > > The description text for a parsing error has changed since the > spec doc was first written; update the example in the docs. > > Suggested-by: Markus Armbruster > Signed-off-by: Peter Maydell > --- > docs/interop/qmp-spec.rst

Re: [PATCH 1/8] block: Call .bdrv_co_create(_opts) unlocked

2023-05-15 Thread Eric Blake
On Mon, May 15, 2023 at 06:19:41PM +0200, Kevin Wolf wrote: > > > @@ -3724,8 +3726,10 @@ qcow2_co_create(BlockdevCreateOptions > > > *create_options, Error **errp) > > > goto out; > > > } > > > > > > +bdrv_graph_co_rdlock(); > > > ret = qcow2_alloc_clusters(blk_bs(blk),

Re: [Libguestfs] [PATCH v3 00/14] qemu patches for 64-bit NBD extensions

2023-05-15 Thread Eric Blake
Adding qemu-block for the cover letter (not sure how I missed that the first time). On Mon, May 15, 2023 at 02:53:29PM -0500, Eric Blake wrote: > > v2 was here: > https://lists.gnu.org/archive/html/qemu-devel/2022-11/msg02340.html > > Since then: > - upstream NBD has accepted the extension on

Re: [PULL 00/21] Tests, docs, s390x and misc patches

2023-05-15 Thread Richard Henderson
On 5/15/23 06:02, Thomas Huth wrote: Hi Richard! The following changes since commit 8844bb8d896595ee1d25d21c770e6e6f29803097: Merge tag 'or1k-pull-request-20230513' ofhttps://github.com/stffrdhrn/qemu into staging (2023-05-13 11:23:14 +0100) are available in the Git repository at: h

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-05-15 Thread Stefano Stabellini
On Sat, 13 May 2023, Bernhard Beschow wrote: > Am 21. April 2023 07:38:10 UTC schrieb "Michael S. Tsirkin" : > >On Mon, Apr 03, 2023 at 09:41:17AM +0200, Bernhard Beschow wrote: > >> There is currently a dedicated PIIX3 device model for use under Xen. By > >> reusing > >> existing PCI API during i

[PATCH 3/3] ACPI: bios-tables-test.c step 5 (update expected table binaries)

2023-05-15 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. The MADT/APIC table diffs show (for pc, q35 and microvm) bumping revision from 1 to 3 (and checksum changing accordingly): Using expected file 'tests/data/acpi/pc/DSDT' acpi-test: Warning! APIC binary file mismatc

[PATCH 0/3] ACPI: i386: bump MADT to revision 3

2023-05-15 Thread Eric DeVolder
The following Linux kernel change broke CPU hotplug for MADT revision less than 5. e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC") Discussion on this topic can be located here: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devol...

[PATCH 1/3] ACPI: bios-tables-test.c step 2 (allowed-diff entries)

2023-05-15 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, set up bios-tables-test-allowed-diff.h to exclude the imminent changes to the APIC tables, per step 2. Signed-off-by: Eric DeVolder --- tests/qtest/bios-tables-test-allowed-diff.h | 4 1 file changed, 4 insertions(+) diff --git a/

[PATCH 2/3] ACPI: i386: bump to MADT to revision 3

2023-05-15 Thread Eric DeVolder
Currently i386 QEMU generates MADT revision 3, and reports MADT revision 1. Set .revision to 3 to match reality. Link: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora cle.com/T/#t Signed-off-by: Eric DeVolder --- hw/i386/acpi-common.c | 2 +- 1 file changed, 1 insertio

Re: [PULL 00/11] Migration 20230515 patches

2023-05-15 Thread Richard Henderson
https://gitlab.com/juan.quintela/qemu.git tags/migration-20230515-pull-request for you to fetch changes up to 6da835d42a2163b43578ae745bc613b06dd5d23c: qemu-file: Remove total from qemu_file_total_transferred_*() (2023-05-15 13:4

Re: [PATCH v4 00/11] *** Add allwinner r40 support ***

2023-05-15 Thread Niek Linnenbank
Hi Qianfan, Thanks for sending the v4. I've reviewed all patches and replied to each individual patch. Great work so far! One thing I wanted to mention is that when you receive a 'Reviewed-by:' or 'Tested-by:' line from a reviewer, please feel free to include it in the commit message on the next

Re: [PATCH v4 11/11] docs: system: arm: Introduce bananapi_m2u

2023-05-15 Thread Niek Linnenbank
On Wed, May 10, 2023 at 12:31 PM wrote: > From: qianfan Zhao > > Add documents for Banana Pi M2U > > Signed-off-by: qianfan Zhao > Reviewed-by: Niek Linnenbank > --- > docs/system/arm/bananapi_m2u.rst | 138 +++ > 1 file changed, 138 insertions(+) > create mode

Re: [PATCH v4 10/11] tests: avocado: boot_linux_console: Add test case for bpim2u

2023-05-15 Thread Niek Linnenbank
On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > Add test case for booting from initrd and sd card. > To make the commit message more complete and reflect the full contents, maybe also mention the gmac and openwrt test? Tests look fine to me, and are running OK on my machine:

Re: [PATCH v4 09/11] hw: arm: allwinner-sramc: Add SRAM Controller support for R40

2023-05-15 Thread Niek Linnenbank
On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > Only a few important registers are added, especially the SRAM_VER > register. > > Signed-off-by: qianfan Zhao > Reviewed-by: Niek Linnenbank > --- > hw/arm/Kconfig| 1 + > hw/arm/allwinner-r40.c

[PATCH v2 16/16] migration/multifd: Compute transferred bytes correctly

2023-05-15 Thread Juan Quintela
In the past, we had to put the in the main thread all the operations related with sizes due to qemu_file not beeing thread safe. As now all counters are atomic, we can update the counters just after the do the write. As an aditional bonus, we are able to use the right value for the compression me

[PATCH v2 15/16] migration/rdma: Simplify the function that saves a page

2023-05-15 Thread Juan Quintela
When we sent a page through QEMUFile hooks (RDMA) there are three posiblities: - We are not using RDMA. return RAM_SAVE_CONTROL_DELAYED and control_save_page() returns false to let anything else to proceed. - There is one error but we are using RDMA. Then we return a negative value, control_sa

[PATCH v2 05/16] migration: Move rate_limit_max and rate_limit_used to migration_stats

2023-05-15 Thread Juan Quintela
These way we can make them atomic and use this functions from any place. I also moved all functions that use rate_limit to migration-stats. Functions got renamed, they are not qemu_file anymore. qemu_file_rate_limit -> migration_rate_exceeded qemu_file_set_rate_limit -> migration_rate_set qemu_f

Re: [PATCH v4 08/11] hw: arm: allwinner-r40: Add emac and gmac support

2023-05-15 Thread Niek Linnenbank
Hi Qianfan, On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > R40 has two ethernet controllers named as emac and gmac. The emac is > compatibled with A10, and the GMAC is compatibled with H3. > > Signed-off-by: qianfan Zhao > --- > hw/arm/allwinner-r40.c | 50 ++

[PATCH v2 10/16] migration: Don't abuse qemu_file transferred for RDMA

2023-05-15 Thread Juan Quintela
Just create a variable for it, the same way that multifd does. This way it is safe to use for other thread, etc, etc. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/migration-stats.c | 5 +++-- migration/rdma.c| 22 -- migratio

[PATCH v2 04/16] qemu-file: Account for rate_limit usage on qemu_fflush()

2023-05-15 Thread Juan Quintela
That is the moment we know we have transferred something. Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater --- migration/qemu-file.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 4bc875b452..956bd2a580 10

[PATCH v2 12/16] migration/rdma: Remove QEMUFile parameter when not used

2023-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/rdma.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 074456f9df..416dec00a2 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2027,7 +2027,7 @@ static int qe

[PATCH v2 11/16] migration/RDMA: It is accounting for zero/normal pages in two places

2023-05-15 Thread Juan Quintela
Remove the one in control_save_page(). Signed-off-by: Juan Quintela --- migration/ram.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index a706edecc0..67ed49b387 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1191,13 +1191,6 @@ static bool c

[PATCH v2 07/16] migration: Add a trace for migration_transferred_bytes

2023-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater --- migration/migration-stats.c | 8 ++-- migration/trace-events | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/migration-stats.c b/migration/migration-stats.c index 9bd97caa23..301392d208 1006

[PATCH v2 13/16] migration/rdma: Don't use imaginary transfers

2023-05-15 Thread Juan Quintela
RDMA protocol is completely asynchronous, so in qemu_rdma_save_page() they "invent" that a byte has been transferred. And then they call qemu_file_credit_transfer() and ram_transferred_add() with that byte. Just remove that calls as nothing has been sent. Signed-off-by: Juan Quintela --- migrat

[PATCH v2 03/16] migration: Move setup_time to mig_stats

2023-05-15 Thread Juan Quintela
It is a time that needs to be cleaned each time cancel migration. Once there create migration_time_since() to calculate how time since a time in the past. Signed-off-by: Juan Quintela --- Rename to migration_time_since (cédric) --- migration/migration-stats.h | 13 + migration/migr

[PATCH v2 14/16] migration: Remove unused qemu_file_credit_transfer()

2023-05-15 Thread Juan Quintela
After this change, nothing abuses QEMUFile to account for data transferrefd during migration. Signed-off-by: Juan Quintela --- migration/qemu-file.h | 8 migration/qemu-file.c | 5 - 2 files changed, 13 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index e

[PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-15 Thread Juan Quintela
We forget several places to add to trasferred amount of data. With this fixes I get: qemu_file_transferred() + multifd_bytes == transferred The only place whrer this is not true is during devices sending. But going all through the full tree searching for devices that use QEMUFile directly is

[PATCH v2 08/16] migration: Use migration_transferred_bytes() to calculate rate_limit

2023-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater --- migration/migration-stats.h | 8 +++- migration/migration-stats.c | 7 +-- migration/migration.c | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-

[PATCH v2 06/16] migration: Move migration_total_bytes() to migration-stats.c

2023-05-15 Thread Juan Quintela
Once there rename it to migration_transferred_bytes() and pass a QEMUFile instead of a migration object. Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater --- migration/migration-stats.h | 11 +++ migration/migration-stats.c | 6 ++ migration/migration.c | 13 +++

[PATCH v2 09/16] migration: We don't need the field rate_limit_used anymore

2023-05-15 Thread Juan Quintela
Since previous commit, we calculate how much data we have send with migration_transferred_bytes() so no need to maintain this counter and remember to always update it. Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater --- migration/migration-stats.h | 14 -- migration/migra

[PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

2023-05-15 Thread Juan Quintela
Define and use RATE_LIMIT_MAX instead. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 6 ++ migration/migration.c | 4 ++-- migration/qemu-file.c | 6 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/migration/migration-stats.h b/migration/mi

[PATCH v2 00/16] Migration: More migration atomic counters

2023-05-15 Thread Juan Quintela
Hi In this v2 series: - More documentation here and there. - Fix migration_rate_set() to really / XFER_LIMIT_RATIO - All reviewed patches are in Migration PULL request 20230515 - There are later reviewed patches, but that depend on the first ones that are still not reviewed. Please review

[PATCH v3 04/14] nbd: Prepare for 64-bit request effect lengths

2023-05-15 Thread Eric Blake
Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits. Move the request magic number to nbd.h, to live alongside the reply magic number. Convert 'bool structured_reply' into a tri-state enum that will eventually track whether the cli

[PATCH v3 12/14] nbd/client: Request extended headers during negotiation

2023-05-15 Thread Eric Blake
All the pieces are in place for a client to finally request extended headers. Note that we must not request extended headers when qemu-nbd is used to connect to the kernel module (as nbd.ko does not expect them), but there is no harm in all other clients requesting them. Extended headers are not

[PATCH v3 11/14] nbd/client: Accept 64-bit block status chunks

2023-05-15 Thread Eric Blake
Because we use NBD_CMD_FLAG_REQ_ONE with NBD_CMD_BLOCK_STATUS, a client in narrow mode should not be able to provoke a server into sending a block status result larger than the client's 32-bit request. But in extended mode, a 64-bit status request must be able to handle a 64-bit status result, once

[PATCH v3 07/14] nbd/server: Refactor to pass full request around

2023-05-15 Thread Eric Blake
Part of NBD's 64-bit headers extension involves passing the client's requested offset back as part of the reply header (one reason for this change: converting absolute offsets stored in NBD_REPLY_TYPE_OFFSET_DATA to relative offsets within the buffer is easier if the absolute offset of the buffer i

[PATCH v3 10/14] nbd/client: Initial support for extended headers

2023-05-15 Thread Eric Blake
Update the client code to be able to send an extended request, and parse an extended header from the server. Note that since we reject any structured reply with a too-large payload, we can always normalize a valid header back into the compact form, so that the caller need not deal with two branche

[PATCH v3 02/14] nbd/client: Add safety check on chunk payload length

2023-05-15 Thread Eric Blake
Our existing use of structured replies either reads into a qiov capped at 32M (NBD_CMD_READ) or caps allocation to 1000 bytes (see NBD_MAX_MALLOC_PAYLOAD in block/nbd.c). But the existing length checks are rather late; if we encounter a buggy (or malicious) server that sends a super-large payload

[PATCH v3 06/14] nbd/server: Refactor handling of request payload

2023-05-15 Thread Eric Blake
Upcoming additions to support NBD 64-bit effect lengths allow for the possibility to distinguish between payload length (capped at 32M) and effect length (up to 63 bits). Without that extension, only the NBD_CMD_WRITE request has a payload; but with the extension, it makes sense to allow at least

[PATCH v3 09/14] nbd/server: Initial support for extended headers

2023-05-15 Thread Eric Blake
Time to support clients that request extended headers. Now we can finally reach the code added across several previous patches. Even though the NBD spec has been altered to allow us to accept NBD_CMD_READ larger than the max payload size (provided our response is a hole or broken up over more tha

[PATCH v3 01/14] nbd/client: Use smarter assert

2023-05-15 Thread Eric Blake
Assigning strlen() to a uint32_t and then asserting that it isn't too large doesn't catch the case of an input string 4G in length. Thankfully, the incoming strings can never be that large: if the export name or query is reflecting a string the client got from the server, we already guarantee that

Re: [PATCH v4 07/11] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support

2023-05-15 Thread Niek Linnenbank
On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > A64's sd register was similar to H3, and it introduced a new register > named SAMP_DL_REG location at 0x144. The dma descriptor buffer size of > mmc2 is only 8K and the other mmc controllers has 64K. > > Also fix allwinner-r40's mm

[PATCH v3 14/14] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-05-15 Thread Eric Blake
Allow a client to request a subset of negotiated meta contexts. For example, a client may ask to use a single connection to learn about both block status and dirty bitmaps, but where the dirty bitmap queries only need to be performed on a subset of the disk; forcing the server to compute that info

[PATCH v3 08/14] nbd/server: Support 64-bit block status

2023-05-15 Thread Eric Blake
The NBD spec states that if the client negotiates extended headers, the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use NBD_REPLY_TYPE_BLOCK_STATUS_EXT which supports 64-bit lengths, even if the reply does not need more than 32 bits. As of this patch, client->header_style is still ne

[PATCH v3 13/14] nbd/server: Prepare for per-request filtering of BLOCK_STATUS

2023-05-15 Thread Eric Blake
The next commit will add support for the new addition of NBD_CMD_FLAG_PAYLOAD during NBD_CMD_BLOCK_STATUS, where the client can request that the server only return a subset of negotiated contexts, rather than all contexts. To make that task easier, this patch populates the list of contexts to retu

[PATCH v3 03/14] nbd/server: Prepare for alternate-size headers

2023-05-15 Thread Eric Blake
Upstream NBD now documents[1] an extension that supports 64-bit effect lengths in requests. As part of that extension, the size of the reply headers will change in order to permit a 64-bit length in the reply for symmetry[2]. Additionally, where the reply header is currently 16 bytes for simple r

[PATCH v3 00/14] qemu patches for 64-bit NBD extensions

2023-05-15 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2022-11/msg02340.html Since then: - upstream NBD has accepted the extension on a branch; once multiple implementations interoperate based on that spec, it will be promoted to mainline (my plan: qemu with this series, libnbd nearly r

[PATCH v3 05/14] nbd: Add types for extended headers

2023-05-15 Thread Eric Blake
Add the constants and structs necessary for later patches to start implementing the NBD_OPT_EXTENDED_HEADERS extension in both the client and server, matching recent commit e6f3b94a934] in the upstream nbd project. This patch does not change any existing behavior, but merely sets the stage. This

Re: [PATCH v4 06/11] hw/arm/allwinner-r40: add SDRAM controller device

2023-05-15 Thread Niek Linnenbank
On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > Types of memory that the SDRAM controller supports are DDR2/DDR3 > and capacities of up to 2GiB. This commit adds emulation support > of the Allwinner R40 SDRAM controller. > > This driver only support 256M, 512M and 1024M memory n

Re: [PATCH v4 05/11] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU

2023-05-15 Thread Niek Linnenbank
Hi Qianfan, Good idea indeed to turn this driver into a more generic one. If possible, its best to re-use code rather than adding new. On Wed, May 10, 2023 at 12:30 PM wrote: > From: qianfan Zhao > > This patch adds minimal support for AXP-221 PMU and connect it to > bananapi M2U board. > > Si

Re: missing boot rom: is it really a fatal error?

2023-05-15 Thread Michael S. Tsirkin
On Mon, May 15, 2023 at 10:02:43AM -0600, Warner Losh wrote: > > > On Mon, May 8, 2023 at 5:48 AM Michael S. Tsirkin wrote: > > On Mon, May 08, 2023 at 01:42:04PM +0300, Michael Tokarev wrote: > > 08.05.2023 13:28, Michael S. Tsirkin wrote: > > > On Sun, May 07, 2023 at 08:56:23PM +

Re: [PATCH 10/21] migration: Move rate_limit_max and rate_limit_used to migration_stats

2023-05-15 Thread Juan Quintela
Cédric Le Goater wrote: > On 5/15/23 15:09, Juan Quintela wrote: >> Cédric Le Goater wrote: >>> On 5/8/23 15:08, Juan Quintela wrote: This way we can make them atomic and use this functions from any place. I also moved all functions that use rate_limit to migration-stats. Fun

Re: [PATCH v5 27/54] tcg/sparc64: Rename tcg_out_movi_imm32 to tcg_out_movi_u32

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:43, Richard Henderson wrote: > > Emphasize that the constant is unsigned. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/5] loongarch-to-apply queue

2023-05-15 Thread Richard Henderson
gitlab.com/gaosong/qemu.git tags/pull-loongarch-20230515 for you to fetch changes up to 7ef0eb35a4e6961d7e40f03f16ed241c95ae93f9: hw/intc: Add NULL pointer check on LoongArch ipi device (2023-05-15 19:09:33 +0800) pull-loongarc

Re: [PATCH v5 26/54] target/sparc64: Remove tcg_out_movi_s13 case from tcg_out_movi_imm32

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:36, Richard Henderson wrote: > > Shuffle the order in tcg_out_movi_int to check s13 first, and > drop this check from tcg_out_movi_imm32. This might make the > sequence for in_prologue larger, but not with worrying about. "worth" > > Signed-off-by: Richard Henderson >

Re: [PATCH v5 25/54] tcg/sparc64: Rename tcg_out_movi_imm13 to tcg_out_movi_s13

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:36, Richard Henderson wrote: > > Emphasize that the constant is signed. > > Signed-off-by: Richard Henderson > --- > tcg/sparc64/tcg-target.c.inc | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 24/54] tcg/sparc64: Allocate %g2 as a third temporary

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/sparc64/tcg-target.c.inc | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 20/54] tcg/arm: Adjust constraints on qemu_ld/st

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:37, Richard Henderson wrote: > > Always reserve r3 for tlb softmmu lookup. Fix a bug in user-only > ALL_QLDST_REGS, in that r14 is clobbered by the BLNE that leads > to the misaligned trap. Remove r0+r1 from user-only ALL_QLDST_REGS; > I believe these had been reserved

Re: [PATCH v5 09/54] tcg/i386: Add have_atomic16

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:36, Richard Henderson wrote: > > Notice when Intel or AMD have guaranteed that vmovdqa is atomic. > The new variable will also be used in generated code. > > Signed-off-by: Richard Henderson > --- > include/qemu/cpuid.h | 18 ++ > tcg/i386/tcg-targe

Re: [RFC 1/3] ARM: Use normal types

2023-05-15 Thread Juan Quintela
Warner Losh wrote: > On Mon, May 15, 2023 at 10:44 AM Warner Losh wrote: > >> >> >> On Wed, May 10, 2023 at 8:39 AM Juan Quintela wrote: >> >>> Someone has a good reason why this is not a good idea? >>> >>> Signed-off-by: Juan Quintela >>> >> >> Reviewed by: Warner Losh >> >> This has been th

Re: [PATCH] ARM: Use normal types

2023-05-15 Thread Warner Losh
On Thu, May 11, 2023 at 2:45 AM Juan Quintela wrote: > This is the only use of u_int32_t in the whole tree. > > Signed-off-by: Juan Quintela > Reviewed-by: Richard Henderson > Reviewed-by: Warner Losh I'll queue this version if others don't beat me to it. I plan on merging that around June 1

Re: [PATCH v5 07/54] tcg: Add 128-bit guest memory primitives

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of MO_ATOM_* reorg > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] scsi-generic: fix buffer overflow on block limits inquiry

2023-05-15 Thread Paolo Bonzini
Il lun 15 mag 2023, 16:49 Théo Maillart ha scritto: > From my perspective r->buflen can be more than 16 bytes, The Block limits > VPD > page length is 0x3c (paragraph 5.4.5 page 475 from SCSI Commands Reference > Manual, Rev. J). > Absolutely you're right. What a mess. :) Paolo > On Mon, May

Re: [PATCH v5 03/54] accel/tcg: Honor atomicity of stores

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:49, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of MO_ATOM_* reorg Reviewed-by: Peter Maydell thanks -- PMM

Re: [RFC 1/3] ARM: Use normal types

2023-05-15 Thread Warner Losh
On Mon, May 15, 2023 at 10:44 AM Warner Losh wrote: > > > On Wed, May 10, 2023 at 8:39 AM Juan Quintela wrote: > >> Someone has a good reason why this is not a good idea? >> >> Signed-off-by: Juan Quintela >> > > Reviewed by: Warner Losh > > This has been that way the bsd-user sources were re

Re: [RFC 1/3] ARM: Use normal types

2023-05-15 Thread Warner Losh
On Wed, May 10, 2023 at 8:39 AM Juan Quintela wrote: > Someone has a good reason why this is not a good idea? > > Signed-off-by: Juan Quintela > Reviewed by: Warner Losh This has been that way the bsd-user sources were reorganized in 2015. I can find no good reason in the FreeBSD sources to

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: > > Create ldst_atomicity.c.inc. > > Not required for user-only code loads, because we've ensured that > the page is read-only before beginning to translate code. > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of MO_ATOM

Re: [PATCH v4 3/8] migration: converts socket backend to accept MigrateAddress struct

2023-05-15 Thread Daniel P . Berrangé
On Mon, May 15, 2023 at 09:58:37PM +0530, Het Gala wrote: > > On 15/05/23 8:46 pm, Het Gala wrote: > > > > On 15/05/23 8:16 pm, Juan Quintela wrote: > > > Het Gala wrote: > > > > On 15/05/23 3:47 pm, Daniel P. Berrangé wrote: > > > > > On Fri, May 12, 2023 at 02:32:35PM +, Het Gala wrote: >

Re: [PATCH 32/84] tcg: Add tlb_dyn_max_bits to TCGContext

2023-05-15 Thread Anton Johansson via
On 5/3/23 09:22, Richard Henderson wrote: Disconnect guest tlb parameters from TCG compilation. Signed-off-by: Richard Henderson --- include/tcg/tcg.h| 1 + accel/tcg/translate-all.c| 1 + tcg/aarch64/tcg-target.c.inc | 2 +- tcg/i386/tcg-target.c.inc| 2 +- 4 files

Re: [PATCH v5 01/54] include/exec/memop: Add MO_ATOM_*

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:34, Richard Henderson wrote: > > This field may be used to describe the precise atomicity requirements > of the guest, which may then be used to constrain the methods by which > it may be emulated by the host. > @@ -2330,17 +2339,23 @@ static void tcg_dump_ops(TCGContex

Re: [PATCH v4 3/8] migration: converts socket backend to accept MigrateAddress struct

2023-05-15 Thread Het Gala
On 15/05/23 8:46 pm, Het Gala wrote: On 15/05/23 8:16 pm, Juan Quintela wrote: Het Gala wrote: On 15/05/23 3:47 pm, Daniel P. Berrangé wrote: On Fri, May 12, 2023 at 02:32:35PM +, Het Gala wrote: Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol

Re: [PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver

2023-05-15 Thread Red Hat Product Security
Hello! INC2534320 ([PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver) has been closed. Opened for: yuval.shaia...@gmail.com Followers: qemu-devel@nongnu.org, soulchen8...@gmail.com, Mauro Matteo Cascella, qemu-secur...@nongnu.org, yuval.shaia...@gmail.com, marcel.apfelb...@

[PATCH v3 0/3] docs/interop: Convert QMP related txt docs to rst

2023-05-15 Thread Peter Maydell
This patchset deals with a couple of the old .txt files that are still hanging around in docs/interop: qmp-spec.txt and qmp-intro.txt. Patch 1 converts qmp-spec to rST and integrates it into the manual. Patch 2 takes the only interesting parts of qmp-intro.txt (the example command lines) and puts t

[PATCH v3 2/3] docs/interop/qmp-spec: Update error description for parsing errors

2023-05-15 Thread Peter Maydell
The description text for a parsing error has changed since the spec doc was first written; update the example in the docs. Suggested-by: Markus Armbruster Signed-off-by: Peter Maydell --- docs/interop/qmp-spec.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/interop/

[PATCH v3 3/3] docs/interop: Delete qmp-intro.txt

2023-05-15 Thread Peter Maydell
qmp-intro.txt is quite small and provides very little information that isn't already in the documentation elsewhere. Fold the example command lines into qemu-options.hx, and delete the now-unneeded plain text document. While we're touching the qemu-options.hx documentation text, wordsmith it a li

[PATCH v3 1/3] docs/interop: Convert qmp-spec.txt to rST

2023-05-15 Thread Peter Maydell
Convert the qmp-spec.txt document to restructuredText. Notable points about the conversion: * numbers at the start of section headings are removed, to match the style of the rest of the manual * cross-references to other sections or documents are hyperlinked * various formatting tweaks (notab

Re: [PATCH 1/8] block: Call .bdrv_co_create(_opts) unlocked

2023-05-15 Thread Kevin Wolf
Am 12.05.2023 um 18:12 hat Eric Blake geschrieben: > > On Wed, May 10, 2023 at 10:35:54PM +0200, Kevin Wolf wrote: > > > > These are functions that modify the graph, so they must be able to take > > a writer lock. This is impossible if they already hold the reader lock. > > If they need a reader

Re: [PATCH v2 1/2] docs/interop: Convert qmp-spec.txt to rST

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 13:36, Markus Armbruster wrote: > > Peter Maydell writes: > > > Convert the qmp-spec.txt document to restructuredText. > > Notable points about the conversion: > > * numbers at the start of section headings are removed, to match > >the style of the rest of the manual >

Re: [RFC] cxl: Multi-headed device design

2023-05-15 Thread Jonathan Cameron via
On Tue, 21 Mar 2023 21:50:33 -0400 Gregory Price wrote: Hi Gregory, Sorry I took so long to reply to this. Busy month... Vince presented at LSF-MM so I feel it's fair game to CC him kernel patches and he may be able to point you in right direction for a few things in this mail. > Originally I

Re: [PATCH trivial for-8.0] hw/virtio/virtio-qmp.c: spelling: suppoted

2023-05-15 Thread Michael Tokarev
01.04.2023 11:51, Michael Tokarev wrote: Fixes: f3034ad71fcd0a6a58bc37830f182b307f089159 Signed-off-by: Michael Tokarev Reviewed-by: Stefan Weil --- hw/virtio/virtio-qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch were previously sent at 5 Nov 2022, now the code moved

Re: [PATCH 1/1] ui/gtk: Launching GTK UI with OpenGL on causes the refreshrate update to not run

2023-05-15 Thread Michael Tokarev
06.12.2020 13:43, Nikola Pavlica wrote: I've discussed this issue back January and September. But it still occurs on my machine, despite the two patches. This time, the issue is that the UI refresh rate doesn't get updated when I launch QEMU with gl=on. My fix for this issue is to move the code f

Re: [PATCH qemu] timer/i8254: Fix one shot PIT mode

2023-05-15 Thread Michael Tokarev
26.02.2023 04:58, Damien Zammit wrote: Currently, the one-shot (mode 1) PIT expires far too quickly, due to the output being set under the wrong logic. This change fixes the one-shot PIT mode to behave similarly to mode 0. TESTED: using the one-shot PIT mode to calibrate a local apic timer. Ha

  1   2   3   4   5   >