Hi Qianfan, Thanks for sending the v4. I've reviewed all patches and replied to each individual patch.
Great work so far! One thing I wanted to mention is that when you receive a 'Reviewed-by:' or 'Tested-by:' line from a reviewer, please feel free to include it in the commit message on the next version of that patch. This helps you and reviewers to keep track on what has been reviewed and what not. For more details on this and the review process, also see this page: https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review Kind regards, Niek On Wed, May 10, 2023 at 12:30 PM <qianfangui...@163.com> wrote: > From: qianfan Zhao <qianfangui...@163.com> > > > *** history *** > > # v1: 2023-03-21 > > The first version which add allwinner-r40 support, supported features: > > + ccu > + dram controller > + uart > + i2c and pmic(axp221) > + sdcard > + emac/gmac > > Also provide a test case under avocado, running quickly test: > > $ AVOCADO_ALLOW_LARGE_STORAGE=yes tests/venv/bin/avocado \ > --verbose --show=app,console run -t machine:bpim2u \ > ../tests/avocado/boot_linux_console.py > > # v2: 2023-03-28 > > 1. Fix the waring and error reported by checkpatch.pl > 2. Remove the other i2c controllers except that i2c0 > 3. Use an array to register mmc and uart devices > 4. Rename axp209 to axp22x and add axp221 support > 5. Add a basic SRAM controller > > # v3: 2023-04-18 > > 1. Update some commit messages > 2. Squash those two commit about sdcard > hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support > hw: arm: allwinner-r40: Fix the mmc controller's type > > # v4: 2023-05-10 > > 1. Rebase to master > > qianfan Zhao (11): > hw: arm: Add bananapi M2-Ultra and allwinner-r40 support > hw/arm/allwinner-r40: add Clock Control Unit > hw: allwinner-r40: Complete uart devices > hw: arm: allwinner-r40: Add i2c0 device > hw/misc: Rename axp209 to axp22x and add support AXP221 PMU > hw/arm/allwinner-r40: add SDRAM controller device > hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support > hw: arm: allwinner-r40: Add emac and gmac support > hw: arm: allwinner-sramc: Add SRAM Controller support for R40 > tests: avocado: boot_linux_console: Add test case for bpim2u > docs: system: arm: Introduce bananapi_m2u > > docs/system/arm/bananapi_m2u.rst | 138 +++++++ > hw/arm/Kconfig | 14 +- > hw/arm/allwinner-r40.c | 526 ++++++++++++++++++++++++++ > hw/arm/bananapi_m2u.c | 145 +++++++ > hw/arm/meson.build | 1 + > hw/misc/Kconfig | 5 +- > hw/misc/allwinner-r40-ccu.c | 209 ++++++++++ > hw/misc/allwinner-r40-dramc.c | 513 +++++++++++++++++++++++++ > hw/misc/allwinner-sramc.c | 184 +++++++++ > hw/misc/axp209.c | 238 ------------ > hw/misc/axp2xx.c | 283 ++++++++++++++ > hw/misc/meson.build | 5 +- > hw/misc/trace-events | 26 +- > hw/sd/allwinner-sdhost.c | 70 +++- > include/hw/arm/allwinner-r40.h | 143 +++++++ > include/hw/misc/allwinner-r40-ccu.h | 65 ++++ > include/hw/misc/allwinner-r40-dramc.h | 108 ++++++ > include/hw/misc/allwinner-sramc.h | 69 ++++ > include/hw/sd/allwinner-sdhost.h | 9 + > tests/avocado/boot_linux_console.py | 176 +++++++++ > 20 files changed, 2679 insertions(+), 248 deletions(-) > create mode 100644 docs/system/arm/bananapi_m2u.rst > create mode 100644 hw/arm/allwinner-r40.c > create mode 100644 hw/arm/bananapi_m2u.c > create mode 100644 hw/misc/allwinner-r40-ccu.c > create mode 100644 hw/misc/allwinner-r40-dramc.c > create mode 100644 hw/misc/allwinner-sramc.c > delete mode 100644 hw/misc/axp209.c > create mode 100644 hw/misc/axp2xx.c > create mode 100644 include/hw/arm/allwinner-r40.h > create mode 100644 include/hw/misc/allwinner-r40-ccu.h > create mode 100644 include/hw/misc/allwinner-r40-dramc.h > create mode 100644 include/hw/misc/allwinner-sramc.h > > -- > 2.25.1 > > -- Niek Linnenbank
