On Mon, Mar 20, 2023 at 8:27 PM John Snow <js...@redhat.com> wrote: > > On Mon, Mar 20, 2023 at 8:20 AM Vladimir Sementsov-Ogievskiy > <vsement...@yandex-team.ru> wrote: > > > > On 20.03.23 13:54, Daniel P. Berrangé wrote: > > > The default message recv limit in asyncio is smaller than our needs, so > > > when opening connections we override it. This was done when opening a > > > connection using a socket address, but was missed when using a > > > pre-opened socket file descriptor. > > > > > > This latent bug was exposed when the QEMUMachine class was enhanced to > > > use socketpair() when no socket address was passed by: > > > > > > commit bd4c0ef409140bd1be393407c04005ac077d4574 > > > Author: Marc-André Lureau<marcandre.lur...@redhat.com> > > > Date: Wed Jan 11 12:01:01 2023 +0400 > > > > > > python/qemu/machine: use socketpair() for QMP by default > > > > > > Signed-off-by: Daniel P. Berrangé<berra...@redhat.com> > > > > Tested-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> > > > > Thanks! > > > > -- > > Best regards, > > Vladimir > > > > Thanks x3. Will stage in both places. >
... Realizing I let the two codebases diverge a bit more than I had meant to allow, and the "open with socket" rewrite I made never got brought back to qemu.git, tch. I believe this bug only exists in qemu.git because of that. I need to backport my changes to qemu.git and ensure that there isn't a problem with the revised code as it exists in qemu.qmp. I'll have to fix that *before* I drop qemu.qmp from the qemu.git repo, which I am hoping will be soon after Paolo takes the new Python patches that create a venv during configure time. --js
