Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

On Mon, Jul 13, 2020 at 10:49:07AM +0200, Igor Mammedov wrote: > On Mon, 29 Jun 2020 16:09:37 +0200 > Andrew Jones wrote: > > > The flash device is exclusively for the host-controlled firmware, so > > we should not expose it to the OS. Exposing it risks the OS messing > > with it, which could bre

Re: [PATCH v2 08/11] docs/devel: fix grammar in multi-thread-tcg

On 13/07/2020 22.04, Alex Bennée wrote: > Review comment came just too late ;-) > > Signed-off-by: Alex Bennée > --- > docs/devel/multi-thread-tcg.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/multi-thread-tcg.rst b/docs/devel/multi-thread-tcg.rst > ind

Re: [PATCH v2 05/11] tests/plugins: don't unconditionally add -Wpsabi

On 13/07/2020 22.04, Alex Bennée wrote: > Not all compilers support the -Wpsabi (clang-9 in my case). To handle > this gracefully we pare back the shared build machinery so the > Makefile is relatively "standalone". We still take advantage of > config-host.mak as configure has done a bunch of probi

[PULL 1/4] qga-win: Fix QGA VSS Provider service stop failure

From: Basil Salman On one hand "guest-fsfreeze-freeze" command, "COM+ System Application service" is stopped, on the other hand "guest-fsfreeze-thaw" stops QGA VSS Provider service from "COM+ Application Admin Catalog". Invoking a series of freeze and thaw commands may result in QGA failing to

[PULL 4/4] qga: Use qemu_get_host_name() instead of g_get_host_name()

From: Michal Privoznik Problem with g_get_host_name() is that on the first call it saves the hostname into a global variable and from then on, every subsequent call returns the saved hostname. Even if the hostname changes. This doesn't play nicely with guest agent, because if the hostname is acqu

[PULL 0/4] qemu-ga patch queue for hard-freeze

The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 16:58:44 +0100) are available in the Git repository at: git://github.com/mdroth/qemu.git tags/qga

[PULL 3/4] util: Introduce qemu_get_host_name()

From: Michal Privoznik This function offers operating system agnostic way to fetch host name. It is implemented for both POSIX-like and Windows systems. Signed-off-by: Michal Privoznik Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Cc: qemu-sta...@nongnu.org Signed-off-by

[PULL 2/4] qga: fix assert regression on guest-shutdown

From: Marc-André Lureau Since commit 781f2b3d1e ("qga: process_event() simplification"), send_response() is called unconditionally, but will assert when "rsp" is NULL. This may happen with QCO_NO_SUCCESS_RESP commands, such as "guest-shutdown". Fixes: 781f2b3d1e5ef389b44016a897fd55e7a780bf35 Cc:

Re: [RFC 05/65] target/riscv: remove vsll.vi, vsrl.vi, vsra.vi insns from using gvec

On Tue, Jul 14, 2020 at 11:35 AM LIU Zhiwei wrote: > > > On 2020/7/14 10:59, Frank Chang wrote: > > On Sat, Jul 11, 2020 at 12:27 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: >> > From: Frank Chang >> > >> > vsll.vi, vsrl.vi

Re: [PATCH 1/1] python: add check-python target

On Mon, Jul 13, 2020 at 09:30:26PM -0400, John Snow wrote: > Move pylintrc and flake8 up to the root of the python folder where > they're the most useful. Add a requirements.cqa.txt file to house > the requirements necessary to build a venv sufficient for running > code quality analysis on the pyth

[Bug 1686980] Re: qemu is very slow when adding 16, 384 virtio-scsi drives

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1686980 Title: qemu is ver

Re: [PATCH v5 12/12] python/machine.py: change default wait timeout to 3 seconds

On Fri, Jul 10, 2020 at 01:06:49AM -0400, John Snow wrote: > Machine.wait() does not appear to be used except in the acceptance tests, > and an infinite timeout by default in a test suite is not the most helpful. > > Change it to 3 seconds, like the default shutdown timeout. > > Signed-off-by: Jo

Re: [PATCH v5 11/12] python/machine.py: re-add sigkill warning suppression

On Fri, Jul 10, 2020 at 01:06:48AM -0400, John Snow wrote: > If the user kills QEMU on purpose, we don't need to warn them about that > having happened: they know already. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) >

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: > This is done primarily to avoid the 'bare except' pattern, which > suppresses all exceptions during shutdown and can obscure errors. > > Replace this with a pattern that isolates the different kind of shutdown > paradigms (_hard_shutdown

Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

On Fri, Jul 10, 2020 at 01:06:46AM -0400, John Snow wrote: > cubieboard does not have a functioning reboot, it halts and QEMU does > not exit. > > vm.shutdown() is modified in a forthcoming patch that makes it less tolerant > of race conditions on shutdown; tests should consciously decide to WAIT

Re: [PATCH v5 08/12] tests/acceptance: wait() instead of shutdown() where appropriate

On Fri, Jul 10, 2020 at 01:06:45AM -0400, John Snow wrote: > When issuing 'reboot' to a VM with the no-reboot option, that VM will > exit. When then issuing a shutdown command, the cleanup may race. > > Add calls to vm.wait() which will gracefully mark the VM as having > exited. Subsequent vm.shut

Re: [RFC 05/65] target/riscv: remove vsll.vi, vsrl.vi, vsra.vi insns from using gvec

On 2020/7/14 10:59, Frank Chang wrote: On Sat, Jul 11, 2020 at 12:27 AM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: Frank Chang mailto:frank.ch...@sifive.com>> > >

Re: [PATCH v2 4/9] tests/acceptance/boot_linux: Expand SD card image to power of 2

On Mon, Jul 13, 2020 at 08:32:04PM +0200, Philippe Mathieu-Daudé wrote: > In few commits we won't allow SD card images with invalid size > (not aligned to a power of 2). Prepare the tests: add the > pow2ceil() and image_pow2ceil_expand() methods and resize the > images (expanding) of the tests usin

Re: [PATCH v2 3/9] tests/acceptance/boot_linux: Tag tests using a SD card with 'device:sd'

On Mon, Jul 13, 2020 at 08:32:03PM +0200, Philippe Mathieu-Daudé wrote: > Avocado tags are handy to automatically select tests matching > the tags. Since these tests use a SD card, tag them. > > We can run all the tests using a SD card at once with: > > $ avocado --show=app run -t u-boot tests/

Re: [PATCH v5 07/12] python/machine.py: Make wait() call shutdown()

On Fri, Jul 10, 2020 at 01:06:44AM -0400, John Snow wrote: > At this point, shutdown(has_quit=True) and wait() do essentially the > same thing; they perform cleanup without actually instructing QEMU to > quit. > > Define one in terms of the other. > > Signed-off-by: John Snow > --- > python/qemu

Re: [RFC 05/65] target/riscv: remove vsll.vi, vsrl.vi, vsra.vi insns from using gvec

On Sat, Jul 11, 2020 at 12:27 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang > > > > vsll.vi, vsrl.vi, vsra.vi cannot use shli gvec as it requires the > > shift immediate value to be within the range: [0.. SEW

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater wrote: > > On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > > This allows these NPCM7xx-based boards to boot from a flash image, e.g. > > one built with OpenBMC. For example like this: > > > > IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc > >

Re: [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown()

On Fri, Jul 10, 2020 at 01:06:43AM -0400, John Snow wrote: > Three seconds is hardcoded. Use it as a default parameter instead, and use > that > value for both waits that may occur in the function. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 8 +--- > 1 file changed, 5 ins

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: > If the VM is not launched, don't try to shut it down. As a change, > _post_shutdown now unconditionally also calls _early_cleanup in order to > offer comprehensive object cleanup in failure cases. > > As a courtesy, treat it as a NOP ins

Re: [PATCH v5 09/11] hw/ssi: NPCM7xx Flash Interface Unit device model

On Mon, Jul 13, 2020 at 10:39 AM Philippe Mathieu-Daudé wrote: > > On 7/12/20 7:42 AM, Havard Skinnemoen wrote: > > On Thu, Jul 9, 2020 at 10:00 AM Philippe Mathieu-Daudé > > wrote: > >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > >>> This implements a device model for the NPCM7xx SPI flash co

[PATCH 0/1] python: add make check-python target

Quick try at getting the code quality analysis tools into a makefile target. Based-on: 20200710052220.3306-1-js...@redhat.com Based-on: 20200710050649.32434-1-js...@redhat.com There are other python patches pulled since that cause new errors to show up, so this definitely can't be enforced just y

[PATCH 1/1] python: add check-python target

Move pylintrc and flake8 up to the root of the python folder where they're the most useful. Add a requirements.cqa.txt file to house the requirements necessary to build a venv sufficient for running code quality analysis on the python folder. Add a makefile that will build the venv and run the test

Re: [PATCH v2 2/2] hw/riscv: sifive_u: Provide a reliable way for bootloader to detect whether it is running in QEMU

On Sun, Jul 12, 2020 at 6:16 PM Bin Meng wrote: > > Hi Alistair, > > On Sun, Jul 12, 2020 at 12:04 AM Alistair Francis > wrote: > > > > On Thu, Jul 9, 2020 at 5:50 PM Bin Meng wrote: > > > > > > Hi Palmer, > > > > > > On Fri, Jul 10, 2020 at 8:45 AM Palmer Dabbelt > > > wrote: > > > > > > > >

[PULL 14/15] tcg/riscv: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Message-Id: <1594600421-22942-1-git-send-email-wang.y...@zte.com.

[PULL 12/15] hw/char: Convert the Ibex UART to use the qdev Clock model

Conver the Ibex UART to use the recently added qdev-clock functions. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-id: b0136fad870a29049959ec161c1217b967d7e19d.1594332223.git.alistair.fran...@wdc.com Message-Id: --- include/hw/char/ibex_uart.h | 3 +++ hw/char/

[PULL 10/15] target/riscv: fix return value of do_opivx_widen()

From: Frank Chang do_opivx_widen() should return false if check function returns false. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Message-Id: <20200710104920.13550-4-frank.ch...@sifive.com> Signed-off-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.inc.c | 2 +- 1

[PULL 08/15] target/riscv: fix rsub gvec tcg_assert_listed_vecop assertion

From: Frank Chang gvec should provide vecop_list to avoid: "tcg_tcg_assert_listed_vecop: code should not be reached bug" assertion. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Message-Id: <20200710104920.13550-2-frank.ch...@sifive.com> Signed-off-by: Alistair Francis --- target

[PULL 09/15] target/riscv: correct the gvec IR called in gen_vec_rsub16_i64()

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Message-Id: <20200710104920.13550-3-frank.ch...@sifive.com> Signed-off-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/

Re: [PULL 00/15] riscv-to-apply queue

On Mon, Jul 13, 2020 at 5:43 PM Alistair Francis wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 > 16:58:44 +0100)

[PULL 07/15] hw/riscv: Modify MROM size to end at 0x10000

From: Bin Meng At present the size of Mask ROM for sifive_u / spike / virt machines is set to 0x11000, which ends at an unusual address. This changes the size to 0xf000 so that it ends at 0x1. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1594289144-24723-1-git-s

[PULL 03/15] riscv: Unify Qemu's reset vector code path

From: Atish Patra Currently, all riscv machines except sifive_u have identical reset vector code implementations with memory addresses being different for all machines. They can be easily combined into a single function in common code. Move it to common function and let all the machines use the

[PULL 15/15] target/riscv: Fix pmp NA4 implementation

From: Alexandre Mergnat The end address calculation for NA4 mode is wrong because the address used isn't shifted. It doesn't watch 4 bytes but a huge range because the end address calculation is wrong. The solution is to use the shifted address calculated for start address variable. Modificati

Re: [PATCH v5 04/11] hw/arm: Add NPCM730 and NPCM750 SoC models

On Mon, Jul 13, 2020 at 8:02 AM Cédric Le Goater wrote: > > On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > > Management Controllers in servers. While the family includes four SoCs, > > this patch implements limited support for two o

[PULL 11/15] target/riscv: fix vill bit index in vtype register

From: Frank Chang vill bit is at vtype[XLEN-1]. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Message-Id: <20200710104920.13550-5-frank.ch...@sifive.com> Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tar

[PULL 13/15] hw/char: Convert the Ibex UART to use the registerfields API

Signed-off-by: Alistair Francis Message-id: 06372c9cdeec715077899e71c858d9f0a2a3395b.1594332223.git.alistair.fran...@wdc.com Message-Id: <06372c9cdeec715077899e71c858d9f0a2a3395b.1594332223.git.alistair.fran...@wdc.com> --- include/hw/char/ibex_uart.h | 76 ++--- hw/char/ibex_u

[PULL 05/15] riscv: Add opensbi firmware dynamic support

From: Atish Patra OpenSBI is the default firmware in Qemu and has various firmware loading options. Currently, qemu loader uses fw_jump which has a compile time pre-defined address where fdt & kernel image must reside. This puts a constraint on image size of the Linux kernel depending on the fdt

[PULL 01/15] MAINTAINERS: Add an entry for OpenSBI firmware

From: Bin Meng List me as the maintainer for OpenSBI firmware related files. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1593177220-28143-1-git-send-email-bmeng...@gmail.com> Signed-off-by: Alistair Francis --- MAINTAINERS | 7 +++ 1 file changed, 7 insertion

[PULL 00/15] riscv-to-apply queue

The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 16:58:44 +0100) are available in the Git repository at: g...@github.com:alistair23/qemu.git tags/

[PULL 02/15] hw/riscv: virt: Sort the SoC memmap table entries

From: Bin Meng Adjust the PCIe memory maps to follow the order. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-Id: <1593746511-19517-1-git-send-email-bmeng...@gmail.com> Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PULL 06/15] RISC-V: Support 64 bit start address

From: Atish Patra Even though the start address in ROM code is declared as a 64 bit address for RV64, it can't be used as upper bits are set to zero in ROM code. Update the ROM code correctly to reflect the 64bit value. Signed-off-by: Atish Patra Reviewed-by: Bin Meng Tested-by: Bin Meng Mes

[PULL 04/15] RISC-V: Copy the fdt in dram instead of ROM

From: Atish Patra Currently, the fdt is copied to the ROM after the reset vector. The firmware has to copy it to DRAM. Instead of this, directly copy the device tree to a pre-computed dram address. The device tree load address should be as far as possible from kernel and initrd images. That's why

Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote: > > > > On Jul 13, 2020, at 12:14 AM, David Gibson > > wrote: > > > > On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: > >> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > >> > >> Signed-off-by: Lijun Pan

device compatibility interface for live migration with assigned devices

hi folks, we are defining a device migration compatibility interface that helps upper layer stack like openstack/ovirt/libvirt to check if two devices are live migration compatible. The "devices" here could be MDEVs, physical devices, or hybrid of the two. e.g. we could use it to check whether - a

Re: cve patch wanted

Quoting Philippe Mathieu-Daudé (2020-07-13 03:16:37) > Hi, > > On 7/11/20 2:28 PM, 林奕帆 wrote: > > Hello > >    I am a student from Fudan University in China. I am doing research on > > CVE patch recently. But i can not find the PATCH COMMIT of > > CVE-2019-12247 cve-2019-12155 cve-2019-6778.Can yo

Re: [PATCH] hw/net/can: Add missing fallthrough statements

Hello Laurent and others, On Monday 06 of July 2020 18:35:50 Laurent Vivier wrote: > Le 30/06/2020 à 09:55, Thomas Huth a écrit : > > Add fallthrough annotations to be able to compile the code without > > warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking > > at the code, it seems l

Re: [PATCH v2 10/11] plugins: add API to return a name for a IO device

On 7/13/20 1:04 PM, Alex Bennée wrote: > This may well end up being anonymous but it should always be unique. > > Signed-off-by: Alex Bennée > [r-b provisional given change to g_intern_string] > Reviewed-by: Clement Deschamps > Reviewed-by: Emilio G. Cota > > --- > v3 > - return a non-freeab

Re: [PATCH v2 08/11] docs/devel: fix grammar in multi-thread-tcg

On 7/13/20 1:04 PM, Alex Bennée wrote: > Review comment came just too late ;-) > > Signed-off-by: Alex Bennée > --- > docs/devel/multi-thread-tcg.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 06/11] cputlb: ensure we save the IOTLB data in case of reset

On 7/13/20 1:04 PM, Alex Bennée wrote: > Any write to a device might cause a re-arrangement of memory > triggering a TLB flush and potential re-size of the TLB invalidating > previous entries. This would cause users of qemu_plugin_get_hwaddr() > to see the warning: > > invalid use of qemu_plugin

Re: [RFC PATCH 5/8] fpu/softfloat: define brain floating-point types

On 7/13/20 1:22 PM, LIU Zhiwei wrote: > Should we just make bfloat16 different or remove all other references? If you have time to do a global remove, I would be grateful. Otherwise, let's just make bfloat16 different. >> The word "brain" is better translated as "neural-network" in english. > D

[PATCH v10 01/10] qcow2: Fix capitalization of header extension constant.

Make the capitalization of the hexadecimal numbers consistent for the QCOW2 header extension constants in docs/interop/qcow2.txt. Suggested-by: Eric Blake Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 +- docs/interop/qcow2.txt | 2 +-

[PATCH v10 07/10] qcow2_format.py: Dump bitmap table serialized entries

Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typeoffset size 0 serialized 4718592 65536 1 serialized 4294967296 65536 2 se

[PATCH v10 05/10] qcow2_format.py: Dump bitmap directory information

Read and dump entries from the bitmap directory of QCOW2 image. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 bitmap_table_offset 0xf bitmap_table_size 1 flags 0x2 (['auto']) type 1

[PATCH v10 03/10] qcow2_format.py: change Qcow2BitmapExt initialization method

There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to 2 to support a scattered reading in the initi

[PATCH v10 02/10] qcow2_format.py: make printable data an extension class member

Let us differ binary data type from string one for the extension data variable and keep the string as the QcowHeaderExtension class member. Signed-off-by: Andrey Shinkevich Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 14 ---

[PATCH v10 04/10] qcow2_format.py: dump bitmap flags in human readable way.

Introduce the class BitmapFlags that parses a bitmap flags mask. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 16 1 file changed, 16 insertions(+) diff --git a/tests/qemu-iotests/qcow2_format.py b/tests/q

[PATCH v10 00/10] iotests: Dump QCOW2 dirty bitmaps metadata

Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py. v10: 01: The modification of the 291.out was removed. 02: Qcow2BitmapExt modified to take control over file cursor position while reading the bitmap extension data from the file (suggested by Vladimir). 03: The

[PATCH v10 06/10] qcow2_format.py: pass cluster size to substructures

The cluster size of an image is the QcowHeader class member and may be obtained by dependent extension structures such as Qcow2BitmapExt for further bitmap table details print. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 18 +++--- 1 file changed, 11 ins

[PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2.py| 19 +++

[PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

As __dict__ is being extended with class members we do not want to print, make a light copy of the initial __dict__ and extend the copy by adding lists we have to print in the JSON output. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 4 1 file changed, 4 inserti

[PATCH v10 10/10] qcow2_format.py: support dumping metadata in JSON format

Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" }, { "name": "Bitmaps", "magi

[PATCH 3/3] hw/arm/virt: Disable memory hotplug when MTE is enabled

When MTE is enabled, tag memory must exist for all RAM. It might be possible to simultaneously hot plug tag memory alongside the corresponding normal memory, but for now just disable hotplug. Signed-off-by: Richard Henderson --- hw/arm/virt.c | 5 + 1 file changed, 5 insertions(+) diff --g

[PATCH 2/3] hw/arm/virt: Error for MTE enabled with KVM

While we expect KVM to support MTE at some future point, it certainly won't be ready in time for qemu 5.1. Signed-off-by: Richard Henderson --- hw/arm/virt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5866c4ce20..a7f3d442db 100644 --- a/hw/arm/v

[PATCH for-5.1 0/3] target/arm: MTE improvements

Since MTE is new, and guest support for MTE is still under development, let's disable it by default. Peter mentioned memory hotplug on IRC as something that would break MTE's assumptions. By putting the enable flag on the machine it's much easier to control. For 5.1, we won't have kvm support, s

[PATCH 1/3] hw/arm/virt: Enable MTE via a machine property

Control this cpu feature via a machine property, much as we do with secure=on, since both require specialized support in the machine setup to be functional. Default MTE to off, since this feature implies extra overhead. Signed-off-by: Richard Henderson --- include/hw/arm/virt.h | 1 + hw/arm/v

Re: [PATCH] vfio: fix use-after-free in display

On Mon, 13 Jul 2020 14:45:20 +0200 Gerd Hoffmann wrote: > Calling ramfb_display_update() might replace the DisplaySurface with the > boot display, which in turn will free the currently active > DisplaySurface. > > So clear our DisplaySurface pinter (dpy->region.surface pointer) to (a)

Re: [PATCH v2 7/9] hw/sd/sdcard: Do not allow invalid SD card sizes

On Mon, 13 Jul 2020 at 19:32, Philippe Mathieu-Daudé wrote: > > QEMU allows to create SD card with unrealistic sizes. This could > work, but some guests (at least Linux) consider sizes that are not > a power of 2 as a firmware bug and fix the card size to the next > power of 2. > > +e

Re: [PATCH v5 03/12] python/machine.py: Add _early_cleanup hook

On Fri, Jul 10, 2020 at 01:06:40AM -0400, John Snow wrote: > Some parts of cleanup need to occur prior to shutdown, otherwise > shutdown might break. Move this into a suitably named method/callback. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 24 +++- > 1 fi

Re: [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too

On Fri, Jul 10, 2020 at 01:06:41AM -0400, John Snow wrote: > This is primarily for consistency, and is a step towards wait() and > shutdown() sharing the same implementation so that the two cleanup paths > cannot diverge. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 1 + > 1 fil

Re: [RFC PATCH 5/8] fpu/softfloat: define brain floating-point types

On 2020/7/14 3:26, Richard Henderson wrote: On 7/12/20 4:45 PM, LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei --- include/fpu/softfloat-types.h | 8 1 file changed, 8 insertions(+) diff --git a/include/fpu/softfloat-types.h b/include/fpu/softfloat-types.h index 7680193ebc..8f8fdfe

Re: [PATCH] gitlab-ci/containers: Add missing wildcard where we should look for changes

On 7/13/20 8:22 PM, Thomas Huth wrote: > The tests/docker/* wildcard seems to only match the files that are directly > in the tests/docker folder - but changes to the files in the directory > tests/docker/dockerfiles are currently ignored. Seems like we need a > separate entry to match the files in

Re: [PATCH v2 01/11] configure: remove all dependencies on a (re)configure

On 7/13/20 10:04 PM, Alex Bennée wrote: > The previous code was brittle and missed cases such as the mipn32 > variants which for some reason has the 64 bit syscalls. This leads to > a number of binary targets having deps lines like: > > all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.

Re: [RFC PATCH 2/8] fpu/softfloat: use the similiar logic to recognize sNaN and qNaN

On 2020/7/14 3:17, Richard Henderson wrote: On 7/12/20 4:45 PM, LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei --- fpu/softfloat-specialize.inc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c index 0

Re: [PATCH] gitlab-ci/containers: Add missing wildcard where we should look for changes

Thomas Huth writes: > The tests/docker/* wildcard seems to only match the files that are directly > in the tests/docker folder - but changes to the files in the directory > tests/docker/dockerfiles are currently ignored. Seems like we need a > separate entry to match the files in that folder. W

[PATCH v2 07/11] plugins: expand the bb plugin to be thread safe and track per-cpu

While there isn't any easy way to make the inline counts thread safe we can ensure the callback based ones are. While we are at it we can reduce introduce a new option ("idle") to dump a report of the current bb and insn count each time a vCPU enters the idle state. Signed-off-by: Alex Bennée Rev

[PATCH v2 11/11] plugins: new hwprofile plugin

This is a plugin intended to help with profiling access to various bits of system hardware. It only really makes sense for system emulation. It takes advantage of the recently exposed helper API that allows us to see the device name (memory region name) associated with a device. You can specify a

[PATCH v2 03/11] docker.py: fix fetching of FROM layers

This worked on a system that was already bootstrapped because the stage 2 images already existed even if they wouldn't be used. What we should have pulled down was the FROM line containers first because building on gitlab doesn't have the advantage of using our build system to build the pre-requisi

[PATCH v2 09/11] hw/virtio/pci: include vdev name in registered PCI sections

When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- v2 - swap ()

[PATCH v2 05/11] tests/plugins: don't unconditionally add -Wpsabi

Not all compilers support the -Wpsabi (clang-9 in my case). To handle this gracefully we pare back the shared build machinery so the Makefile is relatively "standalone". We still take advantage of config-host.mak as configure has done a bunch of probing for us but that is it. Fixes: bac8d222a Sign

[PATCH v2 08/11] docs/devel: fix grammar in multi-thread-tcg

Review comment came just too late ;-) Signed-off-by: Alex Bennée --- docs/devel/multi-thread-tcg.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/multi-thread-tcg.rst b/docs/devel/multi-thread-tcg.rst index 42158b77c7..21483870db 100644 --- a/docs/devel/multi-th

[PATCH v2 06/11] cputlb: ensure we save the IOTLB data in case of reset

Any write to a device might cause a re-arrangement of memory triggering a TLB flush and potential re-size of the TLB invalidating previous entries. This would cause users of qemu_plugin_get_hwaddr() to see the warning: invalid use of qemu_plugin_get_hwaddr because of the failed tlb_lookup which

[PATCH v2 01/11] configure: remove all dependencies on a (re)configure

The previous code was brittle and missed cases such as the mipn32 variants which for some reason has the 64 bit syscalls. This leads to a number of binary targets having deps lines like: all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.d 140: /home/alex/lsrc/qemu.git/linux-user/mips

[PATCH v2 10/11] plugins: add API to return a name for a IO device

This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée [r-b provisional given change to g_intern_string] Reviewed-by: Clement Deschamps Reviewed-by: Emilio G. Cota --- v3 - return a non-freeable const g_intern_string() - checkpatch cleanups --- inc

[PATCH v2 02/11] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

From: Thomas Huth The libssh problem only exists in Ubuntu 18.04 - we can enable it in 20.04 again. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200713185237.9419-1-th...@redhat.com> --- tests/docker/dockerfiles/ubuntu2004.docker |

[PATCH v2 00/11] misc fixes for rc0 (docker, plugins, softfloat)

Hi, These are some candidate patches for rc0 along with a few plugin patches that haven't yet gotten review. The new functionality won't get added to the PR but I'd like to get the cputlb fix in. I've also had another run at fixing the -Wpsabi problem. The following still need review: - docs/de

[PATCH v2 04/11] fpu/softfloat: fix up float16 nan recognition

From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200712234521.3972-2-zhiwei_...@c-sky.com> --- fpu/softfloat-specialize.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat-specialize.inc

Re: [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

LIU Zhiwei writes: > Signed-off-by: LIU Zhiwei Queued to misc/for-5.1-rc0, thanks. -- Alex Bennée

Re: [RFC PATCH] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

Thomas Huth writes: > The libssh problem only exists in Ubuntu 18.04 - we can enable it > in 20.04 again. Queued to misc/for-5.1-rc0, thanks. > > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/ubuntu2004.docker | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/do

[Bug 1884719] Re: Function not implemented when using libaio

Martin, do you want to propose some patches to fix the problem? Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1884719 Title: Function not implemented when using libaio Status in QEMU: N

Re: [PATCH v1] target/riscv: fix pmp implementation

On Mon, Jul 13, 2020 at 3:10 AM Alexandre Mergnat wrote: > > Le ven. 10 juil. 2020 à 22:35, Alistair Francis a > écrit : > > > > On Mon, Jul 6, 2020 at 2:45 AM Alexandre Mergnat > > wrote: > > > > > > The end address calculation for NA4 mode is wrong because the address > > > used isn't shifte

Re: [PATCH v4 07/11] target/ppc: add vmulld to INDEX_op_mul_vec case

> On Jul 1, 2020, at 6:43 PM, Lijun Pan wrote: > > Group vmuluwm and vmulld. Make vmulld-specific > changes since it belongs to new ISA 3.1. > > Signed-off-by: Lijun Pan > --- > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style >us

Re: [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks

On 7/13/20 8:58 PM, P J P wrote: > +-- On Tue, 30 Jun 2020, P J P wrote --+ > | * This series asserts that MemoryRegionOps objects define read/write > | callback methods. Thus avoids potential NULL pointer dereference. > | ex. -> > https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1

Re: [PATCH v2 7/9] hw/sd/sdcard: Do not allow invalid SD card sizes

On Mon, Jul 13, 2020 at 11:33 AM Philippe Mathieu-Daudé wrote: > > QEMU allows to create SD card with unrealistic sizes. This could > work, but some guests (at least Linux) consider sizes that are not > a power of 2 as a firmware bug and fix the card size to the next > power of 2. > > While the po

Re: [PATCH v2 4/9] tests/acceptance/boot_linux: Expand SD card image to power of 2

On Mon, Jul 13, 2020 at 11:34 AM Philippe Mathieu-Daudé wrote: > > In few commits we won't allow SD card images with invalid size > (not aligned to a power of 2). Prepare the tests: add the > pow2ceil() and image_pow2ceil_expand() methods and resize the > images (expanding) of the tests using SD c

Re: [PATCH v4 11/11] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions

> On Jul 1, 2020, at 6:47 PM, Lijun Pan wrote: > > vdivsw: Vector Divide Signed Word > vdivuw: Vector Divide Unsigned Word > vdivsd: Vector Divide Signed Doubleword > vdivud: Vector Divide Unsigned Doubleword > vmodsw: Vector Modulo Signed Word > vmoduw: Vector Modulo Unsigned Word > vmodsd: V

Re: [PATCH v4 10/11] target/ppc: add vmulh{su}d instructions

> On Jul 1, 2020, at 6:47 PM, Lijun Pan wrote: > > vmulhsd: Vector Multiply High Signed Doubleword > vmulhud: Vector Multiply High Unsigned Doubleword > > Signed-off-by: Lijun Pan > --- > Reviewed-by: Richard Henderson > v3: simplify helper_vmulh{su}d > v2: fix coding style >use Power

  1   2   3   4   5   >