On Fri, Jul 10, 2020 at 01:06:46AM -0400, John Snow wrote: > cubieboard does not have a functioning reboot, it halts and QEMU does > not exit. > > vm.shutdown() is modified in a forthcoming patch that makes it less tolerant > of race conditions on shutdown; tests should consciously decide to WAIT > or to SHUTDOWN qemu. > > So long as this test is attempting to reboot, the correct choice would > be to WAIT for the VM to exit. However, since that's broken, we should > SHUTDOWN instead. > > SHUTDOWN is indeed what already happens when the test performs teardown, > however, if anyone fixes cubieboard reboot in the future, this test will > develop a new race condition that might be hard to debug. > > Therefore: remove the reboot test and make it obvious that the VM is > still running when the test concludes, where the test teardown will do > the right thing. > > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/acceptance/boot_linux_console.py | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >
Reviewed-by: Cleber Rosa <cr...@redhat.com> Tested-by: Cleber Rosa <cr...@redhat.com>
signature.asc
Description: PGP signature
