Re: [PATCH v1 5/5] dma/xlnx-zdma: Reorg to fix CUR_DSCR

2020-04-02 Thread Francisco Iglesias
On [2020 Apr 02] Thu 15:47:21, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Reorganize the descriptor handling so that CUR_DSCR always > points to the next descriptor to be processed. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xlnx-zdma.c

Re: is just a wrong function name of libusb_get_port_number? request for a review of the bug fix

2020-04-02 Thread kraxel
On Thu, Apr 02, 2020 at 11:47:17AM +, bauerchen(陈蒙蒙) wrote: > From 6bfb3087866606ed36a21e7bd05f0674e6a97158 Mon Sep 17 00:00:00 2001 > From: Bauerchen > Date: Thu, 2 Apr 2020 19:19:00 +0800 > Subject: [PATCH] Fix:fix the wrong function name of libusb_get_port_number > > [desc]: > libusb_get_p

Re: [PATCH v1 4/5] dma/xlnx-zdma: Advance the descriptor address when stopping

2020-04-02 Thread Francisco Iglesias
On [2020 Apr 02] Thu 15:47:20, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Advance the descriptor address when stopping the channel. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xlnx-zdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [PATCH v1 2/5] dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE

2020-04-02 Thread Francisco Iglesias
On [2020 Apr 02] Thu 15:47:18, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Populate DBG0.CMN_BUF_FREE so that SW can see some free space. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xlnx-zdma.c | 6 ++ > 1 file changed, 6 insertions(+

Re: [PATCH v1 3/5] dma/xlnx-zdma: Clear DMA_DONE when halting

2020-04-02 Thread Francisco Iglesias
On [2020 Apr 02] Thu 15:47:19, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Clear DMA_DONE when halting the DMA channel. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xlnx-zdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/d

Re: bdrv_drained_begin deadlock with io-threads

2020-04-02 Thread Thomas Lamprecht
On 4/2/20 7:10 PM, Kevin Wolf wrote: > Am 02.04.2020 um 18:47 hat Kevin Wolf geschrieben: >> So I think this is the bug: Calling blk_wait_while_drained() from >> anywhere between blk_inc_in_flight() and blk_dec_in_flight() is wrong >> because it will deadlock the drain operation. >> >> blk_aio_read

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Markus Armbruster
Simran Singhal writes: > Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" > to fix the typo. > > Fixes: 8d3265b3 > > Reviewed-by: Eric Blake > Signed-off-by: Simran Singhal First, thank you so much for spotting and fixing my typo! The commit message neglects to explain wh

Re: [PATCH v1 1/5] dma/xlnx-zdma: Remove comment

2020-04-02 Thread Francisco Iglesias
On [2020 Apr 02] Thu 15:47:17, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Remove comment. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xlnx-zdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-z

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-02 Thread David Gibson
On Thu, Apr 02, 2020 at 09:18:09AM +0200, Cédric Le Goater wrote: > On 4/2/20 8:50 AM, David Gibson wrote: > > On Thu, Apr 02, 2020 at 08:41:24AM +0200, Cédric Le Goater wrote: > >> On 4/2/20 2:31 AM, David Gibson wrote: > >>> On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: >

[Bug 1870477] Re: qemu-arm hangs when golang running test

2020-04-02 Thread Donghun Kwak
** Attachment added: "success case log" https://bugs.launchpad.net/qemu/+bug/1870477/+attachment/5345419/+files/qemu_success.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1870477 Title: qem

Qemu doesn't detect hard drive

2020-04-02 Thread Aijaz.Baig
Hi I have a working QEMU image emulating an ARM vexpress-a9 and I run it like so: `sudo qemu-system-arm -m 512M -M vexpress-a9 -D qemu.log -d unimp -kernel buildroot-2019.02.5/output/images/zImage -dtb buildroot-2019.02.5/output/images/vexpress-v2p-ca9.dtb -append "console=ttyAMA0,115200 kgdbo

[Bug 1870477] [NEW] qemu-arm hangs when golang running test

2020-04-02 Thread Donghun Kwak
Public bug reported: 1. Environment: Ubuntu 16.04.5 X86_64 qemu-arm version 4.2.0 go version go 1.14.1 linux/arm 2. Summary: Sometimes "go run test.go" command hang 3. Reproduction Method (Attempts: 500 Occurred: 1 ): Frequency: 1/500 test.go == package ma

Re: [PATCH v2 0/6] nbd: reduce max_block restrictions

2020-04-02 Thread Vladimir Sementsov-Ogievskiy
01.04.2020 19:52, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200401150112.9557-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can prob

Re: [PATCH kvm-unit-tests] fixup! arm/arm64: ITS: pending table migration test

2020-04-02 Thread Auger Eric
Hi Drew, On 4/2/20 8:01 PM, Andrew Jones wrote: > [ Without the fix this test would hang, as timeouts don't work with > the migration scripts (yet). Use errata to skip instead of hang. ] > Signed-off-by: Andrew Jones > --- > arm/gic.c | 18 -- > errata.txt | 1 + > 2 files ch

Re: [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs

2020-04-02 Thread Jason Wang
On 2020/4/2 下午9:46, Peter Xu wrote: On Thu, Apr 02, 2020 at 04:33:02PM +0800, Jason Wang wrote: The complete QEMU set can be found in below link: https://github.com/luxis1999/qemu.git: sva_vtd_v10_v2 Hi Yi: I could not find the branch there. Jason, He typed wrong... It's actually (I found

Re: [PATCH v1] usb: Add read support for HCIVERSION register to XHCI

2020-04-02 Thread Andrew Jeffery
On Wed, 1 Apr 2020, at 21:53, Cédric Le Goater wrote: > Hello, > > On 3/31/20 1:02 PM, Philippe Mathieu-Daudé wrote: > > On 3/31/20 11:57 AM, Cameron Esfahani wrote: > >> Philippe - > >>  From what I've seen, access size has nothing to do with alignment. > > > > Yes, I was wondering if you wer

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Leonardo Bras
On Fri, 2020-04-03 at 10:40 +1100, David Gibson wrote: > Urgh. Ok, I'm sorry Leonardo, but, > > Nack. I will not merge a change where my only knowledge of the spec > has to be based on hearsay. > > By all means use this as ammunition to convince IBM and/or the > openpower foundation to expedite

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread David Gibson
On Thu, Apr 02, 2020 at 08:19:34PM -0300, Leonardo Bras wrote: > On Fri, 2020-04-03 at 10:16 +1100, David Gibson wrote: > > On Thu, Apr 02, 2020 at 08:00:57PM -0300, Leonardo Bras wrote: > > > Hello David, > > > > > > On Fri, 2020-04-03 at 09:49 +1100, David Gibson wrote: > > > > The change looks

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Leonardo Bras
On Fri, 2020-04-03 at 10:16 +1100, David Gibson wrote: > On Thu, Apr 02, 2020 at 08:00:57PM -0300, Leonardo Bras wrote: > > Hello David, > > > > On Fri, 2020-04-03 at 09:49 +1100, David Gibson wrote: > > > The change looks reasonable. Is there a PAPR RFC I can see describing > > > the new bit, th

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread David Gibson
On Thu, Apr 02, 2020 at 08:00:57PM -0300, Leonardo Bras wrote: > Hello David, > > On Fri, 2020-04-03 at 09:49 +1100, David Gibson wrote: > > > > The change looks reasonable. Is there a PAPR RFC I can see describing > > the new bit, though? > > The ACR is approved and I already added the change

Re: [PATCH v7 27/61] target/riscv: vector widening saturating scaled multiply-add

2020-04-02 Thread Alistair Francis
On Mon, Mar 30, 2020 at 9:31 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 22 +++ > target/riscv/insn32.decode | 7 + > target/riscv/insn_trans/tra

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Leonardo Bras
Hello David, On Fri, 2020-04-03 at 09:49 +1100, David Gibson wrote: > > The change looks reasonable. Is there a PAPR RFC I can see describing > the new bit, though? The ACR is approved and I already added the change to LoPAPR/LOPAR, it's just a matter of time to get it released. (I think it's a

Re: [PATCH v1 5/5] dma/xlnx-zdma: Reorg to fix CUR_DSCR

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 6:50 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Reorganize the descriptor handling so that CUR_DSCR always > points to the next descriptor to be processed. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/dma/xl

Re: [PATCH-for-5.1 v2] hw/core/register: Add register_init_block8 helper.

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 9:29 AM Joaquin de Andres wrote: > > There was no support for 8 bits block registers. Changed > register_init_block32 to be generic and static, adding register > size in bits as parameter. Created one helper for each size. > > Signed-off-by: Joaquin de Andres Reviewed-by:

Re: [PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread David Gibson
On Thu, Apr 02, 2020 at 02:23:40PM -0300, Leonardo Bras wrote: > On reboot, all memory that was previously added using object_add and > device_add is placed in this DIMM area. > > The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in > the correct memory zone, so no unmovable

Re: Question on dirty sync before kvm memslot removal

2020-04-02 Thread Peter Xu
On Thu, Apr 02, 2020 at 04:47:58PM -0400, Peter Xu wrote: > On Wed, Apr 01, 2020 at 07:09:28PM -0400, Peter Xu wrote: > > On Wed, Apr 01, 2020 at 01:12:04AM +0200, Paolo Bonzini wrote: > > > On 31/03/20 18:51, Peter Xu wrote: > > > > On Tue, Mar 31, 2020 at 05:34:43PM +0200, Paolo Bonzini wrote: >

[PULL 9/9] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model

2020-04-02 Thread Eduardo Habkost
From: Xiaoyao Li Current Icelake-Server CPU model lacks all the features enumerated by MSR_IA32_ARCH_CAPABILITIES. Add them, so that guest of "Icelake-Server" can see all of them. Signed-off-by: Xiaoyao Li Message-Id: <20200316095605.12318-1-xiaoyao...@intel.com> Signed-off-by: Eduardo Habkost

[PULL 8/9] target/i386: set the CPUID level to 0x14 on old machine-type

2020-04-02 Thread Eduardo Habkost
From: Luwei Kang The CPUID level need to be set to 0x14 manually on old machine-type if Intel PT is enabled in guest. E.g. the CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter. Some Intel PT capabilities are expose

[PULL 4/9] i386: Introduce use_epyc_apic_id_encoding in X86CPUDefinition

2020-04-02 Thread Eduardo Habkost
From: Babu Moger Add a boolean variable use_epyc_apic_id_encoding in X86CPUDefinition. This will be set if this cpu model needs to use new EPYC based apic id encoding. Override the handlers with EPYC based handlers if use_epyc_apic_id_encoding is set. This will be done in x86_cpus_init. Signed-

[PULL 7/9] i386: Fix pkg_id offset for EPYC cpu models

2020-04-02 Thread Eduardo Habkost
From: Babu Moger If the system is numa configured the pkg_offset needs to be adjusted for EPYC cpu models. Fix it calling the model specific handler. Signed-off-by: Babu Moger Reviewed-by: Igor Mammedov Acked-by: Michael S. Tsirkin Message-Id: <158396725589.58170.16424607815207074485.st...@na

[PULL 3/9] hw/i386: Introduce apicid functions inside X86MachineState

2020-04-02 Thread Eduardo Habkost
From: Babu Moger Introduce model specific apicid functions inside X86MachineState. These functions will be loaded from X86CPUDefinition. Signed-off-by: Babu Moger Reviewed-by: Igor Mammedov Acked-by: Michael S. Tsirkin Message-Id: <158396722838.58170.5675998866484476427.st...@naples-babu.amd.

[PULL 1/9] hw/386: Add EPYC mode topology decoding functions

2020-04-02 Thread Eduardo Habkost
From: Babu Moger These functions add support for building EPYC mode topology given the smp details like numa nodes, cores, threads and sockets. The new apic id decoding is mostly similar to current apic id decoding except that it adds a new field node_id when numa configured. Removes all the har

[PULL 6/9] target/i386: Enable new apic id encoding for EPYC based cpus models

2020-04-02 Thread Eduardo Habkost
From: Babu Moger The APIC ID is decoded based on the sequence sockets->dies->cores->threads. This works fine for most standard AMD and other vendors' configurations, but this decoding sequence does not follow that of AMD's APIC ID enumeration strictly. In some cases this can cause CPU topology in

[PULL 5/9] hw/i386: Move arch_id decode inside x86_cpus_init

2020-04-02 Thread Eduardo Habkost
From: Babu Moger Apicid calculation depends on knowing the total number of numa nodes for EPYC cpu models. Right now, we are calculating the arch_id while parsing the numa(parse_numa). At this time, it is not known how many total numa nodes are configured in the system. Move the arch_id calculat

[PULL 2/9] target/i386: Cleanup and use the EPYC mode topology functions

2020-04-02 Thread Eduardo Habkost
From: Babu Moger Use the new functions from topology.h and delete the unused code. Given the sockets, nodes, cores and threads, the new functions generate apic id for EPYC mode. Removes all the hardcoded values. Signed-off-by: Babu Moger Acked-by: Michael S. Tsirkin Acked-by: Igor Mammedov Me

[PULL 0/9] x86 queue for -rc2

2020-04-02 Thread Eduardo Habkost
This was supposed to be submitted before -rc1, but I've dropped the ball (sorry). The following changes since commit 2833ad487cfff7dc33703e4731b75facde1c561e: Update version for v5.0.0-rc1 release (2020-03-31 18:02:47 +0100) are available in the Git repository at: git://github.com/ehabkost/

Re: [PATCH v2 10/10] linux-user: completely re-write init_guest_space

2020-04-02 Thread Richard Henderson
On 4/1/20 2:47 AM, Alex Bennée wrote: > +/* > + * Now we are going to try and map something, we start by trying > + * to satisfy exactly what the guest wants. This is unlikely to > + * succeed but will make the code generators job easier if it can > + * be done. > + * > +

Re: [PATCH for-5.0? v3] qemu-img: Report convert errors by bytes, not sectors

2020-04-02 Thread Philippe Mathieu-Daudé
On 4/2/20 3:57 PM, Eric Blake wrote: Various qemu-img commands are inconsistent on whether they report status/errors in terms of bytes or sector offsets. The latter is confusing (especially as more places move to 4k block sizes), so let's switch everything to just use bytes everywhere. One iote

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

2020-04-02 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/31/20 6:18 PM, Richard Henderson wrote: On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote: This test was written/tested around beginning of 2019, but was extracted from a bigger series and posted end of June 2019 [*]. Unfortunately I did not notice commit 162abf1a8 was merged by

Re: [PATCH] hw/core: properly terminate loading .hex on EOF record

2020-04-02 Thread Philippe Mathieu-Daudé
On 4/1/20 9:38 PM, Alex Bennée wrote: The https://makecode.microbit.org/#editor generates slightly weird .hex files which work fine on a real microbit but causes QEMU to choke. The reason is extraneous data after the EOF record which causes the loader to attempt to write a bigger file than it sho

Re: [PATCH for-5.0? v4 0/7] Tighten qemu-img rules on missing backing format

2020-04-02 Thread Eric Blake
On 3/12/20 2:28 PM, Eric Blake wrote: v3 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01730.html In v4: - old patch 1 was reworked into new patch 1-3, with stricter rules on which backing formats are accepted [Kevin] - patch 4 is new: amend is handled differently from rebase

Re: Question on dirty sync before kvm memslot removal

2020-04-02 Thread Peter Xu
On Wed, Apr 01, 2020 at 07:09:28PM -0400, Peter Xu wrote: > On Wed, Apr 01, 2020 at 01:12:04AM +0200, Paolo Bonzini wrote: > > On 31/03/20 18:51, Peter Xu wrote: > > > On Tue, Mar 31, 2020 at 05:34:43PM +0200, Paolo Bonzini wrote: > > >> On 31/03/20 17:23, Peter Xu wrote: > > Or KVM_MEM_READON

Re: [PULL 00/15] Misc patches for 5.0-rc2

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402190640.1693-1-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

Re: [PULL 00/15] Misc patches for 5.0-rc2

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402190640.1693-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/15] Misc patches for 5.0-rc2 Message-id: 20200402190640.1693-1-pbonz...@redhat.com Type: series =

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PULL 00/15] Misc patches for 5.0-rc2

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402190640.1693-1-pbonz...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count Message-id: 20200402182848.GA3023@

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash exp

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

[PULL 15/15] xen: fixup RAM memory region initialization

2020-04-02 Thread Paolo Bonzini
From: Igor Mammedov Since bd457782b3b0 ("x86/pc: use memdev for RAM") Xen machine fails to start with: qemu-system-i386: xen: failed to populate ram at 0 The reason is that xen_ram_alloc() which is called by memory_region_init_ram(), compares memory region with statically allocated 'global' r

[PULL 09/15] i386: hvf: Reset IRQ inhibition after moving RIP

2020-04-02 Thread Paolo Bonzini
From: Roman Bolshakov The sequence of instructions exposes an issue: sti hlt Interrupts cannot be delivered to hvf after hlt instruction cpu because HF_INHIBIT_IRQ_MASK is set just before hlt is handled and never reset after moving instruction pointer beyond hlt. So, after hvf_vcpu_exec() r

[PULL 13/15] qmp: fix leak on callbacks that return both value and error

2020-04-02 Thread Paolo Bonzini
From: Marc-André Lureau Direct leak of 4120 byte(s) in 1 object(s) allocated from: #0 0x7fa114931887 in __interceptor_calloc (/lib64/libasan.so.6+0xb0887) #1 0x7fa1144ad8f0 in g_malloc0 (/lib64/libglib-2.0.so.0+0x588f0) #2 0x561e3c9c8897 in qmp_object_add /home/elmarco/src/qemu/qom/q

[PULL 12/15] migration: fix cleanup_bh leak on resume

2020-04-02 Thread Paolo Bonzini
From: Marc-André Lureau Since commit 8c6b0356b53977bcfdea5299db07884915425b0c ("util/async: make bh_aio_poll() O(1)"), migration-test reveals a leak: QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qtest/migration-test -p /x86_64/migration/postcopy/recovery tests/qtest/libqtest.c:140:

[PULL 07/15] util/bufferiszero: improve avx2 accelerator

2020-04-02 Thread Paolo Bonzini
From: Robert Hoo By increasing avx2 length_to_accel to 128, we can simplify its logic and reduce a branch. The authorship of this patch actually belongs to Richard Henderson , I just fixed a boundary case on his original patch. Suggested-by: Richard Henderson Signed-off-by: Robert Hoo Messag

[PULL 11/15] target/i386: do not set unsupported VMX secondary execution controls

2020-04-02 Thread Paolo Bonzini
From: Vitaly Kuznetsov Commit 048c95163b4 ("target/i386: work around KVM_GET_MSRS bug for secondary execution controls") added a workaround for KVM pre-dating commit 6defc591846d ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS") which wasn't setting certain available controls.

[PULL 06/15] util/bufferiszero: assign length_to_accel value for each accelerator case

2020-04-02 Thread Paolo Bonzini
From: Robert Hoo Because in unit test, init_accel() will be called several times, each with different accelerator type. Signed-off-by: Robert Hoo Message-Id: <1585119021-46593-1-git-send-email-robert...@linux.intel.com> Signed-off-by: Paolo Bonzini --- util/bufferiszero.c | 3 +++ 1 file chan

[PULL 14/15] object-add: don't create return value if failed

2020-04-02 Thread Paolo Bonzini
No need to return an empty value from object-add (it would also leak if the command failed). While at it, remove the "if" around object_unref since object_unref handles NULL arguments just fine. Reported-by: Marc-André Lureau Message-Id: <20200325184723.2029630-4-marcandre.lur...@redhat.com> Sig

[PULL 10/15] serial: Fix double migration data

2020-04-02 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" After c9808d60281 we have both an object representing the serial-isa device and a separate object representing the underlying common serial uart. Both of these have vmsd's associated with them and thus the migration stream ends up with two copies of the migration d

[PULL 03/15] virtio-iommu: depend on PCI

2020-04-02 Thread Paolo Bonzini
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change. Reported-by: Gerd Hoffmann Signed-off-by: Paolo Bonzini --- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PULL 05/15] MAINTAINERS: Add an entry for the HVF accelerator

2020-04-02 Thread Paolo Bonzini
From: Roman Bolshakov Cc: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Patrick Colp Cc: Cameron Esfahani Cc: Liran Alon Cc: Heiher Signed-off-by: Roman Bolshakov Message-Id: <20200316171825.42544-1-r.bolsha...@yadro.com> Signed-off-by: Paolo Bonzini --- MAINTAINERS | 7 +++

[PULL 08/15] vl: fix broken IPA range for ARM -M virt with KVM enabled

2020-04-02 Thread Paolo Bonzini
From: Igor Mammedov Commit a1b18df9a4848, broke virt_kvm_type() logic, which depends on maxram_size, ram_size, ram_slots being parsed/set on machine instance at the time accelerator (KVM) is initialized. set_memory_options() part was already reverted by commit 2a7b18a3205b, so revert remaining i

[PULL 01/15] hw/scsi/vmw_pvscsi: Remove assertion for kick after reset

2020-04-02 Thread Paolo Bonzini
From: Elazar Leibovich When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes during guest ACPI reset. It crashes on assert(s->rings_info_valid) in pvscsi_process_io(). Analyzing the crash revealed that it happens when userspace issues a sync during a reboot syscall. Below are back

[PULL 02/15] hw/isa/superio: Correct the license text

2020-04-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The license is the 'GNU General Public License v2.0 or later', not 'and': This program is free software; you can redistribute it and/ori modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 o

[PULL 00/15] Misc patches for 5.0-rc2

2020-04-02 Thread Paolo Bonzini
The following changes since commit 2833ad487cfff7dc33703e4731b75facde1c561e: Update version for v5.0.0-rc1 release (2020-03-31 18:02:47 +0100) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 0dc0389fa5455bb2648667018

[PULL 04/15] softmmu: fix crash with invalid -M memory-backend=

2020-04-02 Thread Paolo Bonzini
From: Marc-André Lureau Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that ram_size matches size of machine.memory-backend") Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200309145155.168942-1-marcandre.lur...@re

Re: Questionable aspects of QEMU Error's design

2020-04-02 Thread Paolo Bonzini
On 02/04/20 10:55, Markus Armbruster wrote: > > When you return non-null/null or true/false on success/error, neglecting > to document that in a function contract can perhaps be tolerated; you're > using the return type the common, obvious way. But when you return 0/-1 > or 0/-errno, please spell

Re: [PATCH for-5.0 v2] xen: fixup RAM memory region initialization

2020-04-02 Thread Paolo Bonzini
On 02/04/20 16:54, Igor Mammedov wrote: > Since bd457782b3b0 ("x86/pc: use memdev for RAM") Xen > machine fails to start with: >qemu-system-i386: xen: failed to populate ram at 0 > > The reason is that xen_ram_alloc() which is called by > memory_region_init_ram(), compares memory region with >

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-02 Thread John Snow
On 4/1/20 8:40 AM, Max Reitz wrote: > On 31.03.20 19:39, Kevin Wolf wrote: >> Am 31.03.2020 um 19:23 hat John Snow geschrieben: >>> >>> >>> On 3/31/20 6:21 AM, Max Reitz wrote: On 31.03.20 02:00, John Snow wrote: > Minor cleanup for HMP functions; helps with line length and consolidates

[PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Simran Singhal
Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Fixes: 8d3265b3 Reviewed-by: Eric Blake Signed-off-by: Simran Singhal --- Changes in v3: -Add "Fixes: 8d3265b3" in commit message. Changes in v2: -No need to remove the duplicate occurrence o

Re: [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs

2020-04-02 Thread Peter Xu
On Sun, Mar 29, 2020 at 09:24:39PM -0700, Liu Yi L wrote: > Tests: basci vSVA functionality test, Could you elaborate what's the functionality test? Does that contains at least some IOs go through the SVA-capable device so the nested page table is used? I thought it was a yes, but after I notice

Re: [PATCH v2 15/22] intel_iommu: bind/unbind guest page table to host

2020-04-02 Thread Peter Xu
On Sun, Mar 29, 2020 at 09:24:54PM -0700, Liu Yi L wrote: > +static int vtd_bind_guest_pasid(IntelIOMMUState *s, VTDBus *vtd_bus, > +int devfn, int pasid, VTDPASIDEntry *pe, > +VTDPASIDOp op) > +{ > +VTDHostIOMMUContext *vtd_dev_ic

[PATCH kvm-unit-tests] fixup! arm/arm64: ITS: pending table migration test

2020-04-02 Thread Andrew Jones
[ Without the fix this test would hang, as timeouts don't work with the migration scripts (yet). Use errata to skip instead of hang. ] Signed-off-by: Andrew Jones --- arm/gic.c | 18 -- errata.txt | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arm/gic.c

Re: [PATCH v3 1/1] vl/s390x: fixup ram sizes for compat machines

2020-04-02 Thread Peter Xu
On Thu, Apr 02, 2020 at 05:01:23PM +0200, Igor Mammedov wrote: > On Thu, 2 Apr 2020 14:35:21 +0200 > Christian Borntraeger wrote: > > > On 02.04.20 14:09, Christian Borntraeger wrote: > > > > > > > > > On 02.04.20 14:05, Igor Mammedov wrote: > > >> On Thu, 2 Apr 2020 13:42:22 +0200 > > >> Chr

Re: [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Eric Blake
On 4/2/20 12:19 PM, Simran Singhal wrote: Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Signed-off-by: Simran Singhal Please add: Fixes: 8d3265b3 at which point you can also add: Reviewed-by: Eric Blake --- Changes in v2: -No need to rem

Re: [PATCH v7 26/61] target/riscv: vector single-width fractional multiply with rounding and saturation

2020-04-02 Thread Alistair Francis
On Mon, Mar 30, 2020 at 9:29 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 9 ++ > target/riscv/insn32.decode | 2 + > target/riscv/insn_trans/trans_rvv.inc.c | 4 + > target/risc

Re: [PATCH v7 25/61] target/riscv: vector single-width averaging add and subtract

2020-04-02 Thread Alistair Francis
On Mon, Mar 30, 2020 at 9:27 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 17 > target/riscv/insn32.decode | 5 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 7 ++ > target/

Re: [PATCH for-5.0] aio-posix: fix test-aio /aio/event/wait with fdmon-io_uring

2020-04-02 Thread Cole Robinson
On 4/2/20 10:54 AM, Stefan Hajnoczi wrote: > When a file descriptor becomes ready we must re-arm POLL_ADD. This is > done by adding an sqe to the io_uring sq ring. The ->need_wait() > function wasn't taking pending sqes into account and therefore > io_uring_submit_and_wait() was not being called.

[PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Leonardo Bras
On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area. The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to be easily hot-removed

Re: [PATCH v1 4/5] dma/xlnx-zdma: Advance the descriptor address when stopping

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 6:47 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Advance the descriptor address when stopping the channel. > > Signed-off-by: Edgar E. Iglesias Acked-by: Alistair Francis Alistair > --- > hw/dma/xlnx-zdma.c | 1 - > 1 file changed, 1 deletion(-) > >

Re: [PATCH v1 3/5] dma/xlnx-zdma: Clear DMA_DONE when halting

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 6:50 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Clear DMA_DONE when halting the DMA channel. > > Signed-off-by: Edgar E. Iglesias Acked-by: Alistair Francis Alistair > --- > hw/dma/xlnx-zdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

Re: [PATCH 1/1] target/i386: fix phadd* with identical destination and source register

2020-04-02 Thread Richard Henderson
On 4/1/20 3:52 PM, Janne Grunau wrote: > Detected by asm test suite failures in dav1d > (https://code.videolan.org/videolan/dav1d). Can be reproduced by > `qemu-x86_64 -cpu core2duo ./tests/checkasm --test=mc_8bpc 1659890620`. > > Signed-off-by: Janne Grunau Reviewed-by: Richard Henderson r~

[PATCH v2] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Simran Singhal
Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Signed-off-by: Simran Singhal --- Changes in v2: -No need to remove the duplicate occurence of "parser->bracket_count >= 0" but actually it is a typo and one occurence should be "parser->brace

Re: [PATCH v1 2/5] dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 6:46 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Populate DBG0.CMN_BUF_FREE so that SW can see some free space. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/dma/xlnx-zdma.c | 6 ++ > 1 file changed, 6 ins

Re: [PATCH] target/arm: don't expose "ieee_half" via gdbstub

2020-04-02 Thread Richard Henderson
On 4/2/20 7:39 AM, Alex Bennée wrote: > While support for parsing ieee_half in the XML description was added > to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know > if the gdb end will understand it. Disable it for now and allow older > gdbs to successfully connect to the default

Re: Questionable aspects of QEMU Error's design

2020-04-02 Thread Vladimir Sementsov-Ogievskiy
02.04.2020 18:06, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 02.04.2020 11:55, Markus Armbruster wrote: Peter Maydell writes: On Thu, 2 Apr 2020 at 07:11, Vladimir Sementsov-Ogievskiy wrote: Somehow, in general, especially with long function names and long parameter l

Re: qemu-system-ppc 5.0 rc1 crashing on Windows

2020-04-02 Thread Howard Spoelstra
On Thu, Apr 2, 2020 at 4:58 PM Alex Bennée wrote: > > Howard Spoelstra writes: > > > On Thu, Apr 2, 2020 at 3:20 PM Alex Bennée > wrote: > > > >> > >> Howard Spoelstra writes: > >> > >> > On Thu, Apr 2, 2020 at 12:47 PM Philippe Mathieu-Daudé < > >> phi...@redhat.com> > >> > wrote: > >> > > >>

Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Leonardo Bras
Hello Bharata, thank you for reviewing and testing! During review of this new flag, it was suggested to change it's name to a better one (on platform's viewpoint). So I will have to change the flag name from SPAPR_LMB_FLAGS_HOTPLUGGED to SPAPR_LMB_FLAGS_HOTREMOVABLE. Everything should work the

Re: bdrv_drained_begin deadlock with io-threads

2020-04-02 Thread Kevin Wolf
Am 02.04.2020 um 18:47 hat Kevin Wolf geschrieben: > Am 02.04.2020 um 17:40 hat Dietmar Maurer geschrieben: > > > Can you reproduce the problem with my script, but pointing it to your > > > Debian image and running stress-ng instead of dd? > > > > yes > > > > > If so, how long does > > > it take

Re: [PATCH v1 1/5] dma/xlnx-zdma: Remove comment

2020-04-02 Thread Alistair Francis
On Thu, Apr 2, 2020 at 6:49 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Remove comment. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/dma/xlnx-zdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/dma/xlnx-zdma.c b/hw/dm

Re: [PATCH v2 09/10] linux-user: clean-up padding on /proc/self/maps

2020-04-02 Thread Richard Henderson
On 4/1/20 2:47 AM, Alex Bennée wrote: > Don't use magic spaces, calculate the justification for the file > field like the kernel does with seq_pad. > > Signed-off-by: Alex Bennée > --- > linux-user/syscall.c | 32 +++- > 1 file changed, 19 insertions(+), 13 deletions(

Re: [PATCH v2 08/10] linux-user: factor out reading of /proc/self/maps

2020-04-02 Thread Richard Henderson
On 4/1/20 2:47 AM, Alex Bennée wrote: > +typedef struct { > +uint64_t start; > +uint64_t end; ... > +errors = qemu_strtoul(fields[0], &end, 16, &e->start); > +errors += qemu_strtoul(end + 1, NULL, 16, &e->end); uint64_t vs unsigned long -- you want qemu_str

qemu plugin exposure of register addresses

2020-04-02 Thread Robert Henry
There is now a qemu plugin interface function qemu_plugin_register_vcpu_mem_cb which registers a plugin-side callback. This callback is later invoked at the start of each emulated instruction, and it receives information about memory addresses and read/write indicators. I'm wondering how hard i

Re: [PATCH] hw/core: properly terminate loading .hex on EOF record

2020-04-02 Thread Richard Henderson
On 4/1/20 12:38 PM, Alex Bennée wrote: > The https://makecode.microbit.org/#editor generates slightly weird > .hex files which work fine on a real microbit but causes QEMU to > choke. The reason is extraneous data after the EOF record which causes > the loader to attempt to write a bigger file than

Re: bdrv_drained_begin deadlock with io-threads

2020-04-02 Thread Kevin Wolf
Am 02.04.2020 um 17:40 hat Dietmar Maurer geschrieben: > > Can you reproduce the problem with my script, but pointing it to your > > Debian image and running stress-ng instead of dd? > > yes > > > If so, how long does > > it take to reproduce for you? > > I sometimes need up to 130 iterations .

Re: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-04-02 Thread Auger Eric
Hi Zhangfei, On 3/31/20 10:24 AM, Zhangfei Gao wrote: > Hi, Eric > > On 2020/3/31 下午4:12, Auger Eric wrote: >> Hi Zhangfei, >> >> On 3/31/20 8:42 AM, Zhangfei Gao wrote: >>> Hi, Eric >>> >>> On 2020/3/21 上午12:58, Eric Auger wrote: Up to now vSMMUv3 has not been integrated with VFIO. VFIO >>>

Re: [PATCH] qobject: json-streamer: Remove double test

2020-04-02 Thread Simran Singhal
On Thu, Apr 2, 2020 at 6:42 PM Eric Blake wrote: > On 4/2/20 7:13 AM, Simran Singhal wrote: > > Remove the duplicate test "parser->bracket_count >= 0". > > > > Signed-off-by: Simran Singhal > > --- > > qobject/json-streamer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > d

[PATCH-for-5.1 v2] hw/core/register: Add register_init_block8 helper.

2020-04-02 Thread Joaquin de Andres
There was no support for 8 bits block registers. Changed register_init_block32 to be generic and static, adding register size in bits as parameter. Created one helper for each size. Signed-off-by: Joaquin de Andres --- This patch is small and I could see that there is not much movement with the r

Re: bdrv_drained_begin deadlock with io-threads

2020-04-02 Thread Dietmar Maurer
> It does looks more like your case because I now have bs.in_flight == 0 > and the BlockBackend of the scsi-hd device has in_flight == 8. yes, this looks very familiar. > Of course, this still doesn't answer why it happens, and I'm not sure if we > can tell without adding some debug code. > > I

Re: bdrv_drained_begin deadlock with io-threads

2020-04-02 Thread Dietmar Maurer
> Can you reproduce the problem with my script, but pointing it to your > Debian image and running stress-ng instead of dd? yes > If so, how long does > it take to reproduce for you? I sometimes need up to 130 iterations ... Worse, I thought several times the bug is gone, but then it triggered

  1   2   3   >