On 4/1/20 2:47 AM, Alex Bennée wrote:
> +typedef struct {
> + uint64_t start;
> + uint64_t end;
...
> + errors = qemu_strtoul(fields[0], &end, 16, &e->start);
> + errors += qemu_strtoul(end + 1, NULL, 16, &e->end);
uint64_t vs unsigned long -- you want qemu_strtou64.
> + errors += qemu_strtoul(fields[2], NULL, 16, &e->offset);
Likewise.
> + /* A bit ugly as strsplit doesn't skip multiple separators */
> + if (g_strv_length(fields) > 6) {
> + e->path = g_strdup(fields[g_strv_length(fields) - 1]);
> + }
And if the path contains spaces?
r~
