Re: [Qemu-devel] [PATCH v3 3/7] hw/mips: Express dependencies of the r4k platform with Kconfig

2019-03-10 Thread Thomas Huth
On 11/03/2019 01.56, Philippe Mathieu-Daudé wrote: > This platform use standard PC devices connected to an ISA bus. > Networking is provided by a ne2000 chipset. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v3: remove CONFIG_NE2000_ISA (Thomas) > add PFLASH_CFI01 > --- > default-configs

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Thomas Huth
On 10/03/2019 17.28, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Hi all, >> >> lately I have been thinking of converting the QEMU build system to >> Meson. Meson is a relatively new build system that can replace >> Autotools or hand-written Makefiles such as QEMU; as a die-hard >> Auto

Re: [Qemu-devel] [PATCH v4 19/29] hw/arm: Express dependencies of the MPS2 boards with Kconfig

2019-03-10 Thread Thomas Huth
On 10/03/2019 22.33, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 3/7/19 3:18 PM, Thomas Huth wrote: >> Add Kconfig dependencies for the mps2-an* machines. >> >> Signed-off-by: Thomas Huth >> --- >> default-configs/arm-softmmu.mak | 20 +--- >> hw/arm/Kconfig

Re: [Qemu-devel] [PATCH v5-resend 2/2] mips_fulong2e: Add on-board graphics chip

2019-03-10 Thread Gerd Hoffmann
Hi, > > "git send-email" should send the patches with correct headers, it even > > asks for the charset it should use in case it finds non-ascii > > characters. So BALATON, could you check your mail client config, or > > switch over to "git send-email" for submitting patches? > > I'm sending w

Re: [Qemu-devel] [PATCH v5 04/14] audio: -audiodev command line option basic implementation

2019-03-10 Thread Gerd Hoffmann
Hi, > And magic errors like "'vfio-pci' is not a valid device model name" > after update. Try a full rebuild then. I see strange errors now and then too, that fixed it. Seems the qemu build fails now and then that an object file needs a rebuild. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig

2019-03-10 Thread Thomas Huth
On 11/03/2019 00.53, Philippe Mathieu-Daudé wrote: > The Intel 8042 chipset also includes some functions unrelated to > the keyboard, such the A20-Gate. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/Kconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/input/Kconf

Re: [Qemu-devel] [PATCH v3 1/3] vfio/display: add edid support.

2019-03-10 Thread Gerd Hoffmann
Hi, > Liam and I both found some difficulty with the cleverness of the > macros, so for the sake of better maintainability, I'd like to propose > rolling in the following patch, including Liam's trace format fix. It's > not as compact as your version, but I think it's equivalent, it's easier >

[Qemu-devel] [PATCH 0/2] cleanup select_machine

2019-03-10 Thread Wei Yang
Here is two simple change related to select_machine() [1]: make find_default_machine() local since no one outside file use it [2]: allocate TYPE_MACHINE list only once to select machine type Wei Yang (2): vl.c: make find_default_machine() local vl.c: allocate TYPE_MACHINE list once during boo

[Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local

2019-03-10 Thread Wei Yang
Function find_default_machine() is introduced by commit 2c8cffa599b7 "vl: make find_default_machine externally visible", while it seems no one outside use it. This patch make it local again. Signed-off-by: Wei Yang --- include/hw/boards.h | 1 - vl.c| 4 ++-- 2 files changed, 2

[Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-03-10 Thread Wei Yang
Now all the functions used to select machine is local and the call flow looks like below: select_machine() find_default_machine() machine_parse() find_machine() All these related function will need a GSList for TYPE_MACHINE. Currently we allocate this list each tim

[Qemu-devel] [PATCH v3] exec.c: refactor function flatview_add_to_dispatch()

2019-03-10 Thread Wei Yang
flatview_add_to_dispatch() registers page based on the condition of *section*, which may looks like this: |s|PPP|s| where s stands for subpage and P for page. The procedure of this function could be described as: - register first subpage - register page - register last subpa

Re: [Qemu-devel] [PATCH v2] exec.c: refactor function flatview_add_to_dispatch()

2019-03-10 Thread Wei Yang
On Sun, Mar 10, 2019 at 09:54:54PM -0700, no-re...@patchew.org wrote: >Patchew URL: >https://patchew.org/QEMU/20190311013016.14411-1-richardw.y...@linux.intel.com/ > > > >Hi, > >This series failed the docker-mingw@fedora build test. Please find the testing >commands and >their output below. If yo

Re: [Qemu-devel] [PATCH v3 7/10] qemu-binfmt-conf.sh: add option --reset

2019-03-10 Thread Unai Martinez Corral
2019/3/10 18:15, Laurent Vivier: > On 06/03/2019 05:52, Unai Martinez-Corral wrote: > > Allows to remove a single or a list of already registered binfmt > > interpreters. If is a list, it must be comma-separated. > > I think ARCHS and CPUS are the same thing, so use the same word. They are simila

Re: [Qemu-devel] [PATCH v2] exec.c: refactor function flatview_add_to_dispatch()

2019-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190311013016.14411-1-richardw.y...@linux.intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v3 6/10] qemu-binfmt-conf.sh: generalize to positional

2019-03-10 Thread Unai Martinez Corral
2019/3/10 18:02, Laurent Vivier: > On 06/03/2019 05:50, Unai Martinez-Corral wrote: > > The list can be separated by spaces, tabs, newlines or commas. If no > > I think it would be simpler to not manage commas, and to use the default > field separator. Commas were supported because the same functi

Re: [Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices

2019-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190310235351.1863-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH] migration/postcopy: Update the bandwidth during postcopy

2019-03-10 Thread Peter Xu
On Fri, Mar 08, 2019 at 10:12:10AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The recently added max-postcopy-bandwidth parameter is only read > at the transition from precopy->postcopy where as the older > max-bandwidth parameter updates the migration bandwid

Re: [Qemu-devel] [PATCH] migration/rdma: Check qemu_rdma_init_one_block

2019-03-10 Thread Peter Xu
On Fri, Mar 08, 2019 at 06:51:24PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Actually it can't fail at the moment, but Coverity moans that > it's the only place it's not checked, and it's an easy check. > > Reported-by: Coverity (CID 1399413) > Signed-off-by

Re: [Qemu-devel] [PATCH] migration: fix small leak

2019-03-10 Thread Peter Xu
On Fri, Mar 08, 2019 at 05:07:31PM +0100, Marc-André Lureau wrote: [...] > diff --git a/migration/socket.c b/migration/socket.c > index 239527fb1f..49bacf78fd 100644 > --- a/migration/socket.c > +++ b/migration/socket.c > @@ -199,6 +199,7 @@ static void socket_start_incoming_migration(SocketAddre

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-10 Thread Tian, Kevin
> From: Alex Williamson > Sent: Saturday, March 9, 2019 6:03 AM > > On Fri, 8 Mar 2019 16:21:46 + > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Thu, 7 Mar 2019 23:20:36 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex Willi

Re: [Qemu-devel] [PATCH v7 2/2] mips_fulong2e: Add on-board graphics chip

2019-03-10 Thread BALATON Zoltan
On Mon, 11 Mar 2019, Philippe Mathieu-Daudé wrote: On 3/9/19 6:21 PM, BALATON Zoltan wrote: Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet. Signed-off-by: BALATON Zoltan Re

[Qemu-devel] [PATCH v2] exec.c: refactor function flatview_add_to_dispatch()

2019-03-10 Thread Wei Yang
flatview_add_to_dispatch() registers page based on the condition of *section*, which may looks like this: |s|PPP|s| where s stands for subpage and P for page. The procedure of this function could be described as: - register first subpage - register page - register last subpa

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Neal Gompa
On Thu, Mar 7, 2019 at 1:44 PM Paolo Bonzini wrote: > > On 07/03/19 14:09, Peter Maydell wrote: > > On Thu, 7 Mar 2019 at 12:56, Paolo Bonzini wrote: > >> In any case, this wouldn't change; as you suggest below, configure could > >> remain as a front-end (well, in-srcdir builds are not supported

[Qemu-devel] [PATCH v3 6/7] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge

2019-03-10 Thread Philippe Mathieu-Daudé
Ease the kconfig selection by introducing CONFIG_PCI_BONITO to select the Bonito North Bridge. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips64el-softmmu.mak | 1 + hw/pci-host/Kconfig | 4 hw/pci-host/Makefile.objs| 2 +- 3 files changed, 6 inse

[Qemu-devel] [PATCH v3 5/7] hw/mips: Express dependencies of the Boston machine with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
Boston is built around a Xilinx FPGA, which includes a PCIe root port and an UART. An Intel EG20T PCH connects the I/O peripherals, but only the SATA bus is emulated. Reviewed-by: Thomas Huth Reviewed-by: Paul Burton Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips64el-softmmu.ma

[Qemu-devel] [PATCH v3 3/7] hw/mips: Express dependencies of the r4k platform with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
This platform use standard PC devices connected to an ISA bus. Networking is provided by a ne2000 chipset. Signed-off-by: Philippe Mathieu-Daudé --- v3: remove CONFIG_NE2000_ISA (Thomas) add PFLASH_CFI01 --- default-configs/mips-softmmu-common.mak | 1 - hw/mips/Kconfig

[Qemu-devel] [PATCH v3 4/7] hw/mips: Remove the redundant CONFIG_MIPS_ITU Makefile variable

2019-03-10 Thread Philippe Mathieu-Daudé
The Inter-Thread Communication Unit (ITU, introduced in commit 34fa7e83e11) is part of the Coherent Processing System (CPS), as describe in commit 408294352ad: Make ITU available in the system if CPU supports multithreading and is part of CPS. Replate the CONFIG_MIPS_ITU variable by the C

[Qemu-devel] [PATCH v3 7/7] hw/mips: Express dependencies of the Fulong 2E machine with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The Fulong 2E machine uses a Loongson 2E as CPU, a Bonito64 system controller as North Bridge and a VT82C686 chipset as South Bridge. The network card chipset is a RTL8139D. Signed-off-by: Philippe Mathieu-Daudé --- v3: Loongson 2E = CPU, Fulong 2E = machine (Aleksandar) --- default-configs/mips

[Qemu-devel] [PATCH v3 2/7] hw/mips: Express dependencies of the Jazz machine with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The Jazz use the RC4030 Asic to provide an EISA bus and DMA/IRQ. The framebuffer display is managed by a G364, the network card is a Sonic DP83932. A QLogic ESP216 provides a SCSI bus. Signed-off-by: Philippe Mathieu-Daudé --- v3: Keep CONFIG_JAZZ in default-configs/mips64el-softmmu.mak (Thomas)

[Qemu-devel] [PATCH v3 0/7] Kconfig dependencies for MIPS machines (but Malta)

2019-03-10 Thread Philippe Mathieu-Daudé
Express the MIPS machine dependencies with Kconfig. Due to its complexity, the Malta board fill follow in a different series. v3: - addressed review comments from Thomas and Aleksandar (noted in each patch) v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00887.html - Do not remove

[Qemu-devel] [PATCH v3 1/7] hw/mips: Express dependencies of the MIPSsim machine with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The MIPSsim machine only emulates an 8250 UART and a simple network controller, connected via an ISA bus. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-softmmu-common.mak | 1 - hw/mips/Kconfig | 3 +++ 2 files changed, 3 inserti

Re: [Qemu-devel] [PATCH v7 2/2] mips_fulong2e: Add on-board graphics chip

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 6:21 PM, BALATON Zoltan wrote: > Add (partial) emulation of the on-board GPU of the machine. This > allows the PMON2000 firmware to run and should also work with Linux > console but probably not with X yet. > > Signed-off-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé > Test

[Qemu-devel] [PATCH 4/5] NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based distribs

2019-03-10 Thread Philippe Mathieu-Daudé
Do not enforce GCCx_ARM_PREFIX=arm-linux-gnu- on Debian based distributions. This is a kludge not meant for merging! Signed-off-by: Philippe Mathieu-Daudé --- roms/edk2-funcs.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/roms/edk2-funcs.sh b/roms/edk2-funcs.sh index 402fc126fb..2f1

[Qemu-devel] [PATCH 2/5] roms/edk2: Avoid bashism in script

2019-03-10 Thread Philippe Mathieu-Daudé
Use the POSIX '=' to evaluate equality. This fixes building the roms with a dash shell: $ make -C roms efi [...] cp edk2/Build/ArmVirtQemu-ARM/DEBUG_GCC5/FV/QEMU_EFI.fd \ ../pc-bios/edk2-arm-code.fd truncate --size=64M ../pc-bios/edk2-arm-code.fd /bin/sh: 111: [: i686: unexpecte

[Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms

2019-03-10 Thread Philippe Mathieu-Daudé
Add a job to build and install the EDK2 platform firmware binaries. This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates). Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 21 +

[Qemu-devel] [PATCH 1/5] roms/edk2: Avoid bashism in Makefile 'shell' function

2019-03-10 Thread Philippe Mathieu-Daudé
The shell builtin 'source' command is a bash extension. Use the '.' portable command. This fix building when /bin/sh is dash (Ubuntu 16): $ make -C roms efi [...] Fd File Name:QEMU_EFI (/source/qemu/roms/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/FV/QEMU_EFI.fd) Fd File Name:QEMU_VARS

[Qemu-devel] [PATCH 0/5] travis-ci: Build EDK2 roms

2019-03-10 Thread Philippe Mathieu-Daudé
Hi, This series add a job to Travis CI to build the last EDK2 stable release roms within QEMU. This job is only triggered if a commit matches 'EDK2' or during QEMU releases (when tags are pushed). Job output: https://travis-ci.org/philmd/qemu/jobs/504460932 Duration: 33 min 51 sec (output 5080 li

[Qemu-devel] [PATCH 3/5] roms/edk2: Pass extra arguments to the build script via EDK2_BUILD_OPTIONS

2019-03-10 Thread Philippe Mathieu-Daudé
The current EDK2 options produce a very verbose output. When building the roms on Continuous Integration systems (such Travis CI) the system limit is quickly reached. Add an variable to optionally pass arguments to the edk2-build.sh script. Example of use: $ EDK2_BUILD_OPTIONS="--quiet --silen

Re: [Qemu-devel] [PATCH 1/8] hw/i2c: The ACPI_SMBUS Kconfig depends on ACPI

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/11/19 12:53 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig > index ef1caa6d89..ec62909fa1 100644 > --- a/hw/i2c/Kconfig > +++ b/hw/i2c/Kconfig > @@ -17,

[Qemu-devel] [PATCH 8/8] hw/i386: Move ACPI_SMBUS out of I440FX (Kconfig)

2019-03-10 Thread Philippe Mathieu-Daudé
The SMBus interface is a slow bus not related to the i440fx northbridge, it comes from the PIIX3 southbridge. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 56e72abb8c..9ac833b9

[Qemu-devel] [PATCH 5/8] hw/southbridge: Cleanup the PIIX4 chipset in Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The PIIX4 (Intel 82371AB) is a bridge between PCI <-> ISA. It is an exhanced PIIX3, thus contains the same features. It also contains: - Power Management (ACPI rev 1.0) - IDE UDMA/33 - SMBus interface (host and slave) - RTC Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/Kconfig | 6 +-

[Qemu-devel] [PATCH 4/8] hw/southbridge: Add the PIIX3 chipset to Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The PIIX3 (Intel 82371SB) is a bridge between PCI <-> ISA. It is an exhanced PIIX, thus contains the same features. It also contains: - separate Master/Slave IDE mode - compliant to PCI rev 2.1 specifications - IOAPIC - USB UHCI (2 ports) - USB Legacy Support (emulated devices): - 8042 Key

[Qemu-devel] [PATCH 7/8] hw/i386: The 'isapc' machine is built around a PIIX3 southbridge

2019-03-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/Kconfig | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index f6b74e2dc0..56e72abb8c 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -52,8 +52,6 @@ config I440FX select PC_PCI

[Qemu-devel] [PATCH 6/8] hw/southbridge: Add ACPI_PIIX4 to Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
Since the default-configs/mips-softmmu-common.mak is not yet ported to the Kconfig format, we have to select this variable there (used by the MIPS Malta machine). Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-softmmu-common.mak | 1 + hw/acpi/Kconfig | 7

[Qemu-devel] [PATCH 3/8] hw/southbridge: Add the PIIX chipset to Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The PIIX (Intel 82371FB) is a bridge between PCI <-> ISA. It contains: - IDE interface (PIO and burst transfers) - one 82c54 timer (and speaker tone output) - two 82c59 interrupts controllers - two 8237 DMA controllers - Power Management (programmable SMI) - NMI Signed-off-by: Philippe Math

[Qemu-devel] [PATCH 1/8] hw/i2c: The ACPI_SMBUS Kconfig depends on ACPI

2019-03-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig index ef1caa6d89..ec62909fa1 100644 --- a/hw/i2c/Kconfig +++ b/hw/i2c/Kconfig @@ -17,6 +17,7 @@ config VERSATILE_I2C config ACPI_SMBUS bool selec

[Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices

2019-03-10 Thread Philippe Mathieu-Daudé
Hi, This series is a cleanup for the PIIX/PIIX3/PIIX4 devices. The isapc machine split isn't clean because while designed on a PIIX3, our model uses ACPI features from the PIIX4. The i440fx cleanup is left for the the next development cycle. This series is a prerequisite for the MIPS Malta port

[Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
The Intel 8042 chipset also includes some functions unrelated to the keyboard, such the A20-Gate. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/hw/input/Kconfig b/hw/input/Kconfig index e2e66f0858..83e4546a28 100644 --- a/hw/in

Re: [Qemu-devel] [PATCH] hw/char/parallel: Make it possible to compile also without CONFIG_PARALLEL

2019-03-10 Thread Peter Maydell
On Sat, 9 Mar 2019 at 08:21, Thomas Huth wrote: > > For the downstream distribution of QEMU, we want to compile without > CONFIG_PARALLEL. Commit 9157eee1b1c076ff3 already moved the function > parallel_hds_isa_init() (which is still required for linking) into a file > that is included anyway, but

Re: [Qemu-devel] [PATCH] hw/char/parallel: Make it possible to compile also without CONFIG_PARALLEL

2019-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1552119170-15474-1-git-send-email-th...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [Qemu-devel] [PATCH 04/10] roms/edk2: advance to tag edk2-stable201903

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Update the roms/edk2 submodule hash from edk2-stable201811 to > edk2-stable201903. The release notes are available at > . > > $ git shortlog edk2-stable201811..edk2-stable201903 > > Achin Gu

Re: [Qemu-devel] [PATCH v4 19/29] hw/arm: Express dependencies of the MPS2 boards with Kconfig

2019-03-10 Thread Philippe Mathieu-Daudé
Hi Thomas, On 3/7/19 3:18 PM, Thomas Huth wrote: > Add Kconfig dependencies for the mps2-an* machines. > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 20 +--- > hw/arm/Kconfig | 18 ++ > 2 files changed, 19 insertions(+)

Re: [Qemu-devel] [PATCH v4 03/29] hw/sd/sdhci: Move PCI-related code into a separate file

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/7/19 3:18 PM, Thomas Huth wrote: > Some machines have an SDHCI device, but no PCI. To be able to > compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions > like pci_get_address_space() and pci_allocate_irq() there. Thus > move the PCI-related code into a separate file. > > This

Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

2019-03-10 Thread Michael S. Tsirkin
On Sat, Mar 09, 2019 at 10:30:47AM +0800, Heyi Guo wrote: > After the introduction of generic PCIe root port and PCIe-PCI bridge, we will > also have SHPC controller on ARM, and we don't support ACPI hot plug, so just > enable SHPC native hot plug. > > Igor also spotted the store operation outside

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

2019-03-10 Thread Auer, Lukas
Hi Bin, On Sun, 2019-03-10 at 22:57 +0800, Bin Meng wrote: > Hi Lukas, > > On Sun, Mar 10, 2019 at 9:44 PM Auer, Lukas > wrote: > > Hi Bin, > > > > On Sun, 2019-03-10 at 09:07 +0800, Bin Meng wrote: > > > Hi Lukas, > > > > > > On Mon, Feb 11, 2019 at 6:13 AM Lukas Auer > > > wrote: > > > > Re

Re: [Qemu-devel] [PATCH 01/10] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"

2019-03-10 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 3/10/19 4:17 PM, Philippe Mathieu-Daudé wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: >> Extract the dense logic for architecture and toolchain massaging from >> "tests/uefi-test-tools/build.sh", to a set of small functions. We'll reuse >> these functions for building full platform

Re: [Qemu-devel] [PATCH v3 10/10] qemu-binfmt-conf.sh: support QEMU_TARGETS

2019-03-10 Thread Laurent Vivier
On 06/03/2019 05:55, Unai Martinez-Corral wrote: > Rename CPUS to TARGETS, and support QEMU_TARGETS environment variable. > This does not break backward compatibility, because it is just a placeholder. > > Consistently with 'path', 'suffix', 'persistent' and 'credential', > provide an environment

Re: [Qemu-devel] [PATCH v3 9/10] qemu-binfmt-conf.sh: update usage()

2019-03-10 Thread Laurent Vivier
On 06/03/2019 05:54, Unai Martinez-Corral wrote: > Reduce indentation to better use available space. > > Add list of supported environment variables and their default values. > > Signed-off-by: Unai Martinez-Corral > --- > scripts/qemu-binfmt-conf.sh | 61 - >

Re: [Qemu-devel] [PATCH v3 8/10] qemu-binfmt-conf.sh: refactor usage()

2019-03-10 Thread Laurent Vivier
On 06/03/2019 05:53, Unai Martinez-Corral wrote: > Reorder how the options are presented to the user. Move 'systemd' > and 'debian' to the end, so that the latter is close to the additional > comments and example commands about it. Make the order in the prototype > consistent with the list where ea

Re: [Qemu-devel] [PATCH v3 7/10] qemu-binfmt-conf.sh: add option --reset

2019-03-10 Thread Laurent Vivier
On 06/03/2019 05:52, Unai Martinez-Corral wrote: > This is a partial implementation. > > Allows to remove a single or a list of already registered binfmt > interpreters. If is a list, it must be comma-separated. I think ARCHS and CPUS are the same thing, so use the same word. > Valid values are

Re: [Qemu-devel] [PATCH v3 6/10] qemu-binfmt-conf.sh: generalize to positional

2019-03-10 Thread Laurent Vivier
On 06/03/2019 05:50, Unai Martinez-Corral wrote: > This breaks brackward compatibility. > > Option '--systemd CPU' allows to register binfmt interpreters for a > single target architecture or for 'ALL' (of them). This patch > generalizes the approach to support it in any mode (default, '--debian'

Re: [Qemu-devel] [PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps

2019-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190305234337.18353-1-js...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Markus Armbruster
Cleber Rosa writes: > On Thu, Mar 07, 2019 at 01:09:52PM +, Peter Maydell wrote: >> On Thu, 7 Mar 2019 at 12:56, Paolo Bonzini wrote: >> > In any case, this wouldn't change; as you suggest below, configure could >> > remain as a front-end (well, in-srcdir builds are not supported by >> > Mes

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Markus Armbruster
Paolo Bonzini writes: > Hi all, > > lately I have been thinking of converting the QEMU build system to > Meson. Meson is a relatively new build system that can replace > Autotools or hand-written Makefiles such as QEMU; as a die-hard > Autotools fan, I must say that Meson is by far better than a

Re: [Qemu-devel] [PATCH v2] linux-user: Add missing IPV6 sockopts

2019-03-10 Thread Laurent Vivier
On 10/03/2019 12:12, Helge Deller wrote: > When running ssh over IPv6 with linux-user I faced this warning: > Unsupported setsockopt level=41 optname=67 > setsockopt IPV6_TCLASS 32: Protocol not available: > > This patch adds code to the linux-user emulatation for setting and > retrieving of a f

Re: [Qemu-devel] [PATCH v2] linux-user: Add missing IPV6 sockopts

2019-03-10 Thread Laurent Vivier
On 10/03/2019 12:12, Helge Deller wrote: > When running ssh over IPv6 with linux-user I faced this warning: > Unsupported setsockopt level=41 optname=67 > setsockopt IPV6_TCLASS 32: Protocol not available: > > This patch adds code to the linux-user emulatation for setting and > retrieving of a f

[Qemu-devel] [PATCH] tests: test-qgraph: fix a memory leak

2019-03-10 Thread Li Qiang
Spotted by ASAN when 'make check'. Signed-off-by: Li Qiang --- tests/test-qgraph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c index f6a6565e31..5c7e457075 100644 --- a/tests/test-qgraph.c +++ b/tests/test-qgraph.c @@ -122,7 +12

Re: [Qemu-devel] [PULL 00/60] ppc-for-4.0 queue 20190310

2019-03-10 Thread Peter Maydell
ilable in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190310 > > for you to fetch changes up to 08d020471fcd41cb020fc9987ed1945eefcc8805: > > spapr: Use CamelCase properly (2019-03-10 14:35:44 +1100) > > ---

[Qemu-devel] [Bug 1371915] Re: Make Uninstall Rule Requested

2019-03-10 Thread Deepika Choudhary
Can ubuntu 14.04 support the "checkinstall" program? If yes, then can we use the checkinstall program to fix this issue?? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1371915 Title: Make Uninstall

Re: [Qemu-devel] [PATCH 01/10] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Extract the dense logic for architecture and toolchain massaging from > "tests/uefi-test-tools/build.sh", to a set of small functions. We'll reuse > these functions for building full platform firmware images. > > Signed-off-by: Laszlo Ersek > --- > roms/e

Re: [Qemu-devel] [PATCH 06/10] roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 2:53 AM, Philippe Mathieu-Daudé wrote: > On 3/9/19 2:32 AM, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 3/9/19 1:48 AM, Laszlo Ersek wrote: >>> We don't (can't) have a recipe for building just $(EFIROM); therefore, >>> while we call the target $(EFIROM), we actually build all of

Re: [Qemu-devel] [PATCH 05/10] roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 1:48 AM, Laszlo Ersek wrote: > The edk2 "build" utility natively supports building modules (that is, INF > files) in parallel. The feature is not useful when building a single > module (with the "-m" option), but it is useful for platform firmware > builds (which include many modules). Ad

Re: [Qemu-devel] [PATCH 02/10] roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Adapt the qemu_edk2_get_toolchain() function in "roms/edk2-funcs.sh" in > advance to edk2 commit 8d7cdfae8cb8 ("OvmfPkg: require GCC48 or later", > 2019-01-08), which is part of the "edk2-stable201903" tag. > > Signed-off-by: Laszlo Ersek Reviewed-by: Phi

Re: [Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

2019-03-10 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 3/9/19 5:48 PM, Philippe Mathieu-Daudé wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: >> Add the "efi" target to "Makefile". >> >> Introduce "Makefile.edk2" for building and cleaning the firmware images >> and varstore templates. >> >> Collect the common bits from the recipes in the

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

2019-03-10 Thread Bin Meng
Hi Lukas, On Sun, Mar 10, 2019 at 9:44 PM Auer, Lukas wrote: > > Hi Bin, > > On Sun, 2019-03-10 at 09:07 +0800, Bin Meng wrote: > > Hi Lukas, > > > > On Mon, Feb 11, 2019 at 6:13 AM Lukas Auer > > wrote: > > > Re-add the previous compatible string "riscv-virtio-soc" to the soc > > > device tree

Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/10/19 12:34 PM, Li Qiang wrote: > Fixes: 2dbfadf ^ Please keep tags together (with Signed-off-by, ...) > Spotted by ASAN when 'make check'. I'm not native English speaker but I'd say: Spotted by ASAN [with] 'make check'. or Spotted by ASAN [while running] 'make check'. Here goes: "Fi

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 7 Mar 2019 at 06:39, Thomas Huth wrote: >> On 06/03/2019 19.12, Paolo Bonzini wrote: >> > lately I have been thinking of converting the QEMU build system to >> > Meson. Meson is a relatively new build system that can replace >> > Autotools or hand-written Makefil

[Qemu-devel] [Bug 1819343] [NEW] Qcow2 image stuck as locked after host crash

2019-03-10 Thread Tim Schuster
Public bug reported: After a host crash, the qcow2 image of the VM, stored on a remote NFS share, has become inaccessible. Libvirt/QEMU reports that 'failed to get "write" lock\nIs another process using the image [/path/nfs/image.qcow2]?'. No process is accessing the image from either host or the

Re: [Qemu-devel] converting build system to Meson?

2019-03-10 Thread Markus Armbruster
Daniel P. Berrangé writes: [...] > As long term contributors we've built enough enough knowledge to > QEMU to consider our build system attractive or even "simple", The words that come to my mind aren't "attractive" or "simple", but "impressively clever", "brittle", and "uh, can I hack on someth

[Qemu-devel] [Bug 1818483] Re: qemu user mode does not support binfmt_misc config with flags include "P"

2019-03-10 Thread YunQiang Su
@Peter Luyou and me are working on try to pass the info about whether P flag is enabled or not by enviroment var or auxval. While we have not found the right method to do it from binfmt_misc. In fact, currently qemu trys to process the O flag, and it cannot work at all. When you install qemu-user-

[Qemu-devel] [PATCH v7 0/2] Basic ATI VGA emulation

2019-03-10 Thread BALATON Zoltan
Rebase on master to fix build with new Kconfig based stuff. BALATON Zoltan (2): hw/display: Add basic ATI VGA emulation mips_fulong2e: Add on-board graphics chip hw/display/Kconfig | 6 + hw/display/Makefile.objs | 2 + hw/display/ati.c | 865 +++

[Qemu-devel] [PATCH v7 2/2] mips_fulong2e: Add on-board graphics chip

2019-03-10 Thread BALATON Zoltan
Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar

[Qemu-devel] [PATCH v7 1/2] hw/display: Add basic ATI VGA emulation

2019-03-10 Thread BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fulong2e expect this to be available. Fortunately these are very similar chips so they can be mostly emulated

[Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686

2019-03-10 Thread BALATON Zoltan
Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this. Signed-off-by: BALATON Zoltan --- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 57e09a0cb8..e092da3fc3 100644 --- a/hw/isa/Kco

[Qemu-devel] [PATCH] ati-vga: Implement DDC and EDID info from monitor

2019-03-10 Thread BALATON Zoltan
This adds DDC support to ati-vga and connects i2c-ddc to provide EDID info that is read by guests to find available screen modes. Not sure if this is 100% correct yet but at least MorphOS is happy with it and starts in a high resolution mode instead of 640x480 (although its splash screen is still n

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

2019-03-10 Thread Auer, Lukas
Hi Bin, On Sun, 2019-03-10 at 09:07 +0800, Bin Meng wrote: > Hi Lukas, > > On Mon, Feb 11, 2019 at 6:13 AM Lukas Auer > wrote: > > Re-add the previous compatible string "riscv-virtio-soc" to the soc > > device tree node to allow U-Boot and Linux to bind machine-specific > > drivers to it. The cu

[Qemu-devel] [PATCH] tests: test-announce-self: fix memory leak

2019-03-10 Thread Li Qiang
Spotted by ASAN when 'make check'. Signed-off-by: Li Qiang --- tests/test-announce-self.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/tests/test-announce-self.c b/tests/test-announce-self.c index 1644d34a3f..3f370d8bf5 100644 --- a/tests/test-announc

Re: [Qemu-devel] [PULL 00/25] Misc patches for QEMU 4.0 soft freeze

2019-03-10 Thread Peter Maydell
On Sat, 9 Mar 2019 at 07:50, Paolo Bonzini wrote: > > The following changes since commit 62cfabb52210139843e26c95434356f73a0631b9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190307' into > staging (2019-03-08 15:17:01 +) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-03-10 Thread 李强
Hi Paolo, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang At 2019-01-08 07:41:09, "Paolo Bonzini" wrote: >On 02/01/19 08:41, Li Qiang wrote: >> Commit 376692b9dc6(cpus: protect work list with work_mutex) >> initialize a work_mutex in cpu_common_initfn, however fo

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/10/19 4:56 AM, Michael S. Tsirkin wrote: > On Sat, Mar 09, 2019 at 01:48:16AM +0100, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/qemu.git >> Branch: edk2_build >> >> This series advances the roms/edk2 submodule to the "edk2-stable201903" >> release, and builds and captures platfor

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2019-03-10 Thread Li Qiang
Hi Jason, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang Jason Wang 于2018年11月22日周四 上午10:22写道: > > On 2018/11/22 上午1:39, Michael S. Tsirkin wrote: > > On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote: > >> On 11/21/18 6:23 AM, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PULL 0/4] NBD patches for 2019-03-08, 4.0 softfreeze

2019-03-10 Thread Peter Maydell
On Fri, 8 Mar 2019 at 17:41, Eric Blake wrote: > > The following changes since commit c557a8c7b755d8c153fc0f5be00688228be96e76: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20190306a' into staging (2019-03-06 > 14:50:33 +) > > are available in the Git repository

Re: [Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

2019-03-10 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Add the "efi" target to "Makefile". > > Introduce "Makefile.edk2" for building and cleaning the firmware images > and varstore templates. > > Collect the common bits from the recipes in the helper script > "edk2-build.sh". > > Signed-off-by: L

[Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-10 Thread Li Qiang
Fixes: 2dbfadf Spotted by ASAN when 'make check'. Signed-off-by: Li Qiang --- tests/test-bdrv-graph-mod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c index 458dfa6661..8bf0fe735d 100644 --- a/tests/test-bdrv-graph-mod.c +++ b/test

[Qemu-devel] [PATCH v2] linux-user: Add missing IPV6 sockopts

2019-03-10 Thread Helge Deller
When running ssh over IPv6 with linux-user I faced this warning: Unsupported setsockopt level=41 optname=67 setsockopt IPV6_TCLASS 32: Protocol not available: This patch adds code to the linux-user emulatation for setting and retrieving of a few missing IPV6 options, including IPV6_TCLASS. Sign

Re: [Qemu-devel] [PATCH] Added periodic IRQ support for bcm2836_control local timer

2019-03-10 Thread bzt
Hi, Okay, as you wish. My code works either way and on real hardware as well, because I acknowledge the periodic IRQ as soon as possible, so good for me. Sign-off-by: Zoltán Baldaszti Subject: [PATCH] Added periodic IRQ support for bcm2836_control local timer diff --git a/hw/intc/bcm2836_control

Re: [Qemu-devel] [PATCH v3 2/2] hw/nvram/fw_cfg: Use the ldst API

2019-03-10 Thread Laurent Vivier
On 09/03/2019 19:19, Philippe Mathieu-Daudé wrote: > The load/store API eases code review. > > Reviewed-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/nvram/fw_cfg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/f

Re: [Qemu-devel] [PATCH v3 1/2] hw/arm/virt: Remove null-check in virt_build_smbios()

2019-03-10 Thread Laurent Vivier
On 09/03/2019 19:19, Philippe Mathieu-Daudé wrote: > Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board", > 2014-12-22), the machvirt_init() unconditionally creates the > fw_cfg object. Later, commit c30e15658b1b ("smbios: implement > smbios support for mach-virt", 2015-09-07) added a sup

Re: [Qemu-devel] [PATCH] vfio-pci: enable by default

2019-03-10 Thread Daniel Henrique Barboza
Just faced this problem when trying to test vfio-pci using upstream: qemu-system-ppc64: -device vfio-pci,host=0035:03:00.0,id=hostdev8: 'vfio-pci' is not a valid device model name This patch fixed it. Tested-by: Daniel Henrique Barboza On 3/8/19 2:36 PM, Paolo Bonzini wrote: CONFIG_VFIO_

Re: [Qemu-devel] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 06, 2019 at 08:03:48PM +0100, Igor Mammedov wrote: >> On Mon, 4 Mar 2019 16:35:16 + >> Daniel P. Berrangé wrote: >> >> > On Mon, Mar 04, 2019 at 05:20:13PM +0100, Michal Privoznik wrote: >> > > We couldn't have done that. How we would migrate from ol

  1   2   >