2019/3/10 18:02, Laurent Vivier: > On 06/03/2019 05:50, Unai Martinez-Corral wrote: > > The list can be separated by spaces, tabs, newlines or commas. If no > > I think it would be simpler to not manage commas, and to use the default > field separator.
Commas were supported because the same function is used to parse CPUS here and ARCHS in patch 7/10. ARCHS must be separated by commas. Nonetheless, if we do not support CPUS and ARCHS in a single command, we can avoid managing commas. Agree and thanks for all of the remaining comments. I will apply them: > Why do you need to introduce a new variable "all", you can use directly > "qemu_target_list". > No need to introduce a new variable, you can use directly > checked_target_list > Use directly "qemu_target_list" > You don't need a new variable, you can check "x$cpu" = "x$target" to > know if you have found the target. > I think you don't need to add the ":" at the beginning of the list. Regards, Unai
