On Fri, Mar 08, 2019 at 10:12:10AM +0000, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > The recently added max-postcopy-bandwidth parameter is only read > at the transition from precopy->postcopy where as the older > max-bandwidth parameter updates the migration bandwidth when changed > even if the migration is already running. > > Fix this discrepency so that: > a) You can change the bandwidth during postcopy by setting > max-postcopy-bandwidth > > b) Changing max-bandwidth during postcopy has no effect > (it currently changes the postcopy bandwidth which isn't > expected). > > Fixes: 7e555c6c > bz: https://bugzilla.redhat.com/show_bug.cgi?id=1686321 > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Reviewed-by: Peter Xu <pet...@redhat.com> Now in qapi/migration.json it's not mentioning precopy in the max-bandwidth entry which seems to work even for postcopy but it'll not: # @max-bandwidth: to set maximum speed for migration. maximum speed in # bytes per second. (Since 2.8) Should we consider to touch that up too to match everything? -- Peter Xu
