On 06/03/2019 05:52, Unai Martinez-Corral wrote: > This is a partial implementation. > > Allows to remove a single or a list of already registered binfmt > interpreters. If <ARCHS> is a list, it must be comma-separated.
I think ARCHS and CPUS are the same thing, so use the same word. > Valid values are those in qemu_target_list. If <ARCHS> is 'ALL', all > the existing 'qemu-*' interpreters are removed. > > This is partial because 'debian' and 'systemd' configurations are not > removed. If option 'reset' is provided before any of those, reset is > executed first and the configuration proceeds. However, if 'reset' is > provided after any of them, the script will exit with error 'option > reset not implemented for this mode yet'. > > Removal is done by printing '-1' as explained at: > https://www.kernel.org/doc/Documentation/admin-guide/binfmt-misc.rst > > Signed-off-by: Unai Martinez-Corral <unai.martinezcor...@ehu.eus> > --- > scripts/qemu-binfmt-conf.sh | 36 +++++++++++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh > index 2751363089..824e3c4c34 100755 > --- a/scripts/qemu-binfmt-conf.sh > +++ b/scripts/qemu-binfmt-conf.sh > @@ -197,8 +197,8 @@ qemu_get_family() { > > usage() { > cat <<EOF > -Usage: qemu-binfmt-conf.sh [--path PATH][--debian][--systemd] > - [--help][--credential][--exportdir PATH] > +Usage: qemu-binfmt-conf.sh [--help][--path PATH][--debian][--systemd] > + [--reset ARCHS][--credential][--exportdir PATH] > [--persistent][--suffix SUFFIX][CPUS] I don't like the idea of being able to set and reset different interpretes with same command line call. Make "--reset" exclusive without parameter to be able to use the common cpu list at the end of the command line (this way, I think you would be able to share more common code between setting an resetting). You could have a look to Alex Bennée's patch: https://patchwork.ozlabs.org/patch/938796/ I think this is the good way to do this and it should merge easily with your series. Thanks, Laurent
