Re: [Qemu-devel] [PATCH] intel_iommu: do address space switching when reset

2018-09-05 Thread Peter Xu
On Wed, Sep 05, 2018 at 08:55:50AM -0600, Alex Williamson wrote: > On Wed, 5 Sep 2018 19:31:58 +0800 > Peter Xu wrote: > > > We will drop all the mappings when system reset, however we'll still > > keep the existing memory layouts. That'll be problematic since if IOMMU > > is enabled in the gue

Re: [Qemu-devel] [PATCH 3/5] qemu_init_vcpu: add a new Error paramater to propagate

2018-09-05 Thread Fei Li
On 09/06/2018 01:15 AM, Eric Blake wrote: Adding Markus, as the maintainer of Error APIs, to make sure he sees this thread. Thanks. :) On 09/04/2018 06:22 AM, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 07:08:20PM +0800, Fei Li wrote: In the subject line: s/paramater/parameter/ Th

Re: [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails

2018-09-05 Thread Fei Li
On 09/05/2018 10:38 PM, Fam Zheng wrote: On Wed, 09/05 19:20, Fei Li wrote: On 09/05/2018 04:36 PM, Daniel P. Berrangé wrote: On Wed, Sep 05, 2018 at 12:17:24PM +0800, Fei Li wrote: Thanks for the review! :) On 09/04/2018 07:26 PM, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 07:08

Re: [Qemu-devel] [PATCH v2 3/4] slirp: Implement RFC2132 TFTP server name

2018-09-05 Thread Thomas Huth
On 2018-09-06 07:43, Fam Zheng wrote: > This new usernet option can be used to add data for option 66 (tftp > server name) in the BOOTP reply, which is useful in PXE based automatic > OS install such as OpenBSD. > > Signed-off-by: Fam Zheng > --- > net/slirp.c | 12 ++-- > qapi/net.

Re: [Qemu-devel] [PATCH v2 2/4] slirp: Add sanity check for str option length

2018-09-05 Thread Thomas Huth
On 2018-09-06 07:43, Fam Zheng wrote: > When user provides a long domainname or hostname that doesn't fit in the > DHCP packet, we mustn't overflow the response packet buffer. Instead, > report errors, following the g_warning() in the slirp->vdnssearch > branch. > > Also check the strlen against 2

[Qemu-devel] [PATCH 3/3] scsi: remove unused lsi53c895a_create() and lsi53c810_create() functions

2018-09-05 Thread Mark Cave-Ayland
Now that these functions are no longer required they can be removed. Signed-off-by: Mark Cave-Ayland --- hw/scsi/lsi53c895a.c | 14 -- include/hw/pci/pci.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index edb0b13e23..2094b1ebc

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Hu, Robert
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, September 6, 2018 1:41 > To: Eduardo Habkost > Cc: Robert Hoo ; Paolo Bonzini > ; Hu, Robert ; r...@twiddle.net; > thomas.lenda...@amd.com; qemu-devel@nongnu.org; Liu, Jingqi > ; Markus Armbruster ; Jiri

[Qemu-devel] [PATCH 2/3] scsi: move lsi53c895a_create() and lsi53c810_create() callers to pci_create_simple()

2018-09-05 Thread Mark Cave-Ayland
As part of commits a64aa5785d "hw: Deprecate -drive if=scsi with non-onboard HBAs" and b891538e81 "hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices" the lsi53c895a_create() and lsi53c810_create() functions were added to wrap pci_create_simple() and scsi_bus_legacy_handle_cmdline(). U

[Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions

2018-09-05 Thread Mark Cave-Ayland
As part of an upcoming 40p patchset I have a requirement to change the PCI configuration of the LSI SCSI. However since commits a64aa5785d "hw: Deprecate -drive if=scsi with non-onboard HBAs" and b891538e81 "hw/ppc/prep: Fix implicit creation of "-drive if=scsi", the lsi53c8*_create() wrapper fun

[Qemu-devel] [PATCH 1/3] scsi: move lsi53c895a structures and defines into separate lsi53c895a.h file

2018-09-05 Thread Mark Cave-Ayland
There is also one small change to the new header file which is the addition of the previously missing LSI53C810 define. Signed-off-by: Mark Cave-Ayland --- hw/scsi/lsi53c895a.c | 116 +--- include/hw/scsi/lsi53c895a.h | 137

[Qemu-devel] [PATCH v2 1/4] virtio: update MemoryRegionCaches when guest negotiates features

2018-09-05 Thread Fam Zheng
From: Paolo Bonzini Because the cache is sized to include the rings and the event indices, negotiating the VIRTIO_RING_F_EVENT_IDX feature will result in the size of the cache changing. And because MemoryRegionCache accesses are range-checked, if we skip this we end up with an assertion failure.

[Qemu-devel] [PATCH v2 2/4] slirp: Add sanity check for str option length

2018-09-05 Thread Fam Zheng
When user provides a long domainname or hostname that doesn't fit in the DHCP packet, we mustn't overflow the response packet buffer. Instead, report errors, following the g_warning() in the slirp->vdnssearch branch. Also check the strlen against 256 when initializing slirp, which limit is also fr

[Qemu-devel] [PATCH v2 0/4] tests: VM build in OpenBSD 6.3

2018-09-05 Thread Fam Zheng
In this new version: - Include the virtio fix by Paolo so that it's easier to test this series. - Improve the slirp patch on input validation and buffer overflow. [Thomas] - Use OpenBSD 6.3 image; Use guestfwd and tftp-server-name. Thanks to the loose dependency, the three parts (patc

[Qemu-devel] [PATCH v2 4/4] tests: vm: auto_install OpenBSD

2018-09-05 Thread Fam Zheng
Upgrade OpenBSD to 6.3 using auto_install. Especially, drop SDL1, include SDL2. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 6 ++-- tests/vm/openbsd | 81 -- 2 files changed, 74 insertions(+), 13 deletions(-) diff --git a/tests/vm/basevm.py b

[Qemu-devel] [PATCH v2 3/4] slirp: Implement RFC2132 TFTP server name

2018-09-05 Thread Fam Zheng
This new usernet option can be used to add data for option 66 (tftp server name) in the BOOTP reply, which is useful in PXE based automatic OS install such as OpenBSD. Signed-off-by: Fam Zheng --- net/slirp.c | 12 ++-- qapi/net.json| 5 - qemu-options.hx | 7 ++- sli

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-05 Thread Jason Wang
On 2018年09月04日 16:14, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 11:07:38AM +0800, Jason Wang wrote: On 2018年09月03日 19:54, Daniel P. Berrangé wrote: + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. +

Re: [Qemu-devel] [PATCH v2] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-09-05 Thread Mark Cave-Ayland
On 05/09/18 01:13, David Gibson wrote: > On Tue, Sep 04, 2018 at 09:49:03PM +0200, Hervé Poussineau wrote: >> OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff >> Use it, instead of relying on an unmaintained and very limited firmware. >> >> Signed-off-by: Hervé Poussineau >

Re: [Qemu-devel] [PATCH v3] target/ppc/kvm: set vcpu as online/offline

2018-09-05 Thread David Gibson
On Tue, Sep 04, 2018 at 02:54:18PM +0530, Nikunj A Dadhania wrote: > Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is > online(1) or offline(0) > > KVM will use this information to set the RWMR register, which controls the > PURR > and SPURR accumulation. > > CC: pau..

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-05 Thread Marc-André Lureau
Hi On Tue, Sep 4, 2018 at 10:47 AM Igor Mammedov wrote: > > On Fri, 31 Aug 2018 19:24:24 +0200 > Marc-André Lureau wrote: > > > This allows to pass the last failing test from the Windows HLK TPM 2.0 > > TCG PPI 1.3 tests. > > > > The interface is described in the "TCG Platform Reset Attack > > M

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-05 Thread Peter Xu
On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: > On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > > From: Peter Xu > > > > Before this patch, monitor fd helpers might be called even earlier than > > monitor_init_globals(). This can be problematic. > > > >

[Qemu-devel] [PATCH v11 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-05 Thread Marc-André Lureau
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This interface should be used

[Qemu-devel] [PATCH v11 2/6] tpm: add a "ppi" boolean property

2018-09-05 Thread Marc-André Lureau
The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >3.0 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/compat.h | 11 ++-

[Qemu-devel] [PATCH v11 5/6] acpi: build TPM Physical Presence interface

2018-09-05 Thread Marc-André Lureau
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code

[Qemu-devel] [PATCH v11 6/6] tpm: add ACPI memory clear interface

2018-09-05 Thread Marc-André Lureau
This allows to pass the last failing test from the Windows HLK TPM 2.0 TCG PPI 1.3 tests. The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qem

[Qemu-devel] [PATCH v11 4/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg

2018-09-05 Thread Marc-André Lureau
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [ Marc-A

[Qemu-devel] [PATCH v11 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-09-05 Thread Marc-André Lureau
The following patch is going to add compatiblity parameters. Signed-off-by: Marc-André Lureau --- include/hw/i386/pc.h | 5 - hw/i386/pc_piix.c| 15 --- hw/i386/pc_q35.c | 13 +++-- 3 files changed, 27 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/p

[Qemu-devel] [PATCH v11 0/6] Add support for TPM Physical Presence interface

2018-09-05 Thread Marc-André Lureau
Hi, The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware looks for and acts upon by sending sequences of commands to the TPM. A dedicated memory region is added to the TPM C

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-09-05 Thread Liu, Jing2
Hi Marcle, On 9/6/2018 12:36 AM, Marcel Apfelbaum wrote: On 09/05/2018 05:08 AM, Liu, Jing2 wrote: Hi Marcel and Michael, Got no response so I would like to ask if I need do something more for this serial? :) Hi Jing, Maybe Michael is PTO, let's wait a few more days. Thank you, I got i

Re: [Qemu-devel] [PATCH v8 1/3] qmp: query-current-machine with wakeup-suspend-support

2018-09-05 Thread Michael Roth
Quoting Daniel Henrique Barboza (2018-07-05 15:08:11) > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system reset

Re: [Qemu-devel] [PATCH v8 3/3] qmp hmp: Make system_wakeup check wake-up support and run state

2018-09-05 Thread Michael Roth
Quoting Daniel Henrique Barboza (2018-07-05 15:08:13) > The qmp/hmp command 'system_wakeup' is simply a direct call to > 'qemu_system_wakeup_request' from vl.c. This function verifies if > runstate is SUSPENDED and if the wake up reason is valid before > proceeding. However, no error or warning is

Re: [Qemu-devel] [PATCH v2 3/4] qga: win32: fix crashes when PCI info cannot be retrived

2018-09-05 Thread Michael Roth
Quoting Tomáš Golembiovský (2018-08-07 05:51:37) > The guest-get-fsinfo command collects also information about PCI > controller where the disk is attached. When this fails for some reasons > it tries to return just the partial information. However in certain > cases the pointer to the structure wa

[Qemu-devel] [Bug 1790975] Re: arm virt ecam pcie conflict

2018-09-05 Thread Jonathan Marler
Oh, I forgot, I should have also posted the relevant DTS contents: pcie@1000 { interrupt-map-mask = <0x1800 0x0 0x0 0x7>; interrupt-map = <0x0 0x0 0x0 0x1 0x8001 0x0 0x0 0x0 0x3 0x4 0x0 0x0 0x0 0x2 0x8001 0x0 0x0 0x0 0x4 0x4 0x0 0x0 0x0 0x3 0x8001 0x0 0

[Qemu-devel] [Bug 1790975] [NEW] arm virt ecam pcie conflict

2018-09-05 Thread Jonathan Marler
Public bug reported: This occurs on qemu_v3.0.0 but not on qemu_v2.12.2 (built from qemu_v3.0.0 tag on github) Symptom: You'll see something like this in the kernel output: [1.285210] OF: PCI: host bridge /pcie@1000 ranges: [1.286246] OF: PCI:IO 0x3eff..0x3eff -> 0x00

Re: [Qemu-devel] [PULL 0/9] riscv-pullreq queue

2018-09-05 Thread Alistair Francis
On Tue, Sep 4, 2018 at 4:14 PM, Alistair Francis wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git reposito

[Qemu-devel] [PULL v2 07/10] target/riscv: call gen_goto_tb on DISAS_TOO_MANY

2018-09-05 Thread Alistair Francis
From: "Emilio G. Cota" Performance impact of this and the previous commits, measured with the very-easy-to-cross-compile rv8-bench: https://github.com/rv8-io/rv8-bench Host: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz - Key: before: master after1,2,3: the 3 commits in this series (i.e. 3 is

[Qemu-devel] [PULL v2 04/10] RISC-V: Simplify riscv_cpu_local_irqs_pending

2018-09-05 Thread Alistair Francis
From: Michael Clark This commit is intended to improve readability. There is no change to the logic. Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Signed-off-by: Alistair Francis --- target/r

[Qemu-devel] [PULL v2 06/10] target/riscv: optimize indirect branches

2018-09-05 Thread Alistair Francis
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alistair Francis --- target/riscv/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index ec2988b4f6..66a80ca772

[Qemu-devel] [PULL v2 08/10] hw/riscv/virtio: Set the soc device tree node as a simple-bus

2018-09-05 Thread Alistair Francis
To allow Linux to enumerate devices on the /soc/ node set it as a "simple-bus". Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 248bbdffd3..e8ba4d1

[Qemu-devel] [PULL v2 03/10] RISC-V: Use atomic_cmpxchg to update PLIC bitmaps

2018-09-05 Thread Alistair Francis
From: Michael Clark The PLIC previously used a mutex to protect against concurrent access to the claimed and pending bitfields. Instead of using a mutex, we update the bitfields using atomic_cmpxchg. Rename sifive_plic_num_irqs_pending to sifive_plic_irqs_pending and add an early out if any inte

[Qemu-devel] [PULL v2 09/10] hw/riscv/spike: Set the soc device tree node as a simple-bus

2018-09-05 Thread Alistair Francis
To allow Linux to enumerate devices on the /soc/ node set it as a "simple-bus". Signed-off-by: Alistair Francis --- hw/riscv/spike.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index c8c056c50b..eb857c434e 100644 --- a/hw/riscv/spike.c

[Qemu-devel] [PULL v2 05/10] target/riscv: optimize cross-page direct jumps in softmmu

2018-09-05 Thread Alistair Francis
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alistair Francis --- target/riscv/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 0b6be74f2d..ec2988b4f6

[Qemu-devel] [PULL v2 02/10] RISC-V: Improve page table walker spec compliance

2018-09-05 Thread Alistair Francis
From: Michael Clark - Inline PTE_TABLE check for better readability - Change access checks from ternary operator to if - Improve readibility of User page U mode and SUM test - Disallow non U mode from fetching from User pages - Add reserved PTE flag check: W or W|X - Add misaligned PPN check - Se

[Qemu-devel] [PULL v2 00/10] riscv-pullreq queue

2018-09-05 Thread Alistair Francis
pull-riscv-pullreq-20180905 for you to fetch changes up to 1ca79ece35a5bcdcefb5a2582bc6da91f0640bf2: riscv: remove define cpu_init() (2018-09-05 09:58:38 -0700) A misc collection of RISC-V related patch

[Qemu-devel] [PULL v2 01/10] RISC-V: Update address bits to support sv39 and sv48

2018-09-05 Thread Alistair Francis
From: Michael Clark Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Palmer Dabbelt Reviewed-by: Alistair Francis Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

Re: [Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-09-05 Thread Heiko Sieger
I won’t be able to run any tests for the next 16 days at the very least, as I’m traveling. > On 5 Sep 2018, at 13:21, Dr. David Alan Gilbert wrote: > > I don't have the nvidia for pass through to try this with; but I suggest > that you try the following: > > a) Start a windows vm running an o

Re: [Qemu-devel] [PATCH] memory: size can be different from ptr_size

2018-09-05 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 7:51 PM, Marc-André Lureau wrote: > Hi > > On Wed, Sep 5, 2018 at 1:37 PM, Juan Quintela wrote: >> Marc-André Lureau wrote: >>> memory_region_init_ram*_ptr() take only the size of the MemoryRegion, >>> and allocate a RAMBlock with the same size. However, it may be >>>

[Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-05 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86 does.

[Qemu-devel] [PATCH V9 1/4] tests/migration: Convert x86 boot block compilation script into Makefile

2018-09-05 Thread Wei Huang
The x86 boot block header currently is generated with a shell script. To better support other CPUs (e.g. aarch64), we convert the script into Makefile. This allows us to 1) support cross-compilation easily, and 2) avoid creating a script file for every architecture. Note that, in the new design, t

[Qemu-devel] [PATCH V9 3/4] tests/migration: Add migration-test header file

2018-09-05 Thread Wei Huang
This patch moves the settings related migration-test from the migration-test.c file to a new header file. Reviewed-by: Juan Quintela Reviewed-by: Andrew Jones Signed-off-by: Wei Huang --- tests/migration-test.c | 28 ++-- tests/migration/migration-test.h | 21

[Qemu-devel] [PATCH V9 0/4] tests: Add migration test for aarch64

2018-09-05 Thread Wei Huang
This patchset adds a migration test for aarch64. It leverages Dave Gilbert's migration boot block patches to create a new test case for aarch64. V8->V9: * Remove accel= setting for AArch64. It uses the default "kvm:tcg" now * Revise the header file comment (suggested by drjones) * Name x86 dire

[Qemu-devel] [PATCH V9 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-05 Thread Wei Huang
Recently a new configure option, CROSS_CC_GUEST, was added to $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This patch tries to leverage this option to support cross compilation when the migration boot block file is being re-generated: * The x86 related files are moved to a ne

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread John Snow
On 09/05/2018 06:27 AM, Max Reitz wrote: > On 2018-09-04 22:32, John Snow wrote: >> >> >> On 09/04/2018 02:46 PM, Jeff Cody wrote: >>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: Use the component callbacks; prepare, abort, and clean. NB: prepare is only called when

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2018-09-05 Thread Edward Vielmetti
This bug is mentioned in this account from Cloudflare of porting their software stack to arm64: https://blog.cloudflare.com/porting-our-software-to-arm64/ The relevant section from that blog reads as follows: # Intermittent Go Failures > With a decent amount of Go code running through our CI sy

Re: [Qemu-devel] [RFC-PATCH V2] hw/pci/pci_example.c : Added a new pci example device

2018-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2018 at 12:38:00PM +0300, Yoni Bettan wrote: > The main goal is to add 2 example devices to be used as templates or guideline > for contributors when they wish to create a new device, the first is a PCI > device and the second will be a VirtIO device. > > Those devices may be compi

Re: [Qemu-devel] [PATCH] memory: size can be different from ptr_size

2018-09-05 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 1:37 PM, Juan Quintela wrote: > Marc-André Lureau wrote: >> memory_region_init_ram*_ptr() take only the size of the MemoryRegion, >> and allocate a RAMBlock with the same size. However, it may be >> convenient to expose a smaller MemoryRegion (for ex: a few bytes) than

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eric Blake
On 09/05/2018 11:44 AM, Eduardo Habkost wrote: On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote: On 09/05/2018 09:10 AM, Eduardo Habkost wrote: Question to the QAPI schema maintainers below: ## -{ 'struct': 'X86CPUFeatureWordInfo', - 'data': { 'cpuid-input-eax': 'int', -

Re: [Qemu-devel] [PATCH v4 3/9] target/mips: Split mips instruction handling

2018-09-05 Thread Aleksandar Markovic
> From: Janeczek, Craig > Sent: Tuesday, September 4, 2018 4:44 PM > > Subject: RE: [PATCH v4 3/9] target/mips: Split mips instruction handling > > To clarify the OPC_MUL here is not an MXU instruction, this is the original > OPC_MUL that was in the special2 instruction set. The inclusion of this

Re: [Qemu-devel] [PATCH v4 3/9] target/mips: Split mips instruction handling

2018-09-05 Thread Aleksandar Markovic
> From: Janeczek, Craig > Sent: Tuesday, September 4, 2018 4:44 PM > > Subject: RE: [PATCH v4 3/9] target/mips: Split mips instruction handling > > To clarify the OPC_MUL here is not an MXU instruction, this is the original > OPC_MUL that was in the special2 instruction set. The inclusion of this

Re: [Qemu-devel] [PATCH v2 0/3] target/riscv: use tcg_lookup_and_goto_ptr

2018-09-05 Thread Alistair Francis
On Tue, Sep 4, 2018 at 6:07 PM, Emilio G. Cota wrote: > On Tue, Sep 04, 2018 at 16:42:32 -0700, Alistair Francis wrote: >> On Tue, Sep 4, 2018 at 4:39 PM, Emilio G. Cota wrote: >> > On Tue, Sep 04, 2018 at 13:18:28 -0700, Alistair Francis wrote: >> >> On Fri, Aug 31, 2018 at 3:22 PM, Emilio G. Co

Re: [Qemu-devel] [PATCH 3/5] qemu_init_vcpu: add a new Error paramater to propagate

2018-09-05 Thread Eric Blake
Adding Markus, as the maintainer of Error APIs, to make sure he sees this thread. On 09/04/2018 06:22 AM, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 07:08:20PM +0800, Fei Li wrote: In the subject line: s/paramater/parameter/ The caller of qemu_init_vcpu() already passed the **errp to

Re: [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen

2018-09-05 Thread Alberto Garcia
On Mon 03 Sep 2018 04:34:06 PM CEST, Alberto Garcia wrote: > +value = qemu_opt_get_del(opts, "discard"); > +if (value != NULL) { > +if (bdrv_parse_discard_flags(value, &reopen_state->flags) != 0) { > +error_setg(errp, "Invalid discard option"); > +ret = -EI

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eduardo Habkost
On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote: > On 09/05/2018 09:10 AM, Eduardo Habkost wrote: > > Question to the QAPI schema maintainers below: > > > > > > ## > > > -{ 'struct': 'X86CPUFeatureWordInfo', > > > - 'data': { 'cpuid-input-eax': 'int', > > > -'*cpuid-inpu

Re: [Qemu-devel] Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage

2018-09-05 Thread Eric Blake
On 09/05/2018 09:17 AM, Quan Xu wrote: From 7de4cc7c944bfccde0ef10992a7ec882fdcf0508 Mon Sep 17 00:00:00 2001 From: Quan Xu Date: Wed, 5 Sep 2018 22:06:58 +0800 Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage Since the bulk stage assumes in (migr

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-09-05 Thread Marcel Apfelbaum
On 09/05/2018 05:08 AM, Liu, Jing2 wrote: Hi Marcel and Michael, Got no response so I would like to ask if I need do something more for this serial? :) Hi Jing, Maybe Michael is PTO, let's wait a few more days. Michael, I can send a pull request for this series if you are busy. Thanks, M

[Qemu-devel] [PATCH] docs/block-replication.txt: Add more detail about replication_do_checkpoint_all

2018-09-05 Thread Zhang Chen
Add more detail description for COLO checkpoint use case. Suggested by Dr. David Alan Gilbert Signed-off-by: Zhang Chen --- docs/block-replication.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 6bde673

[Qemu-devel] [PATCH v2] linux-user: do setrlimit selectively

2018-09-05 Thread Max Filippov
setrlimit guest calls that affect memory resources (RLIMIT_{AS,DATA,STACK}) may interfere with QEMU internal memory management. They may result in QEMU lockup because mprotect call in page_unprotect would fail with ENOMEM error code, causing infinite loop of SIGSEGV. E.g. it happens when running li

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Eric Blake
On 09/05/2018 08:09 AM, John Snow wrote: On 09/05/2018 06:43 AM, Max Reitz wrote: On 2018-09-04 19:09, John Snow wrote: For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirr

Re: [Qemu-devel] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 06:40 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> In cases where we abort the block/mirror job, there's no point in >> installing the new backing chain before we finish aborting. >> >> Move this to the "success" portion of mirror_exit. > > Sounds a bit weird no

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eric Blake
On 09/05/2018 09:10 AM, Eduardo Habkost wrote: Question to the QAPI schema maintainers below: ## -{ 'struct': 'X86CPUFeatureWordInfo', - 'data': { 'cpuid-input-eax': 'int', -'*cpuid-input-ecx': 'int', -'cpuid-register': 'X86CPURegister32', +{ 'struct': 'X86CPUIDFeat

[Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-05 Thread Eduardo Habkost
Currently there's no way to make configure not try to use the system-provided capstone library using pkgconfig. Add support to --enable-capstone=internal option to make QEMU not use the system-provided library automatically. Signed-off-by: Eduardo Habkost --- configure | 5 + 1 file changed

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-05 Thread Wolfgang Bumiller
On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > From: Peter Xu > > Before this patch, monitor fd helpers might be called even earlier than > monitor_init_globals(). This can be problematic. > > After previous work, now monitor_init_globals() does not depend on > accelerator

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 16:02 hat Peter Krempa geschrieben: > On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > > > block-commit is able to reopen the format layers and works as expected. > > > > > > Unfortunately though the 'read-only' optio

[Qemu-devel] [Bug 1735049] Re: Need MTTCG support for x86 guests

2018-09-05 Thread Emilio G. Cota
Patches are now on the list to enable MTTCG for i386 and x86_64 guests. See v2 here: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00237.html I'm hoping these patches will be in the next QEMU release. Regarding your last question: > For instance, has support for strong-on-weak memory

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 10:09:46PM +0800, Hongbo Zhang wrote: > On 5 September 2018 at 20:02, Andrew Jones wrote: > > On Wed, Sep 05, 2018 at 06:08:57PM +0800, Hongbo Zhang wrote: > >> On 30 August 2018 at 21:29, Ard Biesheuvel > >> wrote: > >> > On 30 August 2018 at 12:02, Leif Lindholm > >>

[Qemu-devel] [Bug 1529173] Re: Absolutely slow Windows XP SP3 installation

2018-09-05 Thread Emilio G. Cota
For integer workloads such as installing an OS you should expect TCG to be about 12x slower than KVM on average. That is on current master; note that TCG has gotten faster in the last couple of years. See a performance comparison from v2.7.0 to v2.11.0 for SPEC06 here: https://imgur.com/a/5P5zj I'

Re: [Qemu-devel] [PATCH] intel_iommu: do address space switching when reset

2018-09-05 Thread Alex Williamson
On Wed, 5 Sep 2018 19:31:58 +0800 Peter Xu wrote: > We will drop all the mappings when system reset, however we'll still > keep the existing memory layouts. That'll be problematic since if IOMMU > is enabled in the guest and then reboot the guest, SeaBIOS will try to > drive a device that with

Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:28 PM CEST, Max Reitz wrote: > +vm.shutdown() > + > +#assert top_name[:5] == 'json:' > +#top_options = json.loads(top_name[5:]) > + > +#if filter_node_name: > +## This should be present and set > +#assert top_options['

[Qemu-devel] [Bug 1735049] Re: Need MTTCG support for x86 guests

2018-09-05 Thread Emilio G. Cota
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1735049 Title: Need MTTCG support for x86 guests Status in QEMU: In Progress Bug description:

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Fam Zheng
On Wed, 09/05 16:24, Gerd Hoffmann wrote: > On Wed, Sep 05, 2018 at 08:54:39AM -0400, Brad Smith wrote: > > On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: > > > > > On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: > > > > I very much appreciate the effort to bump up to 6.3 as I was going >

Re: [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails

2018-09-05 Thread Fam Zheng
On Wed, 09/05 19:20, Fei Li wrote: > > > On 09/05/2018 04:36 PM, Daniel P. Berrangé wrote: > > On Wed, Sep 05, 2018 at 12:17:24PM +0800, Fei Li wrote: > > > Thanks for the review! :) > > > > > > > > > On 09/04/2018 07:26 PM, Daniel P. Berrangé wrote: > > > > On Tue, Sep 04, 2018 at 07:08:18PM +

Re: [Qemu-devel] [PATCH for-3.1 v10 08/31] iotests: Add test for backing file overrides

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:05 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [Bug 1529173] Re: Absolutely slow Windows XP SP3 installation

2018-09-05 Thread Emilio G. Cota
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529173 Title: Absolutely slow Windows XP SP3 installation Status in QEMU: Invalid Bug descriptio

Re: [Qemu-devel] [PATCH] dump: fix Windows dump memory run mapping

2018-09-05 Thread Прутьянов , Виктор Владимирович
2018-08-29 21:30 GMT+03:00 Viktor Prutyanov : > > We should map and use guest memory run by parts if it can't be mapped as > a whole. > After this patch, continuos guest physical memory blocks which are not > continuos in host virtual address space will be processed correctly. > > Signed-off-by: Vi

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Gerd Hoffmann
On Wed, Sep 05, 2018 at 08:54:39AM -0400, Brad Smith wrote: > On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: > > > On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: > > > I very much appreciate the effort to bump up to 6.3 as I was going > > > to suggest doing that at some point. But bumping

Re: [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:01 PM CEST, Max Reitz wrote: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this > in bdrv_refresh_filename(). > > To see whether it has been overridden, we might want to compare >

[Qemu-devel] Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage

2018-09-05 Thread Quan Xu
From 7de4cc7c944bfccde0ef10992a7ec882fdcf0508 Mon Sep 17 00:00:00 2001 From: Quan Xu Date: Wed, 5 Sep 2018 22:06:58 +0800 Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage Since the bulk stage assumes in (migration_bitmap_find_dirty) that every page

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eduardo Habkost
Question to the QAPI schema maintainers below: On Wed, Sep 05, 2018 at 01:47:55PM +0800, Robert Hoo wrote: > On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote: > > On 10/08/2018 16:06, Robert Hoo wrote: > > > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only. > > > > This should

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Hongbo Zhang
On 5 September 2018 at 20:02, Andrew Jones wrote: > On Wed, Sep 05, 2018 at 06:08:57PM +0800, Hongbo Zhang wrote: >> On 30 August 2018 at 21:29, Ard Biesheuvel wrote: >> > On 30 August 2018 at 12:02, Leif Lindholm wrote: >> >> On Thu, Aug 30, 2018 at 09:39:33AM +0100, Peter Maydell wrote: >> >>>

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Peter Krempa
On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > block-commit is able to reopen the format layers and works as expected. > > > > Unfortunately though the 'read-only' option is actually useful as the > > curl-driver does not work without

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Eric Blake
On 09/05/2018 07:38 AM, Peter Krempa wrote: block-commit is able to reopen the format layers and works as expected. Unfortunately though the 'read-only' option is actually useful as the curl-driver does not work without it: -blockdev {"driver":"http","url":"http://ftp.sjtu.edu.cn:80/ubuntu-cd

Re: [Qemu-devel] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-05 Thread Eduardo Habkost
On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote: > On Tue, 4 Sep 2018 23:12:55 -0300 > Eduardo Habkost wrote: > > > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > > > so that total number of

Re: [Qemu-devel] [PATCH v4 0/9] Add limited MXU instruction support

2018-09-05 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Thursday, August 30, 2018 9:30 PM > > Subject: [PATCH v4 0/9] Add limited MXU instruction support > This patch set begins to add MXU instruction support for mips emulation. Hi, Craig, I mentioned some time ago that we planned to revamp translate.c. Related to tha

Re: [Qemu-devel] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:22 PM CEST, Max Reitz wrote: > If a format BDS's file BDS is in turn a format BDS, we cannot simply use > the same filename, because when opening a BDS tree based on a filename > alone, qemu will create only one format node on top of one protocol node > (disregarding a pote

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 12:42:05PM +, Jaggi, Manish wrote: > > > > On 05-Sep-2018, at 5:50 PM, Andrew Jones wrote: > > > > External Email > > > > On Wed, Sep 05, 2018 at 11:46:11AM +, Jaggi, Manish wrote: > >> (a) Changes in KVM: > >> > >> - Introducing a specific error code (KVM_EINV

[Qemu-devel] [PATCH qemu v2] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-09-05 Thread Geert Uytterhoeven
As of commit 18e8cf159177100e ("serial: sh-sci: increase RX FIFO trigger defaults for (H)SCIF") in Linux v4.11-rc1, the serial console on the QEMU SH4 target is broken: it delays serial input until enough data has been received. Since aforementioned commit, the Linux SCIF driver programs the Recei

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread John Snow
On 09/05/2018 06:43 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> For purposes of minimum code movement, refactor the mirror_exit >> callback to use the post-finalization callbacks in a trivial way. >> >> Signed-off-by: John Snow >> --- >> block/mirror.c | 34 +

Re: [Qemu-devel] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 05:54 AM, Kevin Wolf wrote: > Am 04.09.2018 um 21:30 hat Eric Blake geschrieben: >> On 09/04/2018 02:15 PM, John Snow wrote: >> >>> >>> post-script: I really, really hate the "fake cancel" we've implemented >>> for mirror. It makes the job logic so much worse. >> >> Mirror really d

Re: [Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' on reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > 'force-share' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in a "Cannot change the option" error: > >(qemu) qemu-io virtio0 "reopen -o force-shar

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:18 AM, Fam Zheng wrote: On Fri, 08/24 10:36, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to Clang. Th

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched

  1   2   >