On 2018-09-03 16:34, Alberto Garcia wrote: > 'force-share' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in a "Cannot change the option" error: > > (qemu) qemu-io virtio0 "reopen -o force-share=on" > Cannot change the option 'force-share' > > Since there's no reason why we shouldn't allow changing it and the > implementation is simple let's just do it. > > It's worth noting that after this patch the above reopen call will > still return an error -although a different one- if the image is not > read-only: > > (qemu) qemu-io virtio0 "reopen -o force-share=on" > force-share=on can only be used with read-only images > > Signed-off-by: Alberto Garcia <be...@igalia.com> > Cc: Max Reitz <mre...@redhat.com> > --- > block.c | 30 ++++++++++++++++++++++++------ > include/block/block.h | 1 + > 2 files changed, 25 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
