07.05.2018 21:08, Eric Blake wrote:
On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote:
We have several paranoiac checks for ioc != NULL. But ioc may become
NULL only on close, which should not happen during requests handling.
Also, we check ioc only sometimes, not after each yield, whic
Eduardo Habkost writes:
> On Mon, May 07, 2018 at 09:13:57PM +0200, Thomas Huth wrote:
>> On 07.05.2018 20:21, Eduardo Habkost wrote:
>> > On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
>> >> Eduardo Habkost writes:
>> >>
>> >>> On Fri, Apr 27, 2018 at 08:31:58AM +0200, Marku
On 07.05.2018 21:32, Eduardo Habkost wrote:
> On Mon, May 07, 2018 at 09:13:57PM +0200, Thomas Huth wrote:
>> On 07.05.2018 20:21, Eduardo Habkost wrote:
>>> On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
Eduardo Habkost writes:
> On Fri, Apr 27, 2018 at 08:31:58A
On 07.05.2018 17:51, Cornelia Huck wrote:
> Thomas reported that the subchannel for a 3270 device that ended up
> in a broken state (status pending even though not enabled) did not
> get out of that state even after a reboot (which involves a subsytem
> reset). The reason for this is that the 3270
Hi Paolo and Michael,
Using LM32 images from http://milkymist.walle.cc/README.qemu
(Whether http://milkymist.walle.cc/updates/2012-03-01/flickernoise or
the flash image) I get:
$ lm32-softmmu/qemu-system-lm32 -M milkymist -kernel flickernoise \
-d int,guest_errors,trace:lm32\*
16363@152574349
On Fri, 05/04 00:49, no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
Code indentation issues are due to the pre-existing style in the file and is
not changed by the patch.
Fam
>
> Type: series
> Message-id: 20
On 05/07/2018 07:44 PM, Philippe Mathieu-Daudé wrote:
> Hi Alistair,
>
> On 05/07/2018 05:09 PM, Alistair Francis wrote:
>> Avocado is not trivial to setup on non-Fedora systems. To simplfying
>> future testing add a docker test image that runs Avocado tests.
>
> How big is the image with the new
This feature bit can be used by hypervisor to indicate virtio_net device to
act as a standby for another device with the same MAC address.
I tested this with a small change to the patch to mark the STANDBY feature
'true'
by default as i am using libvirt to start the VMs.
Is there a way to pass th
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:40 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; ge...@hostfission.com;
> k...@tripleback.net; qemu-devel
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:38 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; ge...@hostfission.com;
> k...@tripleback.net; qemu-devel
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:16 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; ge...@hostfission.com;
> k...@tripleback.net; qemu-devel@
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:14 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; ge...@hostfission.com;
> k...@tripleback.net; qemu-devel
From: KONRAD Frederic
When compiling on a machine without libfdt installed the configure script
should try to get libfdt from the git or should die because otherwise
CONFIG_LIBFDT is not set and the build process end in an error in the link
phase.. eg:
hw/riscv/virt.o: In function `riscv_virt_bo
From: KONRAD Frederic
The htif device is supposed to be mapped over an other subregion. So increase
its priority to one to avoid any conflict.
Here is the output of info mtree:
Before:
(qemu) info mtree
address-space: memory
- (prio 0, i/o): system
0
From: KONRAD Frederic
The sanity check on base doesn't allow htif to be mapped @0. Check if the
symbol exists instead so we can map it where we want.
Reviewed-by: Michael Clark
Signed-off-by: KONRAD Frederic
Message-Id: <1525360636-18229-2-git-send-email-frederic.kon...@adacore.com>
---
hw/r
The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into
staging (2018-05-04 14:42:46 +0100)
are available in the git repository at:
https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-mi
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:10 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; ge...@hostfission.com;
> k...@tripleback.net; qemu-devel
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 4:27 PM
> To: Moger, Babu
> Cc: ge...@hostfission.com; k...@vger.kernel.org; m...@redhat.com;
> k...@tripleback.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
> mar...@redhat.com; pbon
Hi Alistair,
On 05/07/2018 05:09 PM, Alistair Francis wrote:
> Avocado is not trivial to setup on non-Fedora systems. To simplfying
> future testing add a docker test image that runs Avocado tests.
How big is the image with the new packages?
If not everybody is interested in using Avocado and Py
Hi Michael,
It looks like this was never applied. Can it be, please?
On Wed, Dec 20, 2017 at 9:24 AM, Michael S. Tsirkin wrote:
> On Wed, Dec 13, 2017 at 10:07:12AM +, Stefan Hajnoczi wrote:
> > On Wed, Dec 13, 2017 at 12:26:44AM -0800, Ben Warren via Qemu-devel
> wrote:
> > > From: Ben Wa
在 2018/5/8 上午2:04, Eric Blake 写道:
On 05/06/2018 10:32 PM, Yi Min Zhao wrote:
In the subject line: s/avoid to compile/avoid compiling/
If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains
s/elevator/elevate/
complied. This would make libvirt set the corresponding capabi
On Fri, Apr 20, 2018 at 09:22:55AM +0200, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
> > On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote:
> >> The SysBusDevice is the last DeviceClass::init user.
> >>
> >> Instead of using
> >> SysBusDeviceClass::realize
> >>-> Device
On Mon, May 07, 2018 at 09:14:27PM +, Moger, Babu wrote:
> Eduardo,
>Thanks for all the comments. Will respond to each one separately.
>
> > -Original Message-
> > From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> > Sent: Monday, May 7, 2018 2:05 PM
> > To: Moger, Babu
> > Cc:
This appears to address it in QEMU v2.4:
commit 6652d0811c9463fbfb2d2d1cb2ec03f388145c5f
Author: Jason Wang
Date: Wed May 27 16:26:07 2015 +0800
virtio-pci: don't try to mask or unmask vqs without notifiers
We should validate the vq index against nvqs_with_notifiers. Otherwise we
Eduardo,
Thanks for all the comments. Will respond to each one separately.
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Monday, May 7, 2018 2:05 PM
> To: Moger, Babu
> Cc: m...@redhat.com; mar...@redhat.com; pbonz...@redhat.com;
> r...@twiddle.net;
On Thu, Apr 26, 2018 at 11:26:49AM -0500, Babu Moger wrote:
> Remove generic non-intel check while validating hyperthreading support.
> Certain AMD CPUs can support hyperthreading now.
>
> CPU family with TOPOEXT feature can support hyperthreading now.
>
> Signed-off-by: Babu Moger
> Tested-by:
The RISC-V Instruction Set Manual, Volume II:
Privileged Architecture, Version 1.10 states
that upon reset the pc is set to
an implementation-defined reset vector
(see chapter 3.3 Reset).
This patch makes it possible to alter default
reset vector by setting "rstvec" property
for TYPE_RISCV_HART_AR
On Thu, Apr 26, 2018 at 11:26:48AM -0500, Babu Moger wrote:
> Enable TOPOEXT feature on EPYC CPU. This is required to support
> hyperthreading on VM guests. Also extend xlevel to 0x801E.
>
> Signed-off-by: Babu Moger
> Tested-by: Geoffrey McRae
Reviewed-by: Eduardo Habkost
--
Eduardo
** Changed in: qemu
Status: Incomplete => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1456819
Title:
OVMF, Hyper-V, virtio, Win7 incompatibility
Status in QEMU:
Invalid
Bug des
Hi,
Sorry for taking so long to send feedback on this series:
On Thu, Apr 26, 2018 at 11:26:46AM -0500, Babu Moger wrote:
> Add information for cpuid 0x801D leaf. Populate cache topology information
> for different cache types(Data Cache, Instruction Cache, L2 and L3) supported
> by 0x801
On Fri, May 4, 2018 at 3:55 PM, Michael Clark wrote:
>
>
> On Sat, May 5, 2018 at 8:12 AM, Alistair Francis
> wrote:
>>
>> Create a SiFive Unleashed U54 SoC and use that in the sifive_u machine.
>>
>> We leave the SoC, RAM, device tree and reset/fdt loading as part of the
>> machine. All the othe
On Mon, May 7, 2018 at 7:51 PM, Eric Blake wrote:
> On 05/06/2018 05:56 AM, Howard Spoelstra wrote:
>>
>> Hi all,
>>
>> I get these errors compiling qemu-system-ppc on Fedora 28, gcc 8.0.1:
>>
>> /home/hsp/src/qemu-master/hw/ppc/e500.c: In function
>> ‘ppce500_load_device_tree’:
>> /home/hsp/src/q
On Thu, Apr 26, 2018 at 11:26:43AM -0500, Babu Moger wrote:
> Initialize pre-determined cache information for EPYC processors.
>
> Signed-off-by: Babu Moger
> Tested-by: Geoffrey McRae
Assuming that the cache information below was validated by people
from AMD, patch looks good to me.
> ---
>
Looking through old bug tickets... Bram, can you still reproduce this
issue with the latest version of QEMU? Or could we close this ticket
nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is sub
On 05/04/2018 12:58 PM, Philippe Mathieu-Daudé wrote:
> This series emerged after last Coverity scan and Peter suggestion in:
> http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg05046.html
>
> (3) "proper" implementation of CRC, so that an sd controller
> can either (a) mark the S
Avocado is not trivial to setup on non-Fedora systems. To simplfying
future testing add a docker test image that runs Avocado tests.
Signed-off-by: Alistair Francis
---
tests/docker/dockerfiles/fedora.docker | 12 +--
tests/docker/test-avocado | 28 ++
Marking as "Won't Fix" according to the last comment.
** Changed in: qemu
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1450891
Title:
VM will not resume on Gluster
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU / libvirt / spice? Or could we close
this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml,
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
Is there still anything left to do here, or could we close this bug
ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1456819
Title:
On 07.05.2018 17:51, Cornelia Huck wrote:
> All the different virtio ccw devices use the same reset handler,
> so let's move setting it into the base virtio ccw device class.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/virtio-ccw.c | 13 +
> 1 file changed, 1 insertion(+), 12 d
On Thu, Apr 26, 2018 at 11:26:47AM -0500, Babu Moger wrote:
> Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT
> feature is supported. This is required to support hyperthreading feature
> on AMD CPUs. This is supported via CPUID_8000_001E extended functions.
>
> Signed-off-by: B
On Thu, Apr 26, 2018 at 11:26:45AM -0500, Babu Moger wrote:
> Use the statically loaded cache definitions if available
> and legacy-cache parameter is not set.
>
> Signed-off-by: Babu Moger
> Tested-by: Geoffrey McRae
Now that I'm looking at the rest of the code, this seems
incomplete:
What ab
On Mon, May 07, 2018 at 09:13:57PM +0200, Thomas Huth wrote:
> On 07.05.2018 20:21, Eduardo Habkost wrote:
> > On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
> >> Eduardo Habkost writes:
> >>
> >>> On Fri, Apr 27, 2018 at 08:31:58AM +0200, Markus Armbruster wrote:
> Eduard
On 07.05.2018 17:51, Cornelia Huck wrote:
> All the different virtio ccw devices use the same reset handler,
> so let's move setting it into the base virtio ccw device class.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/virtio-ccw.c | 13 +
> 1 file changed, 1 insertion(+), 12 d
On Thu, Apr 26, 2018 at 11:26:45AM -0500, Babu Moger wrote:
> Use the statically loaded cache definitions if available
> and legacy-cache parameter is not set.
>
> Signed-off-by: Babu Moger
> Tested-by: Geoffrey McRae
Looks good, but I suggest squashing this with patch 4/9.
Additional suggesti
On Thu, Apr 26, 2018 at 11:26:44AM -0500, Babu Moger wrote:
> This will be used to control the cache information.
> By default new information will be displayed. If user
> passes "-cpu legacy-cache" then older information will
> be displayed even if the hardware supports new information.
> It will
On 07.05.2018 20:21, Eduardo Habkost wrote:
> On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>>> On Fri, Apr 27, 2018 at 08:31:58AM +0200, Markus Armbruster wrote:
Eduardo Habkost writes:
> On Thu, Apr 26, 2018 at 05:20:25PM +0200, T
On Thu, Apr 26, 2018 at 11:26:42AM -0500, Babu Moger wrote:
> Add cache information in X86CPUDefinition and CPUX86State.
>
> Signed-off-by: Babu Moger
> Tested-by: Geoffrey McRae
> ---
> target/i386/cpu.c | 4
> target/i386/cpu.h | 8
> 2 files changed, 12 insertions(+)
>
> diff
Hi,
I was about to apply this because I assumed it was the same patch
I sent in March, but then I found this:
On Thu, Apr 26, 2018 at 11:26:41AM -0500, Babu Moger wrote:
> From: Eduardo Habkost
>
> Instead of having a collection of macros that need to be used in
> complex expressions to build C
On Fri, May 04, 2018 at 11:57:33AM +0800, Jingqi Liu wrote:
> The CLDEMOTE instruction hints to hardware that the cache line that
> contains the linear address should be moved("demoted") from
> the cache(s) closest to the processor core to a level more distant
> from the processor core. This may ac
On 2018-05-04 04:07 PM, Michael S. Tsirkin wrote:
On Fri, May 04, 2018 at 09:30:45AM -0700, Jonathan Helman wrote:
The Linux kernel commit b4325044 ("virtio_balloon: add array
of stat names") defines an array of stat name strings for consumers
of the virtio interface to use via the virtio_
On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Fri, Apr 27, 2018 at 08:31:58AM +0200, Markus Armbruster wrote:
> >> Eduardo Habkost writes:
> >>
> >> > On Thu, Apr 26, 2018 at 05:20:25PM +0200, Thomas Huth wrote:
> >> >> On 26.04.2018 13:45
On Sun, 29 Apr 2018 09:56:37 -0500
Richard Henderson wrote:
> On 04/27/2018 02:01 PM, Michal Suchánek wrote:
> > Is there any reason why the 64bit emulator would not run on 32bit
> > system? The emulated 64bit system is .. emulated after all.
>
> It does run, but it requires that the 32-bit ho
On 05/07/2018 05:10 AM, Gerd Hoffmann wrote:
... to a virtual machine. Without that we fail a ramblock register
sanity check, leading to a abort(), which isn't exactly user friendly.
https://bugzilla.redhat.com/show_bug.cgi?id=1206037
Signed-off-by: Gerd Hoffmann
---
hw/display/vga.c | 8 +++
On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote:
We have several paranoiac checks for ioc != NULL. But ioc may become
NULL only on close, which should not happen during requests handling.
Also, we check ioc only sometimes, not after each yield, which is
inconsistent. Let's drop these c
On 05/06/2018 10:32 PM, Yi Min Zhao wrote:
In the subject line: s/avoid to compile/avoid compiling/
If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains
s/elevator/elevate/
complied. This would make libvirt set the corresponding capability and
s/complied/compiled/
the
On 05/07/2018 04:55 AM, Gerd Hoffmann wrote:
Drop the option-less display types (egl-headless, curses, none) from
parse_display(), so they'll be handled by parse_display_qapi().
Signed-off-by: Gerd Hoffmann
---
vl.c | 6 --
1 file changed, 6 deletions(-)
Reviewed-by: Eric Blake
--
E
On 05/07/2018 04:55 AM, Gerd Hoffmann wrote:
Add parse_display_qapi() function which parses the -display command line
using a qapi visitor for DisplayOptions. Wire up as default catch in
parse_display().
Improves the error message for unknown display types.
Also enables json as -display argume
On 05/07/2018 04:02 AM, Greg Kurz wrote:
qemu-system-ppc fails to build with GCC 8.0.1:
/home/hsp/src/qemu-master/hw/ppc/e500.c: In function ‘ppce500_load_device_tree’:
/home/hsp/src/qemu-master/hw/ppc/e500.c:442:37: error: ‘/pic@’
directive output may be truncated writing 5 bytes into a region
On 05/06/2018 05:56 AM, Howard Spoelstra wrote:
Hi all,
I get these errors compiling qemu-system-ppc on Fedora 28, gcc 8.0.1:
/home/hsp/src/qemu-master/hw/ppc/e500.c: In function ‘ppce500_load_device_tree’:
/home/hsp/src/qemu-master/hw/ppc/e500.c:442:37: error: ‘/pic@’
directive output may be t
On 05/07/2018 12:44 PM, Eric Blake wrote:
> On 05/07/2018 09:30 AM, Collin Walling wrote:
>> When a user incorrectly provides an hmp command, an error response will be
>> printed that prompts the user to try "help ". However, when
>> the command contains multiple parts e.g. "info uuid xyz", only th
From: David Hildenbrand
Let's make it clear at relevant places that we are dealing with device
memory. That it can be used for memory hotplug is just a special case.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-11-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
[ehabkos
From: David Hildenbrand
Rename it to better match the new terminology.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-9-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Eduardo Habkost
---
include/hw/boards.h | 8
hw/ppc/spapr_hcall.c| 6 +
From: David Hildenbrand
This mainly moves code, but does a handfull of optimizations:
- We pass the machine instead of the address space properties
- We check the hinted address directly and handle fragmented memory
better
- We make the search independent of pc-dimm
Signed-off-by: David Hilden
From: David Hildenbrand
We use the machine internally either way, so let's just pass it in then.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-5-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Eduardo Habkost
---
include/hw/mem/pc-dimm.h | 4 ++--
hw/i38
From: David Hildenbrand
Let's make it clear that we are dealing with device memory. That it can
be used for memory hotplug is just a special case.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-10-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Eduardo Habk
From: David Hildenbrand
We can just query it ourselves. When unplugging, we should always be
able to the region (as it was previously plugged). E.g. PPC already
assumed that and used &error_abort.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-4-da...@redhat.com>
Reviewed-by
On 7 May 2018 at 17:50, Markus Armbruster wrote:
> I propose:
>
> * Stuff that's required for QEMU to run is not suppressed by -nodefaults
>
> * Stuff that a real machine has soldered on is also not suppressed
>
> * Stuff that can be pulled out of a real machine may be suppressed, even
> when th
On 16/04/2018 01:05, Philippe Mathieu-Daudé wrote:
> Hi, I already hit this problem on Shippable and tried to resolve it for 2.10;
> and shamefully hit it again yesterday on a Debian 8 host with distrib libfdt
> installed. I wondered how to fix this without root access and realized my
> previous Sh
From: Thomas Huth
The CAN device crashes have been fixed with the commit
089eac81e1d34d202471c0a023284f47f4c5f00e already.
Signed-off-by: Thomas Huth
Message-Id: <1523900489-25950-1-git-send-email-th...@redhat.com>
Signed-off-by: Eduardo Habkost
Reviewed-by: Michael S. Tsirkin
Signed-off-by:
From: David Hildenbrand
Let's allow to query the MemoryHotplugState directly from the machine.
If the pointer is NULL, the machine does not support memory devices. If
the pointer is !NULL, the machine supports memory devices and the
data structure contains information about the applicable physica
From: David Hildenbrand
We will be able to have memory devices (e.g. virtio) not requiring the
slot parameter (e.g. not exposed via ACPI). We still need the maxmem
parameter to setup a proper memory region for device memory. And some
architectures (e.g. s390x) will have to set up the maximum poss
From: David Hildenbrand
Move the checks into memory_device_get_free_addr(). This will check
before doing any calculations if we have KVM/vhost slots left and if
the total region size would be exceeded.
Of course, while at it, make it independent of pc-dimm code.
Signed-off-by: David Hildenbrand
On 07.05.2018 18:50, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
>> On Fri, Apr 27, 2018 at 08:31:58AM +0200, Markus Armbruster wrote:
>>> Eduardo Habkost writes:
>>>
On Thu, Apr 26, 2018 at 05:20:25PM +0200, Thomas Huth wrote:
> On 26.04.2018 13:45, Markus Armbruster wrote:
>>
On 05/04/2018 03:05 AM, Peter Maydell wrote:
> It is implementation defined whether a multiply-add of
> (0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or
> not, so we let the target-specific pickNaNMulAdd function
> handle this. This means that we must do the "return the
> default NaN in def
From: David Hildenbrand
Registering the memory region for migration has do be done by the owner.
There could be cases, where we don't want to migrate the memory.
Signed-off-by: David Hildenbrand
Message-Id: <20180423165126.15441-8-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by
From: David Hildenbrand
On the qmp level, we already have the concept of memory devices:
"query-memory-devices"
Right now, we only support NVDIMM and PCDIMM.
We want to map other devices later into the address space of the guest.
Such device could e.g. be virtio devices. These devices will h
The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into
staging (2018-05-04 14:42:46 +0100)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git tags/machine-next-pull-reque
On 07/05/2018 18:50, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 07/05/2018 13:56, Markus Armbruster wrote:
>>> Adding more and more ways to do the same stuff does not improve an
>>> interface. Interface design needs to be *opinionated*. If we decide
>>> -machine accel=tcg isn't a
On 7 May 2018 at 15:30, Gerd Hoffmann wrote:
> The only one which passes global_vmstate == false is "-device
> secondary-vga", and that does *not* register vga ioports (the
> registers can be accessed via mmio pci bar though).
Looks like virtio-vga does as well.
> So, right now global_vmstate ==
On 02/05/2018 09:34, Vitaly Kuznetsov wrote:
> Vitaly Kuznetsov writes:
>
>> Changes since v4:
>> - Rebase on top of Roman's patches.
>> - Drop PATCH2 as it is no longer needed (after adding explicit
>> hv_frequencies).
>>
>> Previously, Ladi was working on enabling TSC page clocksource for nes
According to PowerISA, the PIR register should be readable in privileged
mode also, not only in hypervisor privileged mode.
PowerISA 3.0 - 4.3.3 Processor Identification Register
"Read access to the PIR is privileged; write access is not provided."
Cc: David Gibson
Cc: Alexander Graf
Cc: qemu-
On 07.05.2018 15:38, Kashyap Chamarthy wrote:
> On Thu, May 03, 2018 at 03:16:10PM +0100, Daniel P. Berrangé wrote:
>> On Thu, May 03, 2018 at 04:06:19PM +0200, Thomas Huth wrote:
>>> On 03.05.2018 15:43, Gerd Hoffmann wrote:
>
> [...]
>
(a) major equals year, minor equals month (ubuntu st
Paolo Bonzini writes:
> On 07/05/2018 13:56, Markus Armbruster wrote:
>> Adding more and more ways to do the same stuff does not improve an
>> interface. Interface design needs to be *opinionated*. If we decide
>> -machine accel=tcg isn't a nice interface, by all means create a better
>> one, b
Eduardo Habkost writes:
> On Fri, Apr 27, 2018 at 08:31:58AM +0200, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>> > On Thu, Apr 26, 2018 at 05:20:25PM +0200, Thomas Huth wrote:
>> >> On 26.04.2018 13:45, Markus Armbruster wrote:
>> >> > Thomas Huth writes:
>> >> [...]
>> >> >> @@ -
On 05/07/2018 09:30 AM, Collin Walling wrote:
When a user incorrectly provides an hmp command, an error response will be
printed that prompts the user to try "help ". However, when
the command contains multiple parts e.g. "info uuid xyz", only the last
whitespace delimited string will be reported
On 05/04/2018 12:39 PM, Emanuele Giuseppe Esposito wrote:
> Hello,
> my name is Emanuele and I am one of the students selected to participate at
> the Google Summer of Code with QEMU.
> I'll work on the current test driver framework and will try to improve it
> (i.e. automatically detect device
Hi Leandro,
You seem to be a newcomer to QEMU development. Welcome ! :)
Please find a few remarks below, so that you can improve your patch submission
skills.
First, it is good practice to provide the subsystem name in the subject, as
stated in:
https://wiki.qemu.org/Contribute/SubmitAPatch#Wr
All the different virtio ccw devices use the same reset handler,
so let's move setting it into the base virtio ccw device class.
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s39
Thomas reported that the subchannel for a 3270 device that ended up
in a broken state (status pending even though not enabled) did not
get out of that state even after a reboot (which involves a subsytem
reset). The reason for this is that the 3270 device did not define
a reset handler.
Let's fix
On Friday, Thomas noticed some problems with 3270 devices. One result
was "s390x/css: disabled subchannels cannot be status pending", but
a reboot did not cure the previous broken status. Turns out that 3270
devices are missing a reset handler.
This series cleans up reset handling a bit and makes
Keep all connection code in one file, to be able to implement reconnect
in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.h | 2 +-
block/nbd-client.c | 37 +++--
block/nbd.c| 41 ++---
To implement nbd reconnect in further patches, we need to distinguish
error codes, returned by nbd server, from channel errors, to reconnect
only in the latter case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c | 83 +++---
1
We have several paranoiac checks for ioc != NULL. But ioc may become
NULL only on close, which should not happen during requests handling.
Also, we check ioc only sometimes, not after each yield, which is
inconsistent. Let's drop these checks.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
bloc
Use exported report, not the variable to be reused (should not really
matter).
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index 14b42f31df..dd712c59b3 100644
--- a/
Split connection code to reuse it for reconnect.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index 6ff505c4b8..14b42f31df 100644
--- a
Hi all!
Here are some preliminary refactoring patches, before NBD reconnect
series.
Vladimir Sementsov-Ogievskiy (5):
block/nbd-client: split channel errors from export errors
block/nbd: move connection code from block/nbd to block/nbd-client
block/nbd-client: split connection from initiali
The commit referenced below changed the logic by causing the gtk-egl
backend to be initialized regardless of whether GtkGlArea initialization
succeeded. This causes eglInitialize to crash in Wayland systems without
XWayland.
This patch restores the previous logic.
Fixes: 4c70280592f5 ("ui/gtk: us
1 - 100 of 180 matches
Mail list logo
