On 05/07/2018 05:10 AM, Gerd Hoffmann wrote:
... to a virtual machine.  Without that we fail a ramblock register
sanity check, leading to a abort(), which isn't exactly user friendly.

https://bugzilla.redhat.com/show_bug.cgi?id=1206037
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  hw/display/vga.c | 8 ++++++++
  1 file changed, 8 insertions(+)


+ if (global_vmstate) {
+        static int have_vga;

It looks funny to declare this as int,

+        if (have_vga) {
+            error_report("only one vga device is supported");
+            exit(1);
+        }
+        have_vga = true;

but to treat it as bool.  Why not just declare it as bool to begin with?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to