On 07.05.2018 17:51, Cornelia Huck wrote: > Thomas reported that the subchannel for a 3270 device that ended up > in a broken state (status pending even though not enabled) did not > get out of that state even after a reboot (which involves a subsytem > reset). The reason for this is that the 3270 device did not define > a reset handler. > > Let's fix this by introducing a base reset handler (set up for all > ccw devices) that resets the subchannel and have virtio-ccw call > its virtio-specific reset procedure in addition to that. > > Reported-by: Thomas Huth <th...@redhat.com> > Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> > Signed-off-by: Cornelia Huck <coh...@redhat.com> > --- > hw/s390x/ccw-device.c | 8 ++++++++ > hw/s390x/virtio-ccw.c | 9 ++++++--- > hw/s390x/virtio-ccw.h | 1 + > 3 files changed, 15 insertions(+), 3 deletions(-)
Looks good! Reviewed-by: Thomas Huth <th...@redhat.com> I also checked that the broken 3270 device is now operational after a reboot again with your two patches, so: Tested-by: Thomas Huth <th...@redhat.com>
