Re: [Qemu-devel] [RFC v2 27/32] vhost+postcopy: Wire up POSTCOPY_END notify

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:25PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Wire up a call to VHOST_USER_POSTCOPY_END message to the vhost clients > right before we ask the listener thread to shutdown. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by

Re: [Qemu-devel] [RFC v2 26/32] vhost: Add VHOST_USER_POSTCOPY_END message

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:24PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This message is sent just before the end of postcopy to get the > client to stop using userfault since we wont respond to any more > requests. It should close userfaultfd so that an

Re: [Qemu-devel] [RFC v2 25/32] vhost+postcopy: Lock around set_mem_table

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:23PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > **HACK - better solution needed ** > We have the situation where: > > qemu bridge > > send set_mem_table > map memory >

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-29 Thread Sam
Qemu-2.6.0 2017-08-30 14:20 GMT+08:00 Sam : > Hi all, > > I could repeat it, host os and guest os is Centos-7, qemu-ga is alive in > guest. the step to repeat it is: > > 1. run python script just like the first email. > 2. send qmp command1(cmd in the python script, like `route -n` command or > s

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-29 Thread Sam
Hi all, I could repeat it, host os and guest os is Centos-7, qemu-ga is alive in guest. the step to repeat it is: 1. run python script just like the first email. 2. send qmp command1(cmd in the python script, like `route -n` command or something, of course it's qmp format), and interrupt it immed

Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Igor Mammedov
On Tue, 29 Aug 2017 19:03:37 -0300 Eduardo Habkost wrote: > The errp argument is ignored by all implementations of the > method, and user_creatable_del() would break if any > implementation set an error (because it calls error_setg(errp) if > the function returns false). Remove the unused parame

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-29 Thread Igor Mammedov
On Wed, 30 Aug 2017 13:05:01 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 09:34:32AM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 14:12:08 +1000 > > David Gibson wrote: > > > > > On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > > > > previous patches cleaned up

Re: [Qemu-devel] [Qemu-discuss] changing from net to netdev with vde switches and double nics

2017-08-29 Thread Thomas Huth
On 29.08.2017 21:22, Paolo wrote: > > -- >> On Tue, 29 Aug 2017 11:48:20 +0200 >> Thomas Huth wrote: > [cut] >> That's interesting, I think you're the first person I know in months or >> even years who really seems to be using th

Re: [Qemu-devel] [RFC v2 22/32] vhost+postcopy: Add vhost waker

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:20PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Register a waker function in vhost-user code to be notified when > pages arrive or requests to previously mapped pages get requested. > > Signed-off-by: Dr. David Alan Gilbert > --

Re: [Qemu-devel] [RFC for-2.10 1/3] pci/pcie: Make a consistent helper for switching PCI/PCIe "hybrid" devices

2017-08-29 Thread David Gibson
On Tue, Aug 29, 2017 at 11:12:36AM -0300, Eduardo Habkost wrote: > On Tue, Aug 29, 2017 at 09:42:39PM +1000, David Gibson wrote: > > On Wed, Apr 26, 2017 at 06:23:58PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Mar 28, 2017 at 01:16:49PM +1100, David Gibson wrote: > > > > virtio-pci and XHCI ar

Re: [Qemu-devel] [RFC v2 17/32] vhost+postcopy: Stash RAMBlock and offset

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:15PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Stash the RAMBlock and offset for later use looking up > addresses. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/trace-events | 1 + > hw/virtio/vhost-user.c | 30

Re: [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Resolve fault addresses read off the clients UFD into RAMBlock > and offset, and call back to the postcopy code to ask for the page. > > Signed-off-by: Dr. David Alan Gilbert > ---

Re: [Qemu-devel] [PATCH v4 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-29 Thread David Gibson
On Fri, Aug 18, 2017 at 03:50:22PM +1000, Sam Bobroff wrote: > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > read only. Doing so causes KVM to act, for that VM, as if the host's > SMT mode was the given value. This is particularly important on Power > 9 systems because their

Re: [Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup develop

Re: [Qemu-devel] [PATCH v2 3/3] Add manpage for QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup developers > to see QEMU's backup features in action. The following co

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +class BackupTool(object): > +"""BackupTool Class""" > +def __init__(self, config_file=os.path.expanduser('~') + > + '/.config/qemu/qemu-backup-config'): > +if "QEMU_BACKUP_CONFIG" in os.environ: > +self.config_f

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +def _restore(self, guest_name): > +""" > +Prints Steps to perform restore operation > +""" > +if guest_name not in self.config.sections(): > +print("Cannot find specified guest", file=sys.stderr) > +

Re: [Qemu-devel] [Qemu devel v7 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Subbaraya, On 08/28/2017 01:38 PM, Subbaraya Sundeep wrote: Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep --- default-configs/arm-softmmu.mak | 1 +

Re: [Qemu-devel] [PATCH 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-29 Thread Philippe Mathieu-Daudé
[...] +# hw/ide/ahci.c +ahci_port_read(void *s, int port, int offset, uint32_t ret) "ahci(%p)[%d]: port read @ 0x%x: 0x%08x" +ahci_irq_raise(void *s) "ahci(%p): raise irq" +ahci_irq_lower(void *s) "ahci(%p): lower irq" +ahci_check_irq(void *s, uint32_t old, uint32_t new) "ahci(%p): check irq 0x%0

Re: [Qemu-devel] [PATCH 4/8] tcg: Add operations for host vectors

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/17/2017 08:01 PM, Richard Henderson wrote: Nothing uses or implements them yet. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg-opc.h | 89 +++ tcg/tcg.h | 24 2 files ch

Re: [Qemu-devel] [Qemu devel v7 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Subbaraya, On 08/28/2017 01:38 PM, Subbaraya Sundeep wrote: Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep --- hw/arm/Makefile.objs | 2 +- hw/arm/msf2-som.c| 94 2 files changed, 9

Re: [Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as

Re: [Qemu-devel] [PATCH 7/9] AHCI: Rework IRQ constants

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/08/2017 03:33 PM, John Snow wrote: Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as

Re: [Qemu-devel] [PATCH 1/8] tcg: Add generic vector infrastructure and ops for add/sub/logic

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Richard, I can't find anything to say about this patch... Hardcore stuff. Some part could be more a bit more verbose but after a while focusing it makes sens. I wonder how long it took you to write this :) "roughly 2h" On 08/17/2017 08:01 PM, Richard Henderson wrote: Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-29 Thread Philippe Mathieu-Daudé
Hi John, On 08/29/2017 05:49 PM, John Snow wrote: Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 17 ++--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 6 -- 4 files changed, 18 insertions(+), 13 deletions

Re: [Qemu-devel] [PATCH 1/8] tcg/s390: Fully convert tcg_target_op_def

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:47 PM, Richard Henderson wrote: From: Richard Henderson Use a switch instead of searching a table. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/s390/tcg-target.inc.c | 278 +- 1 file changed,

Re: [Qemu-devel] [PATCH] oslib-posix: Print errors before aborting on qemu_alloc_stack()

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 06:20 PM, Eduardo Habkost wrote: If QEMU is running on a system that's out of memory and mmap() fails, QEMU aborts with no error message at all, making it hard to debug the reason for the failure. Add perror() calls that will print error information before aborting. Signed-off-by:

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Fam Zheng
On Tue, 08/29 14:34, Philippe Mathieu-Daudé wrote: > > +self._args = [ \ > > +"-nodefaults", "-m", "2G", > > +"-cpu", "host", > > +"-netdev", "user,id=vnet,hostfwd=:0.0.0.0:0-:22", > > +"-device", "virtio-net-pci,netdev=vnet", > > +

Re: [Qemu-devel] [PATCH v4 06/10] tests: Add NetBSD image

2017-08-29 Thread Fam Zheng
On Tue, 08/29 18:47, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 08/29/2017 09:09 AM, Philippe Mathieu-Daudé wrote: > [...]>> +if __name__ == "__main__": > > > +    sys.exit(basevm.main(NetBSDVM)) > > > > This one is failing: > > > > DEBUG:root:ssh_cmd: ssh -q -o StrictHostKeyChecking=no -o >

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Fam Zheng
On Tue, 08/29 09:15, Philippe Mathieu-Daudé wrote: > > +self._args = [ \ > > +"-nodefaults", "-m", "2G", > > +"-cpu", "host", > > +"-netdev", "user,id=vnet,hostfwd=:0.0.0.0:0-:22", > > Testing with debian/unstable: > > $ make vm-build-netbsd V=1 > ./tes

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Fam Zheng
On Tue, 08/29 13:11, Daniel P. Berrange wrote: > On Tue, Aug 29, 2017 at 09:06:48AM -0300, Philippe Mathieu-Daudé wrote: > > Hi Fam, > > > > On 08/28/2017 02:47 PM, Fam Zheng wrote: > > > This is the common code to implement a "VM test" to > > > > > >1) Download and initialize a pre-defined V

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 09:34:32AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 14:12:08 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > > > previous patches cleaned up cpu model/alias naming which > > > allows to simplify cpu model/alias to

Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests

2017-08-29 Thread David Gibson
On Tue, Aug 29, 2017 at 08:13:36PM +0200, Thomas Huth wrote: > Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take > opaque BAR handle") a while ago, but nobody noticed since the tests are > only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized > anymore if

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread David Gibson
On Tue, Aug 29, 2017 at 05:54:28PM -0300, Daniel Henrique Barboza wrote: > > > On 08/29/2017 04:23 AM, David Gibson wrote: > > On Fri, Aug 25, 2017 at 06:11:18PM -0300, Daniel Henrique Barboza wrote: > > > v2: > > > - rebased with ppc-for-2.11 > > > - function 'spapr_cas_completed' dropped > > >

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

2017-08-29 Thread Jason Wang
On 2017年08月29日 18:45, Fam Zheng wrote: On Tue, 08/29 17:01, Jason Wang wrote: On 2017年08月22日 15:16, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1503305719-2512-1-git-send-email-zhangch

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-29 Thread David Gibson
On Tue, Aug 29, 2017 at 09:31:07AM -0700, Ram Pai wrote: > On Tue, Aug 29, 2017 at 11:40:30AM +1000, David Gibson wrote: > > On Mon, Aug 28, 2017 at 10:53:56AM -0700, Ram Pai wrote: > > > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > > > > > > > We could either have two u16 f

Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Wednesday, August 30, 2017 6:04 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei); Paolo Bonzini; Igor Mammedov; Andreas Färber; Lin Ma > Subject: [PATCH] qom: Remove unused errp parameter from can_be_delet

[Qemu-devel] [Bug 1713825] [NEW] Booting Windows 2016 with qxl video crashes qemu

2017-08-29 Thread Maciej Piechotka
Public bug reported: launched from libvirt. qemu version: 2.9.0 host: Linux 4.9.34-gentoo #1 SMP Sat Jul 29 13:28:43 PDT 2017 x86_64 Intel(R) Core(TM) i7-3930K CPU @ 3.20GHz GenuineIntel GNU/Linux guest: Windows 2016 64 bit Thread 28 (Thread 0x7f0e2edff700 (LWP 29860)): #0 __GI_raise (sig=sig

Re: [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 2e75f9b..57bb59d 100644 --- a/hw/ide/

Re: [Qemu-devel] [PATCH v2 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 157 +++- hw/ide/trace-

Re: [Qemu-devel] [PATCH v2 3/9] IDE: add tracing for data ports

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/core.c | 12 +++- hw/ide/trace-events | 5 ++

Re: [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing

2017-08-29 Thread Eric Blake
On 08/25/2017 05:10 PM, Eric Blake wrote: > On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> A bit more refactoring and fixing before BLOCK_STATUS series. >> I've tried to make individual patches simple enough, so there are >> a lot of them. >> >> Vladimir Sementsov-Ogievskiy (17): >>

[Qemu-devel] [PATCH 3/3] vfio/pci: Add NVIDIA GPUDirect Cliques support

2017-08-29 Thread Alex Williamson
NVIDIA has defined a specification for creating GPUDirect "cliques", where devices with the same clique ID support direct peer-to-peer DMA. When running on bare-metal, tools like NVIDIA's p2pBandwidthLatencyTest (part of cuda-samples) determine which GPUs can support peer-to-peer based on chipset a

[Qemu-devel] [PATCH 2/3] vfio/pci: Add virtual capabilities quirk infrastructure

2017-08-29 Thread Alex Williamson
If the hypervisor needs to add purely virtual capabilties, give us a hook through quirks to do that. Note that we determine the maximum size for a capability based on the physical device, if we insert a virtual capability, that can change. Therefore if maximum size is smaller after added virt cap

[Qemu-devel] [PATCH 0/3] vfio/pci: Add NVIDIA GPUDirect P2P clique support

2017-08-29 Thread Alex Williamson
NVIDIA has a specification for exposing a virtual vendor capability which provides a hint to guest drivers as to which sets of GPUs can support direct peer-to-peer DMA. Devices with the same clique ID are expected to support this. The user can specify a clique ID for an NVIDIA graphics device usi

[Qemu-devel] [PATCH 1/3] vfio/pci: Do not unwind on error

2017-08-29 Thread Alex Williamson
If vfio_add_std_cap() errors then going to out prepends irrelevant errors for capabilities we haven't attempted to add as we unwind our recursive stack. Just return error. Fixes: 7ef165b9a8d9 ("vfio/pci: Pass an error object to vfio_add_capabilities") Signed-off-by: Alex Williamson --- hw/vfio/

[Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Eduardo Habkost
The errp argument is ignored by all implementations of the method, and user_creatable_del() would break if any implementation set an error (because it calls error_setg(errp) if the function returns false). Remove the unused parameter. Signed-off-by: Eduardo Habkost --- include/qom/object_interf

Re: [Qemu-devel] [Qemu devel v7 PATCH 1/5] msf2: Add Smartfusion2 System timer

2017-08-29 Thread Alistair Francis
On Mon, Aug 28, 2017 at 10:32 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Tue, Aug 29, 2017 at 3:23 AM, Alistair Francis > wrote: >> >> On Mon, Aug 28, 2017 at 9:37 AM, Subbaraya Sundeep >> wrote: >> > Modelled System Timer in Microsemi's Smartfusion2 Soc. >> > Timer has two 32bit down co

Re: [Qemu-devel] [PATCH v2 0/3] nbd-client: enter read_reply_co during init to avoid crash

2017-08-29 Thread Eric Blake
On 08/29/2017 07:27 AM, Stefan Hajnoczi wrote: > v2: > * Rewrote Patch 1 following Paolo's suggestion [Paolo] > > See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage. > > This is a rare crash that we'll probably only see in testing. It only seems > to > happen with UNIX

Re: [Qemu-devel] [PATCH v4 06/10] tests: Add NetBSD image

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/29/2017 09:09 AM, Philippe Mathieu-Daudé wrote: [...]>> +if __name__ == "__main__": +    sys.exit(basevm.main(NetBSDVM)) This one is failing: DEBUG:root:ssh_cmd: ssh -q -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o ConnectTimeout=1 -p 34091 -i /tmp/qemu-vm-59X

[Qemu-devel] [PATCH] fixup! hostmem-file: Add "discard-data" option

2017-08-29 Thread Eduardo Habkost
On Tue, Aug 29, 2017 at 10:12:58AM -0300, Eduardo Habkost wrote: > On Tue, Aug 29, 2017 at 12:13:45PM +0100, Daniel P. Berrange wrote: > > On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote: [...] > > > @@ -4172,6 +4172,9 @@ the path to either a shared memory or huge page > > > filesy

Re: [Qemu-devel] [PULL 7/9] checkpatch: check trace-events code style

2017-08-29 Thread Alex Williamson
On Tue, 1 Aug 2017 14:16:16 +0100 Stefan Hajnoczi wrote: > From: Vladimir Sementsov-Ogievskiy > > According to CODING_STYLE, check that in trace-events: > 1. hex numbers are prefixed with '0x' > 2. '#' flag of printf is not used > 3. The exclusion from 1. are period-separated groups of numbers

Re: [Qemu-devel] [PATCH v2 6/7] throttle: Make burst_length 64bit and add range checks

2017-08-29 Thread Eric Blake
On 08/24/2017 08:24 AM, Alberto Garcia wrote: > LeakyBucket.burst_length is defined as an unsigned integer but the > code never checks for overflows and it only makes sure that the value > is not 0. > > In practice this means that the user can set something like > throttling.iops-total-max-length=

Re: [Qemu-devel] [PATCH v2 5/7] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-29 Thread Eric Blake
On 08/24/2017 08:24 AM, Alberto Garcia wrote: > Both the throttling limits set with the throttling.iops-* and > throttling.bps-* options and their QMP equivalents defined in the > BlockIOThrottle struct are integer values. > > Those limits are also reported in the BlockDeviceInfo struct and they >

Re: [Qemu-devel] [PATCH v2 3/7] throttle: Make throttle_is_valid() a bit less verbose

2017-08-29 Thread Eric Blake
On 08/24/2017 08:24 AM, Alberto Garcia wrote: > Use a pointer to the bucket instead of repeating cfg->buckets[i] all > the time. This makes the code more concise and will help us expand the > checks later and save a few line breaks. > > Signed-off-by: Alberto Garcia > --- > util/throttle.c | 15

Re: [Qemu-devel] [PATCH v2 2/7] throttle: Update the throttle_fix_bucket() documentation

2017-08-29 Thread Eric Blake
On 08/24/2017 08:24 AM, Alberto Garcia wrote: > The way the throttling algorithm works is that requests start being > throttled once the bucket level exceeds the burst limit. When we get > there the bucket leaks at the level set by the user (bkt->avg), and > that leak rate is what prevents guest I/

[Qemu-devel] [PATCH] oslib-posix: Print errors before aborting on qemu_alloc_stack()

2017-08-29 Thread Eduardo Habkost
If QEMU is running on a system that's out of memory and mmap() fails, QEMU aborts with no error message at all, making it hard to debug the reason for the failure. Add perror() calls that will print error information before aborting. Signed-off-by: Eduardo Habkost --- util/oslib-posix.c | 2 ++

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Eric Blake
On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote: > On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy > wrote: >> This is the follow-up patch that was discussed[*] as part of feedback to >> qemu-iotest 194. >> >> Signed-off-by: Kashyap Chamarthy >> --- >> Changes in v3: >> - Wait for migration t

Re: [Qemu-devel] [PATCH v4 11/43] tcg: define CF_PARALLEL and use it for TB hashing along with CF_COUNT_MASK

2017-08-29 Thread Emilio G. Cota
On Sun, Aug 27, 2017 at 18:15:50 -0400, Pranith Kumar wrote: > Hi Emilio, > > On Fri, Jul 21, 2017 at 1:59 AM, Emilio G. Cota wrote: > > This will enable us to decouple code translation from the value > > of parallel_cpus at any given time. It will also help us minimize > > TB flushes when genera

Re: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing

2017-08-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170829204934.9039-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread Daniel Henrique Barboza
On 08/29/2017 04:23 AM, David Gibson wrote: On Fri, Aug 25, 2017 at 06:11:18PM -0300, Daniel Henrique Barboza wrote: v2: - rebased with ppc-for-2.11 - function 'spapr_cas_completed' dropped - function 'spapr_drc_needed' made public and it's now used inside 'spapr_hotplugged_dev_before_cas'

[Qemu-devel] [PATCH v2 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-29 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow --- hw/ide/ahci.c | 157 +++- hw/ide/trace-events | 49 2 files changed, 117 insertions(+), 89 deletions(-) di

[Qemu-devel] [PATCH v2 8/9] AHCI: pretty-print FIS to buffer instead of stderr

2017-08-29 Thread John Snow
The current FIS printing routines dump the FIS to screen. adjust this such that it dumps to buffer instead, then use this ability to have FIS dump mechanisms via trace-events instead of compiled defines. Signed-off-by: John Snow --- hw/ide/ahci.c | 54 ++

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-29 Thread John Snow
On 08/29/2017 10:30 AM, Eric Blake wrote: > On 08/28/2017 08:18 PM, John Snow wrote: We'd have to develop a new syntax for specifying these resources that can be stored in a qcow2 file, >>> >>> It's called the json-pseudo-protocol and was developed exactly for this. >>> >> >> That's wha

Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements

2017-08-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170829204759.6853-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git lo

[Qemu-devel] [PATCH v2 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-08-29 Thread John Snow
Goodbye, printfs. Hello, fancy printfs. Signed-off-by: John Snow --- hw/ide/atapi.c| 64 +-- hw/ide/trace-events | 15 +++ include/hw/ide/internal.h | 1 - 3 files changed, 38 insertions(+), 42 deletions(-) diff --git a/hw/i

[Qemu-devel] [PATCH 7/8] tcg/s390: Use load-on-condition-2 facility

2017-08-29 Thread Richard Henderson
From: Richard Henderson This allows LOAD HALFWORD IMMEDIATE ON CONDITION, eliminating one insn in some common cases. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.inc.c | 79 +-- 2 files changed, 63 insert

[Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants

2017-08-29 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PATCH v2 3/9] IDE: add tracing for data ports

2017-08-29 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow --- hw/ide/core.c | 12 +++- hw/ide/trace-events | 5 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw

[Qemu-devel] [PATCH v2 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-29 Thread John Snow
Remove the DEBUG_IDE preprocessor definition with something more appropriately flexible, using the trace-events subsystem. This will be less prone to bitrot and will more effectively allow us to target just the functions we care about. Signed-off-by: John Snow Reviewed-by: Eric Blake --- Makef

[Qemu-devel] [PATCH 6/8] tcg/s390: Use distinct-operands facility

2017-08-29 Thread Richard Henderson
From: Richard Henderson This allows using a 3-operand insn form for some arithmetic, logicals and shifts. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.inc.c | 118 +++--- 2 files changed, 91 insertions(+), 2

[Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-29 Thread John Snow
Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 17 ++--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 6 -- 4 files changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 37

[Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro

2017-08-29 Thread John Snow
Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 2e75f9b..57bb59d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -34,17 +34,8 @@ #include "hw/ide/pci.h" #include "hw/ide/ahci_internal.h" -#define DEBU

[Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing

2017-08-29 Thread John Snow
Wherever possible, replace all printfs with proper tracing. In most places I've tried to do a straight replacement, but forthcoming patches may calibrate the tracing to be a little nicer. For now, it's nice to just remove the all-or-nothing tracing. For V2, I opted to leave in the nearly redundan

[Qemu-devel] [PATCH 4/8] tcg/s390: Merge add2i facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 38 ++ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index ff3f644f8e..6b08ccea6d 100644 --- a/tcg

[Qemu-devel] [PATCH 3/8] tcg/s390: Merge muli facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index e075b4844a..ff3f644f8e 100644 --

[Qemu-devel] [PATCH 5/8] tcg/s390: Merge ori+xori facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 101 +++--- 1 file changed, 33 insertions(+), 68 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index 6b08ccea6d..5414c9d879 100644

[Qemu-devel] [PATCH 8/8] tcg/s390: Use slbgr for setcond le and leu

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 119 +- 1 file changed, 43 insertions(+), 76 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index 0de968fde2..38b9e791ee 100644

[Qemu-devel] [PATCH v2 2/9] IDE: Add register hints to tracing

2017-08-29 Thread John Snow
Name the registers for tracing purposes. Signed-off-by: John Snow Reviewed-by: Eric Blake --- hw/ide/core.c | 88 + hw/ide/trace-events | 8 ++--- 2 files changed, 72 insertions(+), 24 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/c

[Qemu-devel] [PATCH 0/8] tcg/s390 improvements

2017-08-29 Thread Richard Henderson
This finally converts s390 to the tcg_target_op_def function, which allows constraints to vary at runtime. Once we have that, we can (1) Perform some facilities checks once during startup instead of every time we evaluate the constraint, (2) Use the distinct-operands facility from z196. In a

[Qemu-devel] [PATCH 1/8] tcg/s390: Fully convert tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Use a switch instead of searching a table. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 278 +- 1 file changed, 154 insertions(+), 124 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-tar

[Qemu-devel] [PATCH 2/8] tcg/s390: Merge cmpi facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 68 +-- 1 file changed, 30 insertions(+), 38 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index d34649eb13..e075b4844a 100644

Re: [Qemu-devel] [RFC PATCH 2/3] cpus-common: Cache allocated work items

2017-08-29 Thread Paolo Bonzini
Il 28 ago 2017 11:43 PM, "Pranith Kumar" ha scritto: On Mon, Aug 28, 2017 at 1:47 PM, Richard Henderson wrote: > On 08/27/2017 08:53 PM, Pranith Kumar wrote: >> Using heaptrack, I found that quite a few of our temporary allocations >> are coming from allocating work items. Instead of doing this

Re: [Qemu-devel] Make NVME device "migratable" (savevm)

2017-08-29 Thread Keith Busch
On Tue, Aug 29, 2017 at 11:09:36AM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 25, 2017 at 11:39:30AM +0300, Sergei Dyshel wrote: > > Hi all, > > From what I understand, I can't "savevm" a VM that uses NVME device because > > it has ".unmigratable = 1" in the code. What support must be implemented

Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile

2017-08-29 Thread Eric Blake
On 08/28/2017 09:41 AM, Cédric Le Goater wrote: > On 08/23/2017 01:53 PM, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> Compiler gets confused with the size of the struct, so move form >>> g_new0() to g_malloc0(). >>> >>> I *think* that the problem is in gcc (or

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 0/2] virtio-iommu: VFIO integration

2017-08-29 Thread Auger Eric
Hi Linu, On 29/08/2017 19:06, Linu Cherian wrote: > Hi, > > On Mon Aug 21, 2017 at 04:18:52PM +0530, Bharat Bhushan wrote: >> This V3 version is mainly about rebasing on v3 version on Virtio-iommu device >> framework from Eric Augur and addresing review comments. >> >> This patch series allows PC

Re: [Qemu-devel] [PATCH v2 1/3] nbd-client: avoid read_reply_co entry if send failed

2017-08-29 Thread Eric Blake
On 08/29/2017 07:27 AM, Stefan Hajnoczi wrote: > The following segfault is encountered if the NBD server closes the UNIX > domain socket immediately after negotiation: > > > In the mean time blk_co_preadv() can be called and nbd_coroutine_end() > calls aio_wake() on read_reply_co. At this point

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Eric Farman
On 08/29/2017 08:45 AM, Cornelia Huck wrote: On Tue, 29 Aug 2017 08:39:27 -0400 Farhan Ali wrote: On 08/29/2017 08:04 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: On 08/28/2017 10:19 AM, Halil Pasic wrote: On 08/28/2017 04:15 PM, Farhan Ali wrote:

[Qemu-devel] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests

2017-08-29 Thread Thomas Huth
Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take opaque BAR handle") a while ago, but nobody noticed since the tests are only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized anymore if bir_pba has the same value as bir_table. With this fix, "make check S

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 07:01 AM, Stefan Hajnoczi wrote: On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: On 08/25/2017 11:40 AM, Peter Maydell wrote: Our choices about our dependencies are generally driven by "what are the versions available on the oldest distros which we wish to support buil

Re: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning

2017-08-29 Thread Pranith Kumar
I should have worded the subject better. The warning is pointing to an actual bug. On Tue, Aug 29, 2017 at 1:32 PM, Pranith Kumar wrote: > Fix the following warning: > > /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is > only applied to the left hand side of this bitwis

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Stefan Hajnoczi
On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy wrote: > This is the follow-up patch that was discussed[*] as part of feedback to > qemu-iotest 194. > > Changes in this patch: > > - Supply 'job-id' parameter to `drive-mirror` invocation. > > - Once migration completes, issue QMP `block-job-

Re: [Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-08-29 Thread Richard Henderson
On 08/29/2017 10:23 AM, Pranith Kumar wrote: > This patch increases the number of entries cached in the TLB. I went > over a few architectures to see if increasing it is problematic. Only > armv6 seems to have a limitation that only 8 bits can be used for > indexing these entries. For other archite

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/28/2017 02:47 PM, Fam Zheng wrote: [...] +def __init__(self, debug=False, vcpus=None): +self._guest = None +self._tmpdir = tempfile.mkdtemp(prefix="qemu-vm-") +atexit.register(shutil.rmtree, self._tmpdir) + +self._ssh_key_file = os.path.join(self._tmpdir,

[Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning

2017-08-29 Thread Pranith Kumar
Fix the following warning: /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^ ~ /home/pranith/qem

[Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-08-29 Thread Pranith Kumar
This patch increases the number of entries cached in the TLB. I went over a few architectures to see if increasing it is problematic. Only armv6 seems to have a limitation that only 8 bits can be used for indexing these entries. For other architectures, the number of TLB entries is increased to a 4

Re: [Qemu-devel] make check speed

2017-08-29 Thread Thomas Huth
On 29.08.2017 18:34, Thomas Huth wrote: > On 23.08.2017 14:20, Cornelia Huck wrote: >> On Wed, 23 Aug 2017 10:35:43 +0200 >> Thomas Huth wrote: >> >>> True. And I just learned that you can also already set the SPEED >>> variable to either "quick" or "slow" and that we're already using >>> g_test_q

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 0/2] virtio-iommu: VFIO integration

2017-08-29 Thread Linu Cherian
Hi, On Mon Aug 21, 2017 at 04:18:52PM +0530, Bharat Bhushan wrote: > This V3 version is mainly about rebasing on v3 version on Virtio-iommu device > framework from Eric Augur and addresing review comments. > > This patch series allows PCI pass-through using virtio-iommu. > > This series is bas

[Qemu-devel] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Kashyap Chamarthy
This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Once migration completes, issue QMP `block-job-cancel` command on the source QEMU to gracefully complete `drive-mir

Re: [Qemu-devel] [PATCH] io: fix check for handshake completion in TLS test

2017-08-29 Thread Eric Blake
On 08/29/2017 11:40 AM, Daniel P. Berrange wrote: > The TLS I/O channel test had mistakenly used && instead > of || when checking for handshake completion. As a > result it could terminate the handshake process before > it had actually completed. This was harmless before but > changes in GNUTLS 3.6

  1   2   3   >