On 08/24/2017 08:24 AM, Alberto Garcia wrote:
> Use a pointer to the bucket instead of repeating cfg->buckets[i] all
> the time. This makes the code more concise and will help us expand the
> checks later and save a few line breaks.
>
> Signed-off-by: Alberto Garcia <be...@igalia.com>
> ---
> util/throttle.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/util/throttle.c b/util/throttle.c
> index 9a6bda813c..bde56fe3de 100644
> --- a/util/throttle.c
> +++ b/util/throttle.c
> @@ -324,32 +324,31 @@ bool throttle_is_valid(ThrottleConfig *cfg, Error
> **errp)
> }
>
> for (i = 0; i < BUCKETS_COUNT; i++) {
> - if (cfg->buckets[i].avg < 0 ||
> - cfg->buckets[i].max < 0 ||
> - cfg->buckets[i].avg > THROTTLE_VALUE_MAX ||
> - cfg->buckets[i].max > THROTTLE_VALUE_MAX) {
> + LeakyBucket *bkt = &cfg->buckets[i];
> + if (bkt->avg < 0 || bkt->max < 0 ||Up to the maintainer, but I'd include a blank line between declarations and code. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
