On 29.08.2017 18:34, Thomas Huth wrote: > On 23.08.2017 14:20, Cornelia Huck wrote: >> On Wed, 23 Aug 2017 10:35:43 +0200 >> Thomas Huth <th...@redhat.com> wrote: >> >>> True. And I just learned that you can also already set the SPEED >>> variable to either "quick" or "slow" and that we're already using >>> g_test_quick() and g_test_slow() in a couple of places to check this. So >>> the framework for running quick vs. thorough tests is already there ... >>> we just might want to add this to some more tests, I guess... >>> >>> Question for the maintainers and the test automation folks: Is anybody >>> already running "make check SPEED=slow" or is this just rather an >>> unheard-of way of running the tests? >> >> So I tried this on master just for fun, and 'make V=1 SPEED=slow >> check-qtest-x86_64' promptly failed for some ivshmem test. >> >> On x86_86: >> TEST: tests/ivshmem-test... (pid=3672) >> /x86_64/ivshmem/single: OK >> /x86_64/ivshmem/hotplug: OK >> /x86_64/ivshmem/memdev: OK >> /x86_64/ivshmem/pair: OK >> /x86_64/ivshmem/server-msi: ** >> ERROR:/home/cohuck/git/qemu/tests/ivshmem-test.c:367:test_ivshmem_server: >> assertion failed (ret == 0): (1 == 0) >> FAIL >> GTester: last random seed: R02Scde8fd6835fdf17450c73e2f74f25007 >> (pid=3697) >> /x86_64/ivshmem/server-irq: OK >> FAIL: tests/ivshmem-test > > Bisecting this problem automatically ("git bisect run" rules!) revealed > that this test broke with this commit: > > commit b4ba67d9a702507793c2724e56f98e9b0f7be02b > Author: David Gibson <da...@gibson.dropbear.id.au> > Title: libqos: Change PCI accessors to take opaque BAR handle > > David, any ideas what's going wrong here?
Never mind, I've found the problem: dev->msix_pba_bar is not properly initialized anymore if bir_pba == bir_table. I'm working on a patch... Thomas