On 2017-05-09 14:09, Richard Henderson wrote:
> On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
> > +tcg_gen_extrl_i64_i32(cpu_fregs[reg + 1], t);
> > +tcg_gen_extrh_i64_i32(cpu_fregs[reg], t);
>
> This is
>
> tcg_gen_extr_i64_i32(cpu_fregs[reg + 1], cpu_fregs[reg], t);
>
Good catch, th
We don't want to carry along old machine types forever. If we are able to
remove the pc machines up to 0.13 one day for example, this would allow
us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM
BARs directly to low memory). So let's start with a deprecation message
for the o
On Mon, May 08, 2017 at 09:25:19AM +0200, Paolo Bonzini wrote:
>
>
> On 08/05/2017 08:13, David Gibson wrote:
> >>
> >>Please start including Docker-based tests in your pre-pull-request
> >> tests.
> > Um.. is there some doco on how to execute these. I tried "make
> > docker-test" and "make
When running with KVM, we update the "family" CPU alias to point
to the right host CPU type, so that it for example possible to
use "-cpu POWER8" on a POWER8NVL host. However, the function for
printing the list of available CPU models is called earlier than
the KVM setup code, so the output of "-cp
Moving the algorithm from print_type_size() into size_to_str() so that
other component can also leverage it. With that, refactor
print_type_size().
Signed-off-by: Peter Xu
---
include/qemu-common.h| 1 +
qapi/string-output-visitor.c | 22 ++
util/cutils.c
v6
- patch 2: instead of create a new size_to_str(), abstract the logic
out from print_type_size(), refactor it, to make sure
print_type_size() dumps exactly the same thing as before. (a simple
test with info qtree is done)
- let suffixes be an array of strings [Markus]
v5
- add r-b for Dave
So that it can simplifies the iterators.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
exec.c | 22 +++---
include/exec/ramlist.h | 5 +
migration/ram.c| 15 ---
3 files changed, 24 insertions(+), 18 deletions(-)
diff -
To dump information about ramblocks. It looks like:
(qemu) info ramblock
Block NamePSize Offset Used
Total
/objects/mem2 MiB 0x 0x8000
0x8000
vga.vram4 KiB 0x00
On 09.05.2017 20:07, Richard Henderson wrote:
> Reviewed-by: Aurelien Jarno
> Signed-off-by: Richard Henderson
> ---
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 10 +++---
> target/s390x/mem_helper.c | 39 ++
> target/s390x/translate.c | 83
> +
On Tue, May 09, 2017 at 04:50:26PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > I stole the algorithm from print_type_size(). I didn't generalize it
> > since that's using [KM...]iB while here we need [KM...]B to finally
> > be able to stands for page sizes (and even more general).
>
On Tue, May 09, 2017 at 05:58:29PM +0200, Igor Mammedov wrote:
> On Mon, 8 May 2017 15:40:04 +1000
> David Gibson wrote:
>
> > On Wed, May 03, 2017 at 02:57:17PM +0200, Igor Mammedov wrote:
> > > legacy cpu to node mapping is using cpu index values to map
> > > VCPU to node with help of '-numa no
On Tue, May 09, 2017 at 09:35:23PM +1000, Alexey Kardashevskiy wrote:
> On 08/05/17 15:53, David Gibson wrote:
> > On Fri, May 05, 2017 at 08:19:30PM +1000, Alexey Kardashevskiy wrote:
> >> This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
> >> as a parent.
> >>
> >> This moves IO
On Tue, 05/09 10:48, Daniel P. Berrange wrote:
> The '--image-opts' flag indicates whether the source filename
> includes options. The target filename has to remain in the
> plain filename format though, since it needs to be passed to
> bdrv_create(). When using --skip-create though, it would be
>
On Tue, May 9, 2017 at 5:04 PM Yunjian Wang wrote:
> > From: w00273186
> >
> > "nc" is freed after hotplug vhost-user, but the watcher don't be removed.
> >
>
>
> > The QEMU crash when the watcher access the "nc" on socket disconnect.
> >
> >
> Do you have a reproducer? thanks
>
reproduce ste
On Tue, May 09, 2017 at 06:49:29AM +0200, Thomas Huth wrote:
> On 08.03.2017 20:05, Thomas Huth wrote:
> > When running with KVM, we update the "family" CPU alias to point
> > to the right host CPU type, so that it is for example possible to
> > use "-cpu POWER8" on a POWER8NVL host. However, the f
On Tue, May 09, 2017 at 06:41:23AM +0200, Thomas Huth wrote:
> On 09.05.2017 05:45, David Gibson wrote:
> > POWER9 DD1 silicon has some bugs which mean it a) isn't really compliant
> > with the ISA v3.00 and b) require a number of special workarounds in the
> > kernel.
> >
> > At the moment, qemu
If trace backend is set to TRACE_NOP, trace_get_vcpu_event_count
returns 0, cause bitmap_new call abort.
Signed-off-by: Anthony Xu
---
qom/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qom/cpu.c b/qom/cpu.c
index f02e9c0..f9111a0 100644
--- a/qom/cpu.c
+++ b/qom/
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
+void superh_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
+MMUAccessType access_type,
+int mmu_idx, uintptr_t retaddr)
+{
+if (retaddr) {
+cpu_restore_state(cs, r
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
We only emulate UP SH4, however as the tas.b instruction is used in the GNU
libc, this improve linux-user emulation.
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
At the same time change the comment describing the instruction the same
way than other instruction, so that the code is easier to read and search.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 26 +++
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
synco is a SH4-A only instruction.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
This doesn't change the generated code on x86, but optimizes it on most
RISC architectures and makes the code simpler to read.
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
+tcg_gen_extrl_i64_i32(cpu_fregs[reg + 1], t);
+tcg_gen_extrh_i64_i32(cpu_fregs[reg], t);
This is
tcg_gen_extr_i64_i32(cpu_fregs[reg + 1], cpu_fregs[reg], t);
Otherwise,
Reviewed-by: Richard Henderson
r~
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
r~
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
There is no need to save flags when entering and exiting the delay slot.
They can be saved only when reaching the end of the TB. If the TB is
interrupted before by an exception, they will be restored using
restore_state_to_opc.
Signed-off-by: Aurelie
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
In case of exception, there is no need to call tcg_gen_exit_tb as the
exception helper won't return.
Also fix a few cases where BS_BRANCH is called instead of BS_EXCP.
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 16 +++-
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
When stopping the translation because the state has changed, goto_tb
should not be used as it might link TB with different flags.
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
Instead of using one bit of the env flags to store the condition of the
next delay slot, use a separate global. It simplifies reading and
writing the flags variable and also removes some confusion between
ctx->envflags and env->flags.
Note that the g
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
Now that ctx->flags has been split, it becomes clear that
DELAY_SLOT_CLEARME has not impact on the code generation: in both case
ctx->envflags is cleared, either by clearing all the flags, or by
setting it to 0. This is left-over from pre-TCG era.
Re
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
DELAY_SLOT_TRUE is used as a dynamic condition for the branch after the
delay slot instruction. It is not used in code generation, so there is
no need to including in the TB state.
Signed-off-by: Aurelien Jarno
---
target/sh4/cpu.h | 3 +--
1 file
On 05/06/2017 04:14 AM, Aurelien Jarno wrote:
There is a confusion (and not only in the SH4 target) between tb->flags,
env->flags and ctx->flags. To avoid it, split ctx->flags into
ctx->tbflags and ctx->envflags. ctx->tbflags stays unchanged during the
whole TB translation, while ctx->envflags ev
On Tue, 9 May 2017 12:04:53 -0700
Stefano Stabellini wrote:
> Use the common utility function, which contains checks on return values,
... and first calls F_GETFD as recommended by POSIX.1-2001.
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
"The arg values to F_GETFD, F_
Hello,
Laurent Vivier, on mar. 09 mai 2017 21:31:11 +0200, wrote:
> This patch implements the SOCKS5 client part for "-net user" backend.
Thanks for the changes!
It seems from the bot result that windows doesn't define in_port_t.
Could you post a revised patch which uses sizeof(uint16_t) instead
On Tue, 9 May 2017 12:04:52 -0700
Stefano Stabellini wrote:
> Assert that the return value is not an error. This issue was found by
> Coverity.
>
> CID: 1374831
>
> Signed-off-by: Stefano Stabellini
> CC: gr...@kaod.org
> CC: pbonz...@redhat.com
> CC: Eric Blake
> ---
> util/oslib-posix.c |
On Tue, 9 May 2017 12:04:51 -0700
Stefano Stabellini wrote:
> CID: 1374836
>
> Signed-off-by: Stefano Stabellini
> CC: anthony.per...@citrix.com
> CC: gr...@kaod.org
> CC: aneesh.ku...@linux.vnet.ibm.com
> ---
> hw/9pfs/xen-9p-backend.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --gi
On Tue, May 09, 2017 at 03:13:37PM +0100, Richard W.M. Jones wrote:
> On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote:
> > On 05/09/2017 06:27 AM, Daniel P. Berrange wrote:
> > >This enables report of a signature in CPUID for the TCG
> > >interpretor.
> > >
> > >Changed in v4:
> >
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v5 0/1] slirp: add SOCKS5 support
Message-id: 20170509193112.16613-1-laur...@vivier.eu
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log -
On Tue, May 09, 2017 at 02:52:38PM -0500, Eric Blake wrote:
On 05/09/2017 02:43 PM, Manos Pitsidianakis wrote:
On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:
+cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET);
+
+if (cookie && cookie_secret) {
+erro
On 05/09/2017 02:43 PM, Manos Pitsidianakis wrote:
> On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:
>> +cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET);
>> +
>> +if (cookie && cookie_secret) {
>> +error_setg(errp,
>> + "curl driver c
On Tue, 9 May 2017, Eric Blake wrote:
> On 05/09/2017 02:20 PM, Eric Blake wrote:
> > On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> >> CID: 1374836
> >>
> >> Signed-off-by: Stefano Stabellini
> >> CC: anthony.per...@citrix.com
> >> CC: gr...@kaod.org
> >> CC: aneesh.ku...@linux.vnet.ibm.com
On Mon, May 08, 2017 at 01:30:31PM -0400, Stefan Hajnoczi wrote:
> On Sun, May 07, 2017 at 10:02:03AM +0300, Michael Tokarev wrote:
> > The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe:
> >
> > Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging
> > (2
On Sun, May 07, 2017 at 10:02:14AM +0300, Michael Tokarev wrote:
> From: "sochin.jiang fix wrong parameter comments in channel-file.h"
>
Hi Michael,
This patch has a corrupted From field. I do not modify pull requests
myself when merging. Could you please resend?
Thanks,
Stefan
signature.as
On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:
+cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET);
+
+if (cookie && cookie_secret) {
+error_setg(errp,
+ "curl driver cannot handle both cookie and cookie secret");
+goto out_no
When the VM is used behind a firewall, This allows
the use of a SOCKS5 proxy server to connect the VM IP stack
directly to the Internet.
This implementation doesn't manage UDP packets, so they
are simply dropped (as with restrict=on), except for
the localhost as we need it for DNS.
Signed-off-by:
This patch implements the SOCKS5 client part for "-net user" backend.
It allows to route all internet traffic of the virtual machine
to a SOCKS5 server.
But all the local traffic (to the host) is sent to the host.
It is needed because this SOCKS5 client doesn't route UDP traffic,
and this allows
On 05/09/2017 02:20 PM, Eric Blake wrote:
> On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
>> CID: 1374836
>>
>> Signed-off-by: Stefano Stabellini
>> CC: anthony.per...@citrix.com
>> CC: gr...@kaod.org
>> CC: aneesh.ku...@linux.vnet.ibm.com
>> ---
>> hw/9pfs/xen-9p-backend.c | 2 ++
>> 1 file
On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> Assert that the return value is not an error. This issue was found by
> Coverity.
>
> CID: 1374831
>
> Signed-off-by: Stefano Stabellini
> CC: gr...@kaod.org
> CC: pbonz...@redhat.com
> CC: Eric Blake
> ---
> util/oslib-posix.c | 4 +++-
> 1
Hello,
Laurent Vivier, on mar. 09 mai 2017 09:21:09 +0200, wrote:
> Le 08/05/2017 à 22:09, Samuel Thibault a écrit :
> > Laurent Vivier, on sam. 06 mai 2017 15:19:44 +0200, wrote:
> >>> Laurent Vivier, on sam. 06 mai 2017 00:48:33 +0200, wrote:
> >> The check is done previously by:
> >>
> >> @@ -4
On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> Use the common utility function, which contains checks on return values,
> instead of manually calling fcntl.
>
> CID: 1374831
>
> Signed-off-by: Stefano Stabellini
> CC: anthony.per...@citrix.com
> CC: gr...@kaod.org
> CC: aneesh.ku...@linux.v
On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> CID: 1374836
>
> Signed-off-by: Stefano Stabellini
> CC: anthony.per...@citrix.com
> CC: gr...@kaod.org
> CC: aneesh.ku...@linux.vnet.ibm.com
> ---
> hw/9pfs/xen-9p-backend.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Eric Blake
Assert that the return value is not an error. This issue was found by
Coverity.
CID: 1374831
Signed-off-by: Stefano Stabellini
CC: gr...@kaod.org
CC: pbonz...@redhat.com
CC: Eric Blake
---
util/oslib-posix.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/oslib-posi
Use the common utility function, which contains checks on return values,
instead of manually calling fcntl.
CID: 1374831
Signed-off-by: Stefano Stabellini
CC: anthony.per...@citrix.com
CC: gr...@kaod.org
CC: aneesh.ku...@linux.vnet.ibm.com
CC: Eric Blake
---
hw/9pfs/xen-9p-backend.c | 2 +-
hw
CID: 1374836
Signed-off-by: Stefano Stabellini
CC: anthony.per...@citrix.com
CC: gr...@kaod.org
CC: aneesh.ku...@linux.vnet.ibm.com
---
hw/9pfs/xen-9p-backend.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
index 9c7f41a..a1fdede 100644
* Alexey (a.pereva...@samsung.com) wrote:
> On Tue, May 09, 2017 at 10:40:34AM +0100, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > On Mon, May 08, 2017 at 12:08:07PM +0300, Alexey wrote:
> > > > On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote:
> > > > > On
HI
- Original Message -
> Hi,
> libvhost-user.h defines:
>VHOST_USER_INPUT_GET_CONFIG = 20,
That slipped by mistake from my vhost-user-input series WIP, please send a fix.
(luckily, this is only internal header for now)
thanks
> while
> vhost-user.c defines:
>VHOST_USER_NET_
On 05/09/2017 12:35 PM, Marc-André Lureau wrote:
> There are no real users of this case, and it's going to be invalid after
> merging of QFloat and QInt use the same QNum type in the following patch.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/test-keyval.c | 3 ---
>
OK, it'll be interesting if you get something repeatable, but sometimes
these type of bugs go and hide in a dark corner until someone trips over
them in a more critical situation.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https:
Hi,
libvhost-user.h defines:
VHOST_USER_INPUT_GET_CONFIG = 20,
while
vhost-user.c defines:
VHOST_USER_NET_SET_MTU = 20,
who wins?
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
On 05/09/2017 12:35 PM, Marc-André Lureau wrote:
> If the property is not of the requested type, the getters will leak a
> QObject.
>
> Signed-off-by: Marc-André Lureau
> ---
> qom/object.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, P
On 05/09/2017 12:35 PM, Marc-André Lureau wrote:
> Remove dependency on qapi qtype, replace a field by a few helper
> functions to determine the default value type (introduced in commit
> 4f2d3d7).
>
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/qdev-core.h | 1 -
> include/hw/qde
On 2017-05-09 11:07, Richard Henderson wrote:
> At the same time, improve STORE FACILITIES LIST
> so that we don't hard-code the list for all cpus.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
> target/s390x/misc_helper.c
Hi Philippe,
On 09.05.2017 18:49, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
> On 05/09/2017 02:19 AM, Thomas Huth wrote:
>> On 09.05.2017 01:39, Philippe Mathieu-Daudé wrote:
>>> This field is accessed in hw/intc/arm_gicv[23*].c
>>
>> default-configs/arm-softmmu.mak sets CONFIG_PCI, so this s
On 05/09/2017 02:19 PM, Eric Blake wrote:
> On 05/09/2017 01:17 PM, Eric Blake wrote:
>> On 05/09/2017 01:09 PM, John Snow wrote:
>>> Or, rather, force the open of a backing image if one was specified
>>> for creation. Using a similar -unsafe option as rebase, allow qemu-img
>>> to ignore the bac
On 05/09/2017 01:17 PM, Eric Blake wrote:
> On 05/09/2017 01:09 PM, John Snow wrote:
>> Or, rather, force the open of a backing image if one was specified
>> for creation. Using a similar -unsafe option as rebase, allow qemu-img
>> to ignore the backing file validation if possible.
>>
>> +++ b/qem
On 05/09/2017 01:09 PM, John Snow wrote:
> Or, rather, force the open of a backing image if one was specified
> for creation. Using a similar -unsafe option as rebase, allow qemu-img
> to ignore the backing file validation if possible.
>
> It may not always be possible, as in the existing case whe
patchew has been saying:
ERROR: open brace '{' following struct go on the same line
Fix up acpi-defs.h to follow this rule.
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/acpi-defs.h | 37 +
1 file changed, 13 insertions(+), 24 deletions(-)
diff --git
Reviewed-by: Aurelien Jarno
Signed-off-by: Richard Henderson
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 10 +++---
target/s390x/mem_helper.c | 39 ++
target/s390x/translate.c | 83 --
4 files changed, 59
On 05/08/2017 12:30 PM, Stefan Hajnoczi wrote:
> On Sun, May 07, 2017 at 10:02:03AM +0300, Michael Tokarev wrote:
>> The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe:
>>
>> Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging
>> (2017-05-04 13:44:32 +010
Or, rather, force the open of a backing image if one was specified
for creation. Using a similar -unsafe option as rebase, allow qemu-img
to ignore the backing file validation if possible.
It may not always be possible, as in the existing case when a filesize
for the new image was not specified.
From: Eric Bischoff
Reviewed-by: Aurelien Jarno
Signed-off-by: Eric Bischoff
Message-Id: <20170228120134.7921-1-ebisch...@suse.com>
[rth: Combine the two via insn->data; free the address temps.]
Signed-off-by: Richard Henderson
---
target/s390x/insn-data.def | 4 +++-
target/s390x/translate.
From: Miroslav Benes
Linux arch/s390/kernel/head(64).S uses LPP instruction if it is
available in facilities list provided by stfl/stfle instruction.
This is the case of newer z/System generations and their qemu
definition.
The description of LPP is at
http://www-01.ibm.com/support/docview.wss?u
Reviewed-by: Aurelien Jarno
Signed-off-by: Richard Henderson
---
target/s390x/insn-data.def | 20 ++--
target/s390x/translate.c | 78 +-
2 files changed, 60 insertions(+), 38 deletions(-)
diff --git a/target/s390x/insn-data.def b/target/s390
All of the interlocked access facility instructions raise a
specification exception for unaligned accesses. Do this by
using the (previously unused) unaligned_access hook.
Reviewed-by: Aurelien Jarno
Signed-off-by: Richard Henderson
---
target/s390x/cpu.c| 1 +
target/s390x/cpu.h| 3
At the same time, improve STORE FACILITIES LIST
so that we don't hard-code the list for all cpus.
Signed-off-by: Richard Henderson
---
target/s390x/helper.h | 2 ++
target/s390x/insn-data.def | 2 ++
target/s390x/misc_helper.c | 59 ++
target/s3
Changes since v2:
* Fix STFLE patch as pointed out by Aurelien.
* Adjust CS patch to change is_64 boolean in
s->insn->data to TCGMemOp.
r~
Eric Bischoff (1):
target/s390x: Implement LOAD PAIR DISJOINT
Miroslav Benes (1):
target/s390x: Implement LOAD PROGRAM PARAMETER
Richard Hende
On Tue, May 09, 2017 at 08:45:35AM -0700, no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PULL 0/8] pci, virtio, vhost: fixes
> Type: series
> Message-id: 1494330527-24163-1-git-send-em
On 05/07/2017 02:02 AM, Michael Tokarev wrote:
> From: "sochin.jiang fix wrong parameter comments in channel-file.h"
>
Do we really want this HUGE email name, or can we get it touched up
before stefanha promotes his staging branch to master?
>
> Signed-off-by: sochin.jiang
> Reviewed-by: Marc
On Wed, Feb 22, 2017 at 02:42:34PM +0100, Gerd Hoffmann wrote:
> Hi folks,
>
> I'd like to start maintaining qemu-specific branches in our ipxe.git
> repo. The reason for this are some problems with the upstream ipxe
> maintainance:
>
> * The ipxe maintainer apparently is pretty busy. Often
On Mon, May 08, 2017 at 05:07:18PM -0400, John Snow wrote:
>
>
> On 05/08/2017 05:02 PM, Denis V. Lunev wrote:
> > On 05/08/2017 10:35 PM, Stefan Hajnoczi wrote:
> >> On Thu, May 04, 2017 at 12:54:40PM +0200, Daniel Kucera wrote:
> >>
> >> Seems like a logical extension along the same lines as th
On Tue, May 09, 2017 at 10:06:17AM +0200, Markus Armbruster wrote:
> [v3]: Rebase & resolve semantic conflicts, with help from Eric Blake
> [v2]: Fix trailing space, note tweaks to PATCH 12 properly in the
> commit message
>
> The following changes since commit dd1559bb267becbb838de41132ef60771d1
On 05/09/2017 12:33 PM, Daniel P. Berrange wrote:
> The tests 033, 140, 145 and 157 were all broken
> when run with LUKS, since they did not correctly use
> the required image opts args syntax to specify the
> decryption secret. Further, the 120 test simply does
> not make sense to run with luks, a
Use a more specific bool type.
Signed-off-by: Marc-André Lureau
---
hw/acpi/ich9.c | 24
hw/acpi/piix4.c | 8
hw/i386/acpi-build.c | 5 +++--
3 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 5c27
The dump functions could be generally useful for any qobject user or for
debugging etc.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qdict.h | 2 ++
include/qapi/qmp/qlist.h | 2 ++
include/qapi/qmp/qobject.h | 7
block/qapi.c | 90 +++--
Signed-off-by: Marc-André Lureau
---
include/qom/object.h | 23 +++
qom/object.c | 33 +
2 files changed, 56 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index cd0f412ce9..abaeb8cf4e 100644
--- a/include/qom/ob
Similar to int support, add uint support.
Note this is RFC because this is currently unused in qemu, I haven't
found a good user for it yet (kaslr qemu-ga code did use it though).
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qdict.h | 5 +
qobject/qdict.c | 38 +++
Switch strtoll() usage to qemu_strtoi64() helper while at it.
Replace temporarily the error in qnum_get_int() with values >INT64_MAX
until the visitor is updated.
Add a few tests for large numbers.
Signed-off-by: Marc-André Lureau
---
qobject/json-lexer.c | 4
qobject/json-
Use the actual unsigned integer type name (this should't break since
property type aren't directly accessed from outside it seems).
Signed-off-by: Marc-André Lureau
---
backends/cryptodev.c | 2 +-
hw/pci-host/piix.c | 8
hw/pci-host/q35.c| 10 +-
hw/ppc/pnv.c |
Use unsigned type for various properties.
Signed-off-by: Marc-André Lureau
---
include/hw/qdev-core.h | 5 +++-
include/hw/qdev-properties.h | 67 ++--
hw/block/fdc.c | 54 +--
hw/core/qdev-properties.c
All those property usages are associated with unsigned integers, so use
appropriate getter/setter.
Signed-off-by: Marc-André Lureau
---
include/hw/isa/isa.h | 2 +-
hw/acpi/memory_hotplug.c | 10
hw/acpi/nvdimm.c | 10
hw/acpi/pcihp.c | 6
In order to store integer values superior to INT64_MAX, add a u64
internal representation.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qnum.h | 4
qobject/qnum.c | 49 +++
tests/check-qnum.c | 51 ++
Switch to use QNum/uint where appropriate to remove i64 limitation.
The input visitor will cast i64 input to u64 for compatibility
reasons (existing json QMP client already use negative i64 for large
u64, and expect an implicit cast in qemu).
Signed-off-by: Marc-André Lureau
---
qapi/qobject-in
Now that the visitor has been switch to use qnum_uint, fix the bad
get_int() to use get_uint() instead. Remove compatibility code.
Signed-off-by: Marc-André Lureau
---
hw/i386/acpi-build.c | 2 +-
qobject/qnum.c | 4 ++--
tests/check-qnum.c | 9 -
3 files changed, 7 insertions(+)
Based on underlying property type, use the appropriate getters/setters.
Signed-off-by: Marc-André Lureau
---
hw/i386/acpi-build.c | 12 ++--
hw/pci-host/gpex.c| 2 +-
hw/pci-host/q35.c | 2 +-
hw/pci-host/xilinx-pcie.c | 2 +-
target/i386/cpu.c | 2 +-
5
Hi,
In previously sent series "[PATCH 00/21] WIP: dump: add kaslr support
(for after 2.9)", I proposed changes to accept uint64 values from
json, by adding a QUint type. During review, it was suggested to
introduce a QNum type to hold various number representations.
This series introduces the QNu
Remove dependency on qapi qtype, replace a field by a few helper
functions to determine the default value type (introduced in commit
4f2d3d7).
Signed-off-by: Marc-André Lureau
---
include/hw/qdev-core.h | 1 -
include/hw/qdev-properties.h | 5 -
hw/core/qdev.c | 32
We would like to use a same QObject type to represent numbers, whether
they are int, uint, or floats. getters will allow some compatibility
between the various types if the number fits other representations
Signed-off-by: Marc-André Lureau
---
scripts/qapi.py | 30 +++--
qnum_to_double() implicity promotes int now.
Signed-off-by: Marc-André Lureau
---
include/qapi/visitor.h | 4 +---
include/qapi/visitor-impl.h| 2 +-
scripts/qapi-visit.py | 12 +++-
qapi/qapi-visit-core.c | 6 +++---
qapi/qapi-clone-visito
On some distros, whenever you close a block device file
descriptor there is a udev rule that resets the file
permissions. This can race with the test script when
we run qemu-io multiple times against the same block
device. Occasionally the second qemu-io invocation
will find udev has reset the perm
If the property is not of the requested type, the getters will leak a
QObject.
Signed-off-by: Marc-André Lureau
---
qom/object.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index eb4bc924ff..c7b8079df6 100644
--- a/qom/object.c
+++ b/qom/
There are no real users of this case, and it's going to be invalid after
merging of QFloat and QInt use the same QNum type in the following patch.
Signed-off-by: Marc-André Lureau
---
tests/test-keyval.c | 3 ---
tests/test-qobject-input-visitor.c | 26 -
1 - 100 of 345 matches
Mail list logo
