On Tue, May 09, 2017 at 02:52:38PM -0500, Eric Blake wrote:
On 05/09/2017 02:43 PM, Manos Pitsidianakis wrote:On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:+ cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET); + + if (cookie && cookie_secret) { + error_setg(errp, + "curl driver cannot handle both cookie and cookie secret"); + goto out_noclean; + } + + if (cookie_secret) { + s->cookie = qcrypto_secret_lookup_as_utf8(cookie_secret, errp); + if (!s->cookie) { + goto out_noclean; + } + } else { + s->cookie = g_strdup(cookie); + }There's no check here for if both cookie and cookie_secret are NULL.Is that a problem? s->cookie ends up as NULL (thanks to g_strdup() semantics), which merely means there's no cookie to be sent after all.
Ah yes, g_strdup(NULL) returns NULL. Apologies for the noise.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: PGP signature
