On 05/09/2017 02:19 PM, Eric Blake wrote: > On 05/09/2017 01:17 PM, Eric Blake wrote: >> On 05/09/2017 01:09 PM, John Snow wrote: >>> Or, rather, force the open of a backing image if one was specified >>> for creation. Using a similar -unsafe option as rebase, allow qemu-img >>> to ignore the backing file validation if possible. >>> > >>> +++ b/qemu-img.c >>> @@ -145,9 +145,11 @@ static void QEMU_NORETURN help(void) >>> " 'snapshot_id_or_name' is deprecated, use 'snapshot_param'\n" >>> " instead\n" >>> " '-c' indicates that target image must be compressed (qcow >>> format only)\n" >>> - " '-u' enables unsafe rebasing. It is assumed that old and new >>> backing file\n" >>> - " match exactly. The image doesn't need a working backing >>> file before\n" >>> - " rebasing in this case (useful for renaming the backing >>> file)\n" >>> + " '-u' allows unsafe backing chains. For rebasing, it is >>> assumed that old and new\n" >>> + " backing file match exactly. The image doesn't need a >>> working backing file\n" >>> + " before rebasing in this case (useful for renaming the >>> backing file)\n" > > Also, a '.' to end this sentence would be nice. >
d'oh. I can respin if that's more convenient, as I am assuming Max or Kevin will have something to say. If not, either edit it if that's easier, or ask me to re-spin. >>> + " For image creation, allow creating without attempting >>> to" >> >> Missing \n >> >> With that fixed, >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> >
