On Tue, 9 May 2017 12:04:52 -0700 Stefano Stabellini <sstabell...@kernel.org> wrote:
> Assert that the return value is not an error. This issue was found by
> Coverity.
>
> CID: 1374831
>
> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org>
> CC: gr...@kaod.org
> CC: pbonz...@redhat.com
> CC: Eric Blake <ebl...@redhat.com>
> ---
> util/oslib-posix.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Greg Kurz <gr...@kaod.org>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 4d9189e..16894ad 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd)
> {
> int f;
> f = fcntl(fd, F_GETFD);
> - fcntl(fd, F_SETFD, f | FD_CLOEXEC);
> + assert(f != -1);
> + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC);
> + assert(f != -1);
> }
>
> /*
pgphWhfK8FVLV.pgp
Description: OpenPGP digital signature
