[Qemu-devel] [Bug 1674117] Re: Qemu VM start kills Pulseaudio

2017-03-24 Thread 3vIL_VIrUs
After switching from SeaBios to OVMF the issue seems to be gone, indicating a problem with the former. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1674117 Title: Qemu VM start kills Pulseaudio S

[Qemu-devel] [Bug 1248168] Re: MIPS, self-modifying code and uncached memory

2017-03-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1248168 Title: MIPS, self-

[Qemu-devel] [Bug 804517] Re: qemu crashes on Darwin in qemu_iohandler_poll

2017-03-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/804517 Title: qemu crashes

[Qemu-devel] [Bug 1253777] Re: OpenBSD VM running on OpenBSD host has sleep calls taking twice as long as they should

2017-03-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1253777 Title: OpenBSD VM

Re: [Qemu-devel] [Qemu-arm] [patch 1/1]about armv8's prefetch decode

2017-03-24 Thread Wangjintang
Hi Peter, More detail illustration at below. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Friday, March 24, 2017 6:06 PM > To: Wangjintang > Cc: Pranith Kumar; Shlomo Pongratz (A); Wanghaibin (Benjamin); qemu-arm; > qemu-devel; Ori Chalak (A)

Re: [Qemu-devel] [PATCH] xen: additionally restrict xenforeignmemory operations

2017-03-24 Thread Stefano Stabellini
On Fri, 24 Mar 2017, Paul Durrant wrote: > Commit f0f272baf3a7 "xen: use libxendevice model to restrict operations" > added a command-line option (-xen-domid-restrict) to limit operations > using the libxendevicemodel API to a specified domid. The commit also > noted that the restriction would be e

[Qemu-devel] slirp + ipxe + ipv6 dns issue

2017-03-24 Thread Cole Robinson
Hi Samuel, A Fedora user reported a regression for his ipxe setup (Jan, CCd). He has a public PXE server and config. You can see details about his config here: http://boot.salstar.sk/ipxe/ Reproducer: wget http://boot.salstar.sk/ipxe/ipxe.lkrn qemu-system-x86_64 -kernel ipxe.lkrn Non-workin

[Qemu-devel] [PATCH] tap-win32: don't abort in tap_enable(); enables -netdev tap

2017-03-24 Thread Andrew Baumann
The docs generally steer users away from using the legacy -net parameter, however on win32 attempting to enable a tap device using -netdev tap fails at an abort() in tap_enable(). Removing the abort()s seems to be enough to get everything working, so do that. Signed-off-by: Andrew Baumann --- ne

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: fix vring_align() on 64-bit win32 platforms

2017-03-24 Thread Andrew Baumann
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Friday, 24 March 2017 15:20 > So is 'win32' really a 64-bit platform, or should the subject be '64-bit > windows'? Sigh. Yes, ok, it's a little silly if you put it like that. I guess I was thinking of the _WIN32 ifdef and the files named *win

[Qemu-devel] [PATCH v3] virtio: fix vring_align() on 64-bit windows

2017-03-24 Thread Andrew Baumann
long is 32-bits on 64-bit windows, which caused the top half of the address to be truncated; this patch changes it to use the QEMU_ALIGN_UP macro which does not suffer the same problem Signed-off-by: Andrew Baumann Reviewed-by: Eric Blake --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-03-24 Thread Andrew Baumann
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, 24 March 2017 15:29 > > From: Andrey Shedel > > > > The multithreaded TCG implementation exposed deadlocks in the win32 > > condition variables: as implemented, qemu_cond_broadcast waited on > > receivers, whereas the pthreads API

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-03-24 Thread Eric Blake
On 03/24/2017 05:01 PM, Andrew Baumann wrote: > From: Andrey Shedel > > The multithreaded TCG implementation exposed deadlocks in the win32 > condition variables: as implemented, qemu_cond_broadcast waited on > receivers, whereas the pthreads API it was intended to emulate does > not. This was ca

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-03-24 Thread Paolo Bonzini
> From: Andrey Shedel > > The multithreaded TCG implementation exposed deadlocks in the win32 > condition variables: as implemented, qemu_cond_broadcast waited on > receivers, whereas the pthreads API it was intended to emulate does > not. This was causing a deadlock because broadcast was called

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-03-24 Thread Paolo Bonzini
> The major implication of this patch is that it drops support for > pre-Vista versions of Windows. However, those OSes are past their end > of life, and other OSS projects have dropped support. e.g.; the last > Cygwin release supporting XP was in Jun 2016. It doesn't seem like a > good tradeoff t

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: fix vring_align() on 64-bit win32 platforms

2017-03-24 Thread Eric Blake
On 03/24/2017 04:21 PM, Andrew Baumann wrote: So is 'win32' really a 64-bit platform, or should the subject be '64-bit windows'? > long is 32-bits on win32, which caused the top half of the address to > be truncated; this patch changes it to use the QEMU_ALIGN_UP macro > which does not suffer the

Re: [Qemu-devel] [PATCH v6] vfio error recovery: kernel support

2017-03-24 Thread Alex Williamson
On Thu, 23 Mar 2017 17:07:31 +0800 Cao jin wrote: A more appropriate patch subject would be: vfio-pci: Report correctable errors and slot reset events to user > From: "Michael S. Tsirkin" This hardly seems accurate anymore. You could say Suggested-by and let Michael add a sign-off, but it's

Re: [Qemu-devel] [PATCH v3 0/3] vfio-pci: support recovery of AER non fatal error

2017-03-24 Thread Alex Williamson
On Thu, 23 Mar 2017 17:09:20 +0800 Cao jin wrote: > v3 changelog: > 1. Address all comments from MST in patch 3, include remove the flag >pci_aer_non_fatal & passive_reset, also the boilerplate code. >The corresponding kernel patch is v6. > > Test: > Test with func1 passthroughed while f

Re: [Qemu-devel] [PATCH v3 1/3] pcie aer: verify if AER functionality is available

2017-03-24 Thread Alex Williamson
On Thu, 23 Mar 2017 17:09:21 +0800 Cao jin wrote: > For devices which support AER function, verify it can work or not in the > system: > 1. AER capable device is a PCIe device, it can't be plugged into PCI bus > 2. If root port doesn't support AER, then there is no need to expose the >AER cap

Re: [Qemu-devel] [PATCH v3 3/3] vfio-pci: process non fatal error of AER

2017-03-24 Thread Alex Williamson
On Thu, 23 Mar 2017 17:09:23 +0800 Cao jin wrote: > Make use of the non fatal error eventfd that the kernel module provide > to process the AER non fatal error. Fatal error still goes into the > legacy way which results in VM stop. > > Register the handler, wait for notification. Construct aer m

Re: [Qemu-devel] [PATCH v3 2/3] vfio pci: new function to init AER capability

2017-03-24 Thread Alex Williamson
On Thu, 23 Mar 2017 17:09:22 +0800 Cao jin wrote: This is not a sufficiently trivial patch to leave the commit log empty. > Signed-off-by: Dou Liyang > Signed-off-by: Cao jin > --- > hw/vfio/pci.c | 41 - > hw/vfio/pci.h | 1 + > 2 files changed, 37 in

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

2017-03-24 Thread John Snow
On 03/08/2017 03:26 AM, Thomas Huth wrote: > > Hi everybody, > > what will be the next version of QEMU after 2.9? Will we go for a 2.10 > (as I've seen it mentioned a couple of times on the mailing list > already), or do we dare to switch to 3.0 instead? > > I personally dislike two-digit min

[Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-03-24 Thread Andrew Baumann
From: Andrey Shedel The multithreaded TCG implementation exposed deadlocks in the win32 condition variables: as implemented, qemu_cond_broadcast waited on receivers, whereas the pthreads API it was intended to emulate does not. This was causing a deadlock because broadcast was called while holdin

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-24 Thread Paolo Bonzini
On 20/03/2017 18:16, Paolo Bonzini wrote: > > > On 20/03/2017 18:01, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 20 March 2017 at 16:29, Markus Armbruster wrote: Peter Maydell writes: > I have some comments which feel kind of nit-picky, but since this > is a publ

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

2017-03-24 Thread luigiburdo
Hi, now i understand . xics have to be build in kernel and is needed by qemu 2.9 with kvm. if is not present in the kernel have the issue that i been reported about xics. I make a test on ubuntu 16.10 and on 17.04. the two distro are ppc 32 and generic. i had build the stable kernel 4.10.5 tw

[Qemu-devel] [PATCH v2] virtio: fix vring_align() on 64-bit win32 platforms

2017-03-24 Thread Andrew Baumann
long is 32-bits on win32, which caused the top half of the address to be truncated; this patch changes it to use the QEMU_ALIGN_UP macro which does not suffer the same problem Signed-off-by: Andrew Baumann --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH for-2.9] i386: Don't override -cpu options on -cpu host/max

2017-03-24 Thread Eduardo Habkost
The existing code for "host" and "max" CPU models overrides every single feature in the CPU object at realize time, even the ones that were explicitly enabled or disabled by the user using "feat=on" or "feat=off", while features set using +feat/-feat are kept. This means "-cpu host,+invtsc" works

Re: [Qemu-devel] [RFC PATCH v4 06/20] core: add new security-policy object

2017-03-24 Thread Brijesh Singh
On 03/24/2017 10:40 AM, Stefan Hajnoczi wrote: Having one security policy doesn't make sense to me. As mentioned, there are many different areas of QEMU that have security relevant configuration. They are all unrelated so combining them into one object with vague parameter names like "debug"

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Qemu-devel [mailto:qemu-devel- > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant > Sent: 24 March 2017 19:18 > To: 'Stefano Stabellini' ; Juergen Gross > > Cc: Anthony Perard ; xen- > de...@lists.xenproject.org; qemu-devel@nongnu.org > Sub

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Eduardo Habkost
On Fri, Mar 24, 2017 at 05:08:56PM +, Peter Maydell wrote: > On 24 March 2017 at 16:58, Markus Armbruster wrote: > > "Sysbus" isn't a bus. In qdev's original design, every device had to > > plug into a bus, period. The ones that really didn't were made to plug > > into "sysbus". > > > > Pret

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 24 March 2017 19:12 > To: Juergen Gross > Cc: Paul Durrant ; qemu-devel@nongnu.org; xen- > de...@lists.xenproject.org; Anthony Perard ; > Stefano Stabellini > Subject: Re: [PATCH RESEND] xen: limit pkg

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Stefano Stabellini
On Fri, 24 Mar 2017, Juergen Gross wrote: > On 24/03/17 18:20, Paul Durrant wrote: > > The Xen tools Makefile has been modified to set PKG_CONFIG_PATH such that > > use of pkg-config in QEMU configure finds the newly built Xen libraries. > > However, because older versions of Xen do not set PKG_CON

Re: [Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/rbd.c | 7 +++ > 1 file changed, 7 insertions(+) > In short, since we have a QAPI enum of valid types, we should verify that all members of the list match that enum. Reviewed-by: Eric Blake

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Eduardo Habkost
On Fri, Mar 24, 2017 at 02:13:48PM +, Peter Maydell wrote: > On 24 March 2017 at 13:48, Eduardo Habkost wrote: > > The problem with today's mechanism is that we have no way to make > > a machine accept one type of sysbus device without making it > > start accepting every other sysbus devices.

Re: [Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > We have two list-values options: > > * "server" is a list of InetSocketAddress. We use members "host" and > "port", and silently ignore the rest. > > * "auth-supported" is a list of RbdAuthMethod. We use its only member > "auth". > > Since

Re: [Qemu-devel] [PATCH RFC v2 6/9] rbd: Clean up runtime_opts, fix -drive to reject filename

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > runtime_opts is used for three different purposes: > This is a confusing mess. Dates back to commit 0f9d252. First step > to clean it up is documenting runtime_opts.desc[]: > > * Reorder entries to match the QAPI schema, like we do in other blo

Re: [Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > The way we communicate extra key-value pairs from > qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter > "keyvalue-pairs" on the command line. It's not wanted there. Hack: > rename the parameter to "=keyvalue-pairs" to make it

Re: [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > This code in qemu_rbd_parse_filename() > > found_str = qemu_rbd_next_tok(p, '\0', &p); This says to take a string starting at p, modify it in place, update p to point past the delimiter (well, to nowhere since the delimiter of '\0' means it i

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Juergen Gross
On 24/03/17 18:20, Paul Durrant wrote: > The Xen tools Makefile has been modified to set PKG_CONFIG_PATH such that > use of pkg-config in QEMU configure finds the newly built Xen libraries. > However, because older versions of Xen do not set PKG_CONFIG_PATH in the > Makefile, the QEMU configure scr

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 17:42, Paul Durrant wrote: >> -Original Message- > [snip] That's a change in behaviour that I, and probably others, have long been >> used to. What we really want, presumably, is to have pkg-config just look >> under tools/pkgconfig when querying for the version of xencontr

Re: [Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > We laboriously enforce parameter values are between one and some > arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from > librbd.h, and I'm not sure it applies. Where the other limits come > from is unclear. > > Drop the length che

Re: [Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > qemu_rbd_open() neglects to check pool and image are present. > Reproducer: > > $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p > Segmentation fault (core dumped) > $ qemu-system-x86_64 -nodefaults -drive if=none,driv

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 17:59, Markus Armbruster wrote: > Peter Maydell writes: >> This isn't really true. Sysbus devices support having MMIO regions >> and IRQ lines and GPIO lines. If you need those you're a >> sysbus device; otherwise you can probably just be a plain old Device. > > Well, "device

Re: [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > We use InetSocketAddress in the QAPI schema. However, the code > doesn't use inet_connect_saddr(), but formats "host" and "port" into a > configuration string for rados_conf_set(). Thus, members "numeric", > "to", "ipv4" and "ipv6" are silently i

Re: [Qemu-devel] [Patch v2] Provided python3 support for qmp.py 2/2]

2017-03-24 Thread Stefan Hajnoczi
On Wed, Mar 22, 2017 at 12:27:44PM +0300, Joannah Nanjekye wrote: > From: nanjekyejoannah Thanks for the patch! > > Signed-off-by: nanjekyejoannah > > The patch provides python 3 support for one of the scripts in scripts/qmp > that is to say qmp.py. This is not a port to python 3 but rather

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Markus Armbruster
Peter Maydell writes: > On 24 March 2017 at 16:58, Markus Armbruster wrote: >> "Sysbus" isn't a bus. In qdev's original design, every device had to >> plug into a bus, period. The ones that really didn't were made to plug >> into "sysbus". >> >> Pretty much the only thing "sysbus" devices had

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Kevin Wolf
Am 24.03.2017 um 14:49 hat Eric Blake geschrieben: > On 03/24/2017 07:42 AM, Jeff Cody wrote: > > > Agree. My preference is to leave it as an array of methods, so long as that > > is tenable to libvirt. > > The -drive syntax should remain unchanged (that's an absolute must for > libvirt). But t

Re: [Qemu-devel] Question nbd_refresh_filename()

2017-03-24 Thread Kevin Wolf
Am 24.03.2017 um 16:47 hat Stefan Hajnoczi geschrieben: > On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote: > > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't > > restrict variants. Thus, all four SOCKET_ADDRESS_KIND_ can occur. > > > > Now have a look at

[Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values

2017-03-24 Thread Markus Armbruster
We laboriously enforce parameter values are between one and some arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from librbd.h, and I'm not sure it applies. Where the other limits come from is unclear. Drop the length checking. The limits librbd actually imposes must be checked by

[Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options

2017-03-24 Thread Markus Armbruster
We have two list-values options: * "server" is a list of InetSocketAddress. We use members "host" and "port", and silently ignore the rest. * "auth-supported" is a list of RbdAuthMethod. We use its only member "auth". Since qemu_rbd_open() takes options as a flattened QDict, options has ke

[Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}

2017-03-24 Thread Markus Armbruster
We use InetSocketAddress in the QAPI schema. However, the code doesn't use inet_connect_saddr(), but formats "host" and "port" into a configuration string for rados_conf_set(). Thus, members "numeric", "to", "ipv4" and "ipv6" are silently ignored. Not nice. Example: -blockdev rbd,node-nam

[Qemu-devel] [PATCH RFC v2 7/9] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

2017-03-24 Thread Markus Armbruster
The conversion from QDict to QemuOpts is pointless. Simply get the stuff straight from the QDict. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/rbd.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/block/rb

[Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

2017-03-24 Thread Markus Armbruster
The way we communicate extra key-value pairs from qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter "keyvalue-pairs" on the command line. It's not wanted there. Hack: rename the parameter to "=keyvalue-pairs" to make it inaccessible. Signed-off-by: Markus Armbruster --- blo

[Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods

2017-03-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block/rbd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index e962641..19fd820 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -15,6 +15,7 @@ #include #include "qapi/error.h" +#include "qapi/util.h" #include "qemu/e

[Qemu-devel] [PATCH RFC v2 6/9] rbd: Clean up runtime_opts, fix -drive to reject filename

2017-03-24 Thread Markus Armbruster
runtime_opts is used for three different purposes: * qemu_rbd_open() uses it to accept options it recognizes, such as "pool" and "image". Other .bdrv_open() methods do it similarly. * qemu_rbd_open() accepts additional list-valued options auth-supported and server, with the help of qemu_rbd_

[Qemu-devel] [PATCH RFC v2 0/9] rbd: Clean up API and code

2017-03-24 Thread Markus Armbruster
This is RFC because it needs more testing and an additional patch to clean up around RbdAuthMethod. I'm sending it out now in the hope of getting some review. Markus Armbruster (9): rbd: Reject -blockdev server.*.{numeric,to,ipv4,ipv6} rbd: Fix to cleanly reject -drive without pool or image

[Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit

2017-03-24 Thread Markus Armbruster
This code in qemu_rbd_parse_filename() found_str = qemu_rbd_next_tok(p, '\0', &p); p = found_str; has no effect. Drop it, and simplify qemu_rbd_next_tok(). Signed-off-by: Markus Armbruster --- block/rbd.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image

2017-03-24 Thread Markus Armbruster
qemu_rbd_open() neglects to check pool and image are present. Reproducer: $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p Segmentation fault (core dumped) $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,image=i qemu-system-x86_64: -drive if=none,driver=

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-24 Thread Stefano Stabellini
On Fri, 24 Mar 2017, Juergen Gross wrote: > On 23/03/17 19:22, Stefano Stabellini wrote: > > On Thu, 23 Mar 2017, Paolo Bonzini wrote: > >> On 23/03/2017 14:55, Juergen Gross wrote: > >>> On 23/03/17 14:00, Greg Kurz wrote: > On Mon, 20 Mar 2017 11:19:05 -0700 > Stefano Stabellini wrote:

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Nikunj A Dadhania
Alex Bennée writes: > Nikunj A Dadhania writes: > >> Richard Henderson writes: >> >>> On 09/12/2016 06:47 AM, Alex Bennée wrote: > > +/* Notice an IO access, or a notdirty page. */ > > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { > > +/* There's really nothing tha

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

2017-03-24 Thread luigiburdo
Hi Cèdric, i had been build the kernel with the Xics option enabled and all work on G5 970MP on Mate 17.04 i will test the same kernel of Fedora server PPC64 and see if there will work too. but it is strange thing, because the option was not needed (by the kernel default) on PowerMacs and was n

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 01:28, Richard Henderson wrote: > I also have access to a sparc box. > > (At the moment I'm trying to update it from 2013 era system libraries, and > to enable the 64-bit userland, before I do any testing of current mainline.) So far I have found that we seem to be mishandling

Re: [Qemu-devel] [PATCH-for-2.9] replay/replay.c: bump REPLAY_VERSION

2017-03-24 Thread Alex Bennée
Eric Blake writes: > On 03/24/2017 10:26 AM, Alex Bennée wrote: >> A previous commit (3d4d16f4) added support for audio record/playback. >> However this breaks the logfile ABI due to the re-ordering of the >> ReplayEvents enum. The REPLAY_VERSION check is meant to prevent you >> from using old l

[Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Paul Durrant
The Xen tools Makefile has been modified to set PKG_CONFIG_PATH such that use of pkg-config in QEMU configure finds the newly built Xen libraries. However, because older versions of Xen do not set PKG_CONFIG_PATH in the Makefile, the QEMU configure script will pick up any Xen libraries that may be

[Qemu-devel] [PATCH] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Paul Durrant
The Xen tools Makefile has been modified to set PKG_CONFIG_PATH such that use of pkg-config in QEMU configure finds the newly built Xen libraries. However, because older versions of Xen do not set PKG_CONFIG_PATH in the Makefile, the QEMU configure script will pick up any Xen libraries that may be

Re: [Qemu-devel] [PATCH 41/51] Add page-size to output in 'info migrate'

2017-03-24 Thread Eric Blake
On 03/23/2017 03:45 PM, Juan Quintela wrote: > From: Chao Fan > > The number of dirty pages outputed in 'pages' in the command s/outputed/is output/ > 'info migrate', so add page-size to calculate the number of dirty > pages in bytes. > > Signed-off-by: Chao Fan > Signed-off-by: Li Zhijian >

Re: [Qemu-devel] [PATCH 02/51] ram: rename block_name to rbname

2017-03-24 Thread Eric Blake
On 03/23/2017 03:44 PM, Juan Quintela wrote: > So all places are consisten on the nambing of a block name parameter. s/consisten/consistent/ s/nambing/naming/ > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) >

Re: [Qemu-devel] [PATCH-for-2.9] replay/replay.c: bump REPLAY_VERSION

2017-03-24 Thread Eric Blake
On 03/24/2017 10:26 AM, Alex Bennée wrote: > A previous commit (3d4d16f4) added support for audio record/playback. > However this breaks the logfile ABI due to the re-ordering of the > ReplayEvents enum. The REPLAY_VERSION check is meant to prevent you > from using old log files in newer QEMUs but

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 16:58, Markus Armbruster wrote: > "Sysbus" isn't a bus. In qdev's original design, every device had to > plug into a bus, period. The ones that really didn't were made to plug > into "sysbus". > > Pretty much the only thing "sysbus" devices had in common was that they > could

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Mar 24, 2017 at 01:49:16PM +0300, Marcel Apfelbaum wrote: >> On 03/22/2017 10:46 PM, Laszlo Ersek wrote: >> > On 03/22/17 21:31, Eduardo Habkost wrote: >> > > Hi, >> > > >> > > I am investigating the current status of has_dynamic_sysbus and >> > > sysbus device

[Qemu-devel] [PATCH] xen: additionally restrict xenforeignmemory operations

2017-03-24 Thread Paul Durrant
Commit f0f272baf3a7 "xen: use libxendevice model to restrict operations" added a command-line option (-xen-domid-restrict) to limit operations using the libxendevicemodel API to a specified domid. The commit also noted that the restriction would be extended to cover operations issued via other xen

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

2017-03-24 Thread Kevin Wolf
Am 24.03.2017 um 09:25 hat Markus Armbruster geschrieben: > Post 2.9, we should either finish the QAPIfication of block > configuration we started with blockdev-add, or back it out, i.e. make > the QAPI schema accept anything, and rely on the QemuOpts-based > checking. > > I want us to finish QAPI

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-24 Thread Brijesh Singh
On 03/24/2017 10:36 AM, Stefan Hajnoczi wrote: I suggest something like this instead: /* Debug memory access for AMD SEV */ That way it's clear this "debug" flag has a very specific meaning in the context of memory encryption. Sure, will update comments. -Brijesh

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- [snip] > >> That's a change in behaviour that I, and probably others, have long been > used to. What we really want, presumably, is to have pkg-config just look > under tools/pkgconfig when querying for the version of xencontrol. Could > that not be done by simply setti

Re: [Qemu-devel] [PATCH 51/51] migration: Remove MigrationState parameter from migration_is_idle()

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Only user don't have a MigrationState handly. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 2 +- > migration/migration.c | 8 +++- > 2 files changed, 4 insertions(+), 6 d

[Qemu-devel] Random hangs in the emulated ISA serial console, caused by glib2 change

2017-03-24 Thread Richard W.M. Jones
Hello Frediano, I'm tracking a rather difficult bug in qemu, where it appears that events in the glib loop are "lost". This is characterized by the emulated qemu serial console hanging until someone presses a key. This is normally disguised in the busy main loop of qemu (since some other event tu

[Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-24 Thread Xu, Anthony
Create libqemutrace.a for all trace.o Currently all trace.o are linked into qemu-system, qemu-img, qemu-nbd, qemu-io etc., even the corresponding components are not included. Create a libqemutrace.a that the linker would only pull in .o files containing symbols that are actually referenced by th

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 24 March 2017 15:55 > To: Paul Durrant ; 'Stefano Stabellini' > > Cc: Anthony Perard ; xen- > de...@lists.xenproject.org; qemu-devel@nongnu.org; kra...@redhat.com > Subject: Re: [Xen-devel] [PATCH 2/2] configure: u

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:51, Juergen Gross wrote: > On 24/03/17 16:44, Paul Durrant wrote: >>> -Original Message- >>> From: Juergen Gross [mailto:jgr...@suse.com] >>> Sent: 24 March 2017 15:35 >>> To: Paul Durrant ; 'Stefano Stabellini' >>> >>> Cc: Anthony Perard ; xen- >>> de...@lists.xenproject.or

Re: [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown

2017-03-24 Thread Alex Bennée
Peter Maydell writes: > On 24 March 2017 at 13:19, Christian Borntraeger > wrote: >> a qemu with an empty s390 guest will exit very quickly. This races >> against the testsuite reading from the console pipe leading to >> intermittent test suite failures. Using -no-shutdown will keep >> the gue

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:44, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 24 March 2017 15:35 >> To: Paul Durrant ; 'Stefano Stabellini' >> >> Cc: Anthony Perard ; xen- >> de...@lists.xenproject.org; qemu-devel@nongnu.org; kra...@redhat.com >> Su

Re: [Qemu-devel] Question nbd_refresh_filename()

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote: > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't > restrict variants. Thus, all four SOCKET_ADDRESS_KIND_ can occur. > > Now have a look at nbd_refresh_filename(). s->saddr->type is If > SOCKET_ADDRESS_KI

Re: [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

2017-03-24 Thread Marc-André Lureau
On Fri, Mar 24, 2017 at 7:32 PM sochin.jiang wrote: > From: "sochin.jiang" > > fix wrong parameter comments in channel-file.h. > > Signed-off-by: sochin.jiang > Reviewed-by: Marc-André Lureau > --- > include/io/channel-file.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

2017-03-24 Thread Cédric Le Goater
On 03/24/2017 12:31 PM, luigi burdo wrote: > Hi Cèdric, > > first of all thanks for your relpy. > > > > >>I have some difficulty sorting out what is going on and what >>could be considered a regression :/ you are reporting many >>issues at the same time with a home made kernel. > >>Could you

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 24 March 2017 15:35 > To: Paul Durrant ; 'Stefano Stabellini' > > Cc: Anthony Perard ; xen- > de...@lists.xenproject.org; qemu-devel@nongnu.org; kra...@redhat.com > Subject: Re: [Xen-devel] [PATCH 2/2] configure: u

Re: [Qemu-devel] [PATCH 0/2] Allocate mutiple clusters for VMDK I/O

2017-03-24 Thread Ashijeet Acharya
On Fri, Mar 24, 2017 at 8:54 PM, Stefan Hajnoczi wrote: > On Thu, Mar 23, 2017 at 4:22 PM, Ashijeet Acharya > wrote: >> On Thu, Mar 23, 2017 at 8:39 PM, Stefan Hajnoczi wrote: >>> On Tue, Mar 21, 2017 at 09:14:08AM +, Ashijeet Acharya wrote: On Tue, 21 Mar 2017 at 13:21, Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH v4 06/20] core: add new security-policy object

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 01:59:48PM -0500, Brijesh Singh wrote: > Hi Stefan, > > > On 03/23/2017 06:35 AM, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2017 at 03:52:09PM -0500, Brijesh Singh wrote: > > > The object can be used to define global security policy for the guest. > > > > "security-polic

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 01:14:17PM -0500, Brijesh Singh wrote: > Hi Stefan, > > > On 03/23/2017 06:29 AM, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: > > > Add a new debug attribute, the attribute should be set when guest memory > > > accesses are per

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:12, Paul Durrant wrote: >> -Original Message- >> From: Stefano Stabellini [mailto:sstabell...@kernel.org] >> Sent: 22 March 2017 18:22 >> To: Juergen Gross >> Cc: Stefano Stabellini ; qemu-devel@nongnu.org; >> xen-de...@lists.xenproject.org; Anthony Perard >> ; kra...@redhat

Re: [Qemu-devel] [PATCH 28/51] ram: Remove ram_save_remaining

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Just unfold it. Move ram_bytes_remaining() with the rest of exported > functions. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 19 +++ > 1 file changed, 7 insertions(+), 12 deleti

Re: [Qemu-devel] [PATCH 40/51] ram: Rename qemu_target_page_bits() to qemu_target_page_size()

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It was used as a size in all cases except one. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > exec.c | 4 ++-- > include/sysemu/sysemu.h | 2 +- > migration/migration.c| 4 ++-- > migration/pos

[Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

2017-03-24 Thread sochin.jiang
From: "sochin.jiang" fix wrong parameter comments in channel-file.h. Signed-off-by: sochin.jiang --- include/io/channel-file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel-file.h b/include/io/channel-file.h index d2462c2..79245f1 100644 --- a/inclu

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-24 Thread Stefan Hajnoczi
On Fri, Mar 24, 2017 at 12:29:39AM +, Xu, Anthony wrote: > > Perhaps all trace.o files should be put into their own .a instead of > > being added directly to the linker line: > > > > COMMON_LDADDS = $(trace-obj-y) libqemuutil.a libqemustub.a > > > > I think the linker would only pull in .o fi

Re: [Qemu-devel] [PATCH 39/51] ram: We don't need MigrationState parameter anymore

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Remove it from callers and callees. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 27 ++- > 1 file changed, 10 insertions(+), 17 deletions(-) > > diff --git a/migration/ram

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 06:57:14PM +0100, Paolo Bonzini wrote: > > > On 23/03/2017 18:44, Stefan Hajnoczi wrote: > >> It's possible to wedge QEMU if the guest tries to reset a virtio-pci > >> device as QEMU is also using the drive for a blockjob. This patchset > >> aims to allow us to safely paus

Re: [Qemu-devel] [PATCH 38/51] migration: Remove MigrationState from migration_in_postcopy

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We need to call for the migrate_get_current() in more that half of the > uses, so call that inside. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 2 +- > migration/migration.c

[Qemu-devel] [PATCH-for-2.9] replay/replay.c: bump REPLAY_VERSION

2017-03-24 Thread Alex Bennée
A previous commit (3d4d16f4) added support for audio record/playback. However this breaks the logfile ABI due to the re-ordering of the ReplayEvents enum. The REPLAY_VERSION check is meant to prevent you from using old log files in newer QEMUs but this is currently broken. Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH 0/2] Allocate mutiple clusters for VMDK I/O

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 4:22 PM, Ashijeet Acharya wrote: > On Thu, Mar 23, 2017 at 8:39 PM, Stefan Hajnoczi wrote: >> On Tue, Mar 21, 2017 at 09:14:08AM +, Ashijeet Acharya wrote: >>> On Tue, 21 Mar 2017 at 13:21, Stefan Hajnoczi wrote: >>> >>> > On Sat, Mar 11, 2017 at 11:54 AM, Ashijeet Ac

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 24 March 2017 15:13 > To: 'Stefano Stabellini' ; Juergen Gross > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Anthony > Perard ; kra...@redhat.com > Subject: RE: [PATCH 2/2] configure: use pkg-config for obtaining xen versio

Re: [Qemu-devel] guest-exec of qemu-guest-agent fails on Windows guest

2017-03-24 Thread Armin Ranjbar
We have tried qemu-ga from Fedora [1] which didn't have guest-exec and guest-exec-status (qemu-ga -b ? didn't list them and running guest-exec returned command not found) and also build msi from HEAD ourselves. gspawn-exec files are there, when we try to run guest-exec command qemu-ga windows appl

Re: [Qemu-devel] [PULL v3 1/3] replay: add record/replay for audio passthrough

2017-03-24 Thread Alex Bennée
Gerd Hoffmann writes: > From: Pavel Dovgalyuk > > This patch adds recording and replaying audio data. Is saves synchronization > information for audio out and inputs from the microphone. > > v2: removed unneeded whitespace change > > Signed-off-by: Pavel Dovgalyuk > Message-id: 20170202055054.

  1   2   >