On 03/24/2017 12:44 PM, Markus Armbruster wrote: > runtime_opts is used for three different purposes:
> This is a confusing mess. Dates back to commit 0f9d252. First step > to clean it up is documenting runtime_opts.desc[]: > > * Reorder entries to match the QAPI schema, like we do in other block > drivers. > > * Document why the schema's "server" and "auth-supported" aren't in > .desc[]. > > * Document why "keyvalue-pairs", "host", "port" and "auth" are in > .desc[], but not the schema. > > * Delete "filename", because none of the three users actually uses it. > This fixes -drive to reject parameter filename instead of silently > ignoring it. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/rbd.c | 39 ++++++++++++++++++++++++--------------- > 1 file changed, 24 insertions(+), 15 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
