On 03/24/2017 12:44 PM, Markus Armbruster wrote: > qemu_rbd_open() neglects to check pool and image are present. > Reproducer: > > $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p > Segmentation fault (core dumped) > $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,image=i > qemu-system-x86_64: -drive if=none,driver=rbd,image=i: error opening pool > (null) > > Doesn't affect -drive with file=..., because qemu_rbd_parse_filename() > always sets both pool and image. > > Doesn't affect -blockdev, because pool and image are mandatory in the > QAPI schema. > > Fix by adding the missing checks. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/rbd.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
