Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 11:22, Richard W.M. Jones wrote: > > I think that the --fork option is mainly intended for command line use > of qemu-nbd. If you're running qemu-nbd from a program there's no > real reason to use --fork, since you can control the fork process > better yourself. > > LISTEN_PID is

Re: [Qemu-devel] [PATCH v3] net: imx: limit buffer descriptor count

2017-02-03 Thread Jason Wang
On 2017年02月02日 18:46, P J P wrote: From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has craft

Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process

2017-02-03 Thread Li, Liang Z
> > > > +static void free_extended_page_bitmap(struct virtio_balloon *vb) { > > + int i, bmap_count = vb->nr_page_bmap; > > + > > + for (i = 1; i < bmap_count; i++) { > > + kfree(vb->page_bitmap[i]); > > + vb->page_bitmap[i] = NULL; > > + vb->nr_page_bmap--; > >

[Qemu-devel] [PATCH Risu 7/7] risu_ppc64le: fix minor code style in assembly test code

2017-02-03 Thread Jose Ricardo Ziviani
Signed-off-by: Jose Ricardo Ziviani --- test_ppc64le.s | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test_ppc64le.s b/test_ppc64le.s index af23ea3..4af770c 100644 --- a/test_ppc64le.s +++ b/test_ppc64le.s @@ -12,15 +12,15 @@ *

[Qemu-devel] [PATCH Risu 6/7] risu_ppc64le: remove fancy shell character cont from messages

2017-02-03 Thread Jose Ricardo Ziviani
Signed-off-by: Jose Ricardo Ziviani --- risu_reginfo_ppc64le.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/risu_reginfo_ppc64le.c b/risu_reginfo_ppc64le.c index 7a54eab..e6bc0e0 100644 --- a/risu_reginfo_ppc64le.c +++ b/risu_reginfo_ppc64le.c @@ -105,9 +105,9 @@ void

[Qemu-devel] [PATCH Risu 3/7] risu_ppc64le: implement sign extend for small neg constants

2017-02-03 Thread Jose Ricardo Ziviani
Signed-off-by: Jose Ricardo Ziviani --- risugen_ppc64.pm | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/risugen_ppc64.pm b/risugen_ppc64.pm index 40f3d4f..561c17b 100644 --- a/risugen_ppc64.pm +++ b/risugen_ppc64.pm @@ -75,6 +75,13 @@ sub write_add_ri($$$)

[Qemu-devel] [PATCH Risu 5/7] risu_ppc64le: stop loading data to register 1 and 13

2017-02-03 Thread Jose Ricardo Ziviani
Register R1 is defined as the stack frame pointer and R13 is the thread local storage by ABI. So, in order to let the program flows, they are better to keep unchanged. Signed-off-by: Jose Ricardo Ziviani --- test_ppc64le.s | 2 -- 1 file changed, 2 deletions(-) diff --git a/test_ppc64le.s b/tes

[Qemu-devel] [PATCH Risu 0/7] Risu PPC improvements

2017-02-03 Thread Jose Ricardo Ziviani
This patchset contains some fixes and improvements for ppc64le. Jose Ricardo Ziviani (7): risu_ppc64le: improve xsrqpi[x] and xsrqpxp instructions risu_ppc64le: fix 32-bit mov immediate risu_ppc64le: implement sign extend for small neg constants risu_ppc64le: implement FP random data for t

[Qemu-devel] [PATCH Risu 2/7] risu_ppc64le: fix 32-bit mov immediate

2017-02-03 Thread Jose Ricardo Ziviani
Two instructions are necessary but the high value should be written first, shifted 16 bit left, and then or'ed the lower value. This commit fixes the problem. Signed-off-by: Jose Ricardo Ziviani --- risugen_ppc64.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/risugen_

[Qemu-devel] [PATCH Risu 4/7] risu_ppc64le: implement FP random data for test improvement

2017-02-03 Thread Jose Ricardo Ziviani
This commit replaces the simple FP data written for tests for a randomically generated one. This functionality stores the same data in FP register and VSX[VRB+32] registers. Signed-off-by: Jose Ricardo Ziviani --- risugen_ppc64.pm | 31 +++ 1 file changed, 31 insertio

[Qemu-devel] [PATCH Risu 1/7] risu_ppc64le: improve xsrqpi[x] and xsrqpxp instructions

2017-02-03 Thread Jose Ricardo Ziviani
New constraint added to the referred instructions in order to avoid generation of reserved (not used today) rounding modes for floating point operations. Signed-off-by: Jose Ricardo Ziviani --- ppc64.risu | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ppc64.risu b/p

[Qemu-devel] QEMU Wiki

2017-02-03 Thread Jonathan Michael Stryer
Hello, Could I have someone create me an account for the QEMU wiki? Thank you. Jonathan Stryer Syracuse University Class of 2018 College of Engineering and Computer Science Bachelor of Science - Computer Science Renée Crown Honors Student

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] POWER9 TCG enablements - part 13

2017-02-03 Thread joserz
On Fri, Feb 03, 2017 at 02:11:31PM -0800, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13 > Message-id: 1486159277-25949-1-git

Re: [Qemu-devel] [PATCH v2 6/6] qemu-img: copy *key-secret opts when opening newly created files

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The qemu-img dd/convert commands will create a image file and > then try to open it. Historically it has been possible to open > new files without passing any options. With encrypted files > though, the *key-secret options are mandatory, so we need t

Re: [Qemu-devel] [PATCH v2 5/6] qemu-img: introduce --target-image-opts for 'convert' command

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The '--image-opts' flags indicates whether the source filename > includes options. The target filename has to remain in the > plain filename format though, since it needs to be passed to > bdrv_create(). When using --skip-create though, it would be

[Qemu-devel] [Bug 1661758] [NEW] qemu-nbd causes data corruption in VDI-format disk images

2017-02-03 Thread Jean-Paul Larocque
Public bug reported: Hi, This is a duplicate of #1422307. I can't figure out a way to re-open it--the status of "Fix Released" is changeable only by a project maintainer or bug supervisor--so I'm opening a new bug to make sure this gets looked at again. qemu-nbd will sometimes corrupt VDI disk

Re: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13

2017-02-03 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13 Message-id: 1486159277-25949-1-git-send-email-jos...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=bas

Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: add support for -o arg to dd command

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The -o arg to the convert command allows specification of format/protocol > options for the newly created image. This adds a -o arg to the dd command > to get feature parity. > > Signed-off-by: Daniel P. Berrange > --- > qemu-img-cmds.hx | 2 +- >

[Qemu-devel] [PATCH 3/4] ppc: implement xssqrtqp instruction

2017-02-03 Thread Jose Ricardo Ziviani
xssqrtqp: VSX Scalar Square Root Quad-Precision. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/fpu_helper.c | 38 + target/ppc/helper.h | 1 + target/ppc/translate/vsx-impl.inc.c | 1 + target/ppc/translate/vsx-ops.inc.c |

[Qemu-devel] [PATCH 2/4] ppc: implement xsrqpxp instruction

2017-02-03 Thread Jose Ricardo Ziviani
xsrqpxp: VSX Scalar Round Quad-Precision to Double-Extended Precision. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/fpu_helper.c | 56 + target/ppc/helper.h | 1 + target/ppc/translate/vsx-impl.inc.c | 1 + target/ppc/transl

[Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13

2017-02-03 Thread Jose Ricardo Ziviani
This set contains 4 new instructions xsrqpi[x] - VSX Scalar Round to Quad-Precision Integer xsrqpxp - VSX Scalar Round Quad-Precision to Double-Extended Precision xssqrtqp - VSX Scalar Square Root Quad-Precision xssubqp - VSX Scalar Subtract Quad-Precision Note: - xssqrtqpo and xssubqpo will be

[Qemu-devel] [PATCH 1/4] ppc: implement xsrqpi[x] instruction

2017-02-03 Thread Jose Ricardo Ziviani
xsrqpi[x]: VSX Scalar Round to Quad-Precision Integer [with Inexact]. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/fpu_helper.c | 60 + target/ppc/helper.h | 1 + target/ppc/internal.h | 1 + target/ppc/transla

[Qemu-devel] [PATCH 4/4] ppc: implement xssubqp instruction

2017-02-03 Thread Jose Ricardo Ziviani
xssubqp: VSX Scalar Subtract Quad-Precision. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/fpu_helper.c | 34 ++ target/ppc/helper.h | 1 + target/ppc/translate/vsx-impl.inc.c | 1 + target/ppc/translate/vsx-ops.inc.c | 1 + 4

Re: [Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

2017-02-03 Thread Laurent Vivier
Le 25/01/2017 à 01:10, Pranith Kumar a écrit : > Adopted from a previous patch posting: > https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg02079.html > > CC: Allan Wirth > CC: Peter Maydell > Signed-off-by: Pranith Kumar > --- > linux-user/signal.c | 264 > +++

Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: add support for conv=nocreat, notrunc args to dd command

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The -n arg to the convert command allows use of a pre-existing image, > rather than creating a new image. This adds equivalent functionality > to the dd command using the 'conv' arg. If 'conv=nocreat' is used, > then it will assume the image already

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-03 Thread Ketan Nilangekar
On 2/3/17, 1:45 AM, "Daniel P. Berrange" wrote: On Thu, Feb 02, 2017 at 09:22:46PM +, Ketan Nilangekar wrote: > > On 2/2/17, 12:57 PM, "Ketan Nilangekar" wrote: > > [Ketan] > Does the QIO interface allow for readv/writev over network for unsecure

Re: [Qemu-devel] [RFC 4/5] exec: allow to get a pointer for some mmio memory region

2017-02-03 Thread Frederic Konrad
On 02/03/2017 06:26 PM, Paolo Bonzini wrote: > > > On 03/02/2017 09:06, fred.kon...@greensocs.com wrote: >> +host = mr->ops->request_ptr(mr->opaque, addr - mr->addr, &size, >> &offset); >> + >> +if (!host || !size) { >> +memory_region_transaction_commit(); >> +return fals

Re: [Qemu-devel] [PATCH v2 2/6] qemu-img: fix --image-opts usage with dd command

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The --image-opts flag can only be used to affect the parsing > of the source image. The target image has to be specified in > the traditional style regardless, since it needs to be passed > to the bdrv_create() API which does not support the new styl

Re: [Qemu-devel] [PATCH v2 1/6] qemu-img: add support for --object with 'dd' command

2017-02-03 Thread Max Reitz
On 03.02.2017 13:02, Daniel P. Berrange wrote: > The qemu-img dd command added --image-opts support, but missed > the corresponding --object support. This prevented passing > secrets (eg auth passwords) needed by certain disk images. > > Reviewed-by: Eric Blake > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] QEMU + OVMF, bootable linux image

2017-02-03 Thread Laszlo Ersek
On 02/03/17 19:20, Jason Dickens wrote: > I am trying to create a raw Linux image that is bootable by QEMU using > the OVMF firmware image. > > Basically, I have used a standard Ubuntu ISO and a empty raw image. > Executing qemu-system-x86_64 with the ISO as CD and the other image as a > hardrive

Re: [Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

2017-02-03 Thread Pranith Kumar
On Fri, Feb 3, 2017 at 11:10 AM, Wirth, Allan wrote: > The patch LGTM. :) Thanks for checking the latest patch and for the initial work. I am happy it did not get lost :) -- Pranith

Re: [Qemu-devel] [Qemu-block] Non-flat command line option argument syntax

2017-02-03 Thread Max Reitz
I like both JSON and dot syntax. But I like them differently in different places. I love JSON when it's in some file where I can turn out syntax highlighting and let my $EDITOR match brackets and braces. I hate JSON when it's on the command line. You have to escape, you get strings in strings, an

Re: [Qemu-devel] [Qemu-block] Non-flat command line option argument syntax

2017-02-03 Thread Max Reitz
On 03.02.2017 08:50, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > >> * Markus Armbruster (arm...@redhat.com) wrote: >>> = Introduction = >>> >> >> >> >>> = Structured option argument syntax = >>> >>> == JSON == >>> >>> The obvious way to provide the expressiveness of JSON on the

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-03 Thread Dr. David Alan Gilbert
Ah well that is a bit better; you see now it's failing in kvm_**get**_msrs rather than put; so the question is which of the two changes made it survive kvm_put_msrs I'd hoped that the flags in (2) would have turned off the CPU flag and thus made it go in both of them. kvm_msr_entry_add: @103 in

[Qemu-devel] [PATCH] qemu-img: Do not truncate before preallocation

2017-02-03 Thread Nir Soffer
When using file system that does not support fallocate() (e.g. NFS < 4.2), truncating the file only when preallocation=OFF speeds up creating raw file. Here is example run, tested on Fedora 24 machine, creating raw file on NFS version 3 server. $ time ./qemu-img-master create -f raw -o preallocat

Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
On Fri, Feb 03, 2017 at 10:58:15AM -0800, Paolo Bonzini wrote: > On 03/02/2017 10:56, Richard W.M. Jones wrote: > > On Fri, Feb 03, 2017 at 09:31:43AM -0800, Paolo Bonzini wrote: > >> On 03/02/2017 09:09, Richard W.M. Jones wrote: > >>> +if (fork_process) { > >>> +return "Fork (--fork)

Re: [Qemu-devel] [PATCH 16/17] iotests: add dirty bitmap migration test

2017-02-03 Thread Max Reitz
On 03.02.2017 12:08, Vladimir Sementsov-Ogievskiy wrote: > 03.02.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: >> 02.02.2017 02:12, Max Reitz wrote: >>> On 22.11.2016 18:54, Vladimir Sementsov-Ogievskiy wrote: The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, d

Re: [Qemu-devel] [PATCH 16/17] iotests: add dirty bitmap migration test

2017-02-03 Thread Max Reitz
On 03.02.2017 11:10, Vladimir Sementsov-Ogievskiy wrote: > 02.02.2017 02:12, Max Reitz wrote: >> On 22.11.2016 18:54, Vladimir Sementsov-Ogievskiy wrote: >>> The test starts two vms (vm_a, vm_b), create dirty bitmap in >>> the first one, do several writes to corresponding device and >>> then migrat

Re: [Qemu-devel] [PATCH 1/2] qemu-io: don't allow I/O operations larger than INT_MAX

2017-02-03 Thread Max Reitz
On 02.02.2017 09:52, Alberto Garcia wrote: > On Wed 01 Feb 2017 11:16:38 PM CET, Max Reitz wrote: > >> Thanks, applied to my block tree, with >> %s/INT_MAX/BDRV_REQUEST_MAX_BYTES/g: > > I think you can use %d to print BDRV_REQUEST_MAX_BYTES, after all the > definition guarantees that it won't be

Re: [Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-02-03 Thread Max Reitz
On 02.02.2017 11:41, Vladimir Sementsov-Ogievskiy wrote: > 01.02.2017 02:20, Max Reitz wrote: >> On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: >>> Realize .bdrv_remove_persistent_dirty_bitmap interface. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/qcow2-bitmap

Re: [Qemu-devel] [PATCH RFC] mem-prealloc: Reduce large guest start-up and migration time.

2017-02-03 Thread Paolo Bonzini
On 02/02/2017 01:35, Jitendra Kolhe wrote: >> Of course you'd still need the memset() trick if qemu was given >> non-hugepages in combination with --mem-prealloc, as you don't >> want to lock normal pages into ram permanently. >> > given above numbers, I think we can stick to memset() implementat

Re: [Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-03 Thread Matwey V. Kornilov
2017-02-03 21:34 GMT+03:00 Dr. David Alan Gilbert : > Hi, > OK, lets see: > > kvm_put_msrs: ret=18 expected=105 > > so I think it's one of the MSRs around 18 that it's upset at: > > kvm_msr_entry_add: @17 index=4b564d03 value=0 > > 41:#define MSR_KVM_STEAL_TIME 0x4b564d03 > > kvm_msr_entry_ad

[Qemu-devel] [PATCH] softfloat: Use correct type in float64_to_uint64_round_to_zero()

2017-02-03 Thread Peter Maydell
In float64_to_uint64_round_to_zero() a typo meant that we were taking the uint64_t return value from float64_to_uint64() and putting it into an int64_t variable before returning it as uint64_t again. Use uint64_t instead of pointlessly casting it back and forth to int64_t. Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH v3 1/1] qemu-char: socket backend: disconnect on write error

2017-02-03 Thread Paolo Bonzini
On 02/02/2017 06:26, Denis V. Lunev wrote: > From: Anton Nefedov > > Socket backend read handler should normally perform a disconnect, however > the read handler may not get a chance to run if the frontend is not ready > (qemu_chr_be_can_write() == 0). > > This means that in virtio-serial fron

Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 10:56, Richard W.M. Jones wrote: > On Fri, Feb 03, 2017 at 09:31:43AM -0800, Paolo Bonzini wrote: >> >> >> On 03/02/2017 09:09, Richard W.M. Jones wrote: >>> + const char *port, >>> +

Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
On Fri, Feb 03, 2017 at 09:31:43AM -0800, Paolo Bonzini wrote: > > > On 03/02/2017 09:09, Richard W.M. Jones wrote: > > + const char *port, > > + bool fork_process) > > +{ > > +if (device != NU

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-02-03 Thread Max Reitz
On 02.02.2017 08:32, Markus Armbruster wrote: > Max Reitz writes: > >> On 01.02.2017 13:28, Daniel P. Berrange wrote: >>> On Wed, Feb 01, 2017 at 01:23:54PM +0100, Max Reitz wrote: On 01.02.2017 13:16, Daniel P. Berrange wrote: > On Wed, Feb 01, 2017 at 01:13:39PM +0100, Max Reitz wrote:

Re: [Qemu-devel] [PATCH 0/3] kvm/ioapic: some tiny tweaks

2017-02-03 Thread Paolo Bonzini
On 02/02/2017 23:18, Peter Xu wrote: > This series fixes the issue pointed out by PMM in thread: > > https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg06323.html > > Along with other two patches to make the version more accurate. Thanks, > > Peter Xu (3): > kvm/ioapic: dump real obj

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-03 Thread Dr. David Alan Gilbert
Hi, OK, lets see: kvm_put_msrs: ret=18 expected=105 so I think it's one of the MSRs around 18 that it's upset at: kvm_msr_entry_add: @17 index=4b564d03 value=0 41:#define MSR_KVM_STEAL_TIME 0x4b564d03 kvm_msr_entry_add: @18 index=38d value=0 #define MSR_CORE_PERF_FIXED_CTR_CTRL

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 00:20, Peter Lieven wrote: > Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >> >> On 31/01/2017 07:36, Peter Lieven wrote: >>> the current implementation fails if we try to freeze an >>> already frozen filesystem. This can happen if a filesystem >>> is mounted more than once (e.g. wi

[Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

2017-02-03 Thread Peter Maydell
The functions vnc_has_job() and vnc_jobs_clear() are never used; remove them. Signed-off-by: Peter Maydell --- I last had a go at this five years ago: http://patchwork.ozlabs.org/patch/192335/ Since then vnc_stop_worker_thread() got removed anyway in commit 09526058d, but the vnc_jobs_clear() f

[Qemu-devel] QEMU + OVMF, bootable linux image

2017-02-03 Thread Jason Dickens
I am trying to create a raw Linux image that is bootable by QEMU using the OVMF firmware image. Basically, I have used a standard Ubuntu ISO and a empty raw image. Executing qemu-system-x86_64 with the ISO as CD and the other image as a hardrive I have been able to install Ubuntu on the image

Re: [Qemu-devel] [PATCH] hw/vfio/pci-quirks: Set category of the "vfio-pci-igd-lpc-bridge" device

2017-02-03 Thread Alex Williamson
On Tue, 24 Jan 2017 09:02:38 +0100 Thomas Huth wrote: > The device has "bridge" in its name, so it should obviously be in > the category DEVICE_CATEGORY_BRIDGE. Well, physical device is a bridge, but this is really just a stub. Does that count? It doesn't create a subordinate bus that can actua

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-03 Thread Halil Pasic
On 02/03/2017 04:37 PM, Michael S. Tsirkin wrote: > On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: >>> +\begin{description} >>> +\item[0] dataq1 >>> +\item[\ldots] >>> +\item[N-1] dataqN >>> +\item[N] controlq >>> +\end{description} >>> + >>> +N is set by \field{max_dataqueues}.

[Qemu-devel] [PATCH] CODING_STYLE: Mention preferred comment form

2017-02-03 Thread Peter Maydell
Our defacto coding style strongly prefers /* */ style comments over the single-line // style, and checkpatch enforces this, but we don't actually document this. Mention it in CODING_STYLE. Suggested-by: Thomas Huth Signed-off-by: Peter Maydell --- CODING_STYLE | 7 +++ 1 file changed, 7 ins

[Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-03 Thread Halil Pasic
The member VMStateField.start is used for two things, partial data migration for VBUFFER data (basically provide migration for a sub-buffer) and for locating next in QTAILQ. The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC is used. This however goes unnoticed because actually

[Qemu-devel] [PATCH v2 2/2] target/arm: A32, T32: Create Instruction Syndromes for Data Aborts

2017-02-03 Thread Peter Maydell
Add support for generating the ISS (Instruction Specific Syndrome) for Data Abort exceptions taken from AArch32. These syndromes are used by hypervisors for example to trap and emulate memory accesses. This is the equivalent for AArch32 guests of the work done for AArch64 guests in commit aaa1f954

[Qemu-devel] [PATCH v2 0/2] target/arm: Support EL1 AArch32 guest under AArch64 EL2

2017-02-03 Thread Peter Maydell
Add support for generating the ISS (Instruction Specific Syndrome) for Data Abort exceptions taken from AArch32. These syndromes are used by hypervisors for example to trap and emulate memory accesses. This is a respin of patch 1/3 from the previous series. Changes v1->v2: * other 2 patches are n

[Qemu-devel] [PATCH v2 1/2] target/arm: Abstract out pbit/wbit tests in ARM ldr/str decode

2017-02-03 Thread Peter Maydell
In the ARM ldr/str decode path, rather than directly testing "insn & (1 << 21)" and "insn & (1 << 24)", abstract these bits out into wbit and pbit local flags. (We will want to do more tests against them to determine whether we need to provide syndrome information.) Signed-off-by: Peter Maydell -

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-03 Thread Richard W.M. Jones
On Thu, Feb 02, 2017 at 08:42:33PM +0100, Markus Armbruster wrote: > There's also the -drive file=json:... syntax. It's a bad fit for > QemuOpts, because QemuOpts and JSON fight for the comma. I'd show you > if I could get it to work. I think this refers to the json: syntax for qemu URIs? Anywa

Re: [Qemu-devel] [PATCH v6 10/18] memory: add section range info for IOMMU notifier

2017-02-03 Thread Alex Williamson
On Fri, 3 Feb 2017 16:22:36 +0800 Peter Xu wrote: > In this patch, IOMMUNotifier.{start|end} are introduced to store section > information for a specific notifier. When notification occurs, we not > only check the notification type (MAP|UNMAP), but also check whether the > notified iova range ov

Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 09:09, Richard W.M. Jones wrote: > + const char *port, > + bool fork_process) > +{ > +if (device != NULL) { > +return "NBD device can't be set when using socket activation

Re: [Qemu-devel] [PATCH v6 02/18] vfio: introduce vfio_get_vaddr()

2017-02-03 Thread Alex Williamson
On Fri, 3 Feb 2017 16:22:28 +0800 Peter Xu wrote: > A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if > the operation is unmap, but it won't hurt much. > > One thing to mention is that we need the RCU read lock to protect the > whole translation and map/unmap procedure. >

Re: [Qemu-devel] [RFC 4/5] exec: allow to get a pointer for some mmio memory region

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 09:06, fred.kon...@greensocs.com wrote: > +host = mr->ops->request_ptr(mr->opaque, addr - mr->addr, &size, &offset); > + > +if (!host || !size) { > +memory_region_transaction_commit(); > +return false; > +} > + > +sub = g_new(MemoryRegion, 1); > +

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-03 Thread Ashijeet Acharya
On Fri, Feb 3, 2017 at 10:44 PM, Paolo Bonzini wrote: > > > On 03/02/2017 02:36, Ashijeet Acharya wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM checks at >> appropriate places to skip migration of RAM in this c

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 02:36, Ashijeet Acharya wrote: > Migration of a "none" machine with no RAM crashes abruptly as > bitmap_new() fails and thus aborts. Instead place zero RAM checks at > appropriate places to skip migration of RAM in this case and complete > migration successfully for devices only. >

Re: [Qemu-devel] [PATCH v6 03/18] vfio: allow to notify unmap for very large region

2017-02-03 Thread Alex Williamson
On Fri, 3 Feb 2017 16:22:29 +0800 Peter Xu wrote: > Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big > region. This can be leveraged by QEMU IOMMU implementation to cleanup > existing page mappings for an entire iova address space (by notifying > with an IOTLB with extremely

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 07:00, Stefan Hajnoczi wrote: > On Thu, Feb 02, 2017 at 07:05:30AM -0800, Paolo Bonzini wrote: >> The replication feature is a small amount of code, does not >> require any external library and unless used does not add >> anything to the guest's attack surface. Since any extra >> c

[Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable

2017-02-03 Thread Paolo Bonzini
The function is not needed anymore now that migration is built on top of QIOChannel. Signed-off-by: Paolo Bonzini --- tests/test-vmstate.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 9d87faf..0c2af4d 100644 --- a/tests/test-vm

[Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
Socket activation (sometimes known as systemd socket activation) allows an Internet superserver to pass a pre-opened listening socket to the process, instead of having qemu-nbd open a socket itself. This is done via the LISTEN_FDS and LISTEN_PID environment variables, and a standard file descripto

Re: [Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages

2017-02-03 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages Message-id: 20170203

[Qemu-devel] [RFC 5/5] xilinx_spips: allow mmio execution

2017-02-03 Thread fred . konrad
From: KONRAD Frederic This allows to execute from the lqspi area. When the request_ptr is called the device loads 1024bytes from the SPI device. Then this code can be executed by the guest. Signed-off-by: KONRAD Frederic --- hw/ssi/xilinx_spips.c | 74 ++---

[Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
v2 -> v3: - Changes suggested by Stefan. - Retested it, using my socket activation code in virt-p2v: https://www.redhat.com/archives/libguestfs/2017-February/msg00036.html Rich.

[Qemu-devel] [RFC 4/5] exec: allow to get a pointer for some mmio memory region

2017-02-03 Thread fred . konrad
From: KONRAD Frederic This introduces a special callback which allows to run code from some MMIO devices. SysBusDevice with a MemoryRegion which implements the request_ptr callback will be notified when the guest try to execute code from their offset. Then it will be able to eg: pre-load some co

[Qemu-devel] [RFC 0/5] execute code from mmio area

2017-02-03 Thread fred . konrad
From: KONRAD Frederic This patch-set allows to execute code from mmio areas. The main goal of this is to be able to run code for example from an SPI device. The three first patch fixes the way get_page_addr_code fills the TLB. The fourth patch implements the mmio execution helpers: the device m

[Qemu-devel] [RFC 2/5] cputlb: move get_page_addr_code

2017-02-03 Thread fred . konrad
From: KONRAD Frederic This just moves the code before VICTIM_TLB_HIT macro definition so we can use it. Signed-off-by: KONRAD Frederic --- cputlb.c | 72 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/cputlb.c b/

[Qemu-devel] [RFC 3/5] cputlb: fix the way get_page_addr_code fills the tlb

2017-02-03 Thread fred . konrad
From: KONRAD Frederic get_page_addr_code(..) does a cpu_ldub_code to fill the tlb: This can lead to some side effects if a device is mapped at this address. So this patch replaces the cpu_memory_ld by a tlb_fill. Signed-off-by: KONRAD Frederic --- cputlb.c | 6 -- 1 file changed, 4 insert

[Qemu-devel] [RFC 1/5] cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT

2017-02-03 Thread fred . konrad
From: KONRAD Frederic This replaces env1 and page_index variables by env and index so we can use VICTIM_TLB_HIT macro later. Signed-off-by: KONRAD Frederic --- cputlb.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cputlb.c b/cputlb.c index 6c39927..665

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-03 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> = Introduction = > >> > > > > > > > >> = Structured option argument syntax = > >> > >> == JSON == > >> > >> The obvious way to provide the expressiveness

[Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages

2017-02-03 Thread Pavel Butsykin
This feature frees the migrated memory on the source during postcopy-ram migration. In the second step of postcopy-ram migration when the source vm is put on pause we can free unnecessary memory. It will allow, in particular, to start relaxing the memory stress on the source host in a load-balancin

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
On Fri, Feb 03, 2017 at 03:16:43PM +, Stefan Hajnoczi wrote: > On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: > > +if (*port == NULL) { > > +*port = g_strdup_printf("%d", NBD_DEFAULT_PORT);; > > Please stringify NBD_DEFAULT_PORT instead of using g_strdup_printf

Re: [Qemu-devel] [PATCH v3 5/7] ARM big-endian system-mode gdbstub support.

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:32, Julian Brown wrote: > When debugging a big-endian (either BE8 or BE32) executable, GDB uses > a big-endian byte ordering for its remote protocol. The gdb stub > code in QEMU needs to interpret data in host (little-endian) order in > arm_cpu_gdb_read_register and arm_c

Re: [Qemu-devel] [PATCH v3 0/7] ARM BE8/BE32 big-endian system-mode fixes (semihosting, gdbstub)

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:30, Julian Brown wrote: > This is the third iteration of a series of patches to implement > semihosting/gdbstub support for big-endian ARM system mode. The previous > series started here: > > http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg00972.html > > I've

Re: [Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-03 Thread Matwey V. Kornilov
Hello, The output is the following: kvm_msr_entry_add: @0 index=174 value=0 kvm_msr_entry_add: @1 index=175 value=0 kvm_msr_entry_add: @2 index=176 value=0 kvm_msr_entry_add: @3 index=277 value=7040600070406 kvm_msr_entry_add: @4 index=c081 value=0 kvm_msr_entry_add: @5 index=c0010117 value=0

[Qemu-devel] [PATCH 2/4] migration: Add VMSTATE_WITH_TMP

2017-02-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" VMSTATE_WITH_TMP is for handling structures where some calculation or rearrangement of the data needs to be performed before the data hits the wire. For example, where the value on the wire is an offset from a non-migrated base, but the data in the structure is the

Re: [Qemu-devel] [PATCH v3 4/7] ARM big-endian semihosting support.

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:32, Julian Brown wrote: > This patch introduces an ARM-specific version of the memory read/write, > etc. functions used for semihosting, in order to byte-swap (big-endian) > target memory that is to be interpreted by the (little-endian) host. > The target_memory_rw_debug f

Re: [Qemu-devel] [PATCH v3 7/7] ARM BE32 watchpoint fix.

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:32, Julian Brown wrote: > In BE32 mode, sub-word size watchpoints can fail to trigger because the > address of the access is adjusted in the opcode helpers before being > compared with the watchpoint registers. This patch reverses the address > adjustment before performin

Re: [Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

2017-02-03 Thread Pranith Kumar
Peter Maydell writes: > On 25 January 2017 at 00:10, Pranith Kumar wrote: >> Adopted from a previous patch posting: >> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg02079.html >> >> CC: Allan Wirth >> CC: Peter Maydell >> Signed-off-by: Pranith Kumar > > Thanks for picking this pat

Re: [Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

2017-02-03 Thread Wirth, Allan
Pranith, Thanks for doing this. I totally forgot about this (my work has moved elsewhere) so thank you for picking it back up. Please don’t worry about the attribution. The patch LGTM. :) Cheers, Allan On 2/3/17, 10:55 AM, "Pranith Kumar" wrote: Peter Maydell writes: > On

[Qemu-devel] [PATCH 4/4] virtio/migration: Migrate virtio-net to VMState

2017-02-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- hw/net/virtio-net.c| 316 +++-- include/hw/virtio/virtio-net.h | 4 +- 2 files changed, 213 insertions(+), 107 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virti

[Qemu-devel] [PATCH 11/18] nbd: BLOCK_STATUS for bitmap export: server part

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Only one meta context type is defined: qemu-bitmap:. Maximum one query is allowed for NBD_OPT_{SET,LIST}_META_CONTEXT, NBD_REP_ERR_TOO_BIG is returned otherwise. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 15 ++ nbd/nbd-internal.h | 6 + nbd/server.c| 445 +

Re: [Qemu-devel] [PATCH v3 6/7] Fix Thumb-1 BE32 execution and disassembly.

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:32, Julian Brown wrote: > Thumb-1 code has some issues in BE32 mode (as currently implemented). In > short, since bytes are swapped within words at load time for BE32 > executables, this also swaps pairs of adjacent Thumb-1 instructions. > > This patch un-swaps those pairs

[Qemu-devel] [PATCH 3/4] tests/migration: Add test for VMSTATE_WITH_TMP

2017-02-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a test for VMSTATE_WITH_TMP to tests/test-vmstate.c Signed-off-by: Dr. David Alan Gilbert --- tests/test-vmstate.c | 98 1 file changed, 92 insertions(+), 6 deletions(-) diff --git a/tests/test-vmstate.c b

[Qemu-devel] [PATCH 1/4] migration: Add VMSTATE_UNUSED_VARRAY_UINT32

2017-02-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" VMSTATE_UNUSED_VARRAY_UINT32 is used to skip a chunk of the stream that's an n-element array; note the array size and the dynamic value read never get multiplied so there's no overflow risk. Signed-off-by: Dr. David Alan Gilbert --- include/migration/vmstate.h |

[Qemu-devel] [PATCH 16/18] iotests: add test for nbd dirty bitmap export

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/180 | 133 + tests/qemu-iotests/180.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 139 insertions(+) create mode 100755 tests/qemu-iotests/180 create mode 10064

[Qemu-devel] [PATCH 12/18] nbd: BLOCK_STATUS for bitmap export: client part

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 146 ++- block/nbd-client.h | 6 +++ block/nbd.c | 9 +++- include/block/nbd.h | 6 ++- nbd/client.c | 103 +++- nbd/ser

Re: [Qemu-devel] [PATCH v3 3/7] Move target_memory_rw_debug function.

2017-02-03 Thread Peter Maydell
On 20 January 2017 at 16:30, Julian Brown wrote: > This patch moves the target_memory_rw_debug function to > include/exec/cpu-all.h, so that it can be used by the ARM semihosting > code as well as the gdbstub code. (I tried Peter Maydell's suggestion > of include/qom/cpu.h as a location for the fu

[Qemu-devel] [PATCH 14/18] qmp: add x-debug-block-dirty-bitmap-sha256

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-core.json | 27 +++

[Qemu-devel] [PATCH 03/18] nbd: Minimal structured read for server

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Minimal implementation of structured read: one data chunk + finishing none chunk. No segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd

[Qemu-devel] [PATCH 01/18] nbd: rename NBD_REPLY_MAGIC to NBD_SIMPLE_REPLY_MAGIC

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
To be consistent when NBD_STRUCTURED_REPLY_MAGIC will be introduced. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 4 ++-- nbd/nbd-internal.h | 2 +- nbd/server.c | 4 ++-- tests/qemu-iotests/nbd-fault

  1   2   3   4   >